Re: Cleanups for physmap_of.c (v2)

2007-09-20 Thread Josh Boyer
On Thu, 20 Sep 2007 11:22:25 +1000 David Gibson [EMAIL PROTECTED] wrote: This patch includes a whole batch of smallish cleanups for drivers/mtd/physmap_of.c. - A bunch of uneeded #includes are removed - We switch to the modern linux/of.h etc. in place of asm/prom.h - Use

Re: Cleanups for physmap_of.c (v2)

2007-09-20 Thread Segher Boessenkool
- (the big one) Despite the name, this driver really has nothing to do with drivers/mtd/physmap.c. The fact that the flash chips must be physically direct mapped is a constrant, but doesn't really say anything about the actual purpose of this driver, which is to instantiate MTD devices

Re: Cleanups for physmap_of.c (v2)

2007-09-20 Thread David Gibson
On Thu, Sep 20, 2007 at 07:11:59PM +0200, Segher Boessenkool wrote: - (the big one) Despite the name, this driver really has nothing to do with drivers/mtd/physmap.c. The fact that the flash chips must be physically direct mapped is a constrant, but doesn't really say anything about

Re: Cleanups for physmap_of.c

2007-09-19 Thread Josh Boyer
On Wed, 19 Sep 2007 14:16:46 +1000 David Gibson [EMAIL PROTECTED] wrote: This patch includes a whole batch of smallish cleanups for drivers/mtd/physmap_of.c. - A bunch of uneeded #includes are removed - We switch to the modern linux/of.h etc. in place of asm/prom.h - Use

Cleanups for physmap_of.c (v2)

2007-09-19 Thread David Gibson
This patch includes a whole batch of smallish cleanups for drivers/mtd/physmap_of.c. - A bunch of uneeded #includes are removed - We switch to the modern linux/of.h etc. in place of asm/prom.h - Use some helper macros to avoid some ugly inline #ifdefs - A few lines

Cleanups for physmap_of.c

2007-09-18 Thread David Gibson
This patch includes a whole batch of smallish cleanups for drivers/mtd/physmap_of.c. - A bunch of uneeded #includes are removed - We switch to the modern linux/of.h etc. in place of asm/prom.h - Use some helper macros to avoid some ugly inline #ifdefs - A few lines