Re: Oops in IDE probing on ppc_440 when PCI is enabled in strapping

2009-09-15 Thread Ludo Van Put
e (patched 2.6.10) >> > >> > 2.6.10?  Really?  If that is truly the case, you probably aren't going to >> > get >> > a whole lot of help from the list, since that kernel is pretty ancient. >> > >> I can only acknowledge that, but we're

Re: Oops in IDE probing on ppc_440 when PCI is enabled in strapping

2009-09-15 Thread Benjamin Herrenschmidt
On Tue, 2009-09-15 at 10:57 +0200, Ludo Van Put wrote: > Thnx for the suggestion, but the ide_insw is in fact of copy of the > _insw assembly routine, and it gets passed > the effective address, without the _IO_BASE offset. > > I was thinking about TLB stuff. I'm not a u-boot expert, but could it

Re: [BUILD FAILURE 07/12] Next April 14 : PPC64 randconfig [drivers/ide/pmac.c]

2009-04-14 Thread Greg KH
On Tue, Apr 14, 2009 at 11:59:19PM +0530, Subrata Modak wrote: > Observed the following build error: I have no objection on being cc:ed on errors that have something to do with stuff I maintain, but on areas I don't maintain, it just ends up as noise in my already-overflowing inbox... thanks,

Re: [BUILD FAILURE 07/12] Next April 14 : PPC64 randconfig [drivers/ide/pmac.c]

2009-04-21 Thread Bartlomiej Zolnierkiewicz
On Tuesday 14 April 2009 20:29:19 Subrata Modak wrote: > Observed the following build error: > --- > CC [M] drivers/ide/pmac.o > drivers/ide/pmac.c: In function ‘pmac_ide_init_dev’: > drivers/ide/pmac.c:955: error: implicit declaration of function > ‘check_media_bay_by_base’ &g

[BUID_FAILURE] next-20080215 Build failure caused by ide: rework PowerMac media-bay support

2008-02-15 Thread Kamalesh Babulal
9: warning: function declaration isn't a prototype make[2]: *** [arch/powerpc/platforms/powermac/setup.o] Error 1 make[1]: *** [arch/powerpc/platforms/powermac] Error 2 make: *** [arch/powerpc/platforms] Error 2 This build failure is caused by the ide: rework PowerMac media-bay support pat

Re: [PATCH 15/18] ide: remove broken/dangerous HDIO_[UNREGISTER, SCAN]_HWIF ioctls

2008-03-27 Thread Sergei Shtylyov
allocated again. * Since ide_init_hwif_ports() is used for ->io_ports[] setup the ioctls don't work for almost all hosts with "non-standard" (== non ISA-like) layout of IDE taskfile registers (there is a lot of such host drivers). * ide_port_init_devices() is not called when p

Re: [PATCH 15/18] ide: remove broken/dangerous HDIO_[UNREGISTER, SCAN]_HWIF ioctls

2008-03-28 Thread Mark Lord
Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: hdparm explicitely marks HDIO_[UNREGISTER,SCAN]_HWIF ioctls as DANGEROUS and given the number of bugs we can assume that there are no real users: .. There is the odd user of these, actually. But the most recent to email me (a few weeks

Re: [PATCH 15/18] ide: remove broken/dangerous HDIO_[UNREGISTER, SCAN]_HWIF ioctls

2008-03-29 Thread Bartlomiej Zolnierkiewicz
On Thursday 27 March 2008, Sergei Shtylyov wrote: [...] > > Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> > > Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> Thanks for reviewing it. > >

Re: [PATCH 15/18] ide: remove broken/dangerous HDIO_[UNREGISTER, SCAN]_HWIF ioctls

2008-03-29 Thread Bartlomiej Zolnierkiewicz
On Friday 28 March 2008, Mark Lord wrote: > Sergei Shtylyov wrote: > > Bartlomiej Zolnierkiewicz wrote: > > > >> hdparm explicitely marks HDIO_[UNREGISTER,SCAN]_HWIF ioctls as DANGEROUS > >> and given the number of bugs we can assume that there are no real users: > .. > > There is the odd user of

[PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-25 Thread Vitaly Bordug
arch/powerpc/boot/dts/mpc8349emitx.dts @@ -37,6 +37,15 @@ reg = < 1000>; }; + [EMAIL PROTECTED] { + compatible = "mmio-ide"; + device_type = "ide"; + reg = ; + ioport_shift =

Re: [PATCH 01/10] alpha: use libata instead of the legacy ide driver

2021-03-17 Thread Al Viro
On Thu, Mar 18, 2021 at 05:56:57AM +0100, Christoph Hellwig wrote: > Switch the alpha defconfig from the legacy ide driver to libata. Umm... I don't have an IDE alpha box in a usable shape (fans on CPU module shat themselves), and it would take a while to resurrect it, but I remember th

Re: [PATCH 01/10] alpha: use libata instead of the legacy ide driver

2021-03-17 Thread Christoph Hellwig
On Thu, Mar 18, 2021 at 05:54:55AM +, Al Viro wrote: > On Thu, Mar 18, 2021 at 05:56:57AM +0100, Christoph Hellwig wrote: > > Switch the alpha defconfig from the legacy ide driver to libata. > > Umm... I don't have an IDE alpha box in a usable shape (fans on > CPU

Re: [PATCH 01/10] alpha: use libata instead of the legacy ide driver

2021-03-18 Thread John Paul Adrian Glaubitz
Hi Al! On 3/18/21 6:54 AM, Al Viro wrote: > On Thu, Mar 18, 2021 at 05:56:57AM +0100, Christoph Hellwig wrote: >> Switch the alpha defconfig from the legacy ide driver to libata. > > Umm... I don't have an IDE alpha box in a usable shape (fans on > CPU module shat themsel

Re: [PATCH 01/10] alpha: use libata instead of the legacy ide driver

2021-03-18 Thread Måns Rullgård
Christoph Hellwig writes: > On Thu, Mar 18, 2021 at 05:54:55AM +, Al Viro wrote: >> On Thu, Mar 18, 2021 at 05:56:57AM +0100, Christoph Hellwig wrote: >> > Switch the alpha defconfig from the legacy ide driver to libata. >> >> Umm... I don't have an IDE a

Re: [PATCH 01/10] alpha: use libata instead of the legacy ide driver

2021-03-18 Thread Måns Rullgård
Måns Rullgård writes: > Christoph Hellwig writes: > >> On Thu, Mar 18, 2021 at 05:54:55AM +, Al Viro wrote: >>> On Thu, Mar 18, 2021 at 05:56:57AM +0100, Christoph Hellwig wrote: >>> > Switch the alpha defconfig from the legacy ide driver to libata. >

Re: [PATCH 01/10] alpha: use libata instead of the legacy ide driver

2021-03-19 Thread Serge Belyshev
Al Viro writes: > ... > > Do you have reports of libata variants of drivers actually tested on > those? PATA_CMD64X works fine on my 164LX for many years, last tested with 5.12-rc3. (with a caveat: in my setup with CF card DMA is broken, but it is broken with BLK_DEV_CMD64X as well).

[PATCH AUTOSEL 5.5 414/542] ide: remove set but not used variable 'hwif'

2020-02-14 Thread Sasha Levin
From: Wang Hai [ Upstream commit 98949a1946d70771789def0c9dbc239497f9f138 ] Fix the following gcc warning: drivers/ide/pmac.c: In function pmac_ide_setup_device: drivers/ide/pmac.c:1027:14: warning: variable hwif set but not used [-Wunused-but-set-variable] Fixes: d58b0c39e32f ("powerpc/

[PATCH AUTOSEL 5.4 354/459] ide: remove set but not used variable 'hwif'

2020-02-14 Thread Sasha Levin
From: Wang Hai [ Upstream commit 98949a1946d70771789def0c9dbc239497f9f138 ] Fix the following gcc warning: drivers/ide/pmac.c: In function pmac_ide_setup_device: drivers/ide/pmac.c:1027:14: warning: variable hwif set but not used [-Wunused-but-set-variable] Fixes: d58b0c39e32f ("powerpc/

[PATCH AUTOSEL 4.19 190/252] ide: remove set but not used variable 'hwif'

2020-02-14 Thread Sasha Levin
From: Wang Hai [ Upstream commit 98949a1946d70771789def0c9dbc239497f9f138 ] Fix the following gcc warning: drivers/ide/pmac.c: In function pmac_ide_setup_device: drivers/ide/pmac.c:1027:14: warning: variable hwif set but not used [-Wunused-but-set-variable] Fixes: d58b0c39e32f ("powerpc/

[PATCH AUTOSEL 4.14 140/186] ide: remove set but not used variable 'hwif'

2020-02-14 Thread Sasha Levin
From: Wang Hai [ Upstream commit 98949a1946d70771789def0c9dbc239497f9f138 ] Fix the following gcc warning: drivers/ide/pmac.c: In function pmac_ide_setup_device: drivers/ide/pmac.c:1027:14: warning: variable hwif set but not used [-Wunused-but-set-variable] Fixes: d58b0c39e32f ("powerpc/

[PATCH AUTOSEL 4.9 106/141] ide: remove set but not used variable 'hwif'

2020-02-14 Thread Sasha Levin
From: Wang Hai [ Upstream commit 98949a1946d70771789def0c9dbc239497f9f138 ] Fix the following gcc warning: drivers/ide/pmac.c: In function pmac_ide_setup_device: drivers/ide/pmac.c:1027:14: warning: variable hwif set but not used [-Wunused-but-set-variable] Fixes: d58b0c39e32f ("powerpc/

[PATCH AUTOSEL 4.4 074/100] ide: remove set but not used variable 'hwif'

2020-02-14 Thread Sasha Levin
From: Wang Hai [ Upstream commit 98949a1946d70771789def0c9dbc239497f9f138 ] Fix the following gcc warning: drivers/ide/pmac.c: In function pmac_ide_setup_device: drivers/ide/pmac.c:1027:14: warning: variable hwif set but not used [-Wunused-but-set-variable] Fixes: d58b0c39e32f ("powerpc/

Re: [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller

2009-12-01 Thread Tejun Heo
(cc'ing Holger Macht, please read the comment below pata_macio_mb_event()) Hello, On 12/01/2009 04:08 PM, Benjamin Herrenschmidt wrote: > This is a libata driver for the "macio" IDE controller used on most Apple > PowerMac and PowerBooks. It's a libata equivalent of dri

Re: [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller

2009-12-01 Thread Benjamin Herrenschmidt
ndeed still be busted, it will have to be updated I'm afraid as it's more/less hard coded to know about IDE gunk I'll have a look. The new yaboot maintainer (Tony Breeds) happens to sit 2 cubicles away from me at work so it shouldn't be a huge deal. Thanks f

Re: [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller

2009-12-01 Thread Mikael Pettersson
Benjamin Herrenschmidt writes: > This is a libata driver for the "macio" IDE controller used on most Apple > PowerMac and PowerBooks. It's a libata equivalent of drivers/ide/ppc/pmac.c > > It supports all the features of its predecessor, including mediabay hotplu

Re: [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller

2009-12-01 Thread Tejun Heo
On 12/01/2009 09:44 PM, Holger Macht wrote: > I do not remember any specific reason for using ata_port_schedule_eh(). I > guess it's just there because the previous implementation used > it. ata_port_freeze()/abort() might as well work properly. However, I > would hesitate to change the existing co

Re: [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller

2009-12-01 Thread Holger Macht
On Tuesday 01 December 2009 09:00:34 Tejun Heo wrote: > (cc'ing Holger Macht, please read the comment below pata_macio_mb_event()) > Hello, > > On 12/01/2009 04:08 PM, Benjamin Herrenschmidt wrote: > > This is a libata driver for the "macio" IDE controller us

Re: [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller

2009-12-01 Thread Andreas Schwab
Benjamin Herrenschmidt writes: > This is a libata driver for the "macio" IDE controller used on most Apple > PowerMac and PowerBooks. It's a libata equivalent of drivers/ide/ppc/pmac.c Tried it on my iBook G4 and I got an oops during probing, in pata_macio_common_init+

Re: [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller

2009-12-01 Thread Benjamin Herrenschmidt
On Tue, 2009-12-01 at 21:43 +0100, Andreas Schwab wrote: > Benjamin Herrenschmidt writes: > > > This is a libata driver for the "macio" IDE controller used on most Apple > > PowerMac and PowerBooks. It's a libata equivalent of drivers/ide/ppc/pmac.c > > Tr

Re: [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller

2009-12-01 Thread Benjamin Herrenschmidt
On Tue, 2009-12-01 at 21:43 +0100, Andreas Schwab wrote: > Benjamin Herrenschmidt writes: > > > This is a libata driver for the "macio" IDE controller used on most Apple > > PowerMac and PowerBooks. It's a libata equivalent of drivers/ide/ppc/pmac.c > > Tr

Re: [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller

2009-12-01 Thread Benjamin Herrenschmidt
On Tue, 2009-12-01 at 17:00 +0900, Tejun Heo wrote: > > +#define IDE_WAKEUP_DELAY (1*HZ) > > nitpick: In libata, it's common to use msecs for timing values so that > might be a better option. Yeah, that's cruft lifted from the old driver, I'll fix it. > > +static const struct pata_macio_timin

Re: [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller

2009-12-01 Thread Tejun Heo
Hello, On 12/02/2009 08:19 AM, Benjamin Herrenschmidt wrote: >> I think you'll need an ata_port_freeze() or abort() here because at >> this point the drive is already gone and all in-flight commands need >> to be failed right away. Holger, do you remember why >> ata_acpi_detach_device() is using

Re: [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller

2009-12-01 Thread Benjamin Herrenschmidt
On Wed, 2009-12-02 at 08:27 +0900, Tejun Heo wrote: > Conceptually freeze would be more approriate but the side effect is > that the port is frozen and EH will try to thaw it by resetting it. > So, abort would work better. BTW. For a plug event, what should I do ? freeze is fine ? Or just schedule

Re: [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller

2009-12-01 Thread Tejun Heo
On 12/02/2009 08:35 AM, Benjamin Herrenschmidt wrote: > On Wed, 2009-12-02 at 08:27 +0900, Tejun Heo wrote: >> Conceptually freeze would be more approriate but the side effect is >> that the port is frozen and EH will try to thaw it by resetting it. >> So, abort would work better. > > BTW. For a p

Re: [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller

2009-12-01 Thread Benjamin Herrenschmidt
On Wed, 2009-12-02 at 08:44 +0900, Tejun Heo wrote: > > BTW. For a plug event, what should I do ? freeze is fine ? Or just > > schedule eh ? Right now, when plugging I see an exception Emask 0x10 > > etc... message in the log when plugging which isn't totally nice :-) > > freeze() and please don't

Re: [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller

2009-12-01 Thread Tejun Heo
On 12/02/2009 09:36 AM, Benjamin Herrenschmidt wrote: > This is a libata driver for the "macio" IDE controller used on most Apple > PowerMac and PowerBooks. It's a libata equivalent of drivers/ide/ppc/pmac.c > > It supports all the features of its predecessor, inclu

Re: [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller

2009-12-01 Thread Benjamin Herrenschmidt
On Wed, 2009-12-02 at 10:07 +0900, Tejun Heo wrote: > On 12/02/2009 09:36 AM, Benjamin Herrenschmidt wrote: > > This is a libata driver for the "macio" IDE controller used on most Apple > > PowerMac and PowerBooks. It's a libata equivalent of drivers/ide/ppc/pmac.

Re: [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller

2009-12-01 Thread Tejun Heo
Hello, On 12/02/2009 10:51 AM, Benjamin Herrenschmidt wrote: > I'm not sure what media bay locking problem you mentioned tho... > > The way the driver does the locking now is that I block the media-bay > thread (lock/unlock_media_bay calls) around initial registration and > driver removal which b

Re: [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller

2009-12-02 Thread Andreas Schwab
Benjamin Herrenschmidt writes: > v2. Better tested now, seems to be reasonably solid. > > Addressed Tejun comments and made remove more robust vs. media-bay, > should also fix Andreas problem. Thanks, this works fine now, including suspend *and* resume. :-) Andreas. -- Andreas Schwab, sch...@

Re: [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller

2009-12-03 Thread Jeff Garzik
On 12/01/2009 07:36 PM, Benjamin Herrenschmidt wrote: This is a libata driver for the "macio" IDE controller used on most Apple PowerMac and PowerBooks. It's a libata equivalent of drivers/ide/ppc/pmac.c It supports all the features of its predecessor, including mediabay hotp

Re: [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller

2009-12-03 Thread Mikael Pettersson
Benjamin Herrenschmidt writes: > This is a libata driver for the "macio" IDE controller used on most Apple > PowerMac and PowerBooks. It's a libata equivalent of drivers/ide/ppc/pmac.c > > It supports all the features of its predecessor, including mediabay hotplu

Re: [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller

2009-12-03 Thread Benjamin Herrenschmidt
On Thu, 2009-12-03 at 03:12 -0500, Jeff Garzik wrote: > Looks fine to me. Two minor comments, which might perhaps be ignored if > that is your taste: > > * prefer enums to #define's, for constants yeah well ... I lifted those definitions from the old driver and didn't feel like changing them a

[PATCH 11/18] ide-generic: add ide_generic class and attribute for adding new interfaces

2008-02-07 Thread Bartlomiej Zolnierkiewicz
intended to be a replacement for obsoleted "idex=base[,ctl[,irq]]" kernel parameters). Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- +391 bytes (x86-32) I also tried interface based on kernel parameters but it sucked (more complex, bigger source code + resu

Re: [BUID_FAILURE] next-20080215 Build failure caused by ide: rework PowerMac media-bay support

2008-02-16 Thread Bartlomiej Zolnierkiewicz
platforms] Error 2 > > This build failure is caused by the ide: rework PowerMac media-bay support > patch.This problem was reported and solution suggested according to > http://lkml.org/lkml/2008/2/13/195 including the > > #include after > > #ifdef CONFIG_BLK_DEV_

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-25 Thread Sergei Shtylyov
reg = < 1000>; > }; > > + [EMAIL PROTECTED] { > + compatible = "mmio-ide"; > + device_type = "ide"; Why not "ata"? > + reg = ; > + ioport_shift = <1>; Please u

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-25 Thread Scott Wood
reg = < 1000>; > }; > > + [EMAIL PROTECTED] { > + compatible = "mmio-ide"; > + device_type = "ide"; > + reg = ; > + ioport_shift = <1>; > + interrupts =

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-25 Thread Sergei Shtylyov
5 @@ >> reg = < 1000>; >> }; >> >>+ [EMAIL PROTECTED] { >>+ compatible = "mmio-ide"; >>+ device_type = "ide"; > Why not "ata"? Also, what mmio-ide in the compat

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-25 Thread Sergei Shtylyov
Scott Wood wrote: >>Also, what mmio-ide in the compat properly means in the context of >>ide_platform which is able to handle both port and memory mapped IDE. >>I think we must get rid with this crap, and since this IDE register >>mapping is pretty much board specific

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-25 Thread Sergei Shtylyov
Hello. Scott Wood wrote: >>Also, what mmio-ide in the compat properly means in the context of >>ide_platform which is able to handle both port and memory mapped IDE. > I/O-space is only valid in the context of PCI, ISA, or similar buses, and > the bus-specific reg format

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-25 Thread Sergei Shtylyov
Scott Wood wrote: >> Scott Wood wrote: >>>> Also, what mmio-ide in the compat properly means in the context >>>> of ide_platform which is able to handle both port and memory mapped >>>> IDE. >>> I/O-space is only valid in the context

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-26 Thread Sergei Shtylyov
Hello. Vitaly Bordug wrote: >>> I acn undertand your complaint in the context of an OF driver >>>(which we don't have yet) but "mmio-ide" just means nothing to the >>>current driver, and it doesn't convery enough info on the >>>programmi

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-26 Thread Vitaly Bordug
On Wed, 25 Jul 2007 13:46:57 -0500 Scott Wood wrote: > Sergei Shtylyov wrote: > >I acn undertand your complaint in the context of an OF driver > > (which we don't have yet) but "mmio-ide" just means nothing to the > > current driver, and it doesn't c

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-26 Thread Vitaly Bordug
f --git a/arch/powerpc/boot/dts/mpc8349emitx.dts > > b/arch/powerpc/boot/dts/mpc8349emitx.dts index db0d003..f8f0e8a > > 100644 --- a/arch/powerpc/boot/dts/mpc8349emitx.dts > > +++ b/arch/powerpc/boot/dts/mpc8349emitx.dts > > @@ -37,6 +37,15 @@ > > reg = <00

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-25 Thread Scott Wood
Sergei Shtylyov wrote: >I acn undertand your complaint in the context of an OF driver (which > we don't have yet) but "mmio-ide" just means nothing to the current > driver, and it doesn't convery enough info on the programming interface > for the conceivable

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-26 Thread Sergei Shtylyov
Hello, I wrote: >>>>> Also, what mmio-ide in the compat properly means in the context >>>>>of ide_platform which is able to handle both port and memory mapped >>>>>IDE. >>>>I/O-space is only valid in the context of PCI, ISA, o

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-25 Thread Scott Wood
On Wed, Jul 25, 2007 at 09:54:07PM +0400, Sergei Shtylyov wrote: > Also, what mmio-ide in the compat properly means in the context of > ide_platform which is able to handle both port and memory mapped IDE. I/O-space is only valid in the context of PCI, ISA, or similar buses, and t

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-25 Thread Scott Wood
Sergei Shtylyov wrote: > Hello. > > Scott Wood wrote: > >>> Also, what mmio-ide in the compat properly means in the context of >>> ide_platform which is able to handle both port and memory mapped IDE. > > >> I/O-space is only valid in the context

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-31 Thread Segher Boessenkool
>>> + [EMAIL PROTECTED] { >>> + compatible = "mmio-ide"; >>> + device_type = "ide"; > >> Why not "ata"? The hardware is called (E)IDE, the protocol is called ATA. Or that's what I was told -- I think

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-31 Thread Segher Boessenkool
hift and > being done with it? reg-shift alone isn't enough to know how to access the device registers. In the case of UARTs, they typically are internal to some SoC, so the device driver can just look up what SoC it is and will then know what to do. For IDE though, as far as I und

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-31 Thread Alan Cox
> The hardware is called (E)IDE, the protocol is called ATA. > Or that's what I was told -- I think there's some historic > revisionism involved, too. ATA is the interface and standards for the ANSI standards based disk attachment. IDE "Integrated Drive Electronics"

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-08-01 Thread Sergei Shtylyov
Hello. Segher Boessenkool wrote: >>>> +[EMAIL PROTECTED] { >>>> + compatible = "mmio-ide"; >>>> +device_type = "ide"; >>> Why not "ata"? > The hardware is called (E)IDE, the protocol is call

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-08-06 Thread Segher Boessenkool
>> The hardware is called (E)IDE, the protocol is called ATA. >> Or that's what I was told -- I think there's some historic >> revisionism involved, too. > > ATA is the interface and standards for the ANSI standards based disk > attachment. IDE "Integra

<    1   2   3   4