Re: [RFC PATCH V3 3/5] powerpc/cpuidle: Generic powerpc backend cpuidle driver.

2013-08-23 Thread Deepthi Dharwar
On 08/23/2013 02:54 AM, Scott Wood wrote: > On Thu, 2013-08-22 at 11:20 +0530, Deepthi Dharwar wrote: >> On 08/22/2013 01:38 AM, Scott Wood wrote: >>> On Wed, 2013-08-21 at 10:23 +0530, Deepthi Dharwar wrote: On 08/19/2013 11:47 PM, Scott Wood wrote: > What actual functionality is common t

Re: [RFC PATCH V3 3/5] powerpc/cpuidle: Generic powerpc backend cpuidle driver.

2013-08-22 Thread Scott Wood
On Thu, 2013-08-22 at 11:20 +0530, Deepthi Dharwar wrote: > On 08/22/2013 01:38 AM, Scott Wood wrote: > > On Wed, 2013-08-21 at 10:23 +0530, Deepthi Dharwar wrote: > >> On 08/19/2013 11:47 PM, Scott Wood wrote: > >>> What actual functionality is common to all powerpc but not common to > >>> other a

Re: [RFC PATCH V3 3/5] powerpc/cpuidle: Generic powerpc backend cpuidle driver.

2013-08-21 Thread Deepthi Dharwar
On 08/22/2013 11:28 AM, Benjamin Herrenschmidt wrote: > On Thu, 2013-08-22 at 11:20 +0530, Deepthi Dharwar wrote: >> But if having cpuidle backend-driver separately for other powerpc arcs >> makes sense such that each one have their own state information etc >> then it makes sense to name the files

Re: [RFC PATCH V3 3/5] powerpc/cpuidle: Generic powerpc backend cpuidle driver.

2013-08-21 Thread Benjamin Herrenschmidt
On Thu, 2013-08-22 at 11:20 +0530, Deepthi Dharwar wrote: > But if having cpuidle backend-driver separately for other powerpc arcs > makes sense such that each one have their own state information etc > then it makes sense to name the files as cpuidle-power.c, > cpuilde-ppc32.c and so on. If by "p

Re: [RFC PATCH V3 3/5] powerpc/cpuidle: Generic powerpc backend cpuidle driver.

2013-08-21 Thread Deepthi Dharwar
On 08/22/2013 01:38 AM, Scott Wood wrote: > On Wed, 2013-08-21 at 10:23 +0530, Deepthi Dharwar wrote: >> On 08/19/2013 11:47 PM, Scott Wood wrote: >>> On Mon, 2013-08-19 at 15:48 +0530, Deepthi Dharwar wrote: Hi Dongsheng, On 08/19/2013 11:22 AM, Wang Dongsheng-B40534 wrote: > I

Re: [RFC PATCH V3 3/5] powerpc/cpuidle: Generic powerpc backend cpuidle driver.

2013-08-21 Thread Scott Wood
On Wed, 2013-08-21 at 10:23 +0530, Deepthi Dharwar wrote: > On 08/19/2013 11:47 PM, Scott Wood wrote: > > On Mon, 2013-08-19 at 15:48 +0530, Deepthi Dharwar wrote: > >> Hi Dongsheng, > >> > >> On 08/19/2013 11:22 AM, Wang Dongsheng-B40534 wrote: > >>> I think we should move the states and handle fu

Re: [RFC PATCH V3 3/5] powerpc/cpuidle: Generic powerpc backend cpuidle driver.

2013-08-20 Thread Deepthi Dharwar
On 08/19/2013 11:47 PM, Scott Wood wrote: > On Mon, 2013-08-19 at 15:48 +0530, Deepthi Dharwar wrote: >> Hi Dongsheng, >> >> On 08/19/2013 11:22 AM, Wang Dongsheng-B40534 wrote: >>> I think we should move the states and handle function to >>> arch/power/platform* >>> The states and handle function

Re: [RFC PATCH V3 3/5] powerpc/cpuidle: Generic powerpc backend cpuidle driver.

2013-08-19 Thread Scott Wood
On Mon, 2013-08-19 at 15:48 +0530, Deepthi Dharwar wrote: > Hi Dongsheng, > > On 08/19/2013 11:22 AM, Wang Dongsheng-B40534 wrote: > > I think we should move the states and handle function to > > arch/power/platform* > > The states and handle function is belong to backend driver, not for this, >

Re: [RFC PATCH V3 3/5] powerpc/cpuidle: Generic powerpc backend cpuidle driver.

2013-08-19 Thread Deepthi Dharwar
Hi Dongsheng, On 08/19/2013 11:22 AM, Wang Dongsheng-B40534 wrote: > I think we should move the states and handle function to arch/power/platform* > The states and handle function is belong to backend driver, not for this, > different platform have different state. > Different platforms to make

RE: [RFC PATCH V3 3/5] powerpc/cpuidle: Generic powerpc backend cpuidle driver.

2013-08-18 Thread Wang Dongsheng-B40534
I think we should move the states and handle function to arch/power/platform* The states and handle function is belong to backend driver, not for this, different platform have different state. Different platforms to make their own deal with these states. I think we cannot put all the status of di