Re: [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure

2024-03-04 Thread Tasmiya Nalatwad
Greetings, The build error is seen on linux-next and mainline also Mainline : 6.8.0-rc7 linux-next : 6.8.0-rc7-next-20240304 --- Traces --- net/core/dev.c: In function ‘netdev_dpll_pin_assign’: ./include/linux/rcupdate.h:462:36: error: dereferencing pointer to incomplete type ‘struct dpll_pi

Re: [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure

2024-02-29 Thread Tasmiya Nalatwad
Greetings, This is tied to gcc version. Build failure is seen while using gcc-8.5.x On 2/29/24 20:17, Jakub Kicinski wrote: On Thu, 29 Feb 2024 09:55:22 +0100 Eric Dumazet wrote: I do not see other solution than this, otherwise we have to add more pollution to include/linux/netdevice.h Right

Re: [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure

2024-02-29 Thread Eric Dumazet
On Thu, Feb 29, 2024 at 3:53 PM Eric Dumazet wrote: > > On Thu, Feb 29, 2024 at 3:47 PM Jakub Kicinski wrote: > > > > On Thu, 29 Feb 2024 09:55:22 +0100 Eric Dumazet wrote: > > > I do not see other solution than this, otherwise we have to add more > > > pollution to include/linux/netdevice.h > >

Re: [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure

2024-02-29 Thread Eric Dumazet
On Thu, Feb 29, 2024 at 3:47 PM Jakub Kicinski wrote: > > On Thu, 29 Feb 2024 09:55:22 +0100 Eric Dumazet wrote: > > I do not see other solution than this, otherwise we have to add more > > pollution to include/linux/netdevice.h > > Right :( > > > diff --git a/include/linux/netdevice.h b/include/l

Re: [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure

2024-02-29 Thread Jakub Kicinski
On Thu, 29 Feb 2024 09:55:22 +0100 Eric Dumazet wrote: > I do not see other solution than this, otherwise we have to add more > pollution to include/linux/netdevice.h Right :( > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index > a9c973b92294bb110cf3cd336485972127b01b58.

Re: [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure

2024-02-29 Thread Vadim Fedorenko
On 29/02/2024 08:55, Eric Dumazet wrote: On Thu, Feb 29, 2024 at 9:04 AM Tasmiya Nalatwad wrote: Greetings, I have tried the patch provided below. Moving struct to file "net/core/rtnetlink.c" is not resolving the problem. Please find the below traces. --- Traces --- In file included from ./

Re: [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure

2024-02-29 Thread Tasmiya Nalatwad
Latest changes suggested below works, and the issue is not seen. Tested-by: Tasmiya Nalatwad On 2/29/24 14:25, Eric Dumazet wrote: On Thu, Feb 29, 2024 at 9:04 AM Tasmiya Nalatwad wrote: Greetings, I have tried the patch provided below. Moving struct to file "net/core/rtnetlink.c" is not re

Re: [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure

2024-02-29 Thread Eric Dumazet
On Thu, Feb 29, 2024 at 9:04 AM Tasmiya Nalatwad wrote: > > Greetings, > > I have tried the patch provided below. Moving struct to file > "net/core/rtnetlink.c" is not resolving the problem. Please find the > below traces. > > --- Traces --- > > In file included from ./include/linux/rbtree.h:24, >

Re: [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure

2024-02-29 Thread Tasmiya Nalatwad
Greetings, I have tried the patch provided below. Moving struct to file "net/core/rtnetlink.c" is not resolving the problem. Please find the below traces. --- Traces --- In file included from ./include/linux/rbtree.h:24, from ./include/linux/mm_types.h:11, f

Re: [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure

2024-02-28 Thread Christophe Leroy
Le 28/02/2024 à 15:43, Eric Dumazet a écrit : > On Wed, Feb 28, 2024 at 3:07 PM Vadim Fedorenko > wrote: >> >> On 28/02/2024 11:09, Tasmiya Nalatwad wrote: >>> Greetings, >>> >>> [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure >>> >>> Reverting below commit fixes the issue >>> >>> c

Re: [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure

2024-02-28 Thread Eric Dumazet
On Wed, Feb 28, 2024 at 3:07 PM Vadim Fedorenko wrote: > > On 28/02/2024 11:09, Tasmiya Nalatwad wrote: > > Greetings, > > > > [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure > > > > Reverting below commit fixes the issue > > > > commit 0d60d8df6f493bb46bf5db40d39dd60a1bafdd4e > >

Re: [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure

2024-02-28 Thread Vadim Fedorenko
On 28/02/2024 11:09, Tasmiya Nalatwad wrote: Greetings, [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure Reverting below commit fixes the issue commit 0d60d8df6f493bb46bf5db40d39dd60a1bafdd4e     dpll: rely on rcu for netdev_dpll_pin() --- Traces --- ./include/linux/dpll.h: In f