Re: [Linuxptp-devel] [PATCH v3 02/11] Respond with an error to management messages to non-existing ports

2014-05-03 Thread Richard Cochran
On Fri, May 02, 2014 at 12:37:45PM +0200, Jiri Benc wrote: Signed-off-by: Jiri Benc jb...@redhat.com --- Applied. Thanks, Richard -- Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run

Re: [Linuxptp-devel] [PATCH v3 03/11] Remove unneeded parameter in port_forward

2014-05-03 Thread Richard Cochran
On Fri, May 02, 2014 at 12:37:46PM +0200, Jiri Benc wrote: This parameter was made obsolete by the common address refactoring. Signed-off-by: Jiri Benc jb...@redhat.com --- Applied. Thanks, Richard -- Accelerate

Re: [Linuxptp-devel] [PATCH v3 04/11] Implement port_forward_to

2014-05-03 Thread Richard Cochran
On Fri, May 02, 2014 at 12:37:47PM +0200, Jiri Benc wrote: Signed-off-by: Jiri Benc jb...@redhat.com --- Applied. Thanks, Richard -- Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run

Re: [Linuxptp-devel] [PATCH v3 06/11] Include TLV in replies to management commands

2014-05-03 Thread Richard Cochran
On Fri, May 02, 2014 at 12:37:49PM +0200, Jiri Benc wrote: The standard requires management TLV in replies to commands: An acknowledge management message is a response to a command management message. The value of the managementId shall be identical to that in the command

Re: [Linuxptp-devel] [PATCH v3 07/11] Subscription time limit

2014-05-03 Thread Richard Cochran
On Fri, May 02, 2014 at 12:37:50PM +0200, Jiri Benc wrote: Add expiration time to subscriptions; they need to be renewed before they expiry. This way, the subscription automatically times out when phc2sys is killed. Signed-off-by: Jiri Benc jb...@redhat.com --- clock.c | 27

Re: [Linuxptp-devel] [PATCH v3 08/11] port: event notification

2014-05-03 Thread Richard Cochran
On Fri, May 02, 2014 at 12:37:51PM +0200, Jiri Benc wrote: Split management message creation to more fine-grained functions to allow notification messages to be created. I must admit I didn't understand what you did, at first reading. Can you lose a few words about how you split the code and