Re: [Linuxptp-devel] [PATCH RFC v3 00/69] New configuration implementation

2015-08-17 Thread Richard Cochran
On Mon, Aug 17, 2015 at 06:53:35AM +, Keller, Jacob E wrote: > > You converted the PI options, but I can't figure exactly how they > were read. There doesn't appear to be any calls to "config_get_int" > or config_get_dbl for them in their respective patches. You are right, Jake. I forgot the

Re: [Linuxptp-devel] [PATCH RFC v3 00/69] New configuration implementation

2015-08-17 Thread Keller, Jacob E
> -Original Message- > From: Richard Cochran [mailto:richardcoch...@gmail.com] > You are right, Jake. I forgot the config_get_dbl() calls. It is hard > to express how mind numbing this conversion work is. On top of that, > I must have rebased this series dozens of times, in order to re

Re: [Linuxptp-devel] [PATCH RFC v3 00/69] New configuration implementation

2015-08-17 Thread Keller, Jacob E
> -Original Message- > From: Keller, Jacob E [mailto:jacob.e.kel...@intel.com] > Sent: Monday, August 17, 2015 1:54 AM > To: Richard Cochran > Cc: linuxptp-devel@lists.sourceforge.net > Subject: Re: [Linuxptp-devel] [PATCH RFC v3 00/69] New configuration > implementation > > > -Origina

Re: [Linuxptp-devel] [PATCH RFC v3 00/69] New configuration implementation

2015-08-17 Thread Richard Cochran
On Mon, Aug 17, 2015 at 09:18:31AM +, Keller, Jacob E wrote: > With some clever use of ack and sed, I did a search for all uses of > config_(double|int)_ that grabbed the various options. The only ones missing > are: > > "pi_integral_exponent" > "pi_integral_norm_max" > "pi_integral_scale" >

Re: [Linuxptp-devel] [PATCH RFC v3 00/69] New configuration implementation

2015-08-17 Thread Miroslav Lichvar
On Sun, Aug 16, 2015 at 10:14:57PM +0200, Richard Cochran wrote: > So in the long run this basis will help us keep the configuration > stuff under control. I have done lots of build testing and minimal > run time testing. Since this series rather large, I pushed the branch > to github in the hope

Re: [Linuxptp-devel] [PATCH RFC v3 00/69] New configuration implementation

2015-08-17 Thread Richard Cochran
On Mon, Aug 17, 2015 at 05:14:18PM +0200, Miroslav Lichvar wrote: > Nice. I like the design. I guess it won't be too difficult to add > string to the supported types and convert the remaining old config > code. Maybe, but I need to take breather from my conversion marathon! BTW, I ran your linuxp

Re: [Linuxptp-devel] [PATCH RFC v3 00/69] New configuration implementation

2015-08-17 Thread Keller, Jacob E
> -Original Message- > From: Richard Cochran [mailto:richardcoch...@gmail.com] > Sent: Monday, August 17, 2015 8:44 AM > To: Miroslav Lichvar > Cc: linuxptp-devel@lists.sourceforge.net > Subject: Re: [Linuxptp-devel] [PATCH RFC v3 00/69] New configuration > implementation > > On Mon, Aug 1

Re: [Linuxptp-devel] [PATCH RFC v3 00/69] New configuration implementation

2015-08-17 Thread Richard Cochran
On Mon, Aug 17, 2015 at 04:15:59PM +, Keller, Jacob E wrote: > Where is the linuxptp-testsuite hosted? https://github.com/mlichvar/linuxptp-testsuite.git You also need: https://github.com/mlichvar/clknetsim.git Cheers, Richard ---

Re: [Linuxptp-devel] [PATCH RFC v3 00/69] New configuration implementation

2015-08-17 Thread Keller, Jacob E
> -Original Message- > From: Richard Cochran [mailto:richardcoch...@gmail.com] > Sent: Monday, August 17, 2015 1:49 PM > To: Keller, Jacob E > Cc: Miroslav Lichvar; linuxptp-devel@lists.sourceforge.net > Subject: Re: [Linuxptp-devel] [PATCH RFC v3 00/69] New configuration > implementation >