Re: [Linuxptp-devel] [PATCH 1/1] Add possibility to set clockIdentity

2018-09-14 Thread Anders Selhammer
Thursday, September 13, 2018 7:07 PM > Just make sure it's documented that all 00s in the config will autogenerate > it. Yes, do you think this is well documented? --- ptp4l.8 --- index 10c5c2f..a485250 100644 @@ -395,6 +395,13 @

Re: [Linuxptp-devel] [PATCH 1/1] Add possibility to set clockIdentity

2018-09-14 Thread Anders Selhammer
Thursday, September 13, 2018 5:01 PM > Thanks for the explanation. > Wouldn't it make more sense to allow adding ports on-the-fly? > The code is ready for this (or at least, someone did the ground work a > few years ago). Yes, that would be great also but it will not solve the clockIdentity prob

Re: [Linuxptp-devel] [PATCH 1/1] G8275 - maxStepsRemoved

2018-09-14 Thread Anders Selhammer
Thursday, September 13, 2018 4:59 PM > Alright, you talked me into it. Great I realized that I forgot the ptp4l.8 in this patch also, I will send in an update before you apply it. /Anders ___ Linuxptp-devel mailing list Linuxptp-devel@lists.sourc

Re: [Linuxptp-devel] [PATCH 1/1] G8275 - maxStepsRemoved

2018-09-14 Thread Anders Selhammer
Thursday, September 13, 2018 4:59 PM >> Alright, you talked me into it. >Great >I realized that I forgot the ptp4l.8 in this patch also, I will send in an >update >before you apply it. I also realized that this attribute is included in v2.1 like masterOnly. I will then leave out the telecom pr

[Linuxptp-devel] [PATCHv2 1/1] Introduce the maxStepsRemoved attribute

2018-09-14 Thread Anders Selhammer
Add attribute maxStepsRemoved which is included in IEEE1588-2017 (v2.1) It is an optional attribute which can decide if an Announce message is considered in the operation of the BMCA or not. Signed-off-by: Anders Selhammer --- clock.c | 7 +++ clock.h | 7 +++ c

[Linuxptp-devel] [PATCHv2 1/1] Add possibility to set clockIdentity

2018-09-14 Thread Anders Selhammer
Currently the clockIdentity is generated from the mac address of the first interface/port in config file. This patch add the possibility to set it in config file. The reason is if the stack is restarted with a different set of ports, it may be circumstances when clockIdentity needs to be equal as b

Re: [Linuxptp-devel] [PATCH 1/1] Add possibility to set clockIdentity

2018-09-14 Thread Richard Cochran
On Fri, Sep 14, 2018 at 07:04:45AM +, Anders Selhammer wrote: > Yes, that would be great also but it will not solve the clockIdentity problem > since the > Identity will stay the same until next restart. And it the port setup is > different, the > identity will change. (and the connented slav

Re: [Linuxptp-devel] [PATCHv2 1/1] Add possibility to set clockIdentity

2018-09-14 Thread Richard Cochran
On Fri, Sep 14, 2018 at 11:14:58AM +0200, Anders Selhammer wrote: > Currently the clockIdentity is generated from the mac address of the first > interface/port in config file. This patch add the possibility to set it in > config file. > The reason is if the stack is restarted with a different set o

Re: [Linuxptp-devel] [PATCH] add report of PTP_SYS_OFFSET_PRECISE support to phc_ctl

2018-09-14 Thread FUSTE Emmanuel
Le 14/09/2018 à 06:37, Richard Cochran a écrit : > On Thu, Aug 16, 2018 at 03:22:51PM +, FUSTE Emmanuel wrote: >> diff --git a/phc_ctl.c b/phc_ctl.c >> index 4a78a19..f6234da 100644 >> --- a/phc_ctl.c >> +++ b/phc_ctl.c >> @@ -353,12 +353,14 @@ static int do_caps(clockid_t clkid, int cmdc, char

Re: [Linuxptp-devel] [PATCH 1/1] Add possibility to set clockIdentity

2018-09-14 Thread Keller, Jacob E
> -Original Message- > From: Richard Cochran [mailto:richardcoch...@gmail.com] > Sent: Friday, September 14, 2018 7:33 AM > To: Anders Selhammer > Cc: linuxptp-devel@lists.sourceforge.net > Subject: Re: [Linuxptp-devel] [PATCH 1/1] Add possibility to set clockIdentity > > On Fri, Sep 14,

Re: [Linuxptp-devel] [PATCH] add report of PTP_SYS_OFFSET_PRECISE support to phc_ctl

2018-09-14 Thread Keller, Jacob E
> -Original Message- > From: FUSTE Emmanuel [mailto:emmanuel.fu...@thalesgroup.com] > Sent: Friday, September 14, 2018 8:57 AM > To: Richard Cochran > Cc: linuxptp-devel@lists.sourceforge.net > Subject: Re: [Linuxptp-devel] [PATCH] add report of PTP_SYS_OFFSET_PRECISE > support to phc_ct