Re: [Linuxptp-devel] [PATCH v2 0/1] Last (?) patch before version 4 release

2023-04-15 Thread Vincent Cheng
On Sat, Apr 15, 2023 at 05:29:32PM -0700, Richard Cochran wrote: > Based on Erez's review, I expanded Christopher's patch to remove the > control field codes completely. I've tested this with the following > hardware, and nothing broke: > > Intel I210 > Intel X550T > LabX Titanium 411 AVB switch

Re: [Linuxptp-devel] [PATCH] Set controlField to zero in message headers

2023-04-15 Thread Richard Cochran
On Thu, Mar 16, 2023 at 02:58:33PM +0100, Andrew Zaborowski wrote: > I was now made aware that Avnu conformance tests for 802.1AS-2011 do > validate the 3 different values required in the control field in that > version of IEEE802.1AS. While 1588-2008 did already say that the use > of this field

[Linuxptp-devel] [PATCH v2 0/1] Last (?) patch before version 4 release

2023-04-15 Thread Richard Cochran
Based on Erez's review, I expanded Christopher's patch to remove the control field codes completely. I've tested this with the following hardware, and nothing broke: Intel I210 Intel X550T LabX Titanium 411 AVB switch Please give this a try with your favorite hardware time stamping device. I'd

[Linuxptp-devel] [PATCH v2 1/1] Set controlField to zero in message headers

2023-04-15 Thread Richard Cochran
From: Christopher S M Hall IEEE1588-2019 and 802.1AS-2020 both require the field to be 0 in transmitted messages except when the "version 1 hardware option" is set (IEEE1588-2019 C.4.2) and only with IPv4. Since ptp4l isn't padding the UDP messages to 124 bytes as required for compatibility with