On Mon, Apr 17, 2023 at 10:50:35AM +0200, Miroslav Lichvar wrote:
> On Sat, Apr 15, 2023 at 09:57:52PM -0400, Vincent Cheng wrote:
> > Compile issue after applying patch against master commit:
> >
> > commit 60d829b102be9b8b13357a0f7a93f3e02d44b4ce
> > Author: Maci
On Sat, Apr 15, 2023 at 05:29:32PM -0700, Richard Cochran wrote:
> Based on Erez's review, I expanded Christopher's patch to remove the
> control field codes completely. I've tested this with the following
> hardware, and nothing broke:
>
> Intel I210
> Intel X550T
> LabX Titanium 411 AVB switch
From: Vincent Cheng
In case of broken network there may be an absolute absence of delay packets.
In this scenario ptp4l log messages do not indicate anything is wrong because
the delay response timer is only activate for LOCKED servo state.
This patch expands the delay_response_timeout feature
From: Vincent Cheng
Sending delay requests prior to getting a delay response grant will incur
unnecessary
delay_response_timeout errors if the remote master only responds to delay
requests
when a delay reponse request was granted.
Signed-off-by: Vincent Cheng
---
port.c | 4 +++-
1 file
From: Vincent Cheng
The original intent of the delay_response_timeout submission was to kick servo
out of LOCKED state if a valid delay response was not received within the
configurable delay response timeout duration. In case of broken network there
may be an absolute absence of delay
From: Vincent Cheng
Signed-off-by: Vincent Cheng
---
unicast_client.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/unicast_client.c b/unicast_client.c
index 1d84183..e635db1 100644
--- a/unicast_client.c
+++ b/unicast_client.c
@@ -500,6 +500,7 @@ void unicast_client_grant(struct port *p
From: Vincent Cheng
Signed-off-by: Vincent Cheng
---
unicast_client.c | 20
unicast_client.h | 8
2 files changed, 28 insertions(+)
diff --git a/unicast_client.c b/unicast_client.c
index 0843554..ef7fc5c 100644
--- a/unicast_client.c
+++ b/unicast_client.c
From: Vincent Cheng
Problem
===
When local data set has better clock class than remote server, log shows best
master is foreign clock.
Expected log to show local clock is best master.
===
| Client 080027.fffe.799fc5
From: Vincent Cheng
When local clock data set is better than remote server, log message says remote
server is best master. The port states are correct.
ex. local clock is clock class 6 and remote server on port 1 is clock class 7.
ptp4l[5709.306]: selected best master clock 080027
On Fri, Jan 27, 2023 at 05:58:24AM -0800, Vadim Fedorenko via Linuxptp-devel
wrote:
> In case of broken network there is a possibility of having management
> packets with proper data but absolute absence of sync packets. In such
> case the selected best master will stuck in HAVE_SYDY state
On Mon, Jan 09, 2023 at 04:09:29PM +, Vincent Cheng wrote:
>
>
> -Original Message-
> From: Rahul Rameshbabu via Linuxptp-devel
>
> Sent: Tuesday, December 20, 2022 4:37 PM
> To: linuxptp-devel@lists.sourceforge.net
> Cc: Gal Pressman ; Saeed Mahameed ; Ta
On Thu, Dec 08, 2022 at 10:36:57AM EST, Richard Cochran wrote:
>On Fri, Dec 02, 2022 at 03:33:42PM -0500, vincent.cheng...@renesas.com wrote:
>
>> @@ -2015,6 +2027,8 @@ static void handle_state_decision_event(struct clock
>> *c)
>> c->best = best;
>> c->best_id = best_id;
>>
>> +
From: Vincent Cheng
Signed-off-by: Vincent Cheng
---
unicast_client.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/unicast_client.h b/unicast_client.h
index e643cb2..4a4d345 100644
--- a/unicast_client.h
+++ b/unicast_client.h
@@ -93,7 +93,7 @@ int unicast_client_timer
From: Vincent Cheng
On termination of a ptp4l unicast session, ptp4l sends
CANCEL_UNICAST_TRANSMISSION for announce, sync and delay
response messages for all entries of the unicast master table
regardless if the service is active or inactive.
This patch modifies unicast_client_tx_cancel
From: Vincent Cheng
When a unicast master is no longer the best master, an UC_EV_UNSELECTED
event occurs for that unicast master entry. However, the sync/delay_response
contracts are not explicitly cancelled.
This patch updates unicast_client_state_changed() to send
CANCEL_UNICAST_TRANSMISSION
From: Vincent Cheng
This patch set improves the sending of CANCEL_UNICAST_TRANSMISSION to cancel
service.
Currently all entries in the unicast master table receive
CANCEL_UNICAST_TRANSMISSION
for announce and sync/delay_response messages regardless if the service is
active or inactive
On Sat, Mar 12, 2022 at 09:33:18PM EST, Richard Cochran wrote:
>On Sat, Mar 12, 2022 at 06:07:11PM -0500, vincent.cheng...@renesas.com wrote:
>
>> However, because there is no checking of received unicast master to
>> configured
>> unicast table, ptp4l is quite content with packets from previous
On Sun, Feb 21, 2021 at 02:08:02PM EST, Richard Cochran wrote:
>On Mon, Feb 15, 2021 at 09:58:53AM -0500, vincent.cheng...@renesas.com wrote:
>> @@ -1730,7 +1743,10 @@ enum servo_state clock_synchronize(struct clock *c,
>> tmv_t ingress, tmv_t origin)
>>
>> c->cur.offsetFromMaster =
On Sun, Feb 14, 2021 at 11:22:13PM EST, Richard Cochran wrote:
>Vincent,
>
>This is shaping up nicely. I only have a few nits to pick...
Thank-you for taking the time to point them out.
>On Sun, Feb 14, 2021 at 05:22:09PM -0500, vincent.cheng...@renesas.com wrote:
>
>> @@ -1193,6 +1195,9 @@
On Sun, Feb 14, 2021 at 04:30:29AM EST, Luigi 'Comio' Mantellini wrote:
>Hi,
>
>This patch cover my scenario where the timestamper can be aligned once at
>second.
>Can I suggest to a avoid to touch free_running variable and introduce
>another one?
Hi Luigi,
Sure. Fixed in v3 patch.
Vincent
On Sat, Feb 13, 2021 at 10:28:32AM EST, Richard Cochran wrote:
>On Mon, Feb 01, 2021 at 05:55:41PM -0500, vincent.cheng...@renesas.com wrote:
>
>> +/* Set up timer expire notification mechanism */
>> +se.sigev_notify = SIGEV_THREAD;
>> +se.sigev_value.sival_ptr = (void *)c;
>> +
Hi Jacob,
On Thu, Jan 07, 2021 at 02:33:56PM EST, Jacob Keller wrote:
>
>
>On 1/6/2021 11:39 AM, vincent.cheng...@renesas.com wrote:
>>
>> diff --git a/port.c b/port.c
>> index db3e9ac..bdc73e4 100644
>> --- a/port.c
>> +++ b/port.c
>> @@ -2568,7 +2568,8 @@ void port_link_status(void *ctx, int
Hi Jacob,
On Thu, Jan 07, 2021 at 02:32:47PM EST, Jacob Keller wrote:
>
>
>On 1/6/2021 11:39 AM, vincent.cheng...@renesas.com wrote:
>> diff --git a/port_private.h b/port_private.h
>> index fcabaa6..6e40e15 100644
>> --- a/port_private.h
>> +++ b/port_private.h
>> @@ -69,6 +69,7 @@ struct port {
23 matches
Mail list logo
