Re: [Linuxptp-devel] [PATCH 1/1] Add possibility to set clockIdentity

2018-09-17 Thread Anders Selhammer
Friday, September 14, 2018 6:49 PM >> What is wrong with keeping the clockIdentity the same? Isn't that the >> whole point to this exercise? >> > I think the comment is that if ptp4l is restarted, the clock identity will > change. >Thanks, >Jake Yes, the restart is the thing here. Different

Re: [Linuxptp-devel] [PATCH 1/1] Add possibility to set clockIdentity

2018-09-14 Thread Keller, Jacob E
> -Original Message- > From: Richard Cochran [mailto:richardcoch...@gmail.com] > Sent: Friday, September 14, 2018 7:33 AM > To: Anders Selhammer > Cc: linuxptp-devel@lists.sourceforge.net > Subject: Re: [Linuxptp-devel] [PATCH 1/1] Add possibility to set clockIdentity &

Re: [Linuxptp-devel] [PATCH 1/1] Add possibility to set clockIdentity

2018-09-14 Thread Richard Cochran
On Fri, Sep 14, 2018 at 07:04:45AM +, Anders Selhammer wrote: > Yes, that would be great also but it will not solve the clockIdentity problem > since the > Identity will stay the same until next restart. And it the port setup is > different, the > identity will change. (and the connented

Re: [Linuxptp-devel] [PATCH 1/1] Add possibility to set clockIdentity

2018-09-14 Thread Anders Selhammer
Thursday, September 13, 2018 5:01 PM > Thanks for the explanation. > Wouldn't it make more sense to allow adding ports on-the-fly? > The code is ready for this (or at least, someone did the ground work a > few years ago). Yes, that would be great also but it will not solve the clockIdentity

Re: [Linuxptp-devel] [PATCH 1/1] Add possibility to set clockIdentity

2018-09-14 Thread Anders Selhammer
Thursday, September 13, 2018 7:07 PM > Just make sure it's documented that all 00s in the config will autogenerate > it. Yes, do you think this is well documented? --- ptp4l.8 --- index 10c5c2f..a485250 100644 @@ -395,6 +395,13

Re: [Linuxptp-devel] [PATCH 1/1] Add possibility to set clockIdentity

2018-09-13 Thread Keller, Jacob E
> -Original Message- > From: Anders Selhammer [mailto:anders.selham...@est.tech] > Sent: Wednesday, September 12, 2018 11:18 PM > To: Richard Cochran > Cc: linuxptp-devel@lists.sourceforge.net > Subject: Re: [Linuxptp-devel] [PATCH 1/1] Add possibility to set clockIdenti

Re: [Linuxptp-devel] [PATCH 1/1] Add possibility to set clockIdentity

2018-09-13 Thread Richard Cochran
On Thu, Sep 13, 2018 at 06:18:15AM +, Anders Selhammer wrote: > If the ptpstack is started with a set of ports and during operational time > ports are added and removed. > If the stack by some reason is restarted, the clockIdentity needs to be the > same even if the port that generated the >

Re: [Linuxptp-devel] [PATCH 1/1] Add possibility to set clockIdentity

2018-09-13 Thread Anders Selhammer
Wednesday, September 12, 2018 8:33 PM > Can you please explain the use case in detail? If the ptpstack is started with a set of ports and during operational time ports are added and removed. If the stack by some reason is restarted, the clockIdentity needs to be the same even if the port that

Re: [Linuxptp-devel] [PATCH 1/1] Add possibility to set clockIdentity

2018-09-12 Thread Richard Cochran
On Wed, Sep 12, 2018 at 12:06:54PM +0200, Anders Selhammer wrote: > The reason is if the stack is restarted with a different set of ports, it > may be circumstances when clockIdentity needs to be equal as before > restart even if the port setup is different. Can you please explain the use case in

[Linuxptp-devel] [PATCH 1/1] Add possibility to set clockIdentity

2018-09-12 Thread Anders Selhammer
Currently the clockIdentity is generated from the mac address of the first interface/port in config file. This patch add the possibility to set it in config file. The reason is if the stack is restarted with a different set of ports, it may be circumstances when clockIdentity needs to be equal as