Re: [Linuxptp-devel] [PATCH 5/6] Add PHC methods for querying and configuring the pin functionality.

2020-03-09 Thread Jacob Keller
On 3/9/2020 7:27 AM, Jiri Benc wrote: > On Mon, 9 Mar 2020 07:16:23 -0700, Richard Cochran wrote: >> But maybe that wouldn't be worst thing in the world. There is a trade >> off between maintaining parallel copies of ptp_clock_caps and the >> convenience of compiling the stack just once with the

Re: [Linuxptp-devel] [PATCH 5/6] Add PHC methods for querying and configuring the pin functionality.

2020-03-09 Thread Jiri Benc
On Mon, 9 Mar 2020 07:16:23 -0700, Richard Cochran wrote: > But maybe that wouldn't be worst thing in the world. There is a trade > off between maintaining parallel copies of ptp_clock_caps and the > convenience of compiling the stack just once with the "future" kernel > definitions. > >

Re: [Linuxptp-devel] [PATCH 5/6] Add PHC methods for querying and configuring the pin functionality.

2020-03-09 Thread Richard Cochran
On Mon, Mar 09, 2020 at 11:55:05AM +0100, Jiri Benc wrote: > On Fri, 6 Mar 2020 11:23:00 -0800, Richard Cochran wrote: > > +int phc_number_pins(clockid_t clkid) > > +{ > > + struct ptp_clock_caps caps; > > + > > + if (phc_get_caps(clkid, )) { > > + return 0; > > + } > > +#ifdef

Re: [Linuxptp-devel] [PATCH 5/6] Add PHC methods for querying and configuring the pin functionality.

2020-03-09 Thread Jiri Benc
On Fri, 6 Mar 2020 11:23:00 -0800, Richard Cochran wrote: > +int phc_number_pins(clockid_t clkid) > +{ > + struct ptp_clock_caps caps; > + > + if (phc_get_caps(clkid, )) { > + return 0; > + } > +#ifdef HAVE_PIN_SETFUNC > + return caps.n_pins; > +#else > + return 0;

[Linuxptp-devel] [PATCH 5/6] Add PHC methods for querying and configuring the pin functionality.

2020-03-06 Thread Richard Cochran
In anticipation of support for external time stamping in PHC devices, this patch adds wrapper functions around the pin functionality. Signed-off-by: Richard Cochran --- phc.c | 30 -- phc.h | 21 + 2 files changed, 49 insertions(+), 2 deletions(-)