On Tue, Oct 30, 2018 at 02:38:54PM -0700, Cliff Spradlin via Linuxptp-devel
wrote:
> Signed-off-by: Cliff Spradlin
> Change-Id: If0fd08df74e1cf108978266cd77768df4b49fb1f
> ---
> Adds one extra missing header. I use a tool that reports when header
> files are not individually compilable, which cau
Wednesday, 31 October, 2018 7:00 AM
> I don't understand this concern. With my patch, non-servo code that
> includes servo.h still only sees the opaque forward-declared version
> of servo. My patch doesn't make servo_private.h any more or less
> accessible than before.
Sorry, my bad.
Should not
On Tue, Oct 30, 2018 at 10:41 PM Anders Selhammer
wrote:
> Otherwise, other who use servo will know about the structure in struct servo,
> which is not the point.
I don't understand this concern. With my patch, non-servo code that
includes servo.h still only sees the opaque forward-declared vers
Tuesday, 30 October, 2018 10:39 PM
> +#include "servo.h"
servo_private.h should not include servo.h
servo.c should include servo.h and servo_private.h
Otherwise, other who use servo will know about the structure in struct servo,
which is not the point.
Please see port_private.h as an example
Signed-off-by: Cliff Spradlin
Change-Id: If0fd08df74e1cf108978266cd77768df4b49fb1f
---
Adds one extra missing header. I use a tool that reports when header
files are not individually compilable, which caught these missing
headers.
designated_fsm.h | 3 +++
servo_private.h | 3 +++
2 files chang
