Re: [Linuxwacom-devel] [PATCH 5/5] Remove ISDV4-specific code from wcmReadPacket().

2010-03-04 Thread Peter Hutterer
Hi Bryan, Thanks much for the testing. On Thu, Mar 04, 2010 at 10:20:42PM -0800, Bryan Hundven wrote: > Attached is a test I did in xournal, exported to pdf. This test was > only with the pen. I pulled from the devel branch on sf. > > On the left side I tried to draw fast, and on the right slow.

Re: [Linuxwacom-devel] [PATCH 5/5] Remove ISDV4-specific code from wcmReadPacket().

2010-03-04 Thread Bryan Hundven
Peter, Attached is a test I did in xournal, exported to pdf. This test was only with the pen. I pulled from the devel branch on sf. On the left side I tried to draw fast, and on the right slow. First of all, this does seem to fix what I was seeing in #2952501. It also provides more evidence tha

Re: [Linuxwacom-devel] [PATCH 3/3] Fix usbGetRanges() for any load order of touch/pad

2010-03-04 Thread Ping Cheng
On Thu, Mar 4, 2010 at 5:41 PM, wrote: > From: Chris Bagwell > > For Bamboo P&T devices, both a touch and pad type are > shared for single input device and can be called in any > order based on xorg.conf. And normal HAL order is to > invoke usbGetRanges() from pad first. > > This meant all logi

Re: [Linuxwacom-devel] [PATCH 3/3] Fix usbGetRanges() for any load order of touch/pad

2010-03-04 Thread Chris Bagwell
Thanks. For those interested, the touch part of Bamboo Pen and Touches should be working fine now in xf86-input-wacom. Thats without gesture support though. There are reports of pen having some issues linuxwacom-discuss so I might switch over and debug that while Ping works on 0.8.5-11. Chris

Re: [Linuxwacom-devel] [PATCH 5/5] Remove ISDV4-specific code from wcmReadPacket().

2010-03-04 Thread Bryan Hundven
I'll give Peter's repo a spin tonight, and report back. On Mar 4, 2010 5:36 PM, "Chris Bagwell" wrote: For all in series: Reviewed-by: Chris Bagwell For this patch, I also noticed this mis-placed code while reviewing isdv4GetRanges() recently. It seems the basic issue is that serial ports ca

Re: [Linuxwacom-devel] [PATCH 3/3] Fix usbGetRanges() for any load order of touch/pad

2010-03-04 Thread Peter Hutterer
On Thu, Mar 04, 2010 at 07:41:57PM -0600, ch...@cnpbagwell.com wrote: > From: Chris Bagwell > > For Bamboo P&T devices, both a touch and pad type are > shared for single input device and can be called in any > order based on xorg.conf. And normal HAL order is to > invoke usbGetRanges() from pad

Re: [Linuxwacom-devel] [PATCH 5/5] Remove ISDV4-specific code from wcmReadPacket().

2010-03-04 Thread Chris Bagwell
On Thu, Mar 4, 2010 at 8:09 PM, Peter Hutterer wrote: > On Thu, Mar 04, 2010 at 07:29:05PM -0600, Chris Bagwell wrote: >> For all in series: >> >> Reviewed-by: Chris Bagwell >> >> For this patch, I also noticed this mis-placed code while reviewing >> isdv4GetRanges() recently.  It seems the basic

Re: [Linuxwacom-devel] [PATCH 5/5] Remove ISDV4-specific code from wcmReadPacket().

2010-03-04 Thread Peter Hutterer
On Thu, Mar 04, 2010 at 07:29:05PM -0600, Chris Bagwell wrote: > For all in series: > > Reviewed-by: Chris Bagwell > > For this patch, I also noticed this mis-placed code while reviewing > isdv4GetRanges() recently. It seems the basic issue is that serial > ports can return variable sized packe

[Linuxwacom-devel] [PATCH 3/3] Fix usbGetRanges() for any load order of touch/pad

2010-03-04 Thread chris
From: Chris Bagwell For Bamboo P&T devices, both a touch and pad type are shared for single input device and can be called in any order based on xorg.conf. And normal HAL order is to invoke usbGetRanges() from pad first. This meant all logic related to IsTouch() was not correctly running. Upda

Re: [Linuxwacom-devel] [PATCH 5/5] Remove ISDV4-specific code from wcmReadPacket().

2010-03-04 Thread Chris Bagwell
For all in series: Reviewed-by: Chris Bagwell For this patch, I also noticed this mis-placed code while reviewing isdv4GetRanges() recently. It seems the basic issue is that serial ports can return variable sized packets based on what user is doing. That tells me setting initial values for wcmP

[Linuxwacom-devel] [PATCH 5/5] Remove ISDV4-specific code from wcmReadPacket().

2010-03-04 Thread Peter Hutterer
The packet length only matters on ISDV4, the code should be in the matching part of the source. Signed-off-by: Peter Hutterer --- src/wcmISDV4.c | 15 +++ src/xf86Wacom.c | 22 -- 2 files changed, 15 insertions(+), 22 deletions(-) diff --git a/src/wcmISDV4.c

[Linuxwacom-devel] [PATCH 4/5] Pass the length of the buffer into the parsing code.

2010-03-04 Thread Peter Hutterer
Just handing down a data pointer is risky, since we can't do any model-specific checking for buffer length in the actual model-specific code. So instead, for any buffer size, call the parser. The parser then can return 0 if the length of the buffer isn't sufficient. Signed-off-by: Peter Hutterer

[Linuxwacom-devel] [PATCH 3/5] Remove a bunch of now unused defines.

2010-03-04 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/xf86WacomDefs.h |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/src/xf86WacomDefs.h b/src/xf86WacomDefs.h index d383ac5..f2e1655 100644 --- a/src/xf86WacomDefs.h +++ b/src/xf86WacomDefs.h @@ -40,15 +40,6 @@ #define PROXOUT_GR

[Linuxwacom-devel] [PATCH 2/5] Purge Read() abstraction from the device models.

2010-03-04 Thread Peter Hutterer
We only support ISDV4 and usb tablets and both use the same read method. Signed-off-by: Peter Hutterer --- src/wcmISDV4.c |1 - src/wcmUSB.c|1 - src/xf86Wacom.c |5 + src/xf86WacomDefs.h |1 - 4 files changed, 1 insertions(+), 7 deletions(-) diff --git a/sr

[Linuxwacom-devel] [PATCH 0/5] More cleanup in the data reading code

2010-03-04 Thread Peter Hutterer
Note quite the accurate summary, but the data read code cleanup is the more important one. If you have a serial tablet please test this to make sure I haven't broken your tablet :) USB tablets work but testing is of course always appreciated. As usual, available for testing on my devel branch: gi

[Linuxwacom-devel] [PATCH 1/5] Fix a superfluous linebreak.

2010-03-04 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/xf86Wacom.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/xf86Wacom.c b/src/xf86Wacom.c index 0547614..f339788 100644 --- a/src/xf86Wacom.c +++ b/src/xf86Wacom.c @@ -1129,8 +1129,7 @@ void wcmReadPacket(LocalDevicePtr local)

Re: [Linuxwacom-devel] 1 Finger Gesture Behavior

2010-03-04 Thread Ping Cheng
Hi Chris, Thank you for sharing your thoughts. I see the beauty of your state machine. I am still in -11, which I would like to push out first. Ping On Wed, Mar 3, 2010 at 6:38 PM, Chris Bagwell wrote: > > /* Filters out events related to following gestures and replaces with > * specified a

[Linuxwacom-devel] New repository: wacom-kernel

2010-03-04 Thread Przemo Firszt
Hi, There is a new repository for wacom drivers: git://linuxwacom.git.sourceforge.net/gitroot/linuxwacom/wacom-kernel Web interface: http://linuxwacom.git.sourceforge.net/git/gitweb.cgi?p=linuxwacom/wacom-kernel Currently there are 2 branches: master - it's clean copy of Linus' tree devel - the l