Re: [Linuxwacom-devel] [PATCH 7/7] Fix get_map to return proper wheel/strip button number

2011-03-31 Thread Jason Gerecke
On Wed, Mar 30, 2011 at 9:20 PM, Peter Hutterer wrote: > On Wed, Mar 30, 2011 at 01:54:47PM -0700, Jason Gerecke wrote: >> Adding to the only-kinda-hackish use of XGetDeviceButtonMapping, >> in get_map, this total hackjob of a patch "fixes" the problem with >> us having no way of knowing the drive

Re: [Linuxwacom-devel] [PATCH 1/7] Fail with warnings where possible

2011-03-31 Thread Peter Hutterer
On Wed, Mar 30, 2011 at 11:53:45PM -0700, Jason Gerecke wrote: > On Wed, Mar 30, 2011 at 8:57 PM, Peter Hutterer > wrote: > > On Wed, Mar 30, 2011 at 01:54:41PM -0700, Jason Gerecke wrote: > >> For many commands, improper arguments cause a silent failure. The > >> user is often given no indication

Re: [Linuxwacom-devel] [PATCH 3/3] Centralize pen and touch arbitration

2011-03-31 Thread Ping Cheng
On Wed, Mar 30, 2011 at 11:17 PM, Peter Hutterer wrote: > > { > > - temppriv = (WacomDevicePtr) > device->private; > > - tempcommon = temppriv->common; > > - > > - if ((tempcommon->tablet_id =

Re: [Linuxwacom-devel] [PATCH 3/3] Centralize pen and touch arbitration

2011-03-31 Thread Peter Hutterer
On Thu, Mar 31, 2011 at 04:25:23PM -0700, Ping Cheng wrote: > On Wed, Mar 30, 2011 at 11:17 PM, Peter Hutterer > > > + if ((tmpcommon->tablet_id == common->tablet_id) && > > > + tmppriv != priv) > > > + { > > > +

Re: [Linuxwacom-devel] [PATCH 5/7] Decrease minimum number of args to 'set' [allow wheels/strips "reset"]

2011-03-31 Thread Peter Hutterer
On Wed, Mar 30, 2011 at 11:51:22PM -0700, Jason Gerecke wrote: > On Wed, Mar 30, 2011 at 9:04 PM, Peter Hutterer > wrote: > > On Wed, Mar 30, 2011 at 01:54:45PM -0700, Jason Gerecke wrote: > >> Since the worker functions now check that they have the appropriate > >> number of arguments, its possib

Re: [Linuxwacom-devel] [PATCH 7/7] Fix get_map to return proper wheel/strip button number

2011-03-31 Thread Peter Hutterer
On Thu, Mar 31, 2011 at 12:07:32AM -0700, Jason Gerecke wrote: > On Wed, Mar 30, 2011 at 9:20 PM, Peter Hutterer > wrote: > > On Wed, Mar 30, 2011 at 01:54:47PM -0700, Jason Gerecke wrote: > >> Adding to the only-kinda-hackish use of XGetDeviceButtonMapping, > >> in get_map, this total hackjob of

Re: [Linuxwacom-devel] [PATCH v2] usb: count the number of buttons instead of hardcoding them.

2011-03-31 Thread Peter Hutterer
On Wed, Mar 30, 2011 at 10:34:34AM -0500, Chris Bagwell wrote: > On Tue, Mar 29, 2011 at 10:53 PM, Peter Hutterer > wrote: > > Signed-off-by: Peter Hutterer > > --- > > > > Chris, can you comment on the fixme I have added here. The current code > > seems to increase the number of buttons on the d

Re: [Linuxwacom-devel] [PATCH 3/3] Centralize pen and touch arbitration

2011-03-31 Thread Ping Cheng
On Thu, Mar 31, 2011 at 10:57 PM, Peter Hutterer wrote: > On Thu, Mar 31, 2011 at 10:37:54PM -0700, Ping Cheng wrote: > > On Thu, Mar 31, 2011 at 4:43 PM, Peter Hutterer < > peter.hutte...@who-t.net>wrote: > > > > >/* FIXME: why strstr and not strcmp? */ > > > if (!strstr(device->d