[Linuxwacom-devel] [RFC PATCH] Add mask checking macros. (was Cintiq: TabletPCButton = on?)

2011-04-11 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- > I could remove WCM_LCD from the definition of WCM_TPC but I think the > more correct fix would actually be changing TabletHasFeature(common, > feature): > > from > > (((common->tablet_type) & (feature)) != 0) > > to > > (((common->tablet_type) & (feature))

Re: [Linuxwacom-devel] Cintiq: TabletPCButton = on?

2011-04-11 Thread Ping Cheng
On Mon, Apr 11, 2011 at 11:33 AM, Jason Gerecke wrote: > Right now the man page indicates that TabletPCButton is 'on' for > TabletPCs and 'off' for everything else. It appears that this option > is also 'on' for my Cintiq 21UX. It's a bug. As the name, TabletPCButton, indicated, it is only on fo

Re: [Linuxwacom-devel] Cintiq: TabletPCButton = on?

2011-04-11 Thread Jason Gerecke
Yup, that seems to be the case. Looks like WCM_TPC is defined as (0x200 | WCM_LCD) in an effort to ensure that the "LCD" feature flag is also set. When wcmParseOptions uses TabletHasFeature to check for Tablet PCs, LCDs are included as well. I could remove WCM_LCD from the definition of WCM_TPC bu

Re: [Linuxwacom-devel] Cintiq: TabletPCButton = on?

2011-04-11 Thread Favux ...
Hi Jason, It should be off for a Cintiq as far as I know. Maybe WCM_LCD and WCM_TPC are getting confabulated somewhere? Favux On Mon, Apr 11, 2011 at 1:33 PM, Jason Gerecke wrote: > Right now the man page indicates that TabletPCButton is 'on' for > TabletPCs and 'off' for everything else. It a

[Linuxwacom-devel] Cintiq: TabletPCButton = on?

2011-04-11 Thread Jason Gerecke
Right now the man page indicates that TabletPCButton is 'on' for TabletPCs and 'off' for everything else. It appears that this option is also 'on' for my Cintiq 21UX. Is this just less-than-clear documentation, or a driver bug? I was leaning to the first (as they're both "transparent" tablets), but