[Linuxwacom-devel] libwacom: [PATCH] test: warn if a tablet has buttons but no layout

2012-12-12 Thread Olivier Fourdan
>From 67ff0a18b8807d4d254b8e074f0d3d83a8b64547 Mon Sep 17 00:00:00 2001 From: Olivier Fourdan Date: Wed, 12 Dec 2012 09:55:07 +0100 Subject: [PATCH] test: warn if a tablet has buttons but no layout so we can quickly spot the layouts to contribute, but do not assert since layouts are not mandato

[Linuxwacom-devel] libwacom: [PATCH 2/2] data: fix wrong size in intuos4 6x9 layout

2012-12-12 Thread Olivier Fourdan
>From 2ffeca2fb6954eccb02dc8844eee5f9cd037d1af Mon Sep 17 00:00:00 2001 From: Olivier Fourdan Date: Wed, 12 Dec 2012 09:54:00 +0100 Subject: [PATCH 2/2] data: fix wrong size in intuos4 6x9 layout and adjust buttons' position accordingly. Signed-off-by: Olivier Fourdan --- data/layouts/intuos

[Linuxwacom-devel] libwacom: [PATCH 1/2] data: add layout for intuos4 4x9 wireless

2012-12-12 Thread Olivier Fourdan
>From 2b5578af252629c573f353225004159646a21b98 Mon Sep 17 00:00:00 2001 From: Olivier Fourdan Date: Wed, 12 Dec 2012 09:53:18 +0100 Subject: [PATCH 1/2] data: add layout for intuos4 4x9 wireless Signed-off-by: Olivier Fourdan --- data/intuos4-6x9-wl.tablet |1 + data/layouts/intuos4-

Re: [Linuxwacom-devel] [PATCH 1/4] Remove channel duplication code for generic devices

2012-12-12 Thread Jason Gerecke
Though I can't quite convince myself that this is safe, I don't see any problems with it. Acked-By: Jason Gerecke Jason --- When you're rife with devastation / There's a simple explanation: You're a toymaker's creation / Trapped inside a crystal ball. And whichever way he tilts it / Know that

Re: [Linuxwacom-devel] [PATCH 2/4] Bring generic PAD support back

2012-12-12 Thread Jason Gerecke
On Thu, Dec 6, 2012 at 4:21 PM, Ping Cheng wrote: > While adding support to true MT in the driver, generic PAD support > was broken. The generic way of reporting PAD events in the kernel > is a big pain in the xxx. It has caused more trouble than it's > worth. The community wanted it this way. Bu

Re: [Linuxwacom-devel] [PATCH 3/4] Send generic PAD events before other events

2012-12-12 Thread Jason Gerecke
On Thu, Dec 6, 2012 at 4:21 PM, Ping Cheng wrote: > If we wait until we finish other verifications, we may miss PAD > events since they will be filtered out if there are no motion > events sent simultaneously. > > Signed-off-by: Ping Cheng > --- > src/wcmUSB.c | 14 ++ > 1 file ch

Re: [Linuxwacom-devel] [PATCH 4/4] BTN_TOOL_FINGER is not for PAD if MT is supported

2012-12-12 Thread Jason Gerecke
Reviewed-By: Jason Gerecke Jason --- When you're rife with devastation / There's a simple explanation: You're a toymaker's creation / Trapped inside a crystal ball. And whichever way he tilts it / Know that we must be resilient We won't let them break our spirits / As we sing our silly song.

Re: [Linuxwacom-devel] [PATCH 1/4] Remove channel duplication code for generic devices

2012-12-12 Thread Ping Cheng
On Wed, Dec 12, 2012 at 9:45 AM, Jason Gerecke wrote: > Though I can't quite convince myself that this is safe, I don't see any > problems with it. > > Acked-By: Jason Gerecke > Will I say it is tested on older and new systems make it easier to convince you? Ping > Jason > > --- > When you'r

Re: [Linuxwacom-devel] [PATCH 2/4] Bring generic PAD support back

2012-12-12 Thread Ping Cheng
On Wed, Dec 12, 2012 at 9:49 AM, Jason Gerecke wrote: > On Thu, Dec 6, 2012 at 4:21 PM, Ping Cheng wrote: > >> While adding support to true MT in the driver, generic PAD support >> was broken. The generic way of reporting PAD events in the kernel >> is a big pain in the xxx. It has caused more t

Re: [Linuxwacom-devel] [PATCH 1/4] Remove channel duplication code for generic devices

2012-12-12 Thread Jason Gerecke
It certainly doesn't hurt :) I think my biggest problem is that I never really understood exactly when this code was required. It makes sense that only MT using *TAP events would need it (or dual-track, but that's protocol 5), so I don't really see any problem given the testing you've done. Jason

Re: [Linuxwacom-devel] [PATCH 3/4] Send generic PAD events before other events

2012-12-12 Thread Ping Cheng
On Wed, Dec 12, 2012 at 9:58 AM, Jason Gerecke wrote: > On Thu, Dec 6, 2012 at 4:21 PM, Ping Cheng wrote: > >> If we wait until we finish other verifications, we may miss PAD >> events since they will be filtered out if there are no motion >> events sent simultaneously. >> >> Signed-off-by: Ping

Re: [Linuxwacom-devel] [PATCH 1/4] Remove channel duplication code for generic devices

2012-12-12 Thread Ping Cheng
On Wed, Dec 12, 2012 at 10:54 AM, Jason Gerecke wrote: > It certainly doesn't hurt :) I think my biggest problem is that I never > really understood exactly when this code was required. I bet you don't want to know ;-). Chris knows this chunk of code way better than me. It is a long story and it

Re: [Linuxwacom-devel] libwacom: [PATCH 1/6] data: add layout for Wacom Graphire4 4x5

2012-12-12 Thread Peter Hutterer
On Tue, Dec 11, 2012 at 08:09:38PM +0100, Olivier Fourdan wrote: > >From b6f902ea9b358ace5599e408e1906e08f8e4ee6a Mon Sep 17 00:00:00 2001 > From: Olivier Fourdan > Date: Tue, 11 Dec 2012 15:50:37 +0100 > Subject: [PATCH 1/6] data: add layout for Wacom Graphire4 4x5 > > Signed-off-by: Olivier Fo

Re: [Linuxwacom-devel] libwacom: [PATCH] test: warn if a tablet has buttons but no layout

2012-12-12 Thread Peter Hutterer
On Wed, Dec 12, 2012 at 10:03:35AM +0100, Olivier Fourdan wrote: > > >From 67ff0a18b8807d4d254b8e074f0d3d83a8b64547 Mon Sep 17 00:00:00 2001 > From: Olivier Fourdan > Date: Wed, 12 Dec 2012 09:55:07 +0100 > Subject: [PATCH] test: warn if a tablet has buttons but no layout > > so we can quickly

Re: [Linuxwacom-devel] libwacom: [PATCH 1/2] data: add layout for intuos4 4x9 wireless

2012-12-12 Thread Peter Hutterer
On Wed, Dec 12, 2012 at 10:12:26AM +0100, Olivier Fourdan wrote: > > >From 2b5578af252629c573f353225004159646a21b98 Mon Sep 17 00:00:00 2001 > From: Olivier Fourdan > Date: Wed, 12 Dec 2012 09:53:18 +0100 > Subject: [PATCH 1/2] data: add layout for intuos4 4x9 wireless > > Signed-off-by: Olivie