LTER_PRESSURE_RES and so hides problems.
Chris
On Fri, Jan 7, 2011 at 9:10 AM, AndrewP wrote:
> Actually, issue is still open. I didn't have any troubles with xsetwacom,
> though.
>
>
> On Thu, Jan 6, 2011 at 13:22, ODDie wrote:
>>
>> Hi
>>
>> I fou
On Thu, Jan 6, 2011 at 10:53 AM, Ping Cheng wrote:
> On Thu, Jan 6, 2011 at 6:56 AM, Chris Bagwell wrote:
>> On Wed, Jan 5, 2011 at 6:49 PM, Ping Cheng wrote:
>>> Ok, I see the connection between the two patches. That's why 1/2 is
>>> the first ;).
>>
For patches 1-4:
Reviewed-by: Chris Bagwell
I'd known that the issue addressed in patch #2 must be involved in
original bug reports so glad to see that one addressed.
I did review patch 5 if you want to add it for that as well but since
I've also no idea what original code intended t
l so applications can know what
keys/abs/rel's are valid for the current BTN_TOOL_* when it switches.
But it doesn't seem strictly needed at this exact moment.
Chris
--
Learn how Oracle Real Application Clusters (R
It's good that you can test other. But please hold off on this patch until
patch 1 is acked. The below bug let's MT bamboo be useable until patch 1 is
submitted.
Chris
On Jan 4, 2011, at 7:39 PM, Ping Cheng wrote:
> On Fri, Dec 31, 2010 at 8:48 PM, wrote:
>>
From: Chris Bagwell
Kernel side input event filtering forces user land to track previous
tools values when switching to new tools. If its not accounted
for, sending new-but-duplicate values for new tool would cause confusion.
Most cases of cursor jumps when entering proximity can be traced
to
From: Chris Bagwell
This is second version of patch to allow using previous tools
event values and get rid of memset(). This patch continues
to do memset() for protocol 5 devices because of their complexities
and it keeps PAD device isolated for protocol 4 and generic.
Because of how MT events
From: Chris Bagwell
Somewhere along cleanups, it got switched to looking at wcmKeys
instead of abs. This bug though was making tablet usable
with MT Bamboo driver until memset() could be removed.
Signed-off-by: Chris Bagwell
---
src/wcmUSB.c |2 +-
1 files changed, 1 insertions(+), 1
From: Chris Bagwell
This allows new tochpad/touchscreens to be supported
without modifications to xf86-input-wacom.
BTN_TOOL_FINGER/DOUBLETAP/TRIPLETAP have incompatible meanings
between generic and protocol 4/5 devices. Add logic to detect
generic devices very early and override default value
From: Chris Bagwell
These patches were inspired by yet another new Bamboo being
discussed and the trouble users where having patching
xf86-input-wacom to get touch feature working.
First patch fixes existing issue with MT Bamboo driver were
we were not defaulting to same values as Protocol 4
From: Chris Bagwell
Since wcmKeys can have double meanings (MT Bamboo),
switch to tablet featues.
Signed-off-by: Chris Bagwell
---
src/wcmValidateDevice.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/wcmValidateDevice.c b/src/wcmValidateDevice.c
index
On Wed, Dec 29, 2010 at 12:01 PM, Ping Cheng wrote:
> Hi Chris,
>
> I like the concept of this patchset. Patch one looks fine. I have some
> comments for this one inline.
>
> Thank you.
>
> Ping
>
> On Tue, Dec 28, 2010 at 5:10 PM, wrote:
>> From: Chris Bagw
From: Chris Bagwell
BTN_TOOL_FINGER/DOUBLETAP/TRIPLETAP have incompatible meanings
between generic and protocol 4/5 devices. Add logic to give
rough value of wcmProtocolLevel when probing wcmKeys (can't
tell difference between 4 and 5 which is OK at this level).
Use this rough value to ge
From: Chris Bagwell
These patches were inspired by yet another new Bamboo being
discussed and the trouble users where having patching
xf86-input-wacom to get touch feature working.
First patch fixes existing issue with MT Bamboo driver were
we were not defaulting to same values as Protocol 4
From: Chris Bagwell
Since wcmKeys can have double meanings (MT Bamboo),
switch to tablet featues.
Signed-off-by: Chris Bagwell
---
src/wcmValidateDevice.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/wcmValidateDevice.c b/src/wcmValidateDevice.c
index
from config.h?
Chris
On Wed, Dec 22, 2010 at 3:56 PM, Ping Cheng wrote:
> Sorry, the warning is still there.
>
> Ping
>
> On Tue, Dec 21, 2010 at 10:36 PM, Peter Hutterer
> wrote:
>> CC wcmConfig.lo
>> wcmConfig.c: In function ‘NewWcmPreInit’:
>>
On Tue, Dec 21, 2010 at 5:32 PM, Ping Cheng wrote:
> On Mon, Dec 20, 2010 at 5:59 PM, wrote:
>> From: Chris Bagwell
>>
>> Kernel side input event filtering forces user land to track previous
>> tools values when switching to new tools. Sending new-but-duplicate
&
kernel is filtering events and we will not
lose them anymore. The 2 touch gesture logic in today's non-MT
drivers should work better with this patch.
I'd love to hear how protocol 5 devices work with patch.
Chris
On Mon, Dec 20, 2010 at 7:59 PM, wrote:
> From: Chris Bagwell
>
I had thought it was merged as well. Yes, my ack still applies.
This will help newer Bamboo's and probably wacom_w8001 as well.
Chris
On Mon, Dec 20, 2010 at 10:07 PM, Ping Cheng wrote:
> Process devices that do not report device_id through ABS_MISC from
> the kernel as WCM_PROTO
From: Chris Bagwell
This patch adds support for processing multi-touch (MT) kernel events.
To do this, it must filter out older style single touch (ST) events
to prevent conflicts.
For Bamboo's/Tablet PC, channel 0 == 1st finger and channel 1 == 2nd finger.
In older Bamboo kernel d
From: Chris Bagwell
Kernel side input event filtering forces user land to track previous
tools values when switching to new tools. Sending new-but-duplicate
values for new tool would cause confusion.
At one time, all wacom's sent zero values when going out of proximity
which allowed xf86-
On Mon, Dec 20, 2010 at 7:49 PM, Peter Hutterer
wrote:
> On Mon, Dec 20, 2010 at 02:07:14PM -0600, ch...@cnpbagwell.com wrote:
>> From: Chris Bagwell
>>
>> This patch adds support for processing multi-touch (MT) kernel events.
>> To do this, it must filter out o
From: Chris Bagwell
This patch adds support for processing multi-touch (MT) kernel events.
To do this, it must filter out older style single touch (ST) events
to prevent conflicts.
For Bamboo's/Tablet PC, channel 0 == 1st finger and channel 1 == 2nd finger.
In older Bamboo kernel d
From: Chris Bagwell
This patch adds support for processing multi-touch (MT) kernel events.
To do this, it must filter out older style single touch (ST) events
to prevent conflicts.
For Bamboo's/Tablet PC, channel 0 == 1st finger and channel 1 == 2nd finger.
In older Bamboo kernel d
On Sun, Dec 19, 2010 at 9:46 PM, wrote:
> From: Chris Bagwell
>
> This patch adds support for processing multi-touch (MT) kernel events.
> To do this, it must filter out older style single touch (ST) events
> to prevent conflicts.
>
> For Bamboo's/Tablet PC, channel 0
From: Chris Bagwell
This patch adds support for processing multi-touch (MT) kernel events.
To do this, it must filter out older style single touch (ST) events
to prevent conflicts.
For Bamboo's/Tablet PC, channel 0 == 1st finger and channel 1 == 2nd finger.
In older Bamboo kernel d
rall, very nice cleanup and much easier to understand now.
In the past, I toyed with sending "pad" buttons of Bamboo along with
the "touch" device. It was this tricky area of code that made me run
away screaming from that idea. Now, with this refactor, maybe its not
so hard a
see unique input per tool
this way.
Also, the name "hotplug" has always bothered me here. For some
reason, it makes me think on-demand-when-tool-used more then creating
all possible tool inputs when base tablet is hot-plugged in.
I don't real
On Thu, Dec 9, 2010 at 4:01 PM, Ping Cheng wrote:
> On Thu, Dec 9, 2010 at 1:30 PM, Chris Bagwell wrote:
>>> Event if we set absinfo.resolution properly in the kernel driver, we
>>> can not pass them to the user land. There is no ioctl to support it
>>> yet. I
On Thu, Dec 9, 2010 at 1:55 PM, Ping Cheng wrote:
> On Thu, Dec 9, 2010 at 11:16 AM, Chris Bagwell wrote:
>> Thanks for the conversion work, Peter.
>>
>> Acked-by: Chris Bagwell
>>
>> I was to lazy up to this point to compute myself. I plan on taking
>>
I'm hoping by this weekend I'll send a Tested-by. I'm also hoping
this fixes the Bamboo increased acceleration issue that occurred with
the newer MT driver.
Any chance it does that?
Chris
On Tue, Dec 7, 2010 at 3:29 PM, Ping Cheng wrote:
> The physical size of the touch
Thanks for the conversion work, Peter.
Acked-by: Chris Bagwell
I was to lazy up to this point to compute myself. I plan on taking
the values below, divide by 1000, and submit to kernel drivers as part
of the input_absinfo.resolution field (which is now agreed to be
units/mm).
I'll then h
On Mon, Dec 6, 2010 at 3:25 PM, Ping Cheng wrote:
> On Sat, Dec 4, 2010 at 8:07 PM, Chris Bagwell wrote:
>> Storing sample change:
>>
>> Stop storing new X/Y values when no change. High resolution
>> pressure changes can come in without X/Y changes in gr
On Sat, Dec 4, 2010 at 7:14 PM, Ping Cheng wrote:
> On Sat, Dec 4, 2010 at 12:10 PM, Chris Bagwell wrote:
>> You've my ack on the patch because its right concept...but it may
>> slightly delay MT patch submission.
>
> Thank you for your reply. I can update this patc
see this offset error on Bamboo tablets by drawing
fast to white line on edge of tablet. When going out of proximity
at this line, the offset does not allow cursor to reach edge of screen.
Signed-off-by: Chris Bagwell
---
This is a bugfix version of previous patch I sent.
This patch is to test s
from wcmCommon.c.
This means ISDV4 devices will now have their samples filtered;
which seems a good idea.
If devices need to disable filtering then the pre-existing
RAW_FILTERING_FLAG is better option then NULL function checks.
Signed-off-by: Chris Bagwell
---
Peter, this is requested patch to
low patch is wrong necessarily. It means MT
patch would need some if()'s to ignore single touch events when it
detects MT events are possible.
You've my ack on the patch because its right concept...but it may
slightly delay MT patch submission.
Chris
On Fri, Dec 3, 2010 at 3:15 PM, Ping Cheng
tch and protocol GENERIC and protocol 4 always
use fixed serial #'s for same device_type's based on channel #.
We could also auto-hotplug a new tool if the for() loop ever hits end
without finding matching serial # or a case were tool->serial == 0.
This is only an untested idea
dless of tool/hw. You still need same if()'s
but they are only needed at init phase instead of runtime.
Chris
On Mon, Nov 29, 2010 at 11:35 AM, Ping Cheng wrote:
> Due to the limitation of number of valators we can use, Airbrush
> wheel and Art Pen rotation share the same fifth valuator
Identifier "Wacom class"
MatchProduct "Wacom"
Option "MatchSerial" "123"
Option "Name" "I3 Pen"
Option "Hotplug" "auto" <-- Creates stylus/eraser when serial #
is seen. Needs more thought
us that map to same BTN_TOOL_*
but probably your usecase is most common?
As for the long names, they are a little bit of pain but my hope is we
never really use them directly. I mean no config files needed; no
xinput or xsetwacom needed; just some GUI's that show device names in
drop down list
do some basic tests. Can you do
this?
If we need to disable 4-sample-average filter for some devices (which
I highly doubt), I think a better option is to set wcmRawSamples to 1
then to have NULL function.
Chris
--
Incre
patches to
linux-input?
Reviewed-by: Chris Bagwell
Chris
On Thu, Nov 25, 2010 at 8:44 PM, Ping Cheng wrote:
> Kernel input driver does not allow a specific tool type for pad
> tool. We are forced to move all devices to PROTOCOL_GENERIC in
> the kernel. Let's plan for the change so
Any chance this is related to this:
http://sourceforge.net/tracker/?func=detail&aid=3075216&group_id=69596&atid=525124
On Wed, Nov 24, 2010 at 10:58 PM, Peter Hutterer
wrote:
> The pad has an abswheel too, normalizing this into the rotation range
> screws the coordinates.
>
> Signed-off-by: Pete
On Tue, Nov 23, 2010 at 10:06 PM, Peter Hutterer
wrote:
> On Tue, Nov 23, 2010 at 05:30:21PM -0800, Ping Cheng wrote:
>> Added a few new ones in wcmDeviceTypeKeys
>>
>> Signed-off-by: Ping Cheng
>> ---
>> src/wcmValidateDevice.c | 26 +-
>> 1 files changed, 25 insertion
From: Chris Bagwell
Combining filter routines to reduce upkeep and
keep all step step of filtering aligned.
There are two steps in filtering. 1) Storing filter and
2) filtering samples.
Stage #1 is storing X/Y and optionally storing
tiltX/tiltY based on HANDLE_TILT().
Stage #2 is filtering
From: Chris Bagwell
1st patch is a high priority fix to filtering logic. I had
mistakenly caused filter window size to be 1 sample.
Good news is tablets seem to produce good samples so not
extremely noticable. Bad news is you can see jitter when
drawing fast circles.
The last patch is an
From: Chris Bagwell
I assume npoints means number points so align with that.
Its really only being used as boolean value for init phase
in todays code but that may change.
Signed-off-by: Chris Bagwell
---
src/wcmFilter.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git
From: Chris Bagwell
Up until recent commits there was an if() statement inside
reset function which prevented window being reset while
in proximity. That got removed which caused a bug were
sample size was always size of 1.
Remove the blind reset call and rely on existing conditional call
From: Chris Bagwell
For Bamboo's/Tablet PC, channel 0 == 1st finger and channel 1 == 2nd finger.
In older Bamboo kernel driver, serial #1 == 1st finger and serial #2 ==
2nd finger. Mapping to channel was serial # - 1 and events had to
come in isolated by separate BTN_TOOL_DOUBLETAP/TRIP
On Sun, Nov 21, 2010 at 11:10 PM, Peter Hutterer
wrote:
> On Sun, Nov 21, 2010 at 06:13:38PM -0600, ch...@cnpbagwell.com wrote:
>> From: Chris Bagwell
>>
>>
>> + if (!(ISBITSET (common->wcmKeys, BTN_TOOL_MOUSE)))
>> + {
>> + /* I
of dependencies installed first and I couldn't
find a master build script like X has.
Chris
--
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1, ECMAScript5, an
From: Chris Bagwell
Its natural for newer touchpads, such as Bamboo Touch,
to report buttons that overlap with mouse tools.
These will get remapped to pad device based on previous
patches but button count was not correctly initialed
to account for this remapping.
Now, make sure minimum nkeypad
From: Chris Bagwell
Newer MT Bamboo drivers send BTN_LEFT, BTN_RIGHT,
BTN_FORWARD, and BTN_BACK instead of BTN_0, 1, 2, 3.
BTN_LEFT/RIGHT already were handled for mouse tools.
Add BTN_FORWARD/BACK and treat same as BTN_SIDE/EXTRA
mouse buttons. This is good because by default these
go to
From: Chris Bagwell
The code to set nbuttons for non-pad buttons was checking
for a lot of buttons that no current wacom tablets send
or that is understood by xf86-input-wacom. Remove that
dead code.
The remaining logic seem to be trying to detect mouse
versus other tools (stylus mainly) and
From: Chris Bagwell
It was not allowing BTN_0 or BTN_FORWARD events to be
processed for any tablet. Not sure if other negative
behavior existed.
Signed-off-by: Chris Bagwell
---
src/wcmUSB.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/wcmUSB.c b/src
On Fri, Nov 19, 2010 at 5:33 PM, Ping Cheng wrote:
> On Fri, Nov 19, 2010 at 1:46 PM, Chris Bagwell wrote:
>> On Fri, Nov 19, 2010 at 10:53 AM, Ping Cheng wrote:
>>> On Fri, Nov 19, 2010 at 6:16 AM, Chris Bagwell wrote:
>>>> On Thu, Nov 18, 2010 at 10:20 PM, wr
On Fri, Nov 19, 2010 at 10:53 AM, Ping Cheng wrote:
> On Fri, Nov 19, 2010 at 6:16 AM, Chris Bagwell wrote:
>> On Thu, Nov 18, 2010 at 10:20 PM, wrote:
>>> From: Chris Bagwell
>>
>>> -#define DEFINE_MODEL(mname, identifier, protocol, filter) \
>>&g
On Thu, Nov 18, 2010 at 9:36 PM, Chris Bagwell wrote:
> On Thu, Nov 18, 2010 at 3:51 PM, Ping Cheng wrote:
>> Since it is no longer used for pad, update the comments and code too.
break;
>>
>> - case BTN_TOOL_FINGER:
>> -
On Thu, Nov 18, 2010 at 10:20 PM, wrote:
> From: Chris Bagwell
> -#define DEFINE_MODEL(mname, identifier, protocol, filter) \
> +#define DEFINE_MODEL(mname, identifier, protocol) \
> static struct _Waco
From: Chris Bagwell
The two filter routines were doing exact same math.
The only different is some devices needed to filter
tilt X/Y values in addition to standard X/Y.
Storing of raw samples had already been converted to detect
tilt generically. Now Convert filter routine to detect
r BTN_TOOL_FINGER though simply
because it stops use for needlessly calling usbParseBTNEvent() when
this event is sent for Bamboo MT touchpads. Something like this:
case BTN_TOOL_FINGER:
/* This is either
Update looks good. This patch let's generic tablet support move forward so...
Reviewed-by: Chris Bagwell
On Nov 17, 2010, at 2:33 PM, Ping Cheng wrote:
> From: Ping Cheng
>
> They said using BTN_TOOL_FINGER is too confusing. But we still
> need to configure those tablet b
On Tue, Nov 16, 2010 at 7:35 PM, Chris Bagwell wrote:
>
> This change is not super flexible design so maybe not worth it?
>
I mean your patch works fine without this modification. The change is only
needed if we think its valuable improvemen
On Tue, Nov 16, 2010 at 6:22 PM, Ping Cheng wrote:
> On Tue, Nov 16, 2010 at 4:03 PM, Chris Bagwell
> wrote:
>
> > I also grepped drivers/input and agree with all your previous findings.
> > Below seems to work for all cases... and even will for "cursor" if they
ou search until zero value so that
table can expand with no code changes?
Besides that:
Reviewed-by: Chris Bagwell
On Tue, Nov 16, 2010 at 3:47 PM, Ping Cheng wrote:
> From: Ping Cheng
>
> They said using BTN_TOOL_FINGER is too confusing. But we still
> need to configure those table
On Mon, Nov 15, 2010 at 2:56 PM, Ping Cheng wrote:
> On Mon, Nov 15, 2010 at 7:19 AM, Chris Bagwell wrote:
>> I'd really prefer to solve these issues within the confines of events sent
>> by what I'm calling "generic" touchpads, touchscreens, and pen tablets.
On Mon, Nov 15, 2010 at 12:29 PM, Ping Cheng wrote:
> On Mon, Nov 15, 2010 at 6:47 AM, Chris Bagwell
> wrote:
> > On Sun, Nov 14, 2010 at 11:01 PM, Ping Cheng
> wrote:
> >>
> >> On Sun, Nov 14, 2010 at 9:08 AM, wrote:
> >> > From: Chris B
On Sun, Nov 14, 2010 at 4:23 PM, Ping Cheng wrote:
> On Sun, Nov 14, 2010 at 8:46 AM, wrote:
> > From: Chris Bagwell
> >
> > Signed-off-by: Chris Bagwell
> > ---
> > src/wcmUSB.c | 16 ++--
> > 1 files changed, 10 insertions(+), 6 deletio
On Sun, Nov 14, 2010 at 11:01 PM, Ping Cheng wrote:
> On Sun, Nov 14, 2010 at 9:08 AM, wrote:
> > From: Chris Bagwell
> >
> > This helps abstract out filtering better and also allows
> > custom behavior on storing of samples as well; such as not
> > moving
From: Chris Bagwell
Signed-off-by: Chris Bagwell
---
src/wcmUSB.c | 16 ++--
1 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/src/wcmUSB.c b/src/wcmUSB.c
index 4d8a0fb..eb4d592 100644
--- a/src/wcmUSB.c
+++ b/src/wcmUSB.c
@@ -929,12 +929,16 @@ static int
From: Chris Bagwell
This helps abstract out filtering better and also allows
custom behavior on storing of samples as well; such as not
moving avg window if no X/Y values have changed in current
event cycle.
Intent of this change is refactor only (no behavior change).
Most off diff is moving
From: Chris Bagwell
Old logic was relying on multiple sync windows occuring while
out of proximity to reset averaging window; which doesn't always happen.
Signed-off-by: Chris Bagwell
---
src/wcmCommon.c | 16 +++-
1 files changed, 7 insertions(+), 9 deletions(-)
diff --
From: Chris Bagwell
Signed-off-by: Chris Bagwell
---
src/wcmCommon.c |2 --
src/xf86WacomDefs.h |2 --
2 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/src/wcmCommon.c b/src/wcmCommon.c
index 14f8f92..f68bc8b 100644
--- a/src/wcmCommon.c
+++ b/src/wcmCommon.c
From: Chris Bagwell
This is a resend of patches. I've added a 6th patch based
on Ping's feedback. It removes some dead code to reduce
confusion reading filter logic.
Text from original send:
This series of patches doesn't result in any visible differences.
Well, it m
From: Chris Bagwell
Signed-off-by: Chris Bagwell
---
src/wcmCommon.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/src/wcmCommon.c b/src/wcmCommon.c
index cd550ea..f77cad7 100644
--- a/src/wcmCommon.c
+++ b/src/wcmCommon.c
@@ -968,7 +968,9 @@ void wcmEvent
From: Chris Bagwell
When out of proximity, changes to values to X/Y/etc are not
meaningful. Some non-wacom tablets will send these values while
out of proximity.
Although we correctly ignore their values elsewhere, its more
efficient to ignore right away.
Signed-off-by: Chris Bagwell
From: Chris Bagwell
It does not seem like a good idea to ever discard events
based on filtering logic. Filters generally should smooth out
values and not cause us to discard whole window of samples.
Currently, all filter routines hardcode return to 0 anyways
and so this dead code only caused
On Thu, Nov 11, 2010 at 1:32 PM, Ping Cheng wrote:
> On Thu, Nov 11, 2010 at 6:37 AM, Chris Bagwell wrote:
>>
>>
>> On Wed, Nov 10, 2010 at 9:41 PM, Peter Hutterer
>> wrote:
>>>
>>> The pad tool doesn't send any pointer events, so we don'
at ever a touch wheel is. And
we are not scaling or validating these relative values it seems so area
values are unused.
Your in best position to understand this code... so other then above comment
on commit message you have my:
Acked-by: Chris Bagwell
Chris
>
> Signed-off-by
On Wed, Nov 10, 2010 at 10:53 PM, Peter Hutterer
wrote:
> On Wed, Nov 10, 2010 at 03:38:09PM -0600, Chris Bagwell wrote:
>> On Wed, Nov 10, 2010 at 2:53 PM, Favux ... wrote:
>> > For xf86-input-wacom's wcmUSB.c.
>> >
>> > Adds three new Bamboo Pen &
Opps, never mind on my question. Looks like the X/Y values have been
specified in kernel patch.
Chris
On Wed, Nov 10, 2010 at 2:50 PM, Favux ... wrote:
> For linuxwacom's wacom_wac.c and wcmUSB.c.
>
> Adds three new Bamboo Pen & Touch models:
>
ing wacom_wac.c file to add their USB ID's, the
hard coded X/Y values should match whats returned from this log file.
Chris
--
The Next 800 Companies to Lead America's Growth: New Video Whitepaper
David G. Tho
On Mon, Nov 8, 2010 at 3:44 PM, Ping Cheng wrote:
> On Mon, Nov 8, 2010 at 7:31 AM, Chris Bagwell wrote:
>> On Sun, Nov 7, 2010 at 4:44 PM, Ping Cheng wrote:
>>> On Sun, Nov 7, 2010 at 9:50 AM, Chris Bagwell wrote:
>>>> Please do not submit this 1 patch. #2 is O
On Sun, Nov 7, 2010 at 4:44 PM, Ping Cheng wrote:
> On Sun, Nov 7, 2010 at 9:50 AM, Chris Bagwell wrote:
>> Please do not submit this 1 patch. #2 is OK to submit still.
>>
>> I had forgot that tablet PC's/touchscreens only send BTN_TOUCH without
>> a BTN_TOO
Please do not submit this 1 patch. #2 is OK to submit still.
I had forgot that tablet PC's/touchscreens only send BTN_TOUCH without
a BTN_TOOL_FINGER. So we should continue behaviour as treating
BTN_TOUCH ~= BTN_TOOL_FINGER.
I'll submit a new patch to update comments to make this cle
On Fri, Nov 5, 2010 at 12:15 PM, Ping Cheng wrote:
> On Thu, Nov 4, 2010 at 6:01 PM, wrote:
>> From: Chris Bagwell
>>
>> First two patches are cleanups based on feedback on mailing list.
>
> I am fine with the first 2 patches. So, they are:
>
> Acked-by: Ping
From: Chris Bagwell
First two patches are cleanups based on feedback on mailing list.
Last one is resend of MT support. This version has change such that
it will only compile in MT support if you have 2.3.36+ kernel headers
in /usr/include/linux or have somehow added a -I/path to find those
From: Chris Bagwell
Change logic from using BTN_TOUCH as indication of touchpad
tool events to instead use BTN_TOOL_FINGER. Both ways work
for touchpads but basing it on tool indication is much more in
the tablet spirit.
Signed-off-by: Chris Bagwell
---
src/wcmUSB.c | 31
From: Chris Bagwell
Changed logic to dispatch 1 or 2 channels events to be
based on value of wcmBTNChannel instead of based on protocol
used.
Although previous logic worked, this way is clearer to reason
why wcmEvent() needs to be called for 1 or 2 channel's.
Signed-off-by: Chris Ba
From: Chris Bagwell
For Bamboo's/Tablet PC, channel 0 == 1st finger and channel 1 == 2nd finger.
In older Bamboo kernel driver, serial #1 == 1st finger and serial #2 ==
2nd finger. Mapping to channel was serial # - 1 and events had to
come in isolated by separate BTN_TOOL_DOUBLETAP/TRIP
see I recently had my touchpad mindset
when I updated usbParseKeyEvent(). I detected touchpad by BTN_TOUCH
event but it would probably have been better if I detected in
BTN_TOOL_FINGER case... and for future "dumb tablets" support it
should probably be detected in
Reviewed-by: Chris Bagwell
On Tue, Nov 2, 2010 at 11:30 PM, Peter Hutterer
wrote:
> There's a path in getWheelButtons() where fakeKey is not set. Check for
> that.
>
> Reported-by: Ping Cheng
> Signed-off-by: Peter Hutterer
> ---
> src/wcmCommon.c | 6 ++
On Mon, Nov 1, 2010 at 1:58 PM, Ping Cheng wrote:
> On Sun, Oct 31, 2010 at 2:23 PM, wrote:
>> From: Chris Bagwell
>>
>> For Bamboo's/Tablet PC, channel 0 == 1st finger and channel 1 == 2nd finger.
>>
>> In older Bamboo kernel driver, serial #1 == 1st
uos1 &
2?), you can see how it would be pretty easy to move their kernel
interfaces over to the MT events now.
Chris
--
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps &
Some comments to myself. :-)
On Sun, Oct 31, 2010 at 4:23 PM, wrote:
> From: Chris Bagwell
>
> For Bamboo's/Tablet PC, channel 0 == 1st finger and channel 1 == 2nd finger.
>
> In older Bamboo kernel driver, serial #1 == 1st finger and serial #2 ==
> 2nd finger. Mappin
From: Chris Bagwell
For Bamboo's/Tablet PC, channel 0 == 1st finger and channel 1 == 2nd finger.
In older Bamboo kernel driver, serial #1 == 1st finger and serial #2 ==
2nd finger. Mapping to channel was serial # - 1 and events had to
come in isolated by separate BTN_TOOL_DOUBLETAP/TRIP
On Mon, Sep 6, 2010 at 11:20 AM, Chris Bagwell wrote:
> On Mon, Sep 6, 2010 at 1:29 AM, Nikolai Kondrashov wrote:
>> On 09/06/2010 09:30 AM, Peter Hutterer wrote:
>>>
>>> one example would be having a button switch the stylus between screens in
>>> a
>&g
;\fP
> sets the max distance from tablet to stop reporting movement for cursor in
> relative mode.
While the topic is up, did you know that we are limiting debug levels
to maximum of 10 and not 12? From what I remember, there are a hand
full of level 11's that are unprintable but no
For the whole series:
Reviewed-by: Chris Bagwell
USB stuff is fresh on my mind so good timing for review.
And patch #4 clears one of my TODO items. Thanks.
Chris
On Wed, Oct 27, 2010 at 10:31 PM, Peter Hutterer
wrote:
> Use a DEFINE_MODEL macro to de-duplicate the common intializations
501 - 600 of 805 matches
Mail list logo
