[Lldb-commits] [lldb] r246623 - Address flakyness in TestAttachResume

2015-09-02 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Sep 2 04:12:28 2015 New Revision: 246623 URL: http://llvm.org/viewvc/llvm-project?rev=246623&view=rev Log: Address flakyness in TestAttachResume Summary: The test (among other things) attempts to verify that detaching works while the inferior is running. However, this w

Re: [Lldb-commits] [PATCH] D12527: Address flakyness in TestAttachResume

2015-09-02 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL246623: Address flakyness in TestAttachResume (authored by labath). Changed prior to commit: http://reviews.llvm.org/D12527?vs=33689&id=33785#toc Repository: rL LLVM http://reviews.llvm.org/D12527

[Lldb-commits] [lldb] r246624 - Fix Clang-tidy misc-use-override warnings in include/lldb/API, Breakpoint and Symbol, unify closing inclusion guards

2015-09-02 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Sep 2 04:19:24 2015 New Revision: 246624 URL: http://llvm.org/viewvc/llvm-project?rev=246624&view=rev Log: Fix Clang-tidy misc-use-override warnings in include/lldb/API, Breakpoint and Symbol, unify closing inclusion guards patch by Eugene Zelenko. Modified: lldb/t

[Lldb-commits] [lldb] r246626 - Fix Clang-tidy misc-use-override warnings in some files in include/lldb/Target, unify closing inclusion guards

2015-09-02 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Sep 2 04:24:21 2015 New Revision: 246626 URL: http://llvm.org/viewvc/llvm-project?rev=246626&view=rev Log: Fix Clang-tidy misc-use-override warnings in some files in include/lldb/Target, unify closing inclusion guards patch by Eugene Zelenko. Differential Revision: htt

[Lldb-commits] [lldb] r246627 - Fix Clang-tidy misc-use-override warnings in some files in include/lldb/Interpreter, unify closing inclusion guards

2015-09-02 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Sep 2 04:28:35 2015 New Revision: 246627 URL: http://llvm.org/viewvc/llvm-project?rev=246627&view=rev Log: Fix Clang-tidy misc-use-override warnings in some files in include/lldb/Interpreter, unify closing inclusion guards patch by Eugene Zelenko. Differential Revision

[Lldb-commits] [lldb] r246628 - Fix Clang-tidy misc-use-override warnings in source/Commands headers, unify closing inclusion guards

2015-09-02 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Sep 2 04:33:09 2015 New Revision: 246628 URL: http://llvm.org/viewvc/llvm-project?rev=246628&view=rev Log: Fix Clang-tidy misc-use-override warnings in source/Commands headers, unify closing inclusion guards patch by Eugene Zelenko. Differential Revision: http://review

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

2015-09-02 Thread Jaydeep Patil via lldb-commits
jaydeep updated this revision to Diff 33793. jaydeep added a comment. Added GetCallableFileAddress for MIPS Repository: rL LLVM http://reviews.llvm.org/D12079 Files: include/lldb/Core/Address.h include/lldb/Symbol/Function.h include/lldb/Target/Target.h source/Breakpoint/BreakpointRe

Re: [Lldb-commits] [PATCH] D12531: Fix tab completion for command arguments containing spaces

2015-09-02 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL246639: Fix tab completion for command arguments containing spaces (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D12531?vs=33702&id=33794#toc Repository: rL LLVM http:/

[Lldb-commits] [lldb] r246639 - Fix tab completion for command arguments containing spaces

2015-09-02 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Wed Sep 2 05:35:27 2015 New Revision: 246639 URL: http://llvm.org/viewvc/llvm-project?rev=246639&view=rev Log: Fix tab completion for command arguments containing spaces If a command argument contains a space then it have to be escaped with backslash signs so the argume

[Lldb-commits] [PATCH] D12552: Fix deadlock while attaching to inferiors

2015-09-02 Thread Pavel Labath via lldb-commits
labath created this revision. labath added reviewers: clayborg, ovyalov. labath added a subscriber: lldb-commits. There was a race condition in the AsyncThread, where we would end up sending a vAttach notification to the thread before it got a chance set up its listener (this can be reproduced b

Re: [Lldb-commits] [lldb] r246616 - Move more functionality from the LanguageRuntimes to the Languages.

2015-09-02 Thread Pavel Labath via lldb-commits
This commit seems to be breaking TestObjCBreakpoints.py on mac: . On 2 September 2015 at 02:59, Jim Ingham via lldb-commits wrote: > Author: jingham > Date: Tue Sep 1 20:59:14 2015 > New Revision: 246616 > > URL: http://llvm.

[Lldb-commits] [lldb] r246644 - XFAIL new tests in TestCompletion on windows due to missing pexpect

2015-09-02 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Sep 2 07:09:31 2015 New Revision: 246644 URL: http://llvm.org/viewvc/llvm-project?rev=246644&view=rev Log: XFAIL new tests in TestCompletion on windows due to missing pexpect Modified: lldb/trunk/test/functionalities/completion/TestCompletion.py Modified: lldb/trunk

[Lldb-commits] [lldb] r246645 - Fix test.html webpage alignment

2015-09-02 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Sep 2 07:20:41 2015 New Revision: 246645 URL: http://llvm.org/viewvc/llvm-project?rev=246645&view=rev Log: Fix test.html webpage alignment Modified: lldb/trunk/www/test.html Modified: lldb/trunk/www/test.html URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/www/

[Lldb-commits] [PATCH] D12553: Fix arm disassambler with specifying armv8.1a architecture

2015-09-02 Thread Tamas Berghammer via lldb-commits
tberghammer created this revision. tberghammer added reviewers: labath, dsrbecky. tberghammer added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. Fix arm disassambler with specifying armv8.1a architecture If no architecture is defined for the disassambler command then

[Lldb-commits] [lldb] r246647 - Enable a couple of tests in TestExitDuringStep on linux

2015-09-02 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Sep 2 08:01:21 2015 New Revision: 246647 URL: http://llvm.org/viewvc/llvm-project?rev=246647&view=rev Log: Enable a couple of tests in TestExitDuringStep on linux tests have been reliably passing at least the last 100 runs of the build bot. Modified: lldb/trunk/tes

Re: [Lldb-commits] [PATCH] D12553: Fix arm disassambler with specifying armv8.1a architecture

2015-09-02 Thread Pavel Labath via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. sounds reasonable to me Comment at: source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp:668 @@ +667,3 @@ +// If no sub architecture specified then use the most recent a

Re: [Lldb-commits] [PATCH] D12553: Fix arm disassambler with specifying armv8.1a architecture

2015-09-02 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL246648: Fix arm disassambler with specifying armv8.1a architecture (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D12553?vs=33800&id=33801#toc Repository: rL LLVM http:/

[Lldb-commits] [lldb] r246648 - Fix arm disassambler with specifying armv8.1a architecture

2015-09-02 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Wed Sep 2 08:24:50 2015 New Revision: 246648 URL: http://llvm.org/viewvc/llvm-project?rev=246648&view=rev Log: Fix arm disassambler with specifying armv8.1a architecture If no architecture is defined for the disassambler command then it uses the architecture of the targ

[Lldb-commits] [lldb] r246649 - Only create alternative thumb disassembler if the main one is arm

2015-09-02 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Wed Sep 2 08:31:18 2015 New Revision: 246649 URL: http://llvm.org/viewvc/llvm-project?rev=246649&view=rev Log: Only create alternative thumb disassembler if the main one is arm This fixes a regression caused by r245645 where creating alternative thumb disassembler was e

Re: [Lldb-commits] [lldb] r245645 - The llvm Triple for an armv6m now comes back as llvm::Triple::thumb.

2015-09-02 Thread Tamas Berghammer via lldb-commits
Hi Jason, This commit caused a regression in disassembling thumb code when the architecture is specified explicitly for the disassemble because we try to create an alternative thumb disassembler even when the primary disassembler is already thumb. I committed in a fix as http://llvm.org/viewvc/l

Re: [Lldb-commits] [lldb] r246578 - Have the Process hold a weak_ptr to the Target.

2015-09-02 Thread Ed Maste via lldb-commits
On 1 September 2015 at 16:02, Zachary Turner via lldb-commits wrote: > Author: zturner > Date: Tue Sep 1 15:02:29 2015 > New Revision: 246578 > > URL: http://llvm.org/viewvc/llvm-project?rev=246578&view=rev > Log: > Have the Process hold a weak_ptr to the Target. Hi Zach, would you be able to ma

Re: [Lldb-commits] [lldb] r246578 - Have the Process hold a weak_ptr to the Target.

2015-09-02 Thread Zachary Turner via lldb-commits
I'll take a look today, thanks for letting me know On Wed, Sep 2, 2015 at 7:54 AM Ed Maste wrote: > On 1 September 2015 at 16:02, Zachary Turner via lldb-commits > wrote: > > Author: zturner > > Date: Tue Sep 1 15:02:29 2015 > > New Revision: 246578 > > > > URL: http://llvm.org/viewvc/llvm-pro

Re: [Lldb-commits] [lldb] r246578 - Have the Process hold a weak_ptr to the Target.

2015-09-02 Thread Ed Maste via lldb-commits
On 2 September 2015 at 10:55, Zachary Turner wrote: > I'll take a look today, thanks for letting me know Np. I need to get a FreeBSD buildbot back up again; the previous one was taken down because the machine was overloaded (and flaky). ___ lldb-commit

Re: [Lldb-commits] [lldb] r246644 - XFAIL new tests in TestCompletion on windows due to missing pexpect

2015-09-02 Thread Zachary Turner via lldb-commits
Is pexpect actually needed for this test? If it is for some reason, then just looking at the test it seems like we only really care about testing auto completion right? Could it just be a unit test? I think we should make it an explicit goal to avoid pexpect tests unless the test specificially r

[Lldb-commits] [PATCH] D12556: Introduce new address class eAddressClassDataIntermixedCode

2015-09-02 Thread Tamas Berghammer via lldb-commits
tberghammer created this revision. tberghammer added a reviewer: clayborg. tberghammer added a subscriber: lldb-commits. Herald added a subscriber: aemerson. Introduce new address class eAddressClassDataIntermixedCode It is used for marking data what is intermixed into the code section on arm/aar

Re: [Lldb-commits] [PATCH] D12360: RenderScript pending kernel breakpoints.

2015-09-02 Thread Ewan Crawford via lldb-commits
EwanCrawford added a comment. Does this address your concerns Jim? Repository: rL LLVM http://reviews.llvm.org/D12360 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [lldb] r246644 - XFAIL new tests in TestCompletion on windows due to missing pexpect

2015-09-02 Thread Pavel Labath via lldb-commits
It could possibly be a unit test (depending on e.g. whether we want to test that function names from the current process are completed properly as this test seems to be doing), but we could definitely test most of the functionality through SBCommandInterpreter API. Any volunteers for the job? :) O

[Lldb-commits] [PATCH] D12558: Fix rare failure in TestProcessIO

2015-09-02 Thread Pavel Labath via lldb-commits
labath created this revision. labath added reviewers: clayborg, ovyalov. labath added a subscriber: lldb-commits. There was a race condition in Process class, where we would not wait for process stdout to propagate fully before we would shut down the connection (repro case: slow down the stdio t

[Lldb-commits] [lldb] r246666 - Improved logging for deported types in the ClangASTImporter.

2015-09-02 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Wed Sep 2 11:39:23 2015 New Revision: 24 URL: http://llvm.org/viewvc/llvm-project?rev=24&view=rev Log: Improved logging for deported types in the ClangASTImporter. Modified: lldb/trunk/source/Symbol/ClangASTImporter.cpp Modified: lldb/trunk/source/Symbol/ClangAS

[Lldb-commits] [lldb] r246667 - Removed comments that suggested that asserts in the ClangASTImporter should be

2015-09-02 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Wed Sep 2 11:40:59 2015 New Revision: 246667 URL: http://llvm.org/viewvc/llvm-project?rev=246667&view=rev Log: Removed comments that suggested that asserts in the ClangASTImporter should be debug-only. This is not the case; when they fire we are about to crash or do somethin

[Lldb-commits] [lldb] r246668 - XFAIL test_thread_state_after_continue on Windows.

2015-09-02 Thread Zachary Turner via lldb-commits
Author: zturner Date: Wed Sep 2 11:47:01 2015 New Revision: 246668 URL: http://llvm.org/viewvc/llvm-project?rev=246668&view=rev Log: XFAIL test_thread_state_after_continue on Windows. https://llvm.org/pr24660 Modified: lldb/trunk/test/functionalities/thread/state/TestThreadStates.py Modifi

[Lldb-commits] [lldb] r246669 - [Windows] XFAIL test that depend on dynamic value types.

2015-09-02 Thread Zachary Turner via lldb-commits
Author: zturner Date: Wed Sep 2 11:47:13 2015 New Revision: 246669 URL: http://llvm.org/viewvc/llvm-project?rev=246669&view=rev Log: [Windows] XFAIL test that depend on dynamic value types. Modified: lldb/trunk/test/functionalities/value_md5_crash/TestValueMD5Crash.py lldb/trunk/test/lan

[Lldb-commits] [lldb] r246671 - Change Windows XFAIL comment for TestCompletion.py

2015-09-02 Thread Zachary Turner via lldb-commits
Author: zturner Date: Wed Sep 2 11:47:37 2015 New Revision: 246671 URL: http://llvm.org/viewvc/llvm-project?rev=246671&view=rev Log: Change Windows XFAIL comment for TestCompletion.py Instead of fixing these tests by finding a pexpect replacement, this set of tests can be fixed by re-writing the

[Lldb-commits] [lldb] r246670 - XFAIL tests on Windows that are failing to resolve breakpoints.

2015-09-02 Thread Zachary Turner via lldb-commits
Author: zturner Date: Wed Sep 2 11:47:29 2015 New Revision: 246670 URL: http://llvm.org/viewvc/llvm-project?rev=246670&view=rev Log: XFAIL tests on Windows that are failing to resolve breakpoints. llvm.org/pr24668 Modified: lldb/trunk/test/functionalities/thread/create_during_step/TestCrea

Re: [Lldb-commits] [lldb] r246578 - Have the Process hold a weak_ptr to the Target.

2015-09-02 Thread Zachary Turner via lldb-commits
I tried to fix this in r246672. I can't build on FreeBSD so I'm pretty much just guessing. If this doesn't fix it then please update me with the new build errors and I'll try again. On Wed, Sep 2, 2015 at 7:58 AM Ed Maste wrote: > On 2 September 2015 at 10:55, Zachary Turner wrote: > > I'll t

[Lldb-commits] [lldb] r246672 - Try to fix FreeBSD build.

2015-09-02 Thread Zachary Turner via lldb-commits
Author: zturner Date: Wed Sep 2 11:47:47 2015 New Revision: 246672 URL: http://llvm.org/viewvc/llvm-project?rev=246672&view=rev Log: Try to fix FreeBSD build. Modified: lldb/trunk/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp lldb/trunk/source/Plugins/Process/FreeBSD/ProcessFreeBSD.h

[Lldb-commits] [lldb] r246674 - Added an ExpressionParser plugin skeleton with nothing in it (yet).

2015-09-02 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Wed Sep 2 11:49:14 2015 New Revision: 246674 URL: http://llvm.org/viewvc/llvm-project?rev=246674&view=rev Log: Added an ExpressionParser plugin skeleton with nothing in it (yet). Added: lldb/trunk/source/Plugins/ExpressionParser/ Modified: lldb/trunk/lldb.xcodeproj/p

Re: [Lldb-commits] [lldb] r246644 - XFAIL new tests in TestCompletion on windows due to missing pexpect

2015-09-02 Thread Zachary Turner via lldb-commits
I filed a new bug for it with a better indication of how to fix it, and updated the XFAIL comment in the test accordingly. Don't know when we'll be able to fix it, but at least this way I can prioritize it differently than all the other pexpect test failures. On Wed, Sep 2, 2015 at 8:49 AM Pavel

[Lldb-commits] [lldb] r246677 - Added a skeleton plugin for the Clang expression parser, so I can start factoring stuff into it.

2015-09-02 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Wed Sep 2 11:59:02 2015 New Revision: 246677 URL: http://llvm.org/viewvc/llvm-project?rev=246677&view=rev Log: Added a skeleton plugin for the Clang expression parser, so I can start factoring stuff into it. Added: lldb/trunk/source/Plugins/ExpressionParser/Clang/ Modif

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

2015-09-02 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. DWARF parser should be stripping bit #0 for all addresses from mips targets: line tables, all address ranges for functions and blocks and variables should have this bit #0 stripp

Re: [Lldb-commits] [PATCH] D12552: Fix deadlock while attaching to inferiors

2015-09-02 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D12552 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D12556: Introduce new address class eAddressClassDataIntermixedCode

2015-09-02 Thread Greg Clayton via lldb-commits
clayborg added a comment. Changing all $d symbols to always say they are eAddressClassDataIntermixedCode is wrong because the symbols in the .data section now would be marked as eAddressClassDataIntermixedCode. To clarify a few things, lets say we have the following code: 0x1000: bx Non-tail

Re: [Lldb-commits] [PATCH] D12552: Fix deadlock while attaching to inferiors

2015-09-02 Thread Oleksiy Vyalov via lldb-commits
ovyalov accepted this revision. ovyalov added a comment. LGTM http://reviews.llvm.org/D12552 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12556: Introduce new address class eAddressClassDataIntermixedCode

2015-09-02 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Marking as needing changes due to above comments. http://reviews.llvm.org/D12556 ___ lldb-commits mailing list lldb-commits@lists.l

Re: [Lldb-commits] [lldb] r246616 - Move more functionality from the LanguageRuntimes to the Languages.

2015-09-02 Thread Jim Ingham via lldb-commits
Huh, I didn't see any new failures, but I'll check it out. Jim > On Sep 2, 2015, at 4:22 AM, Pavel Labath wrote: > > This commit seems to be breaking TestObjCBreakpoints.py on mac: >

[Lldb-commits] [lldb] r246682 - When redirecting stdio, use FILE_SHARE_DELETE.

2015-09-02 Thread Zachary Turner via lldb-commits
Author: zturner Date: Wed Sep 2 12:59:19 2015 New Revision: 246682 URL: http://llvm.org/viewvc/llvm-project?rev=246682&view=rev Log: When redirecting stdio, use FILE_SHARE_DELETE. Some tests were failing because the test would try to delete the file before inferior had exited, but on Windows thi

Re: [Lldb-commits] [PATCH] D11102: Set the default language to use when evaluating to that of the frame's CU.

2015-09-02 Thread Dawn Perchik via lldb-commits
dawn added a comment. HI Jim/Sean, Did you guys want to have a final review or can I go ahead and commit? Basically, this patch includes the changes you requested, but it also 1) fixes how the languages are recognized (the switch statement was incomplete) and 2) reworks the language-based test

Re: [Lldb-commits] [PATCH] D12558: Fix rare failure in TestProcessIO

2015-09-02 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks fine. http://reviews.llvm.org/D12558 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [lldb] r246644 - XFAIL new tests in TestCompletion on windows due to missing pexpect

2015-09-02 Thread Jim Ingham via lldb-commits
I think - at least for completions - using the SBInterpreter API's would be better than unit tests. You should be able to do all this through the SB API. If you can't we should fix this since any UI that provides a console will need to use those API's. So adding tests for them is a good thin

Re: [Lldb-commits] [PATCH] D12556: Introduce new address class eAddressClassDataIntermixedCode

2015-09-02 Thread Tamas Berghammer via lldb-commits
tberghammer added a comment. In http://reviews.llvm.org/D12556#238457, @clayborg wrote: > Changing all $d symbols to always say they are > eAddressClassDataIntermixedCode is wrong because the symbols in the .data > section now would be marked as eAddressClassDataIntermixedCode. We only use th

Re: [Lldb-commits] [PATCH] D12556: Introduce new address class eAddressClassDataIntermixedCode

2015-09-02 Thread Greg Clayton via lldb-commits
clayborg added a comment. I would leave everything as is (no eAddressClassDataIntermixedCode), but I would change the code to use: target->GetOpcodeLoadAddress (return_load_addr, eAddressClassCode); We don't need to lookup the address class type when determining return addresses. Then this s

Re: [Lldb-commits] [PATCH] D12556: Introduce new address class eAddressClassDataIntermixedCode

2015-09-02 Thread Greg Clayton via lldb-commits
clayborg added a comment. So: target->GetOpcodeLoadAddress (return_load_addr, eAddressClassCode); Would get used in the stack backtracing code that is currently looking up the real address class of the return address... http://reviews.llvm.org/D12556 _

Re: [Lldb-commits] [lldb] r246578 - Have the Process hold a weak_ptr to the Target.

2015-09-02 Thread Ed Maste via lldb-commits
On 2 September 2015 at 12:49, Zachary Turner wrote: > I tried to fix this in r246672. I can't build on FreeBSD so I'm pretty much > just guessing. If this doesn't fix it then please update me with the new > build errors and I'll try again. Great, thanks -- I was able to build it now, and will c

[Lldb-commits] [lldb] r246709 - We want Python int or long to both be usable as-a tid_t for API purposes. Introduce a typemap to this effect

2015-09-02 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Sep 2 15:53:43 2015 New Revision: 246709 URL: http://llvm.org/viewvc/llvm-project?rev=246709&view=rev Log: We want Python int or long to both be usable as-a tid_t for API purposes. Introduce a typemap to this effect Modified: lldb/trunk/scripts/Python/python-typemap

Re: [Lldb-commits] [lldb] r245645 - The llvm Triple for an armv6m now comes back as llvm::Triple::thumb.

2015-09-02 Thread Jason Molenda via lldb-commits
Ah, I see the problem, sorry for causing that regression. I'll conditionalize the change in DisassemblerLLVMC.cpp to only happen for the Cortex-M0/3/4 variants that are thumb-only. J > On Sep 2, 2015, at 6:35 AM, Tamas Berghammer wrote: > > Hi Jason, > > This commit caused a regression in d

[Lldb-commits] [lldb] r246723 - XFAIL tests that rely on exact thread counts.

2015-09-02 Thread Zachary Turner via lldb-commits
Author: zturner Date: Wed Sep 2 17:40:40 2015 New Revision: 246723 URL: http://llvm.org/viewvc/llvm-project?rev=246723&view=rev Log: XFAIL tests that rely on exact thread counts. On Windows we have to deal with OS created threads, so we can never know the exact number of threads. llvm.org/pr246

[Lldb-commits] [lldb] r246724 - XFAIL more bugs that depend on dynamic value resolution.

2015-09-02 Thread Zachary Turner via lldb-commits
Author: zturner Date: Wed Sep 2 17:40:59 2015 New Revision: 246724 URL: http://llvm.org/viewvc/llvm-project?rev=246724&view=rev Log: XFAIL more bugs that depend on dynamic value resolution. llvm.org/pr24663 Modified: lldb/trunk/test/functionalities/data-formatter/dump_dynamic/TestDumpDynam

[Lldb-commits] [lldb] r246725 - XFAIL more watchpoint tests on Windows.

2015-09-02 Thread Zachary Turner via lldb-commits
Author: zturner Date: Wed Sep 2 17:41:15 2015 New Revision: 246725 URL: http://llvm.org/viewvc/llvm-project?rev=246725&view=rev Log: XFAIL more watchpoint tests on Windows. llvm.org/pr24446 Modified: lldb/trunk/test/functionalities/watchpoint/hello_watchpoint/TestMyFirstWatchpoint.py

[Lldb-commits] [lldb] r246726 - Skip the rest of the Objective C tests on Windows.

2015-09-02 Thread Zachary Turner via lldb-commits
Author: zturner Date: Wed Sep 2 17:41:28 2015 New Revision: 246726 URL: http://llvm.org/viewvc/llvm-project?rev=246726&view=rev Log: Skip the rest of the Objective C tests on Windows. Modified: lldb/trunk/test/lang/objc/modules-auto-import/TestModulesAutoImport.py lldb/trunk/test/lang/o

[Lldb-commits] [lldb] r246736 - Fix ObjCLanguage::MethodName::GetCategory after r246616; I was just moving things around too fast...

2015-09-02 Thread Jim Ingham via lldb-commits
Author: jingham Date: Wed Sep 2 19:03:13 2015 New Revision: 246736 URL: http://llvm.org/viewvc/llvm-project?rev=246736&view=rev Log: Fix ObjCLanguage::MethodName::GetCategory after r246616; I was just moving things around too fast... Modified: lldb/trunk/source/Plugins/Language/ObjC/ObjCLan

[Lldb-commits] [lldb] r246737 - In preparation for factoring persistent variables into a generic part and a

2015-09-02 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Wed Sep 2 19:35:46 2015 New Revision: 246737 URL: http://llvm.org/viewvc/llvm-project?rev=246737&view=rev Log: In preparation for factoring persistent variables into a generic part and a Clang-specific part, create the ExpressionVariable source/header file and move ClangExpre

[Lldb-commits] [lldb] r246738 - Jim told me about a cleaner way to include headers from plug-ins.

2015-09-02 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Wed Sep 2 19:48:23 2015 New Revision: 246738 URL: http://llvm.org/viewvc/llvm-project?rev=246738&view=rev Log: Jim told me about a cleaner way to include headers from plug-ins. This is still something I need to fix, but at least it's not so ugly, and it's consistent with the

[Lldb-commits] [PATCH] D12582: NetBSD doesn't ship with getopt_long_only(3)

2015-09-02 Thread Kamil Rytarowski via lldb-commits
krytarowski created this revision. krytarowski added a reviewer: joerg. krytarowski added a subscriber: lldb-commits. krytarowski set the repository for this revision to rL LLVM. Implement it with the original NetBSD style. Repository: rL LLVM http://reviews.llvm.org/D12582 Files: include/l

[Lldb-commits] [lldb] r246740 - Remove the list of all languages in the help for "help language" since

2015-09-02 Thread Jim Ingham via lldb-commits
Author: jingham Date: Wed Sep 2 20:13:26 2015 New Revision: 246740 URL: http://llvm.org/viewvc/llvm-project?rev=246740&view=rev Log: Remove the list of all languages in the help for "help language" since almost all the elements on the list can't actually be passed to the language command and all

Re: [Lldb-commits] [PATCH] D12485: NetBSD ships with paccept(2), a superset of accept4(2)

2015-09-02 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. Thank you. If everything is done, please commit it. Repository: rL LLVM http://reviews.llvm.org/D12485 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com

[Lldb-commits] [lldb] r246743 - CXXFormatterFunctions.{h|cpp} is not a good thing to have around, so start splitting stuff in different files in preparation for removing it and factoring formatters to

2015-09-02 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Sep 2 20:29:42 2015 New Revision: 246743 URL: http://llvm.org/viewvc/llvm-project?rev=246743&view=rev Log: CXXFormatterFunctions.{h|cpp} is not a good thing to have around, so start splitting stuff in different files in preparation for removing it and factoring formatte

[Lldb-commits] [lldb] r246744 - Purge a few places where *LanguageRuntime.h was being used when it

2015-09-02 Thread Jim Ingham via lldb-commits
Author: jingham Date: Wed Sep 2 20:40:51 2015 New Revision: 246744 URL: http://llvm.org/viewvc/llvm-project?rev=246744&view=rev Log: Purge a few places where *LanguageRuntime.h was being used when it wasn't needed. Modified: lldb/trunk/source/Commands/CommandObjectExpression.cpp lldb/tr

[Lldb-commits] [PATCH] D12584: Fix TestCompletion.py failure on Darwin after r246639

2015-09-02 Thread Ying Chen via lldb-commits
chying created this revision. chying added a reviewer: tberghammer. chying added a subscriber: lldb-commits. - send empty line for multiple commands to complete http://reviews.llvm.org/D12584 Files: test/functionalities/completion/TestCompletion.py Index: test/functionalities/completion/TestC

[Lldb-commits] [lldb] r246745 - [MIPS64] Emulate MSA branch instructions

2015-09-02 Thread Sagar Thakur via lldb-commits
Author: slthakur Date: Wed Sep 2 22:57:44 2015 New Revision: 246745 URL: http://llvm.org/viewvc/llvm-project?rev=246745&view=rev Log: [MIPS64] Emulate MSA branch instructions This patch adds MSA branch instruction emulation for MIPS64. Reviewers: tberghammer, jaydeep Subscribers: tberghammer, l

[Lldb-commits] [lldb] r246746 - Fix cmake build.

2015-09-02 Thread Bruce Mitchener via lldb-commits
Author: brucem Date: Wed Sep 2 23:17:57 2015 New Revision: 246746 URL: http://llvm.org/viewvc/llvm-project?rev=246746&view=rev Log: Fix cmake build. Added: lldb/trunk/source/Plugins/ExpressionParser/CMakeLists.txt lldb/trunk/source/Plugins/ExpressionParser/Clang/CMakeLists.txt Modified:

[Lldb-commits] [PATCH] D12586: [cmake] Remove LLVM_NO_RTTI.

2015-09-02 Thread Bruce Mitchener via lldb-commits
brucem created this revision. brucem added reviewers: chaoren, labath. brucem added a subscriber: lldb-commits. Herald added subscribers: danalbert, tberghammer, emaste. This doesn't exist in other LLVM projects any longer and doesn't do anything. http://reviews.llvm.org/D12586 Files: scripts/

Re: [Lldb-commits] [PATCH] D12356: [MIPS64] Emulate MSA branch instructions

2015-09-02 Thread Sagar Thakur via lldb-commits
sagar closed this revision. sagar added a comment. Committed in revision 246745 Repository: rL LLVM http://reviews.llvm.org/D12356 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [PATCH] D12587: Roll desep.py parallel test runner into dotest.py command line

2015-09-02 Thread Todd Fiala via lldb-commits
tfiala created this revision. tfiala added a reviewer: clayborg. tfiala added a subscriber: lldb-commits. This is a change discussed in http://reviews.llvm.org/D12416. This change does the following: * Removes the need to call dosep.py directly. Indeed, calling dosep.py now errors out (intentio

Re: [Lldb-commits] [PATCH] D12587: Roll desep.py parallel test runner into dotest.py command line

2015-09-02 Thread Todd Fiala via lldb-commits
tfiala added a comment. > Removes the need to call dosep.py directly. Indeed, calling dosep.py now > errors out (intentionally). Calling it *directly* errors out. detest.py still uses it under the covers at the moment. http://reviews.llvm.org/D12587 __

Re: [Lldb-commits] [PATCH] D12416: Parse dotest.py/dosep.py output, providing general stats and skip reason breakdown by counts.

2015-09-02 Thread Todd Fiala via lldb-commits
tfiala added a comment. I just put up http://reviews.llvm.org/D12587 to take care of merging the user experience of dosep.py and dotest.py into dotest.py. I want to knock that and another change out before coming back to the skip reason tallying here. http://reviews.llvm.org/D12416 ___

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

2015-09-02 Thread Zachary Turner via lldb-commits
zturner added a subscriber: zturner. zturner added a comment. Are there any plans to actually just kill dosep.py at some point? I know you mentioned you want to do further cleanup, so I'm wondering if this is just an incremental step towards a dosep'less world. I'll review this in more detail

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

2015-09-02 Thread Todd Fiala via lldb-commits
Yep, all good. I was planning on waiting for feedback first. I've checked on Linux but don't have a Windows box available at the moment. On Wednesday, September 2, 2015, Zachary Turner wrote: > zturner added a subscriber: zturner. > zturner added a comment. > > Are there any plans to actually j