That'll also let me set it up so Greg can poke around with the threading
version on OS X.
On Fri, Sep 4, 2015 at 10:04 PM, Todd Fiala wrote:
> Yep, I'm thinking that's right.
>
> On Fri, Sep 4, 2015 at 10:02 PM, Zachary Turner
> wrote:
>
>> The pluggable method would at least allow everyone to
Yep, I'm thinking that's right.
On Fri, Sep 4, 2015 at 10:02 PM, Zachary Turner wrote:
> The pluggable method would at least allow everyone to continue working
> until someone has time to dig into what's wrong with multiprocess on Windows
>
> On Fri, Sep 4, 2015 at 9:56 PM Todd Fiala wrote:
>
>
The pluggable method would at least allow everyone to continue working
until someone has time to dig into what's wrong with multiprocess on Windows
On Fri, Sep 4, 2015 at 9:56 PM Todd Fiala wrote:
> On Fri, Sep 4, 2015 at 5:40 PM, Zachary Turner wrote:
>
>>
>>
>> On Fri, Sep 4, 2015 at 5:10 PM
On Fri, Sep 4, 2015 at 5:40 PM, Zachary Turner wrote:
>
>
> On Fri, Sep 4, 2015 at 5:10 PM Todd Fiala wrote:
>
>> tfiala added a comment.
>>
>> In http://reviews.llvm.org/D12651#240480, @zturner wrote:
>>
>> > Tried out this patch, unfortunately I'm seeing the same thing. The very
>> > first c
krytarowski created this revision.
krytarowski added a reviewer: joerg.
krytarowski added a subscriber: lldb-commits.
krytarowski set the repository for this revision to rL LLVM.
Herald added a subscriber: emaste.
Linux and FreeBSD occasionally send SI_KERNEL codes, nonexistent on other
platforms
On Fri, Sep 4, 2015 at 5:10 PM Todd Fiala wrote:
> tfiala added a comment.
>
> In http://reviews.llvm.org/D12651#240480, @zturner wrote:
>
> > Tried out this patch, unfortunately I'm seeing the same thing. The very
> > first call to worker.join() is never returning.
> >
> > It's unfortunate tha
tfiala added a comment.
In http://reviews.llvm.org/D12651#240480, @zturner wrote:
> Tried out this patch, unfortunately I'm seeing the same thing. The very
> first call to worker.join() is never returning.
>
> It's unfortunate that it's so hard to debug this stuff, do you have any
> suggestion
Tried out this patch, unfortunately I'm seeing the same thing. The very
first call to worker.join() is never returning.
It's unfortunate that it's so hard to debug this stuff, do you have any
suggestions for how I can try to nail down what the child dotest instance
is actually doing? I wonder if
krytarowski added a comment.
Thank you.
Please commit this change.
Repository:
rL LLVM
http://reviews.llvm.org/D12654
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
Hey Zachary,
Can you give the latest patch a try? That might stop some unintentional
blockage as adding items to those two queues would be blocking.
I'm going to be relocating home in a minute, but the other thing I'm going to
try is to go back to the multiprocessing.P
tfiala updated this revision to Diff 34089.
tfiala added a comment.
Specify tight queue sizes for the job description queue and the job results
queue.
This *might* stop unintentional queue blocking when adding items to the queue
if they were sized too small by default. Might be a possible diff
krytarowski created this revision.
krytarowski added a reviewer: joerg.
krytarowski added a subscriber: lldb-commits.
krytarowski set the repository for this revision to rL LLVM.
Problem was caught on NetBSD.
Repository:
rL LLVM
http://reviews.llvm.org/D12654
Files:
tools/lldb-mi/MIUtilStri
Author: sivachandra
Date: Fri Sep 4 18:11:38 2015
New Revision: 246894
URL: http://llvm.org/viewvc/llvm-project?rev=246894&view=rev
Log:
[TestMiBreak] Replace expectedFlakeyLinux with an appropriate expectedFailureAll
Reviewers: chaoren
Subscribers: lldb-commits
Differential Revision: http://r
sivachandra created this revision.
sivachandra added a reviewer: chaoren.
sivachandra added a subscriber: lldb-commits.
http://reviews.llvm.org/D12653
Files:
test/tools/lldb-mi/breakpoint/TestMiBreak.py
Index: test/tools/lldb-mi/breakpoint/TestMiBreak.py
===
tfiala added a comment.
In http://reviews.llvm.org/D12651#240443, @zturner wrote:
> Correct, it doesn't do that prior to the patch. It looks like it's never
> exiting this loop:
>
> try:
> for worker in workers:
> worker.join()
> except:
>
>
> either when a Ctrl+C happens
Correct, it doesn't do that prior to the patch. It looks like it's never
exiting this loop:
try:
for worker in workers:
worker.join()
except:
either when a Ctrl+C happens, or when all the processes finish. I guess
it's stuck in there for some reason.
tfiala added a comment.
In http://reviews.llvm.org/D12651#240439, @zturner wrote:
> Hmm, yea the problem is worse than I thought. Even if I don't do Ctrl+C at
> all (I just run the test suite like I always have and let it finish) it's
> just leaving a bunch of stale processes at the end withou
clayborg added a comment.
Were you running dosep.py on Windows before as the way to run your test suite?
Or were you running dotest.py (no multi-threading)?
http://reviews.llvm.org/D12651
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
clayborg added a comment.
I believe that python is also weird in that if you want to catch a CTRL+C it
has to be executing python code (not in a python code the entered C/C++ code)
otherwise the CTRL+C might not get to the python itself. This might be only a
problem in the embedded python inter
Hmm, yea the problem is worse than I thought. Even if I don't do Ctrl+C at
all (I just run the test suite like I always have and let it finish) it's
just leaving a bunch of stale processes at the end without them shutting
down on their own.
On Fri, Sep 4, 2015 at 3:39 PM Todd Fiala wrote:
> tfi
tfiala added a comment.
In http://reviews.llvm.org/D12651#240429, @zturner wrote:
> I can try to put a little time into figuring out what's wrong. I'd rather
> it not go in broken though, so let me take a look first and we can figure
> out what to do after that.
Yep absolutely.
http://revi
tfiala added a comment.
In http://reviews.llvm.org/D12651#240423, @zturner wrote:
> Ctrl+C once doesn't work on Windows with this patch. It seems to continue
> starting up new processes, and after all of them are done, I'm left with the
> original set of Python processes not doing any work, ju
I can try to put a little time into figuring out what's wrong. I'd rather
it not go in broken though, so let me take a look first and we can figure
out what to do after that.
On Fri, Sep 4, 2015 at 3:35 PM Greg Clayton wrote:
> clayborg accepted this revision.
> clayborg added a comment.
> This
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine. Zach, do you need to make some modifications for Windows? Or should
we just check this in and you can fix windows with a separate patch?
http://reviews.llvm.org/D12651
zturner added a comment.
Ctrl+C once doesn't work on Windows with this patch. It seems to continue
starting up new processes, and after all of them are done, I'm left with the
original set of Python processes not doing any work, just sitting there. If I
Ctrl+C again everything does.
Note tha
Author: gclayton
Date: Fri Sep 4 17:29:46 2015
New Revision: 246887
URL: http://llvm.org/viewvc/llvm-project?rev=246887&view=rev
Log:
Check for null compile unit so we don't crash.
Modified:
lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
Modified: lldb/trunk/source/Plugins/
Author: sivachandra
Date: Fri Sep 4 17:26:52 2015
New Revision: 246885
URL: http://llvm.org/viewvc/llvm-project?rev=246885&view=rev
Log:
Convert "long" input to "long long" in typemap for lldb::tid_t.
Summary: lldb::tid_t is 64 bit, but "long" need not always be 64 bit.
Reviewers: chying, clayb
tfiala created this revision.
tfiala added reviewers: clayborg, zturner.
tfiala added a subscriber: lldb-commits.
This change does the following:
* If Ctrl-C is hit once, the parallel dotest.py runner will stop any further
work from being started, but will wait for the existing tests in progress
Author: enrico
Date: Fri Sep 4 17:07:48 2015
New Revision: 246884
URL: http://llvm.org/viewvc/llvm-project?rev=246884&view=rev
Log:
Add a --language (-l) option to type category {enable|disable} to allow people
to turn on and off formatters for a given language
Modified:
lldb/trunk/include
Author: enrico
Date: Fri Sep 4 16:22:54 2015
New Revision: 246876
URL: http://llvm.org/viewvc/llvm-project?rev=246876&view=rev
Log:
Never mind, I see what the problem is on the Windows build. Attempt a fix
Modified:
lldb/trunk/source/DataFormatters/CXXFunctionPointer.cpp
lldb/trunk/sourc
> On Sep 4, 2015, at 2:01 PM, Enrico Granata via lldb-commits
> wrote:
>
> Added:
>lldb/trunk/include/lldb/DataFormatters/CXXFunctionPointer.h
> - copied unchanged from r246859,
> lldb/trunk/include/lldb/DataFormatters/CXXFunctionPointer.h
The Windows buildbot claims it can’t find th
tfiala added a comment.
I'm glad that worked for you, Dawn!
Users:
tfiala (Author)
dawn (Auditor)
http://reviews.llvm.org/rL246794
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
I agree with Zachary that we shouldn't mess around with options piecemeal, but
let Todd get done with this first round of fixes then go take a hatchet to the
options that dotest has, hopefully removing all the ones that nobody needs and
rationalizing the others.
Jim
> On Sep 4, 2015, at 1:31 P
Author: spyffe
Date: Fri Sep 4 15:54:25 2015
New Revision: 246872
URL: http://llvm.org/viewvc/llvm-project?rev=246872&view=rev
Log:
I accidentally committed some project-file changes. Undid those.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
lldb/trunk/lldb.xcodeproj/xcshareddata
Author: spyffe
Date: Fri Sep 4 15:49:51 2015
New Revision: 246871
URL: http://llvm.org/viewvc/llvm-project?rev=246871&view=rev
Log:
This patch separates the generic portion of ClangExpressionVariable, which
stores information about a variable that different parts of LLDB use, from the
compiler-sp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246870: Sleep-and-retry after a failure to delete a log
file, which may be because… (authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D12641?vs=34063&id=34071#toc
Repository:
r
Author: amccarth
Date: Fri Sep 4 15:48:48 2015
New Revision: 246870
URL: http://llvm.org/viewvc/llvm-project?rev=246870&view=rev
Log:
Sleep-and-retry after a failure to delete a log file, which may be because
antimalware is holding the handle to the just-created file.
Differential Revision: htt
sas accepted this revision.
sas added a reviewer: sas.
sas added a comment.
This revision is now accepted and ready to land.
Wow, this is funny.
Thanks for the explanation @zturner and thanks for adding the comment @amccarth.
http://reviews.llvm.org/D12641
___
dawn accepted this commit.
dawn added a comment.
Apparently now you must use:
./dotest.py --output-on-success -v --executable $INSTALLDIR/bin/lldb
to see the same detailed output as you used to see with:
./dosep.py -s --options "-v --executable $INSTALLDIR/bin/lldb"
or:
./dotest.py -v -
On Fri, Sep 04, 2015 at 12:44:36PM -0700, Todd Fiala wrote:
> Please try:
>
> ./dotest.py --output-on-success -v --executable $INSTALLDIR/bin/lldb
Yes, this appears to work. With this, I'm now back up to my old totals :)
lldb_failures=0
lldb_errors=0
lldb_passes=1146
lldb_total=1
amccarth updated this revision to Diff 34063.
amccarth added a comment.
I've put more detail in the comment.
http://reviews.llvm.org/D12641
Files:
test/lldbtest.py
Index: test/lldbtest.py
===
--- test/lldbtest.py
+++ test/lldbte
zturner added a subscriber: zturner.
zturner added a comment.
Windows is well-known (I wouldn't say documented necessarily, but it seems
everyone has run into this problem before) where there is a very short
window after a process exits where some of the handles that were used by
the file (e.g. op
Windows is well-known (I wouldn't say documented necessarily, but it seems
everyone has run into this problem before) where there is a very short
window after a process exits where some of the handles that were used by
the file (e.g. open files, the image file itself, etc) are still locked by
the o
spyffe updated this revision to Diff 34061.
spyffe added a comment.
Added a newline to the end of ExpressionVariable.cpp
http://reviews.llvm.org/D12602
Files:
include/lldb/Core/ValueObject.h
include/lldb/Expression/ClangExpressionDeclMap.h
include/lldb/Expression/ClangFunction.h
include
On Fri, Sep 04, 2015 at 12:40:12PM -0700, Todd Fiala wrote:
> > Now there is no equivelent to "dosep.py -s", and:
> >./dotest.py -v --executable $INSTALLDIR/bin/lldb
>
> All of dosep's args moved over to dotest. I think if you wanted dosep.py
> -s behavior, you only need to use --output-on-su
Yeah I'm actually hoping that once we move over to a test event stream that
can be formatted with a customizable formatter, we can pretty much start
deprecating the other output streams aside from the pure test run
stdout/stderr.
On Fri, Sep 4, 2015 at 12:45 PM, Zachary Turner wrote:
>
>
> On Fr
sas added a subscriber: sas.
sas added a comment.
Can you just explain why this race happens?
Otherwise, looks good.
http://reviews.llvm.org/D12641
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
On Fri, Sep 4, 2015 at 12:40 PM Todd Fiala wrote:
> > Now there is no equivelent to "dosep.py -s", and:
> >./dotest.py -v --executable $INSTALLDIR/bin/lldb
>
> All of dosep's args moved over to dotest. I think if you wanted dosep.py
> -s behavior, you only need to use --output-on-success (lo
Please try:
./dotest.py --output-on-success -v --executable $INSTALLDIR/bin/lldb
I think you'll find that is identical output to what used to be this:
./dosep.py -s --options "-v --executable $INSTALLDIR/bin/lldb"
If you find differently, please let me know. I couldn't maintain the '-s'
mappin
I see how that could have been confusing. I should have called that out
more.
On Fri, Sep 4, 2015 at 12:40 PM, Todd Fiala wrote:
> > Now there is no equivelent to "dosep.py -s", and:
> >./dotest.py -v --executable $INSTALLDIR/bin/lldb
>
> All of dosep's args moved over to dotest. I think i
> Now there is no equivelent to "dosep.py -s", and:
>./dotest.py -v --executable $INSTALLDIR/bin/lldb
All of dosep's args moved over to dotest. I think if you wanted dosep.py
-s behavior, you only need to use --output-on-success (long form of what
used to be -s in dosep I believe). The reaso
On Fri, Sep 04, 2015 at 06:25:44PM +, Todd Fiala wrote:
> tfiala added a comment.
>
> Dawn, the output supported by the command shouldn't have been changed. I'll
> have a peek at what may have caused that to happen. All this change was
> trying to do was stop the need to call dosep and rol
jingham added a comment.
That look good. There's one place (noted inline) where you are missing a
newline at the end of a file. Fix that and it's good to go.
Comment at: source/Expression/ExpressionVariable.cpp:32-33
@@ +31,2 @@
+return NULL;
+}
\ No newline at end of fil
spyffe updated this revision to Diff 34055.
spyffe added a comment.
Applied Jim's suggestion that FindVariableInList return a
ClangExpressionVariable *. Also fixed some places where we should have called
shared_from_this instead of creating a new shared pointer.
http://reviews.llvm.org/D12602
krytarowski added a comment.
$ python2.7
Python 2.7.10 (default, Jul 2 2015, 13:17:37)
[GCC 4.8.4] on netbsd7
Type "help", "copyright", "credits" or "license" for more information.
>>> import sys
>>> print sys.platform
n
On Fri, Sep 04, 2015 at 06:25:44PM +, Todd Fiala wrote:
> tfiala added a comment.
>
> Dawn, the output supported by the command shouldn't have been changed. I'll
> have a peek at what may have caused that to happen. All this change was
> trying to do was stop the need to call dosep and rol
spyffe added a comment.
Working on that now. I have to be careful not just to stuff
ClangExpressionVariable* into ExpressionVariableSP, but to use
shared_from_this, otherwise I get crashes in the testsuite. I'll update this
patch once I get that cleaned up.
http://reviews.llvm.org/D12602
I guess the thing to do in that case would be to fix it. I know priorities
and all, but I don't want to hold back progress supporting an external
workflow.
In any case, Todd says that the output shouldn't have changed, so it may
still be that you can continue doing this (for now). But at some po
On Fri, Sep 04, 2015 at 06:17:03PM +, Zachary Turner wrote:
> To be honest I think grepping the output is the wrong way to go about
> counting the tests.
> [...] Log scraping is kind of a horrible thing to do,
Agreed, but it was the only way to get correct totals. I would love for
dosep.py t
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
Allows about 10 passing tests to succeed rather than fail due to log file
juggling.
http://reviews.llvm.org/D12641
Files:
test/lldbtest.py
Index: test/lldbtest.py
==
ki.stfu requested changes to this revision.
ki.stfu added a comment.
This revision now requires changes to proceed.
Source code looks good but please move the test to TestMiData.py.
Comment at: test/tools/lldb-mi/variable/TestMiVar.py:39-42
@@ -38,2 +38,6 @@
self.expect
tfiala added a comment.
Dawn, the output supported by the command shouldn't have been changed. I'll
have a peek at what may have caused that to happen. All this change was trying
to do was stop the need to call dosep and roll that behavior into dotest.
Zachary, I'm in the process of add xUnit
To be honest I think grepping the output is the wrong way to go about
counting the tests.
If there's a regression in that you no longer have access to a piece of
information that you need, then we should fix it by printing the value you
need. Log scraping is kind of a horrible thing to do, becaus
dawn added a comment.
I really liked that dosep.py -s and dotest.py would report the run of each test
case:
Collected 6 tests
1: test_double_type_from_block_with_dsym (TestFloatTypes.FloatTypesTestCase)
Test that double-type variables are displayed correctly from a block. ... ok
2: te
dawn added a subscriber: dawn.
dawn raised a concern with this commit.
dawn added a comment.
I'm very unhappy with this change. Before I could count up all the test
failures using:
./dotest.py -v --executable $INSTALLDIR/bin/lldb 2>&1 | tee
$INSTALLDIR/lldb_test_out.log || true
lldb_fai
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
Comment at: include/lldb/Symbol/ClangASTContext.h:484
@@ -483,3 +483,3 @@
//--
-
+
dawn added a subscriber: lldb-commits.
Users:
tfiala (Author)
http://reviews.llvm.org/rL246794
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
We really do need to restrict this for single stepping purposes. If the thread
plans that single step and set breakpoints for stepping think they should place
a breakpoint on 0x1004 if the
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
I would rather see the register variables laid out in a way which makes the
offsets meaningful. I.e., instead of having m_fpr, m_gpr, ... we put something
like
struct Regs {
uint32_t gp
Author: abidh
Date: Fri Sep 4 11:34:19 2015
New Revision: 246859
URL: http://llvm.org/viewvc/llvm-project?rev=246859&view=rev
Log:
Use correct #ifdef check for ProcessWindowsLog::Terminate() call.
The call to ProcessWindowsLog::Initialize() is protected by #if
defined(_MSC_VER).
But the call to
If the user says "break set -a " I have no problem with our
setting the breakpoint there even if we don't think it is a terribly good idea.
But if lldb is converting any other specification to an address, it should
always move past data in text. The failure modes if you aren't careful about
t
tberghammer added a comment.
I agree that we want to enable it only in very special cases when the user
really know what he/she wants (probably pass in a --force flag). Anyway, it
isn't implemented with this change and I don't expect it to be implemented in
the near future.
http://reviews.llv
jingham added a subscriber: jingham.
jingham added a comment.
If the user says "break set -a " I have no problem with our
setting the breakpoint there even if we don't think it is a terribly good idea.
But if lldb is converting any other specification to an address, it should
always move past
Author: abidh
Date: Fri Sep 4 11:10:48 2015
New Revision: 246858
URL: http://llvm.org/viewvc/llvm-project?rev=246858&view=rev
Log:
Fix CMICmdArgValConsume to correctly handle "--".
CMICmdArgValConsume::Validate was not removing it from the input stream.
Modified:
lldb/trunk/tools/lldb-mi/M
tberghammer updated this revision to Diff 34038.
tberghammer added a comment.
Updated the change based on the comments.
I don't fully agree with restricting the user from setting breakpoint in
non-code locations because if LLDB classified a section incorrectly (e.g.
haven't found the SO file fo
jingham added a subscriber: jingham.
jingham added a comment.
It isn't technically necessary, but on OS X it is very common for people to
want to examine global app state from wherever and that is always ObjC, so we'd
tick off our users if we forced them to explicitly dial up ObjC in other
cont
It isn't technically necessary, but on OS X it is very common for people to
want to examine global app state from wherever and that is always ObjC, so we'd
tick off our users if we forced them to explicitly dial up ObjC in other
contexts. For other platforms it would be fine to choose just C++.
tberghammer created this revision.
tberghammer added reviewers: labath, chaoren, omjavaid.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer, rengolin, aemerson.
Fix the handling of FPR offsets in Linux arm/aarch64 register contexts
This should fix the
tfiala resigned from this revision.
tfiala removed a reviewer: tfiala.
tfiala added a comment.
Stale and not happening AFAICT.
http://reviews.llvm.org/D5806
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
abidh created this revision.
abidh added a reviewer: ki.stfu.
abidh added a subscriber: lldb-commits.
For an array declared like "blk[2][3]", this command was showing:
-data-evaluate-expression blk
^done,value="{[0] = [3], [1] = [3]}"
After this fix, it shows:
-data-evaluate-expression blk
^done,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246852: Fix TestLoadUnload.test_load_unload for android API
> 21 (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12601?vs=33949&id=34025#toc
Repository:
rL LLVM
http://r
Author: tberghammer
Date: Fri Sep 4 07:42:41 2015
New Revision: 246852
URL: http://llvm.org/viewvc/llvm-project?rev=246852&view=rev
Log:
Fix TestLoadUnload.test_load_unload for android API > 21
* Change Module::MatchesModuleSpec to return true in case the file spec
in the specified module spec
jaydeep added inline comments.
Comment at: source/Target/RegisterContext.cpp:106-116
@@ -105,3 +105,13 @@
uint32_t reg = ConvertRegisterKindToRegisterNumber (eRegisterKindGeneric,
LLDB_REGNUM_GENERIC_PC);
-return ReadRegisterAsUnsigned (reg, fail_value);
+uint64_t pc
Author: abidh
Date: Fri Sep 4 06:26:53 2015
New Revision: 246847
URL: http://llvm.org/viewvc/llvm-project?rev=246847&view=rev
Log:
Fix multiple problems in -break-condition command.
1. To handle the expression with spaces, this command uses 2 arguments. For a
case
like -break-condition 1 i =
Author: labath
Date: Fri Sep 4 05:21:15 2015
New Revision: 246845
URL: http://llvm.org/viewvc/llvm-project?rev=246845&view=rev
Log:
Add a repro case for bug llvm.org/pr24702
Added:
lldb/trunk/test/functionalities/jitloader_gdb/
lldb/trunk/test/functionalities/jitloader_gdb/Makefile
l
tberghammer added inline comments.
Comment at: source/Core/Module.cpp:1712
@@ -1712,1 +1711,3 @@
+if (!FileSpec::Equal (file_spec, m_file,
(bool)file_spec.GetDirectory()) &&
+!FileSpec::Equal (file_spec, m_platform_file,
(bool)file_spec.GetDirectory()))
Sorry for the breakage. It should be fixed by r246791
On Fri, Sep 4, 2015 at 1:34 AM Dawn Perchik wrote:
> dawn added a subscriber: dawn.
> dawn added a comment.
>
> We're seeing 2 new failures on OSX since this commit:
>
>
> Failure-TestCompletion.CommandLineCompletionTestCase.test_symbol_name
tberghammer added a subscriber: tberghammer.
tberghammer added a comment.
Sorry for the breakage. It should be fixed by r246791
Users:
tberghammer (Author)
http://reviews.llvm.org/rL246639
___
lldb-commits mailing list
lldb-commits@lists.llvm.or
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246843: Move GetOptInc to the common namespace (authored by
labath).
Changed prior to commit:
http://reviews.llvm.org/D12582?vs=33944&id=34020#toc
Repository:
rL LLVM
http://reviews.llvm.org/D12582
Author: labath
Date: Fri Sep 4 04:06:15 2015
New Revision: 246843
URL: http://llvm.org/viewvc/llvm-project?rev=246843&view=rev
Log:
Move GetOptInc to the common namespace
Summary:
GetOptInc provides getopt(), getopt_long() and getopt_long_only().
Windows (for defined(_MSC_VER)) doesn't ship wit
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246842: RenderScript pending kernel breakpoints. (authored
by EwanCrawford).
Changed prior to commit:
http://reviews.llvm.org/D12360?vs=33425&id=34018#toc
Repository:
rL LLVM
http://reviews.llvm.org
Author: ewancrawford
Date: Fri Sep 4 03:56:52 2015
New Revision: 246842
URL: http://llvm.org/viewvc/llvm-project?rev=246842&view=rev
Log:
RenderScript pending kernel breakpoints.
Currently the RS breakpoint command can only find a kernel if it's in an
already loaded RS module.
This patch allows
labath added a comment.
In http://reviews.llvm.org/D12599#239378, @tfiala wrote:
> 13% size decrease sounds nice! Was that with a DebugAsserts build,
> optimized, or what?
This was a release build (-O3 -DNDEBUG). Size went down from ~58 to ~51 MB.
> tfiala, on Mac OS X with this change, the
Author: abhishek
Date: Fri Sep 4 02:44:05 2015
New Revision: 246841
URL: http://llvm.org/viewvc/llvm-project?rev=246841&view=rev
Log:
SysV ABI for i386 Architecture
Summary:
- Capability to force return user specified values
from inside of a function on lldb command terminal
- Support f
94 matches
Mail list logo
