[Lldb-commits] [lldb] r246955 - Bug 24457 - X87 FPU Special Purpose Registers

Author: abhishek Date: Mon Sep 7 02:40:16 2015 New Revision: 246955 URL: http://llvm.org/viewvc/llvm-project?rev=246955=rev Log: Bug 24457 - X87 FPU Special Purpose Registers Summary: - For 'register read --all' command on x86_64-Linux Platform: -- Provide correct values of X87 FPU

[Lldb-commits] [PATCH] D12670: [LLDB][MIPS] MIPS load/store instruction emulation for hardware watchpoints

mohit.bhakkad created this revision. mohit.bhakkad added a reviewer: clayborg. mohit.bhakkad added subscribers: jaydeep, bhushan, sagar, nitesh.jain, lldb-commits. mohit.bhakkad set the repository for this revision to rL LLVM. Emulate MIPS32/64 load and store instructions for HW watchpoints.

[Lldb-commits] [lldb] r246956 - Extend the XFAIL for TestMiBreak

Author: labath Date: Mon Sep 7 02:58:29 2015 New Revision: 246956 URL: http://llvm.org/viewvc/llvm-project?rev=246956=rev Log: Extend the XFAIL for TestMiBreak the test is occasionally failing on linux for all tested scenarios. Modified:

Re: [Lldb-commits] [PATCH] D12661: NetBSD doesn't provide struct statfs, make use of struct statvfs

labath added a subscriber: labath. labath added a comment. In http://reviews.llvm.org/D12661#240625, @joerg wrote: > One good question is whether using statvfs(3) shouldn't be the default as it > is the POSIX interface. Unfortunately, that will not work as linux does not define the MNT_LOCAL

[Lldb-commits] [lldb] r246957 - Fixup TestRegisters after r246955

Author: labath Date: Mon Sep 7 03:54:34 2015 New Revision: 246957 URL: http://llvm.org/viewvc/llvm-project?rev=246957=rev Log: Fixup TestRegisters after r246955 - clang is picky about inline assembly: add the correct instruction size suffix - mark the new test as expectedFailureClang: the test

Re: [Lldb-commits] [lldb] r246955 - Bug 24457 - X87 FPU Special Purpose Registers

Hi, this new test fails when the inferior is compiled with clang, as the produced line tables are not what you expect. I have marked it as XFAIL to get the bots green, but it would be great if we could write it in a way that works on clang as well. pl On 7 September 2015 at 08:40, Abhishek

[Lldb-commits] [lldb] r246969 - [www] Typo fixes.

Author: brucem Date: Mon Sep 7 08:03:07 2015 New Revision: 246969 URL: http://llvm.org/viewvc/llvm-project?rev=246969=rev Log: [www] Typo fixes. Reviewers: clayborg, ki.stfu Subscribers: tberghammer, danalbert, srhines, lldb-commits Differential Revision: http://reviews.llvm.org/D12668

[Lldb-commits] [lldb] r246958 - Use eAddressClassCode for address lookup for opcodes for stack frames

Author: tberghammer Date: Mon Sep 7 04:58:09 2015 New Revision: 246958 URL: http://llvm.org/viewvc/llvm-project?rev=246958=rev Log: Use eAddressClassCode for address lookup for opcodes for stack frames It is required because of the following edge case on arm: bxNon-tail call in a no return

[Lldb-commits] [lldb] r246966 - Mark TestCreateDuringInstructionStep as flaky on android arm

Author: labath Date: Mon Sep 7 07:15:27 2015 New Revision: 246966 URL: http://llvm.org/viewvc/llvm-project?rev=246966=rev Log: Mark TestCreateDuringInstructionStep as flaky on android arm Modified:

Re: [Lldb-commits] [PATCH] D12636: Fix the handling of FPR offsets in Linux arm/aarch64 register contexts

This revision was automatically updated to reflect the committed changes. Closed by commit rL246959: Fix the handling of FPR offsets in Linux arm/aarch64 register contexts (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D12636?vs=34034=34138#toc Repository: rL

[Lldb-commits] [lldb] r246965 - Fix -data-evaluate-expression for array.

Author: abidh Date: Mon Sep 7 07:00:51 2015 New Revision: 246965 URL: http://llvm.org/viewvc/llvm-project?rev=246965=rev Log: Fix -data-evaluate-expression for array. Summary: For an array declared like "blk[2][3]", this command was showing: -data-evaluate-expression blk ^done,value="{[0] =

Re: [Lldb-commits] [PATCH] D12671: [LLDB][MIPS] Added support for the debugging of N32/O32 applications on MIPS64 target.

nitesh.jain updated the summary for this revision. nitesh.jain updated this revision to Diff 34146. nitesh.jain added a comment. Added include/lldb/Core/ArchSpec.h diff Repository: rL LLVM http://reviews.llvm.org/D12671 Files: include/lldb/Core/ArchSpec.h source/Core/ArchSpec.cpp

[Lldb-commits] [lldb] r246964 - Skip RegisterCommandsTestCase.test_fp_register_write on Android i386

Author: labath Date: Mon Sep 7 06:59:01 2015 New Revision: 246964 URL: http://llvm.org/viewvc/llvm-project?rev=246964=rev Log: Skip RegisterCommandsTestCase.test_fp_register_write on Android i386 it appears a kernel bug is preventing us from writing into the register. Modified:

Re: [Lldb-commits] [PATCH] D12634: Fix -data-evaluate-expression for array.

abidh updated this revision to Diff 34136. abidh added a comment. Handle review comments. Moved the test to data directory and put it in a separate function. http://reviews.llvm.org/D12634 Files: test/tools/lldb-mi/data/TestMiData.py test/tools/lldb-mi/data/main.cpp

Re: [Lldb-commits] [lldb] r246955 - Bug 24457 - X87 FPU Special Purpose Registers

Hi Thanks a lot for pointing out. There was a problem with the compilation of the inferior with clang and hence, the absence of the inferior's executable was causing the failure of the test for clang compiler. I fixed it and will soon upstream the change. Thanks & Regards Abhishek Aggarwal

Re: [Lldb-commits] [PATCH] D12636: Fix the handling of FPR offsets in Linux arm/aarch64 register contexts

tberghammer added a comment. I prefer to keep it this way because there is no canonical register layout we can rely on so putting them just next to each other would be just an arbitrary layout what might break in the future. If we want the offsets to make sense, then on arm/aarch64 the best

[Lldb-commits] [lldb] r246959 - Fix the handling of FPR offsets in Linux arm/aarch64 register contexts

Author: tberghammer Date: Mon Sep 7 05:11:23 2015 New Revision: 246959 URL: http://llvm.org/viewvc/llvm-project?rev=246959=rev Log: Fix the handling of FPR offsets in Linux arm/aarch64 register contexts Differential revision: http://reviews.llvm.org/D12636 Modified:

Re: [Lldb-commits] [PATCH] D12677: Bug 24733: TestRegisters.py for Clang inferiors

labath added a subscriber: lldb-commits. Comment at: test/functionalities/register/TestRegisters.py:195 @@ +194,3 @@ +for x in range(0,16): +self.runCmd ("si", RUN_SUCCEEDED) + First I would like to applaud for writing a test case for

[Lldb-commits] [lldb] r246972 - XFAIL single_step_only_steps_one_instruction related tests on arm/aarch64

Author: tberghammer Date: Mon Sep 7 11:01:26 2015 New Revision: 246972 URL: http://llvm.org/viewvc/llvm-project?rev=246972=rev Log: XFAIL single_step_only_steps_one_instruction related tests on arm/aarch64 Modified: lldb/trunk/test/tools/lldb-server/TestGdbRemoteSingleStep.py

Re: [Lldb-commits] [PATCH] D12677: Bug 24733: TestRegisters.py for Clang inferiors

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. looks good. please also close the relevant bug after submission. http://reviews.llvm.org/D12677 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D12672: add a dependency on terminfo library if llvm uses it

jeremi.piotrowski created this revision. jeremi.piotrowski added a subscriber: lldb-commits. Ncurses related symbols can either all be found in libnurses or split between libncurses and libtinfo. The main LLVM cmake scripts look for the setupterm symbol and stores the library that has it in

Re: [Lldb-commits] [PATCH] D12291: Add split dwarf support to SymbolFileDWARF

tberghammer added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DIERef.cpp:34-44 @@ +33,13 @@ + +DIERef::DIERef(const DWARFFormValue& form_value) : +cu_offset(DW_INVALID_OFFSET), +die_offset(DW_INVALID_OFFSET) +{ +if (form_value.IsValid()) +{ +

Re: [Lldb-commits] [PATCH] D12677: Bug 24733: TestRegisters.py for Clang inferiors

abhishek.aggarwal added inline comments. Comment at: test/functionalities/register/TestRegisters.py:195 @@ +194,3 @@ +for x in range(0,16): +self.runCmd ("si", RUN_SUCCEEDED) + labath wrote: > First I would like to applaud for writing

Re: [Lldb-commits] [PATCH] D12677: Bug 24733: TestRegisters.py for Clang inferiors

abhishek.aggarwal updated this revision to Diff 34161. abhishek.aggarwal added a comment. Clang/GCC generate different assembly for same inferior. Changed a.cpp to remove dependency of TestRegisters.py on assembly instructions generated by Clang/GCC. Changed TestRegisters.py to write a generic

Re: [Lldb-commits] [PATCH] D12651: Add ctrl-c support to parallel dotest.py.

Adrian, can you verify this in the morning? Basically just trying to ensure that ninja check-lldb still works as it did before. There's a chance I'm going to be OOO tomorrow (or at the very best late) due to something unexpected. On Mon, Sep 7, 2015 at 9:38 PM Todd Fiala

Re: [Lldb-commits] [PATCH] D12651: Add ctrl-c support to parallel dotest.py.

zturner added a comment. Adrian, can you verify this in the morning? Basically just trying to ensure that ninja check-lldb still works as it did before. There's a chance I'm going to be OOO tomorrow (or at the very best late) due to something unexpected. http://reviews.llvm.org/D12651

Re: [Lldb-commits] [PATCH] D12667: [cmake] Remove LLDB_ENABLE_PYTHON_SCRIPTS_SWIG_API_GENERATION.

brucem added a comment. zturner, was that an approval to land this? http://reviews.llvm.org/D12667 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12667: [cmake] Remove LLDB_ENABLE_PYTHON_SCRIPTS_SWIG_API_GENERATION.

Yes On Mon, Sep 7, 2015 at 9:58 PM Bruce Mitchener wrote: > brucem added a comment. > > zturner, was that an approval to land this? > > > http://reviews.llvm.org/D12667 > > > > ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D12683: Fix debugger shutdown when Python interpreter is loaded

tfiala added inline comments. Comment at: source/Core/Debugger.cpp:426 @@ +425,3 @@ +for (const auto& debugger: debuggers) +debugger->Clear(); + ovyalov wrote: > tfiala wrote: > > Wouldn't Clear() be considered a mutating function? So a const

Re: [Lldb-commits] [PATCH] D12683: Fix debugger shutdown when Python interpreter is loaded

What were the symptoms of this? How'd you find it? On Mon, Sep 7, 2015 at 6:47 PM Oleksiy Vyalov via lldb-commits < lldb-commits@lists.llvm.org> wrote: > ovyalov created this revision. > ovyalov added a reviewer: clayborg. > ovyalov added a subscriber: lldb-commits. > > Python locks in memory a

Re: [Lldb-commits] [PATCH] D12651: Add ctrl-c support to parallel dotest.py.

tfiala added a comment. @zturner, at this point you should be able to run this and see no change on Windows (assuming I did the os check correctly). The Windows test runner is set to be the previous multithreading-pool strategy. For everyone else, they'll get the multithreading strategy by

Re: [Lldb-commits] [PATCH] D12651: Add ctrl-c support to parallel dotest.py.

tfiala updated this revision to Diff 34186. tfiala added a comment. Adds "threading" test-runner strategy, which mirrors the "multithreading" runner in terms of supporting Ctrl-C and hand-rolling the worker model. Like multiprocessing over multiprocessing-pool, threading outperforms

[Lldb-commits] [PATCH] D12683: Fix debugger shutdown when Python interpreter is loaded

ovyalov created this revision. ovyalov added a reviewer: clayborg. ovyalov added a subscriber: lldb-commits. Python locks in memory a few global objects like lldb.debugger,lldb.target,... - as a consequence, ~Debugger isn't called upon shutdown. Calling Debugger::Clear ensures that

Re: [Lldb-commits] [PATCH] D12683: Fix debugger shutdown when Python interpreter is loaded

ovyalov added inline comments. Comment at: source/Core/Debugger.cpp:426 @@ +425,3 @@ +for (const auto& debugger: debuggers) +debugger->Clear(); + tfiala wrote: > Wouldn't Clear() be considered a mutating function? So a const debugger ref > seems

Re: [Lldb-commits] [PATCH] D12672: add a dependency on terminfo library if llvm uses it

zturner added a comment. Looks fine, do you have commit access? If so feel free to commit whenever. Otherwise I can do it for you tomorrow http://reviews.llvm.org/D12672 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D12672: add a dependency on terminfo library if llvm uses it

Looks fine, do you have commit access? If so feel free to commit whenever. Otherwise I can do it for you tomorrow On Mon, Sep 7, 2015 at 1:15 PM Jeremi Piotrowski < jeremi.piotrow...@gmail.com> wrote: > jeremi.piotrowski updated this revision to Diff 34169. > jeremi.piotrowski added a comment.

Re: [Lldb-commits] [PATCH] D12672: add a dependency on terminfo library if llvm uses it

jeremi.piotrowski updated this revision to Diff 34169. jeremi.piotrowski added a comment. - combine nested if conditions with `and` as suggested by zturner and remove condtition from `endif` as that seems to be the convention. http://reviews.llvm.org/D12672 Files:

[Lldb-commits] [PATCH] D12671: [LLDB][MIPS] Added support for the debugging of N32/O32 applications on MIPS64 target.

nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, ovyalov. nitesh.jain added subscribers: jaydeep, bhushan, sagar, mohit.bhakkad, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. Repository: rL LLVM http://reviews.llvm.org/D12671 Files:

Re: [Lldb-commits] [PATCH] D12672: add a dependency on terminfo library if llvm uses it

zturner added a subscriber: zturner. zturner added a comment. Looks fine to me, but as a nitpick, I would suggest combining the nested if into a single if with an AND clause. http://reviews.llvm.org/D12672 ___ lldb-commits mailing list