Re: [Lldb-commits] [PATCH] D12746: The pipe2(2) call is supported on NetBSD

On Thu, Sep 10, 2015 at 01:15:43AM +, Kamil Rytarowski wrote: > Linux and NetBSD versions are compatible, modulo flag values: > - O_CLOEXEC and O_NONBLOCK are the same, > - O_NOSIGPIPE on NetBSD, > - O_DIRECT on Linux. I wonder why we don't just detect this via appropiate build test. There sho

Re: [Lldb-commits] [PATCH] D12115: [LLDB-MI] Fix -data-info-line and -symbol-list-lines when Windows filenames are used.

I'm probably not the best person for this since I don't know anything about the MI stuff On Wed, Sep 9, 2015 at 8:33 PM Dawn Perchik wrote: > dawn added a comment. > > ping? > > > Repository: > rL LLVM > > http://reviews.llvm.org/D12115 > > > > ___ l

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

jaydeep added a comment. In http://reviews.llvm.org/D12079#242742, @clayborg wrote: > So DumpAddress() in FormatEntity.cpp is a generic "dump any address by > describing it". You can't just change the code to suit your needs for MIPS. > This address could be any address: code or data. If you wa

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

jaydeep added a comment. In http://reviews.llvm.org/D12079#242751, @clayborg wrote: > Actually not a new format type, but an extra arg will need to be passed to > DumpAddress like "bool addr_is_callable". > > Can you explain something to me? In the following example: > > 0x8020067d <+0>: addi

Re: [Lldb-commits] [PATCH] D12115: [LLDB-MI] Fix -data-info-line and -symbol-list-lines when Windows filenames are used.

dawn added a comment. ping? Repository: rL LLVM http://reviews.llvm.org/D12115 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12115: [LLDB-MI] Fix -data-info-line and -symbol-list-lines when Windows filenames are used.

dawn updated this revision to Diff 34406. Repository: rL LLVM http://reviews.llvm.org/D12115 Files: test/tools/lldb-mi/symbol/Makefile test/tools/lldb-mi/symbol/TestMiSymbol.py test/tools/lldb-mi/symbol/main.cpp test/tools/lldb-mi/symbol/x.cpp test/tools/lldb-mi/symbol/x.h tools/ll

[Lldb-commits] [PATCH] D12750: Link NetBSD with execinfo (CMAKE build)

krytarowski created this revision. krytarowski added a reviewer: joerg. krytarowski added a subscriber: lldb-commits. krytarowski set the repository for this revision to rL LLVM. FreeBSD and NetBSD share the same library execinfo. Repository: rL LLVM http://reviews.llvm.org/D12750 Files: cm

Re: [Lldb-commits] [PATCH] D12659: Use SI_KERNEL on platforms defining it

krytarowski added a comment. Still valid. Repository: rL LLVM http://reviews.llvm.org/D12659 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12749: Link liblldb.so with LLVMObjCARCOpts.a

krytarowski added a comment. Older reports: https://llvm.org/bugs/show_bug.cgi?id=18214 Repository: rL LLVM http://reviews.llvm.org/D12749 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [PATCH] D12749: Link liblldb.so with LLVMObjCARCOpts.a

krytarowski created this revision. krytarowski added a reviewer: joerg. krytarowski added a subscriber: lldb-commits. krytarowski set the repository for this revision to rL LLVM. Problems reported on NetBSD: ``` llvm[4]: Linking Debug+Asserts executable lldb /tmp/build-llvm/Debug+Asserts/lib/lib

[Lldb-commits] [PATCH] D12748: Include platform agnostic in the place of

krytarowski created this revision. krytarowski added a reviewer: joerg. krytarowski added a subscriber: lldb-commits. krytarowski set the repository for this revision to rL LLVM. Problem caught on NetBSD with missing getopt_long_only(3). Repository: rL LLVM http://reviews.llvm.org/D12748 File

[Lldb-commits] [PATCH] D12746: The pipe2(2) call is supported on NetBSD

krytarowski created this revision. krytarowski added a reviewer: joerg. krytarowski added a subscriber: lldb-commits. krytarowski set the repository for this revision to rL LLVM. Linux and NetBSD versions are compatible, modulo flag values: - O_CLOEXEC and O_NONBLOCK are the same, - O_NOSIGPIPE on

[Lldb-commits] [lldb] r247227 - Removed debug prints that I accidentally left in.

Author: gclayton Date: Wed Sep 9 19:57:34 2015 New Revision: 247227 URL: http://llvm.org/viewvc/llvm-project?rev=247227&view=rev Log: Removed debug prints that I accidentally left in. Modified: lldb/trunk/scripts/build-llvm.pl Modified: lldb/trunk/scripts/build-llvm.pl URL: http://llvm.or

[Lldb-commits] [lldb] r247224 - On MacOSX, revamp the way we link against the llvm/clang .a files by making a text file that contains all .a filenames and use that when linking in Xcode.

Author: gclayton Date: Wed Sep 9 19:48:44 2015 New Revision: 247224 URL: http://llvm.org/viewvc/llvm-project?rev=247224&view=rev Log: On MacOSX, revamp the way we link against the llvm/clang .a files by making a text file that contains all .a filenames and use that when linking in Xcode. Modif

[Lldb-commits] [lldb] r247206 - Fix a small comment typo in Windows Process code.

Author: sas Date: Wed Sep 9 17:58:23 2015 New Revision: 247206 URL: http://llvm.org/viewvc/llvm-project?rev=247206&view=rev Log: Fix a small comment typo in Windows Process code. Modified: lldb/trunk/source/Plugins/Process/Windows/Live/LocalDebugDelegate.h Modified: lldb/trunk/source/Plugin

Re: [Lldb-commits] [lldb] r247082 - Implement a Target::GetTypeSystemForLanguage API, as well as provide helpers on the TypeSystem to get numeric types of specific sizes and signedness

On Wed, Sep 9, 2015 at 2:57 PM Enrico Granata wrote: > On Sep 9, 2015, at 2:47 PM, Ryan Brown wrote: > > > On Tue, Sep 8, 2015 at 3:10 PM Enrico Granata via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > >> Author: enrico >> Date: Tue Sep 8 17:09:19 2015 >> New Revision: 247082 >> >> UR

[Lldb-commits] [lldb] r247202 - Fix the build-llvm.pl to not create one monster .a file from all of the llvm and clang .a files. We now just make a file list which we pass to the linker.

Author: gclayton Date: Wed Sep 9 17:35:25 2015 New Revision: 247202 URL: http://llvm.org/viewvc/llvm-project?rev=247202&view=rev Log: Fix the build-llvm.pl to not create one monster .a file from all of the llvm and clang .a files. We now just make a file list which we pass to the linker. Modif

[Lldb-commits] [lldb] r247200 - Introduce the notion of an escape helper. Different languages have different notion of what to print in a string and how to escape non-printable things. The escape help

Author: enrico Date: Wed Sep 9 17:30:24 2015 New Revision: 247200 URL: http://llvm.org/viewvc/llvm-project?rev=247200&view=rev Log: Introduce the notion of an escape helper. Different languages have different notion of what to print in a string and how to escape non-printable things. The escape

[Lldb-commits] [lldb] r247197 - Remove unused function.

Author: gclayton Date: Wed Sep 9 17:13:36 2015 New Revision: 247197 URL: http://llvm.org/viewvc/llvm-project?rev=247197&view=rev Log: Remove unused function. Modified: lldb/trunk/include/lldb/Symbol/ClangASTContext.h lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: lldb/trunk/inc

[Lldb-commits] [lldb] r247196 - Now that CompilerType uses a "TypeSystem *" and a "void *" instead of a "clang::ASTContext *" and a "void *", we need to know if anyone is trying to create a CompilerTy

Author: gclayton Date: Wed Sep 9 17:13:01 2015 New Revision: 247196 URL: http://llvm.org/viewvc/llvm-project?rev=247196&view=rev Log: Now that CompilerType uses a "TypeSystem *" and a "void *" instead of a "clang::ASTContext *" and a "void *", we need to know if anyone is trying to create a Com

[Lldb-commits] [lldb] r247195 - Remove Target::GetBasicType()

Author: enrico Date: Wed Sep 9 17:00:18 2015 New Revision: 247195 URL: http://llvm.org/viewvc/llvm-project?rev=247195&view=rev Log: Remove Target::GetBasicType() I was experimenting with it briefly, and then settled on Target::GetTypeSystem + TypeSystem::GetBasicType, so this API is not necessar

Re: [Lldb-commits] [lldb] r247082 - Implement a Target::GetTypeSystemForLanguage API, as well as provide helpers on the TypeSystem to get numeric types of specific sizes and signedness

> On Sep 9, 2015, at 2:47 PM, Ryan Brown wrote: > > > On Tue, Sep 8, 2015 at 3:10 PM Enrico Granata via lldb-commits > mailto:lldb-commits@lists.llvm.org>> wrote: > Author: enrico > Date: Tue Sep 8 17:09:19 2015 > New Revision: 247082 > > URL: http://llvm.org/viewvc/llvm-project?rev=247082&v

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

clayborg added a comment. Actually not a new format type, but an extra arg will need to be passed to DumpAddress like "bool addr_is_callable". Can you explain something to me? In the following example: 0x8020067d <+0>: addiusp -16 0x8020067f <+2>: sw $fp, 12($sp) 0x80200681 <+4>: m

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. So DumpAddress() in FormatEntity.cpp is a generic "dump any address by describing it". You can't just change the code to suit your needs for MIPS. This address could be any addre

Re: [Lldb-commits] [lldb] r247082 - Implement a Target::GetTypeSystemForLanguage API, as well as provide helpers on the TypeSystem to get numeric types of specific sizes and signedness

On Tue, Sep 8, 2015 at 3:10 PM Enrico Granata via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: enrico > Date: Tue Sep 8 17:09:19 2015 > New Revision: 247082 > > URL: http://llvm.org/viewvc/llvm-project?rev=247082&view=rev > Log: > Implement a Target::GetTypeSystemForLanguage API,

[Lldb-commits] [lldb] r247193 - Remove a call to deleted function.

Author: gclayton Date: Wed Sep 9 16:34:32 2015 New Revision: 247193 URL: http://llvm.org/viewvc/llvm-project?rev=247193&view=rev Log: Remove a call to deleted function. Modified: lldb/trunk/source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp Modified: lldb/trunk/source/Plugins/Disassemb

[Lldb-commits] [lldb] r247189 - Preparatory work for letting language plugins help the StringPrinter with formatting special characters

Author: enrico Date: Wed Sep 9 15:59:49 2015 New Revision: 247189 URL: http://llvm.org/viewvc/llvm-project?rev=247189&view=rev Log: Preparatory work for letting language plugins help the StringPrinter with formatting special characters Modified: lldb/trunk/include/lldb/DataFormatters/Strin

[Lldb-commits] [lldb] r247190 - For now skip ThreadSpecificBreakTestCase on FreeBSD

Author: emaste Date: Wed Sep 9 16:00:10 2015 New Revision: 247190 URL: http://llvm.org/viewvc/llvm-project?rev=247190&view=rev Log: For now skip ThreadSpecificBreakTestCase on FreeBSD It often hangs or times out, and obscures issues with other tests. Just skip it for now (until the FreeBSD test

Re: [Lldb-commits] [PATCH] D12728: New RenderScript command to break on all kernels

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This looks fine to me. You might want to add LIBLLDB_LOG_BREAKPOINT to your log creation, you can them together, and if I was tracking breakpoints with "log enable lldb breakpoint" I'd expe

Re: [Lldb-commits] [PATCH] D12677: Bug 24733: TestRegisters.py for Clang inferiors

ovyalov added a comment. In http://reviews.llvm.org/D12677#242290, @abhishek.aggarwal wrote: > In http://reviews.llvm.org/D12677#242006, @ovyalov wrote: > > > I reverted the CL because it was causing > > TestRegisters.test_fp_special_purpose_register_read to fail on OSX: > > > > - stop reason =

Re: [Lldb-commits] [lldb] r247173 - Don't allow duplicate names for tests.

On 9 September 2015 at 14:25, Zachary Turner via lldb-commits wrote: > Author: zturner > Date: Wed Sep 9 13:25:13 2015 > New Revision: 247173 > > URL: http://llvm.org/viewvc/llvm-project?rev=247173&view=rev > Log: > Don't allow duplicate names for tests. > > We had 2 tests named TestCPPBreakpoint

[Lldb-commits] [lldb] r247175 - Make sure to flush the stream to make sure the string is up to date when we query its size.

Author: gclayton Date: Wed Sep 9 13:41:50 2015 New Revision: 247175 URL: http://llvm.org/viewvc/llvm-project?rev=247175&view=rev Log: Make sure to flush the stream to make sure the string is up to date when we query its size. Modified: lldb/trunk/source/Plugins/Disassembler/llvm/Disassembl

[Lldb-commits] [lldb] r247173 - Don't allow duplicate names for tests.

Author: zturner Date: Wed Sep 9 13:25:13 2015 New Revision: 247173 URL: http://llvm.org/viewvc/llvm-project?rev=247173&view=rev Log: Don't allow duplicate names for tests. We had 2 tests named TestCPPBreakpoints.py. If one of those tests failed, both of them would be reported as failures and co

Re: [Lldb-commits] TestFormattersBoolRefPtr.py on OSX

> On Sep 9, 2015, at 11:19 AM, Tamas Berghammer wrote: > > I attached the log for the failure (come from the build bot). > > About the double reporting, I seen it on one of the build bot, but we have > some case when 2 different test have the same name what can explain the issue > (e.g. TestF

Re: [Lldb-commits] TestFormattersBoolRefPtr.py on OSX

I attached the log for the failure (come from the build bot). About the double reporting, I seen it on one of the build bot, but we have some case when 2 different test have the same name what can explain the issue (e.g. TestFormattersBoolRefPtr) Tamas On Wed, Sep 9, 2015 at 6:54 PM Zachary Turn

Re: [Lldb-commits] TestFormattersBoolRefPtr.py on OSX

+Todd just in case this is related to his changes. We were seeing 1 or 2 test failures double reporting on Windows after the patch, so I'm not sure if it could be related. On Wed, Sep 9, 2015 at 10:37 AM Enrico Granata via lldb-commits < lldb-commits@lists.llvm.org> wrote: > > On Sep 9, 2015, at

Re: [Lldb-commits] TestFormattersBoolRefPtr.py on OSX

> On Sep 9, 2015, at 5:10 AM, Tamas Berghammer wrote: > > Hi Enrico, > > TestFormattersBoolRefPtr.py started to fail on the OSX buildbot. I think the > first build where it is failed is > http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/5522 >

[Lldb-commits] [lldb] r247164 - Fix some compiler warnings.

Author: zturner Date: Wed Sep 9 12:25:43 2015 New Revision: 247164 URL: http://llvm.org/viewvc/llvm-project?rev=247164&view=rev Log: Fix some compiler warnings. Modified: lldb/trunk/source/Core/DataExtractor.cpp lldb/trunk/source/DataFormatters/ValueObjectPrinter.cpp lldb/trunk/sourc

[Lldb-commits] [PATCH] D12728: New RenderScript command to break on all kernels

EwanCrawford created this revision. EwanCrawford added reviewers: clayborg, jingham. EwanCrawford added subscribers: lldb-commits, domipheus, ADodds. EwanCrawford set the repository for this revision to rL LLVM. Patch adds a command to RenderScript plugin allowing users to automatically set break

[Lldb-commits] [lldb] r247143 - Update expectedFailureFreeBSD to expectedFlakeyFreeBSD for intermittent tests

Author: emaste Date: Wed Sep 9 08:15:14 2015 New Revision: 247143 URL: http://llvm.org/viewvc/llvm-project?rev=247143&view=rev Log: Update expectedFailureFreeBSD to expectedFlakeyFreeBSD for intermittent tests Due to LLDB or test race conditions these tests do not pass consistently. llvm.org/pr

[Lldb-commits] [lldb] r247141 - XFAIL TestFormatters on FreeBSD

Author: emaste Date: Wed Sep 9 08:10:33 2015 New Revision: 247141 URL: http://llvm.org/viewvc/llvm-project?rev=247141&view=rev Log: XFAIL TestFormatters on FreeBSD The test is hitting an assertion in Clang. This is an extension of r246766. llvm.org/pr24691 Modified: lldb/trunk/test/expres

[Lldb-commits] TestFormattersBoolRefPtr.py on OSX

Hi Enrico, TestFormattersBoolRefPtr.py started to fail on the OSX buildbot. I think the first build where it is failed is http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/5522, but I am not sure as the bot is a bit unreliable. Can you take a look for it, or if not, then are you fin

[Lldb-commits] [lldb] r247137 - Fix type in include header name

Author: tberghammer Date: Wed Sep 9 06:28:52 2015 New Revision: 247137 URL: http://llvm.org/viewvc/llvm-project?rev=247137&view=rev Log: Fix type in include header name Modified: lldb/trunk/include/lldb/Core/MappedHash.h Modified: lldb/trunk/include/lldb/Core/MappedHash.h URL: http://llvm.

[Lldb-commits] [lldb] r247135 - Add missing include after rL247131

Author: tberghammer Date: Wed Sep 9 06:16:32 2015 New Revision: 247135 URL: http://llvm.org/viewvc/llvm-project?rev=247135&view=rev Log: Add missing include after rL247131 Modified: lldb/trunk/include/lldb/Core/MappedHash.h Modified: lldb/trunk/include/lldb/Core/MappedHash.h URL: http://ll

Re: [Lldb-commits] [PATCH] D12677: Bug 24733: TestRegisters.py for Clang inferiors

abhishek.aggarwal added a comment. In http://reviews.llvm.org/D12677#242006, @ovyalov wrote: > I reverted the CL because it was causing > TestRegisters.test_fp_special_purpose_register_read to fail on OSX: > > - stop reason = EXC_BREAKPOINT > - "register read ftag" yields 0x80 instead of expecte

[Lldb-commits] [lldb] r247134 - [LLDB][MIPS] Added support for the debugging of N32/O32 applications on MIPS64 target.

Author: mohit.bhakkad Date: Wed Sep 9 05:32:20 2015 New Revision: 247134 URL: http://llvm.org/viewvc/llvm-project?rev=247134&view=rev Log: [LLDB][MIPS] Added support for the debugging of N32/O32 applications on MIPS64 target. Patch by Nitesh Jain Reviewers: clayborg, ovyalov. Subscribers: jayde

Re: [Lldb-commits] [PATCH] D12671: [LLDB][MIPS] Added support for the debugging of N32/O32 applications on MIPS64 target.

This revision was automatically updated to reflect the committed changes. Closed by commit rL247134: [LLDB][MIPS] Added support for the debugging of N32/O32 applications on… (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D12671?vs=34146&id=34314#toc Repository:

Re: [Lldb-commits] [PATCH] D12699: Change the looping stack detection code

This revision was automatically updated to reflect the committed changes. Closed by commit rL247133: Change the looping stack detection code (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D12699?vs=34227&id=34313#toc Repository: rL LLVM http://reviews.llvm.org/D

[Lldb-commits] [lldb] r247133 - Change the looping stack detection code

Author: tberghammer Date: Wed Sep 9 05:26:50 2015 New Revision: 247133 URL: http://llvm.org/viewvc/llvm-project?rev=247133&view=rev Log: Change the looping stack detection code In some special case (e.g. signal handlers, hand written assembly) it is valid to have 2 stack frame with the same CFA

Re: [Lldb-commits] [PATCH] D12699: Change the looping stack detection code

tberghammer added a comment. In ABI conforming code we will never have even 2 consecutive frames with the same CFA for all ABI I know about. In practice, 2 consecutive frame with the same CFA can happen (for hand written assembly and signal handling), but more then 2 is highly unlikely. In theor

[Lldb-commits] [lldb] r247131 - Code cleanup in preparation of adding split dwarf support

Author: tberghammer Date: Wed Sep 9 05:20:36 2015 New Revision: 247131 URL: http://llvm.org/viewvc/llvm-project?rev=247131&view=rev Log: Code cleanup in preparation of adding split dwarf support * Remove some unused code * Remove usage of DWARFDebugInfoEntry::Attributes where usage isn't reaso

Re: [Lldb-commits] [PATCH] D12374: Code cleanup in preparation of adding split dwarf support

This revision was automatically updated to reflect the committed changes. Closed by commit rL247131: Code cleanup in preparation of adding split dwarf support (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D12374?vs=33226&id=34309#toc Repository: rL LLVM http://

[Lldb-commits] [lldb] r247130 - Remove the dwo files in the cleanup stage of the tests

Author: tberghammer Date: Wed Sep 9 05:20:30 2015 New Revision: 247130 URL: http://llvm.org/viewvc/llvm-project?rev=247130&view=rev Log: Remove the dwo files in the cleanup stage of the tests The dwo files are generated when the tests run with split dwarf info. Modified: lldb/trunk/test/mak

[Lldb-commits] [lldb] r247129 - [LLDB][MIPS] MIPS load/store instruction emulation for hardware watchpoints

Author: mohit.bhakkad Date: Wed Sep 9 05:17:58 2015 New Revision: 247129 URL: http://llvm.org/viewvc/llvm-project?rev=247129&view=rev Log: [LLDB][MIPS] MIPS load/store instruction emulation for hardware watchpoints Reviewers: clayborg. Subscribers: jaydeep, bhushan, sagar, nitesh.jain, lldb-comm

Re: [Lldb-commits] [PATCH] D12670: [LLDB][MIPS] MIPS load/store instruction emulation for hardware watchpoints

This revision was automatically updated to reflect the committed changes. Closed by commit rL247129: [LLDB][MIPS] MIPS load/store instruction emulation for hardware watchpoints (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D12670?vs=34132&id=34308#toc Repository

[Lldb-commits] [lldb] r247124 - Remove an invalid check in DW_OP_piece processing.

Author: abidh Date: Wed Sep 9 04:06:05 2015 New Revision: 247124 URL: http://llvm.org/viewvc/llvm-project?rev=247124&view=rev Log: Remove an invalid check in DW_OP_piece processing. Summary: When lldb is processing a location containing DW_OP_piece, the result is being stored in the 'pieces' var

Re: [Lldb-commits] [PATCH] D12674: Remove an invalid check in DW_OP_piece processing.

This revision was automatically updated to reflect the committed changes. Closed by commit rL247124: Remove an invalid check in DW_OP_piece processing. (authored by abidh). Changed prior to commit: http://reviews.llvm.org/D12674?vs=34154&id=34301#toc Repository: rL LLVM http://reviews.llvm.