[Lldb-commits] [lldb] r247973 - xunit output: add backtraces; limit attribute

2015-09-18 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Fri Sep 18 02:08:09 2015 New Revision: 247973 URL: http://llvm.org/viewvc/llvm-project?rev=247973&view=rev Log: xunit output: add backtraces; limit attribute When pexpect errors occurred, the / element's message attribute could get too long and contain invalid characters for

Re: [Lldb-commits] [PATCH] D12899: cmake fixups: post-build python step dependency and lldb-server dependency for lldb on Linux

2015-09-18 Thread Ilia K via lldb-commits
ki.stfu added a subscriber: ki.stfu. ki.stfu added a comment. Hi guys, As for me it wasn't a bug and lldb should not require lldb-server and python framework. "ninja lldb" means "make a lldb executable please". I don't want to build lldb-server or python framework when typing that. If you are r

Re: [Lldb-commits] [PATCH] D12899: cmake fixups: post-build python step dependency and lldb-server dependency for lldb on Linux

2015-09-18 Thread Ilia K via lldb-commits
ki.stfu added a comment. i. e. +1 with @zturner http://reviews.llvm.org/D12899 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12900: Fix link failures when BUILD_SHARED_LIBS=ON.

2015-09-18 Thread Pavel Labath via lldb-commits
labath added a subscriber: labath. labath added a reviewer: labath. labath added a comment. Thanks for the patch. LLDBDependencies.cmake sets LLDB_SYSTEM_LIBS to the list of libraries lldb depends on. Could you check if it is not sufficient to add this to the list of dependencies? I'd like to a

Re: [Lldb-commits] [PATCH] D12900: Fix link failures when BUILD_SHARED_LIBS=ON.

2015-09-18 Thread Kamil Rytarowski via lldb-commits
krytarowski added a subscriber: krytarowski. krytarowski requested changes to this revision. krytarowski added a reviewer: krytarowski. This revision now requires changes to proceed. Comment at: tools/lldb-server/CMakeLists.txt:40 @@ +39,3 @@ + if (NOT LLDB_DISABLE_CURSES) +t

Re: [Lldb-commits] [PATCH] D12900: Fix link failures when BUILD_SHARED_LIBS=ON.

2015-09-18 Thread Daniel Sanders via lldb-commits
dsanders updated this revision to Diff 35075. dsanders added a comment. Pavel's suggestion to use LLDB_SYSTEM_LIBS works for me. Updated the patch. http://reviews.llvm.org/D12900 Files: tools/lldb-server/CMakeLists.txt Index: tools/lldb-server/CMakeLists.txt =

Re: [Lldb-commits] [PATCH] D12748: Include platform agnostic in the place of

2015-09-18 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. Any interest? Repository: rL LLVM http://reviews.llvm.org/D12748 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12900: Fix link failures when BUILD_SHARED_LIBS=ON.

2015-09-18 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL247991: Fix link failures when BUILD_SHARED_LIBS=ON. (authored by labath). Changed prior to commit: http://reviews.llvm.org/D12900?vs=35075&id=35082#toc Repository: rL LLVM http://reviews.llvm.org/D

[Lldb-commits] [lldb] r247991 - Fix link failures when BUILD_SHARED_LIBS=ON.

2015-09-18 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Sep 18 09:22:45 2015 New Revision: 247991 URL: http://llvm.org/viewvc/llvm-project?rev=247991&view=rev Log: Fix link failures when BUILD_SHARED_LIBS=ON. patch by Daniel Sanders. Reviewers: labath, krytarowski Subscribers: krytarowski, labath, lldb-commits Differential

Re: [Lldb-commits] [PATCH] D12900: Fix link failures when BUILD_SHARED_LIBS=ON.

2015-09-18 Thread Pavel Labath via lldb-commits
labath added a comment. Committed as r247991. We can tweak this later if needed after Kamil's changes go in. Repository: rL LLVM http://reviews.llvm.org/D12900 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[Lldb-commits] [PATCH] D12962: Use ClangASTContext for compile units with language eLanguageTypeMipsAssembler

2015-09-18 Thread Tamas Berghammer via lldb-commits
tberghammer created this revision. tberghammer added reviewers: jingham, dawn. tberghammer added a subscriber: lldb-commits. Use ClangASTContext for compile units with language eLanguageTypeMipsAssembler Both GNU AS and LLVM emits language type DW_LANG_Mips_Assembler for all assembly code. http

[Lldb-commits] [PATCH] D12963: Eliminate a potential crash in the struct layout code with a gracefull fallback

2015-09-18 Thread Tamas Berghammer via lldb-commits
tberghammer created this revision. tberghammer added a reviewer: spyffe. tberghammer added a subscriber: lldb-commits. Eliminate a potential crash in the struct layout code with a gracefull fallback http://reviews.llvm.org/D12963 Files: source/Expression/ClangASTSource.cpp Index: source/Expre

[Lldb-commits] [PATCH] D12964: [lldb-server] No need to add pthread twice.

2015-09-18 Thread Daniel Sanders via lldb-commits
dsanders created this revision. dsanders added subscribers: krytarowski, labath, lldb-commits. Following on from r247991: pthread is in LLDB_SYSTEM_LIBS so there's no need to explicitly add it to the link. http://reviews.llvm.org/D12964 Files: tools/lldb-server/CMakeLists.txt Index: tools/ll

Re: [Lldb-commits] [PATCH] D12964: [lldb-server] No need to add pthread twice.

2015-09-18 Thread Daniel Sanders via lldb-commits
dsanders updated this revision to Diff 35086. dsanders added a comment. Correct the patch. Arcanist created the diff based on a revision prior to r247991 for some reason. http://reviews.llvm.org/D12964 Files: tools/lldb-server/CMakeLists.txt Index: tools/lldb-server/CMakeLists.txt =

Re: [Lldb-commits] [PATCH] D12899: cmake fixups: post-build python step dependency and lldb-server dependency for lldb on Linux

2015-09-18 Thread Zachary Turner via lldb-commits
One possible solution is to make an lldb-all target. On Fri, Sep 18, 2015 at 12:38 AM Ilia K wrote: > ki.stfu added a comment. > > i. e. +1 with @zturner > > > http://reviews.llvm.org/D12899 > > > > ___ lldb-commits mailing list lldb-commits@lists.llvm

Re: [Lldb-commits] [PATCH] D12899: cmake fixups: post-build python step dependency and lldb-server dependency for lldb on Linux

2015-09-18 Thread Zachary Turner via lldb-commits
zturner added a comment. One possible solution is to make an lldb-all target. http://reviews.llvm.org/D12899 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12899: cmake fixups: post-build python step dependency and lldb-server dependency for lldb on Linux

2015-09-18 Thread Ilia K via lldb-commits
ki.stfu added a comment. In http://reviews.llvm.org/D12899#248648, @zturner wrote: > One possible solution is to make an lldb-all target. As I said, it would much better rather than changing lldb dependencies. But I'm still not sure, do we really need something like lldb-all? Why we can't use

Re: [Lldb-commits] [PATCH] D12899: cmake fixups: post-build python step dependency and lldb-server dependency for lldb on Linux

2015-09-18 Thread Tamas Berghammer via lldb-commits
tberghammer added a subscriber: tberghammer. tberghammer added a comment. In http://reviews.llvm.org/D12899#248654, @ki.stfu wrote: > In http://reviews.llvm.org/D12899#248648, @zturner wrote: > > > One possible solution is to make an lldb-all target. > > > As I said, it would much better rather t

[Lldb-commits] [PATCH] D12966: Renderscript plugin support for aarch64

2015-09-18 Thread Dean De Leo via lldb-commits
dean created this revision. dean added reviewers: jingham, clayborg. dean added subscribers: lldb-commits, ADodds, EwanCrawford. dean set the repository for this revision to rL LLVM. Herald added subscribers: srhines, danalbert, tberghammer, rengolin, aemerson. This patch adds support to the rende

[Lldb-commits] [PATCH] D12968: Fix for lldb-mi crash in Listener code if -exec-abort MI command was invoked without getting process stopped

2015-09-18 Thread Kirill Lapshin via lldb-commits
KLapshin created this revision. KLapshin added reviewers: dawn, ki.stfu, abidh. KLapshin added a subscriber: lldb-commits. KLapshin set the repository for this revision to rL LLVM. This patch fixes lldb core crash in Listener waiting for process ended and operates with already invalid data if lld

[Lldb-commits] [lldb] r247998 - xUnit test output: implemented proper xml escaping

2015-09-18 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Fri Sep 18 11:00:52 2015 New Revision: 247998 URL: http://llvm.org/viewvc/llvm-project?rev=247998&view=rev Log: xUnit test output: implemented proper xml escaping Now does proper Unicode code region scanning for invalid XML characters. Strips out XML-invalid characters. Doe

Re: [Lldb-commits] [PATCH] D12954: Reduce inclusion of clang headers.

2015-09-18 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Very nice. http://reviews.llvm.org/D12954 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

Re: [Lldb-commits] [PATCH] D12954: Reduce inclusion of clang headers.

2015-09-18 Thread Greg Clayton via lldb-commits
clayborg added a comment. It would be great if there were an automated tool that could detect when any #include wasn't needed for both headers and implementation files. http://reviews.llvm.org/D12954 ___ lldb-commits mailing list lldb-commits@lists

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

2015-09-18 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. Repository: rL LLVM http://reviews.llvm.org/D12079 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D12899: cmake fixups: post-build python step dependency and lldb-server dependency for lldb on Linux

2015-09-18 Thread Todd Fiala via lldb-commits
tfiala added a comment. From a high level, when we ask a build system to build the lldb executable, we want that to mean "build me an lldb and anything it will use as part of its normal operation." If we did not build the lldb executable's expected components (as was the case when I started th

[Lldb-commits] [lldb] r248003 - Differential Revision: http://reviews.llvm.org/D12966

2015-09-18 Thread Aidan Dodds via lldb-commits
Author: aidandodds Date: Fri Sep 18 11:49:39 2015 New Revision: 248003 URL: http://llvm.org/viewvc/llvm-project?rev=248003&view=rev Log: Differential Revision: http://reviews.llvm.org/D12966 On behalf of Dean De Leo Modified: lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScri

Re: [Lldb-commits] [PATCH] D12899: cmake fixups: post-build python step dependency and lldb-server dependency for lldb on Linux

2015-09-18 Thread Ilia K via lldb-commits
ki.stfu added a comment. In http://reviews.llvm.org/D12899#248657, @tberghammer wrote: > In http://reviews.llvm.org/D12899#248654, @ki.stfu wrote: > > > In http://reviews.llvm.org/D12899#248648, @zturner wrote: > > > > > One possible solution is to make an lldb-all target. > > > > > > As I said,

[Lldb-commits] [lldb] r248004 - Reduce inclusion of clang headers.

2015-09-18 Thread Bruce Mitchener via lldb-commits
Author: brucem Date: Fri Sep 18 12:02:48 2015 New Revision: 248004 URL: http://llvm.org/viewvc/llvm-project?rev=248004&view=rev Log: Reduce inclusion of clang headers. Summary: With the recent changes to separate clang from the core structures of LLDB, many inclusions of clang headers can be remo

Re: [Lldb-commits] [PATCH] D12954: Reduce inclusion of clang headers.

2015-09-18 Thread Bruce Mitchener via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL248004: Reduce inclusion of clang headers. (authored by brucem). Changed prior to commit: http://reviews.llvm.org/D12954?vs=35058&id=35097#toc Repository: rL LLVM http://reviews.llvm.org/D12954 Fil

[Lldb-commits] [PATCH] D12971: Remove unused modules from module cache

2015-09-18 Thread Oleksiy Vyalov via lldb-commits
ovyalov created this revision. ovyalov added reviewers: clayborg, zturner. ovyalov added a subscriber: lldb-commits. When putting a new module into module cache sysroot folder may contain existing hard link for an existing module with the same name but different build-id. Use hard link counter t

[Lldb-commits] [lldb] r248007 - Link NetBSD with execinfo (CMAKE build)

2015-09-18 Thread Stephane Sezer via lldb-commits
Author: sas Date: Fri Sep 18 12:14:49 2015 New Revision: 248007 URL: http://llvm.org/viewvc/llvm-project?rev=248007&view=rev Log: Link NetBSD with execinfo (CMAKE build) Summary: FreeBSD and NetBSD share the same library execinfo. Reviewers: joerg, sas, brucem Subscribers: brucem, sas, lldb-com

Re: [Lldb-commits] [PATCH] D12750: Link NetBSD with execinfo (CMAKE build)

2015-09-18 Thread Stephane Sezer via lldb-commits
sas closed this revision. sas added a comment. Committed as r248007. Repository: rL LLVM http://reviews.llvm.org/D12750 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12971: Remove unused modules from module cache

2015-09-18 Thread Zachary Turner via lldb-commits
zturner added inline comments. Comment at: source/Host/windows/FileSystem.cpp:130 @@ +129,3 @@ +HANDLE file_handle = ::CreateFile(file_spec.GetCString(), + GENERIC_READ, + FILE_SHARE_READ, --

Re: [Lldb-commits] [PATCH] D12971: Remove unused modules from module cache

2015-09-18 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Flow looks good, take care of Zachs issues and this is good to go. http://reviews.llvm.org/D12971 ___ lldb-commits mailing list lldb-commits@

Re: [Lldb-commits] [PATCH] D12968: Fix for lldb-mi crash in Listener code if -exec-abort MI command was invoked without getting process stopped

2015-09-18 Thread Ilia K via lldb-commits
ki.stfu added a subscriber: clayborg. ki.stfu added a comment. For me it looks like a workaround because here is assumed the SBProcess::Destroy will do all required work. @clayborg, is it permissible to make a Process::Destroy(force_kill=false) for a running process? If so, it's a bug in lldb

[Lldb-commits] [PATCH] D12976: Fix TestChangeProcessGroup to properly step out of sleep.

2015-09-18 Thread Chaoren Lin via lldb-commits
chaoren created this revision. chaoren added a reviewer: labath. chaoren added a subscriber: lldb-commits. http://reviews.llvm.org/D12976 Files: test/functionalities/process_group/TestChangeProcessGroup.py Index: test/functionalities/process_group/TestChangeProcessGroup.py

Re: [Lldb-commits] [PATCH] D12971: Remove unused modules from module cache

2015-09-18 Thread Oleksiy Vyalov via lldb-commits
ovyalov updated this revision to Diff 35106. ovyalov added a comment. Replaced GENERIC_READ with FILE_READ_ATTRIBUTES when using ::CreateFile. http://reviews.llvm.org/D12971 Files: include/lldb/Host/FileSystem.h source/Host/posix/FileSystem.cpp source/Host/windows/FileSystem.cpp source/

Re: [Lldb-commits] [PATCH] D12971: Remove unused modules from module cache

2015-09-18 Thread Oleksiy Vyalov via lldb-commits
ovyalov added inline comments. Comment at: source/Host/windows/FileSystem.cpp:130 @@ +129,3 @@ +HANDLE file_handle = ::CreateFile(file_spec.GetCString(), + FILE_READ_ATTRIBUTES, + FILE_SHARE_READ, --

Re: [Lldb-commits] [PATCH] D12899: cmake fixups: post-build python step dependency and lldb-server dependency for lldb on Linux

2015-09-18 Thread Todd Fiala via lldb-commits
tfiala added a comment. In http://reviews.llvm.org/D12899#248741, @ki.stfu wrote: > In http://reviews.llvm.org/D12899#248657, @tberghammer wrote: > > > In http://reviews.llvm.org/D12899#248654, @ki.stfu wrote: > > > > > In http://reviews.llvm.org/D12899#248648, @zturner wrote: > > > > > > > One p

Re: [Lldb-commits] [PATCH] D12971: Remove unused modules from module cache

2015-09-18 Thread Zachary Turner via lldb-commits
Ok, lgtm then On Fri, Sep 18, 2015 at 10:42 AM Oleksiy Vyalov wrote: > ovyalov added inline comments. > > > Comment at: source/Host/windows/FileSystem.cpp:130 > @@ +129,3 @@ > +HANDLE file_handle = ::CreateFile(file_spec.GetCString(), > +

[Lldb-commits] [PATCH] D12977: LLDB MI addition for getting process stopped at first instruction right after launch via -exec-run

2015-09-18 Thread Kirill Lapshin via lldb-commits
KLapshin created this revision. KLapshin added reviewers: dawn, ki.stfu, abidh. KLapshin added a subscriber: lldb-commits. KLapshin set the repository for this revision to rL LLVM. In some cases debugger user may want to get debugged process stopped at very early point - at first instruction. Wi

Re: [Lldb-commits] [PATCH] D12977: LLDB MI addition for getting process stopped at first instruction right after launch via -exec-run

2015-09-18 Thread Kirill Lapshin via lldb-commits
KLapshin updated the summary for this revision. KLapshin removed rL LLVM as the repository for this revision. KLapshin updated this revision to Diff 35109. KLapshin added a comment. Minor initial diff cleanup. http://reviews.llvm.org/D12977 Files: test/tools/lldb-mi/TestMiGdbSetShow.py tool

Re: [Lldb-commits] [PATCH] D12976: Fix TestChangeProcessGroup to properly step out of sleep.

2015-09-18 Thread Chaoren Lin via lldb-commits
chaoren updated this revision to Diff 35113. chaoren added a comment. Remove old line. http://reviews.llvm.org/D12976 Files: test/functionalities/process_group/TestChangeProcessGroup.py Index: test/functionalities/process_group/TestChangeProcessGroup.py ==

Re: [Lldb-commits] [PATCH] D12976: Fix TestChangeProcessGroup to properly step out of sleep.

2015-09-18 Thread Chaoren Lin via lldb-commits
chaoren added a comment. I thought this was supposed to be fixed, but TestChangeProcessGroup, TestExpressionInSyscall, and TestRegisters just started failing for me recently because of this. http://reviews.llvm.org/D12976 ___ lldb-commits mailing

[Lldb-commits] [lldb] r248017 - Remove unused modules from module cache.

2015-09-18 Thread Oleksiy Vyalov via lldb-commits
Author: ovyalov Date: Fri Sep 18 13:12:39 2015 New Revision: 248017 URL: http://llvm.org/viewvc/llvm-project?rev=248017&view=rev Log: Remove unused modules from module cache. http://reviews.llvm.org/D12971 Modified: lldb/trunk/include/lldb/Host/FileSystem.h lldb/trunk/source/Host/posix

Re: [Lldb-commits] [PATCH] D12971: Remove unused modules from module cache

2015-09-18 Thread Oleksiy Vyalov via lldb-commits
ovyalov closed this revision. ovyalov added a comment. Files: /lldb/trunk/include/lldb/Host/FileSystem.h /lldb/trunk/source/Host/posix/FileSystem.cpp /lldb/trunk/source/Host/windows/FileSystem.cpp /lldb/trunk/source/Utility/ModuleCache.cpp Users: ovyalov (Author) http://reviews.llvm.

Re: [Lldb-commits] [PATCH] D12968: Fix for lldb-mi crash in Listener code if -exec-abort MI command was invoked without getting process stopped

2015-09-18 Thread Greg Clayton via lldb-commits
clayborg added a comment. To work around it you might be able to call SBProcess::Halt() first? Repository: rL LLVM http://reviews.llvm.org/D12968 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

Re: [Lldb-commits] [PATCH] D12968: Fix for lldb-mi crash in Listener code if -exec-abort MI command was invoked without getting process stopped

2015-09-18 Thread Greg Clayton via lldb-commits
clayborg added a comment. You should be able to just call Destroy(), we shouldn't crash. We will need to fix the core it allow this since people can/will call this. Repository: rL LLVM http://reviews.llvm.org/D12968 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D12976: Fix TestChangeProcessGroup to properly step out of sleep.

2015-09-18 Thread Pavel Labath via lldb-commits
labath added a comment. We have been looking into these failures also, and the cause is the recent changes, which make it impossible to evaluate c(++) expression in assembly language frames (see http://reviews.llvm.org/D12962). This is not the purpose of this test, but I don't think we should w

Re: [Lldb-commits] [PATCH] D12976: Fix TestChangeProcessGroup to properly step out of sleep.

2015-09-18 Thread Pavel Labath via lldb-commits
labath added a comment. (I wouldn't be opposed to temporarily XFAILing the failing tests, so they don't bother anyone running the test suite) http://reviews.llvm.org/D12976 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D12977: LLDB MI addition for getting process stopped at first instruction right after launch via -exec-run

2015-09-18 Thread Dawn Perchik via lldb-commits
dawn added a comment. lgtm, but Ilia and Abid are more familiar with lldb-mi - please wait for their review. Repository: rL LLVM http://reviews.llvm.org/D12977 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-b

Re: [Lldb-commits] [PATCH] D12962: Use ClangASTContext for compile units with language eLanguageTypeMipsAssembler

2015-09-18 Thread Dawn Perchik via lldb-commits
dawn accepted this revision. dawn added a comment. This revision is now accepted and ready to land. lgtm :) http://reviews.llvm.org/D12962 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

[Lldb-commits] [PATCH] D12980: Have a clean(er) shutdown when detaching from processes

2015-09-18 Thread Zachary Turner via lldb-commits
zturner created this revision. zturner added a reviewer: amccarth. zturner added a subscriber: lldb-commits. Log file pre-patch: 1442531634.44200 [0448/5520]: DoDetach called for process 25769804660 while state = 2673276. Detaching... 1442531634.44200 [0448/5520]: StopDebugging('false')

[Lldb-commits] [lldb] r248028 - Make libc++ tests skip themselves if libc++ is not actually loaded in the target

2015-09-18 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Sep 18 15:12:52 2015 New Revision: 248028 URL: http://llvm.org/viewvc/llvm-project?rev=248028&view=rev Log: Make libc++ tests skip themselves if libc++ is not actually loaded in the target Modified: lldb/trunk/test/functionalities/data-formatter/data-formatter-stl/l

Re: [Lldb-commits] [PATCH] D12980: Have a clean(er) shutdown when detaching from processes

2015-09-18 Thread Adrian McCarthy via lldb-commits
amccarth accepted this revision. This revision is now accepted and ready to land. Comment at: source/Plugins/Process/Windows/Live/DebuggerThread.cpp:309 @@ -308,1 +308,3 @@ { +if (m_pid_to_detach != 0 && dbe.u.Exception.ExceptionRecord

Re: [Lldb-commits] [PATCH] D12980: Have a clean(er) shutdown when detaching from processes

2015-09-18 Thread Zachary Turner via lldb-commits
I should be able to move it into `HandleExceptionEvent` On Fri, Sep 18, 2015 at 1:39 PM Adrian McCarthy wrote: > amccarth accepted this revision. > This revision is now accepted and ready to land. > > > Comment at: source/Plugins/Process/Windows/Live/DebuggerThread.cpp:309 > @@

[Lldb-commits] [PATCH] D12983: Adds parallel worker queue index to test events

2015-09-18 Thread Todd Fiala via lldb-commits
tfiala created this revision. tfiala added a reviewer: clayborg. tfiala added a subscriber: lldb-commits. This change does the following: - Adds a mechanism for adding arbitrary event content to all test events from the command line. - Adds a 0-based worker_index key into all inferior test e

Re: [Lldb-commits] [PATCH] D12983: Adds parallel worker queue index to test events

2015-09-18 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good! http://reviews.llvm.org/D12983 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[Lldb-commits] [lldb] r248036 - Adds parallel work queue index to test events, stdout/stderr results support.

2015-09-18 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Fri Sep 18 16:01:13 2015 New Revision: 248036 URL: http://llvm.org/viewvc/llvm-project?rev=248036&view=rev Log: Adds parallel work queue index to test events, stdout/stderr results support. See http://reviews.llvm.org/D12983 for details. Modified: lldb/trunk/test/dosep.p

Re: [Lldb-commits] [PATCH] D12983: Adds parallel worker queue index to test events

2015-09-18 Thread Todd Fiala via lldb-commits
tfiala added a comment. Committed here: Sendingtest/dosep.py Sendingtest/dotest.py Sendingtest/dotest_args.py Sendingtest/test_results.py Transmitting file data Committed revision 248036. I'm going to add some way to announce the number of workers

Re: [Lldb-commits] [PATCH] D12983: Adds parallel worker queue index to test events

2015-09-18 Thread Todd Fiala via lldb-commits
tfiala closed this revision. tfiala added a comment. Closed with content from previous comment. http://reviews.llvm.org/D12983 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12968: Fix for lldb-mi crash in Listener code if -exec-abort MI command was invoked without getting process stopped

2015-09-18 Thread Dawn Perchik via lldb-commits
dawn resigned from this revision. dawn edited reviewers, added: clayborg; removed: dawn. dawn added a comment. I'll watch and learn from Ilia and Greg :) Repository: rL LLVM http://reviews.llvm.org/D12968 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [PATCH] D12984: Resolve symlinks when looking for the LLDB shlib

2015-09-18 Thread Sean Callanan via lldb-commits
spyffe created this revision. spyffe added a reviewer: clayborg. spyffe added a subscriber: lldb-commits. When running the testsuite, the LLDB shlib is a symlink to its actual location, so finding shlib-relative resources can be problematic. This patch fixes that by resolving symlinks. http://

Re: [Lldb-commits] [PATCH] D12984: Resolve symlinks when looking for the LLDB shlib

2015-09-18 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. This revision now requires changes to proceed. Comment at: include/lldb/Host/FileSpec.h:516 @@ -514,1 +515,3 @@ +FileSpec +GetSymbolicLinkTarget () const; rename to ResolveSymbolicLink? Comme

[Lldb-commits] [lldb] r248047 - Fix Makefile build by adding LLVMSupport to liblldb

2015-09-18 Thread Keno Fischer via lldb-commits
Author: kfischer Date: Fri Sep 18 16:32:10 2015 New Revision: 248047 URL: http://llvm.org/viewvc/llvm-project?rev=248047&view=rev Log: Fix Makefile build by adding LLVMSupport to liblldb `llvm-mi` now depends on the regex functionality available in LLVM's support library. Modified: lldb/trun

Re: [Lldb-commits] [PATCH] D12984: Resolve symlinks when looking for the LLDB shlib

2015-09-18 Thread Sean Callanan via lldb-commits
spyffe updated this revision to Diff 35138. spyffe added a comment. Updated to reflect Greg's comments. http://reviews.llvm.org/D12984 Files: include/lldb/Host/FileSpec.h source/Host/common/FileSpec.cpp source/Host/common/HostInfoBase.cpp Index: source/Host/common/HostInfoBase.cpp ==

Re: [Lldb-commits] [PATCH] D12984: Resolve symlinks when looking for the LLDB shlib

2015-09-18 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D12984 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D12984: Resolve symlinks when looking for the LLDB shlib

2015-09-18 Thread Zachary Turner via lldb-commits
Can you move this to FileSystem.h? I don't think we should be adding more things that hit the file system to FileSpec. That's exactly the reason FileSystem.h exists, because many of the operations will be implemented differently across platforms, so we should be using the Host layer. On Fri, Sep

[Lldb-commits] [lldb] r248048 - Added support for resolving symbolic links to FileSpec.

2015-09-18 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Fri Sep 18 16:39:31 2015 New Revision: 248048 URL: http://llvm.org/viewvc/llvm-project?rev=248048&view=rev Log: Added support for resolving symbolic links to FileSpec. We use the symbolic link to resolver to find the target of the LLDB shlib symlink if there is a symlink. Th

Re: [Lldb-commits] [lldb] r248048 - Added support for resolving symbolic links to FileSpec.

2015-09-18 Thread Zachary Turner via lldb-commits
Any time there's something involving windows, even if you're just #ifdef'ing out a code path, I would prefer if you could wait until I or someone else who works on Windows has a chance to comment before committing. On Fri, Sep 18, 2015 at 2:40 PM Sean Callanan via lldb-commits < lldb-commits@lists

Re: [Lldb-commits] [PATCH] D12984: Resolve symlinks when looking for the LLDB shlib

2015-09-18 Thread Zachary Turner via lldb-commits
zturner added a comment. Furthermore, FileSpec can refer to a remote path, so you can't even guarantee that the OS you're on is the same OS as that which the path refers to. So another reason why putting this in FileSpec doesn't make sense in my opinion. http://reviews.llvm.org/D12984 __

Re: [Lldb-commits] [PATCH] D12984: Resolve symlinks when looking for the LLDB shlib

2015-09-18 Thread Sean Callanan via lldb-commits
Sure. On it. Sean > On Sep 18, 2015, at 2:44 PM, Zachary Turner wrote: > > zturner added a comment. > > Furthermore, FileSpec can refer to a remote path, so you can't even > guarantee that the OS you're on is the same OS as that which the path > refers to. So another reason why putting this

Re: [Lldb-commits] [PATCH] D12984: Resolve symlinks when looking for the LLDB shlib

2015-09-18 Thread Sean Callanan via lldb-commits
spyffe added a subscriber: spyffe. spyffe added a comment. Sure. On it. Sean http://reviews.llvm.org/D12984 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12984: Resolve symlinks when looking for the LLDB shlib

2015-09-18 Thread Zachary Turner via lldb-commits
Thanks! Feel free to leave the method in Host/windows/FileSystem.cpp empty, i'll fill it out. On Fri, Sep 18, 2015 at 3:08 PM Sean Callanan wrote: > spyffe added a subscriber: spyffe. > spyffe added a comment. > > Sure. On it. > > Sean > > > http://reviews.llvm.org/D12984 > > > > _

Re: [Lldb-commits] [PATCH] D12984: Resolve symlinks when looking for the LLDB shlib

2015-09-18 Thread Sean Callanan via lldb-commits
spyffe added a reviewer: zturner. spyffe removed a subscriber: zturner. spyffe updated this revision to Diff 35143. spyffe added a comment. At zturner's suggestion, moved the function to FileSystem and renamed it to be more consistent with what other FileSystem functions are called. http://revi

Re: [Lldb-commits] [PATCH] D12984: Resolve symlinks when looking for the LLDB shlib

2015-09-18 Thread Zachary Turner via lldb-commits
zturner added a comment. If you change the name back to `ResolveSymbolicLink` or `GetSymbolicLinkTarget`, then this looks fine. Comment at: include/lldb/Host/FileSystem.h:43 @@ -42,1 +42,3 @@ + +static Error Realpath(const FileSpec &src, FileSpec &dst); --

Re: [Lldb-commits] [PATCH] D12984: Resolve symlinks when looking for the LLDB shlib

2015-09-18 Thread Sean Callanan via lldb-commits
spyffe updated this revision to Diff 35144. spyffe added a comment. Restored the old name based on zturner's suggestion that Realpath() is too specific and has semantics that Windows wouldn't honor. http://reviews.llvm.org/D12984 Files: include/lldb/Host/FileSpec.h include/lldb/Host/FileSy

Re: [Lldb-commits] [PATCH] D12984: Resolve symlinks when looking for the LLDB shlib

2015-09-18 Thread Zachary Turner via lldb-commits
zturner accepted this revision. zturner added a comment. Thanks! http://reviews.llvm.org/D12984 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r248055 - Moved ResolveSymbolicLink() to the FileSystem where it belongs, thanks

2015-09-18 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Fri Sep 18 17:24:57 2015 New Revision: 248055 URL: http://llvm.org/viewvc/llvm-project?rev=248055&view=rev Log: Moved ResolveSymbolicLink() to the FileSystem where it belongs, thanks zturner! http://reviews.llvm.org/D12984 Modified: lldb/trunk/include/lldb/Host/FileSpec.

[Lldb-commits] [lldb] r248057 - On Linux, if you can't actually locate the libc++ install, do not attempt to use it

2015-09-18 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Sep 18 17:26:34 2015 New Revision: 248057 URL: http://llvm.org/viewvc/llvm-project?rev=248057&view=rev Log: On Linux, if you can't actually locate the libc++ install, do not attempt to use it The failure mode when one gets this wrong is quite gnarly to then walk oneself

[Lldb-commits] [PATCH] D12987: test events: announce worker count in new initialize event

2015-09-18 Thread Todd Fiala via lldb-commits
tfiala created this revision. tfiala added a reviewer: clayborg. tfiala added a subscriber: lldb-commits. This change: - renames TestFormatter.process_event() to TestFormatter.handle_event() - does away with TestFormatter.begin_session()/end_session(), replacing them with new initialize and termi

Re: [Lldb-commits] [PATCH] D12987: test events: announce worker count in new initialize event

2015-09-18 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good http://reviews.llvm.org/D12987 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[Lldb-commits] [lldb] r248059 - test events: announce worker count in new initialize event

2015-09-18 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Fri Sep 18 17:45:31 2015 New Revision: 248059 URL: http://llvm.org/viewvc/llvm-project?rev=248059&view=rev Log: test events: announce worker count in new initialize event See the following for details: http://reviews.llvm.org/D12987 Modified: lldb/trunk/test/dosep.py

Re: [Lldb-commits] [PATCH] D12987: test events: announce worker count in new initialize event

2015-09-18 Thread Todd Fiala via lldb-commits
tfiala closed this revision. tfiala added a comment. Sendingtest/dosep.py Sendingtest/dotest.py Sendingtest/dotest_args.py Sendingtest/test_results.py Transmitting file data Committed revision 248059. http://reviews.llvm.org/D12987

[Lldb-commits] [lldb] r248060 - test events: add test_filename to all test-related events.

2015-09-18 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Fri Sep 18 17:57:04 2015 New Revision: 248060 URL: http://llvm.org/viewvc/llvm-project?rev=248060&view=rev Log: test events: add test_filename to all test-related events. The test_filename is the full path to the TestCase class's implementation file. Modified: lldb/trunk

[Lldb-commits] [lldb] r248066 - test events: added optional value type to extra event key/val pairs

2015-09-18 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Fri Sep 18 18:46:30 2015 New Revision: 248066 URL: http://llvm.org/viewvc/llvm-project?rev=248066&view=rev Log: test events: added optional value type to extra event key/val pairs The test events had worker indexes coming across as strings. I want them to be ints. worker_in

[Lldb-commits] [lldb] r248072 - Added a curses based way to see the test suite running. Works only where curses is implemented. Try it out with:

2015-09-18 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Fri Sep 18 19:39:09 2015 New Revision: 248072 URL: http://llvm.org/viewvc/llvm-project?rev=248072&view=rev Log: Added a curses based way to see the test suite running. Works only where curses is implemented. Try it out with: ./dotest.py --results-formatter=test_results.Cur

[Lldb-commits] [lldb] r248075 - Fix Linux bot.

2015-09-18 Thread Chaoren Lin via lldb-commits
Author: chaoren Date: Fri Sep 18 19:57:11 2015 New Revision: 248075 URL: http://llvm.org/viewvc/llvm-project?rev=248075&view=rev Log: Fix Linux bot. Modified: lldb/trunk/test/dosep.py Modified: lldb/trunk/test/dosep.py URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/dosep.py?rev=24