Re: [Lldb-commits] [PATCH] D12748: Include platform agnostic in the place of

This revision was automatically updated to reflect the committed changes. Closed by commit rL248990: Include platform agnostic in the place of (authored by brucem). Changed prior to commit: http://reviews.llvm.org/D12748?vs=35950&id=36194#toc Repository: rL LLVM http://reviews.llvm.org/D1

[Lldb-commits] [lldb] r248990 - Include platform agnostic in the place of

Author: brucem Date: Thu Oct 1 02:45:58 2015 New Revision: 248990 URL: http://llvm.org/viewvc/llvm-project?rev=248990&view=rev Log: Include platform agnostic in the place of Summary: Problem caught on NetBSD with missing getopt_long_only(3). Change by Kamil Rytarowski Reviewers: joerg, bruc

[Lldb-commits] [lldb] r248991 - Use the correct Python lib for each build configuration generated by the Visual Studio CMake generator

Author: brucem Date: Thu Oct 1 02:47:38 2015 New Revision: 248991 URL: http://llvm.org/viewvc/llvm-project?rev=248991&view=rev Log: Use the correct Python lib for each build configuration generated by the Visual Studio CMake generator Summary: Previously `CMAKE_BUILD_TYPE` was used to determine

Re: [Lldb-commits] [PATCH] D13234: Use the correct Python lib for each build configuration generated by the Visual Studio CMake generator

This revision was automatically updated to reflect the committed changes. Closed by commit rL248991: Use the correct Python lib for each build configuration generated by the… (authored by brucem). Changed prior to commit: http://reviews.llvm.org/D13234?vs=36072&id=36196#toc Repository: rL LL

[Lldb-commits] [lldb] r248992 - Add a Post-Build Event on Windows to copy the correct custom Python DLL to the LLDB binaries dir

Author: brucem Date: Thu Oct 1 02:55:44 2015 New Revision: 248992 URL: http://llvm.org/viewvc/llvm-project?rev=248992&view=rev Log: Add a Post-Build Event on Windows to copy the correct custom Python DLL to the LLDB binaries dir Summary: After a developer builds LLDB from source on Windows (ass

Re: [Lldb-commits] [PATCH] D13237: Add a Post-Build Event on Windows to copy the correct custom Python DLL to the LLDB binaries dir

This revision was automatically updated to reflect the committed changes. Closed by commit rL248992: Add a Post-Build Event on Windows to copy the correct custom Python DLL to… (authored by brucem). Changed prior to commit: http://reviews.llvm.org/D13237?vs=35948&id=36197#toc Repository: rL

Re: [Lldb-commits] [PATCH] D13028: Merge dsym and dwarf test cases

emaste added a comment. > I'm leaving shortly to travel to EuroBSDCon so probably will not be able to > test before Wednesday, but I can investigate and update decorators as > appropriate afterwards. A follow up - the tests look good on FreeBSD after this change. On my branch with a few updat

Re: [Lldb-commits] [PATCH] D13300: Run tests with dwo symbol files

labath added a comment. Only small comments from me. Comment at: test/dotest_args.py:63 @@ -62,3 +62,3 @@ group = parser.add_argument_group('Test filtering options') -group.add_argument('-N', choices=['dwarf', 'dsym'], help="Don't do test cases marked with the @dsym de

[Lldb-commits] [lldb] r248995 - Revert "Fixing a subtle issue on Mac OS X systems with dSYMs..."

Author: labath Date: Thu Oct 1 04:03:33 2015 New Revision: 248995 URL: http://llvm.org/viewvc/llvm-project?rev=248995&view=rev Log: Revert "Fixing a subtle issue on Mac OS X systems with dSYMs..." This reverts commit r248985, as it was breaking all remote expression-evaluating tests (on android

Re: [Lldb-commits] [lldb] r248985 - Fixing a subtle issue on Mac OS X systems with dSYMs (possibly

Hi, I have reverted this as it was causing many failures on our remote android buildbots . I am hoping I will get a chance to investigate and give you a more accurate error description by EOD (your morning). Given that

[Lldb-commits] [PATCH] D13333: Reduce header inclusion in Expression.

brucem created this revision. brucem added a reviewer: spyffe. brucem added a subscriber: lldb-commits. http://reviews.llvm.org/D1 Files: include/lldb/Expression/ExpressionParser.h include/lldb/Expression/ExpressionVariable.h include/lldb/Expression/FunctionCaller.h include/lldb/Expre

Re: [Lldb-commits] [PATCH] D13323: Use %HOME%/.lldb/module_cache as a default module cache directory

tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D13323 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[Lldb-commits] [lldb] r248998 - Trim the output of mktem in PlatformAndroid::DownloadSymbolFile

Author: tberghammer Date: Thu Oct 1 04:42:23 2015 New Revision: 248998 URL: http://llvm.org/viewvc/llvm-project?rev=248998&view=rev Log: Trim the output of mktem in PlatformAndroid::DownloadSymbolFile Differential revision: http://reviews.llvm.org/D13293 Modified: lldb/trunk/source/Plugins/

Re: [Lldb-commits] [PATCH] D13293: Trim the output of mktem in PlatformAndroid::DownloadSymbolFile

This revision was automatically updated to reflect the committed changes. Closed by commit rL248998: Trim the output of mktem in PlatformAndroid::DownloadSymbolFile (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D13293?vs=36111&id=36209#toc Repository: rL LLVM h

Re: [Lldb-commits] [lldb] r248985 - Fixing a subtle issue on Mac OS X systems with dSYMs (possibly

From one of the failing tests: === runCmd: expr release_child_flag = 1 output: (volatile int) $0 = 1 Expecting sub string: = 1 Matched runCmd: print (int)getpgid(0) runCmd failed! error: use of undeclared identifier 'getpgid' error: 1 errors parsing expression === he

[Lldb-commits] [PATCH] D13334: Preliminary NetBSD support

krytarowski created this revision. krytarowski added a reviewer: joerg. krytarowski added a subscriber: lldb-commits. krytarowski set the repository for this revision to rL LLVM. This adds platform code without the cmake/gmake glue to the existing infrastructure. The missing and incompatibility

[Lldb-commits] [PATCH] D13335: [LLDB][MIPS] Skip invalid size watchpoint testcase for MIPS

mohit.bhakkad created this revision. mohit.bhakkad added a reviewer: jaydeep. mohit.bhakkad added a subscriber: lldb-commits. mohit.bhakkad set the repository for this revision to rL LLVM. There is no hard constraint on MIPS hardware watches, so skipping this test. Repository: rL LLVM http://r

Re: [Lldb-commits] [PATCH] D13334: Preliminary NetBSD support

labath added subscribers: emaste, labath. Comment at: source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp:1 @@ +1,2 @@ +//===-- PlatformNetBSD.cpp -*- C++ -*-===// +// This platform code looks like it was copy-pasted from Platform

Re: [Lldb-commits] [PATCH] D13334: Preliminary NetBSD support

krytarowski added a comment. Primary reason to skip for now build scripts is that this patch takes long to be landed. http://reviews.llvm.org/D12994 I don't want to submit a diff to patches sources... Repository: rL LLVM http://reviews.llvm.org/D13334 ___

Re: [Lldb-commits] [PATCH] D13334: Preliminary NetBSD support

krytarowski added inline comments. Comment at: source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp:1 @@ +1,2 @@ +//===-- PlatformNetBSD.cpp -*- C++ -*-===// +// labath wrote: > This platform code looks like it was copy-pasted from

Re: [Lldb-commits] [PATCH] D13334: Preliminary NetBSD support

labath added inline comments. Comment at: source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp:1 @@ +1,2 @@ +//===-- PlatformNetBSD.cpp -*- C++ -*-===// +// krytarowski wrote: > labath wrote: > > This platform code looks like it wa

Re: [Lldb-commits] [PATCH] D13334: Preliminary NetBSD support

krytarowski added inline comments. Comment at: source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp:1 @@ +1,2 @@ +//===-- PlatformNetBSD.cpp -*- C++ -*-===// +// labath wrote: > krytarowski wrote: > > labath wrote: > > > This platf

[Lldb-commits] [lldb] r249012 - Restrict the scope of a hack in DYLDRendezvous

Author: tberghammer Date: Thu Oct 1 08:57:54 2015 New Revision: 249012 URL: http://llvm.org/viewvc/llvm-project?rev=249012&view=rev Log: Restrict the scope of a hack in DYLDRendezvous The hack is there to work around an incorrect load address reported by the android linker on API 21 and 22 devic

[Lldb-commits] [lldb] r249014 - Fix Android-SDK detection on API 10 device

Author: tberghammer Date: Thu Oct 1 08:58:01 2015 New Revision: 249014 URL: http://llvm.org/viewvc/llvm-project?rev=249014&view=rev Log: Fix Android-SDK detection on API 10 device Run the getprop command with AdbClient::Shell instead of Platform::RunShellCommand because getting the output from g

[Lldb-commits] [lldb] r249013 - Fix breakpoint opcode calculation on Linux

Author: tberghammer Date: Thu Oct 1 08:57:57 2015 New Revision: 249013 URL: http://llvm.org/viewvc/llvm-project?rev=249013&view=rev Log: Fix breakpoint opcode calculation on Linux Change the way we detect if we have to place a thumb breakpoint instead of an arm breakpoint in the case when no sym

Re: [Lldb-commits] [PATCH] D13288: Restrict the scope of a hack in DYLDRendezvous

This revision was automatically updated to reflect the committed changes. Closed by commit rL249012: Restrict the scope of a hack in DYLDRendezvous (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D13288?vs=36097&id=36240#toc Repository: rL LLVM http://reviews.llv

Re: [Lldb-commits] [PATCH] D13334: Preliminary NetBSD support

labath added inline comments. Comment at: source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp:1 @@ +1,2 @@ +//===-- PlatformNetBSD.cpp -*- C++ -*-===// +// krytarowski wrote: > labath wrote: > > krytarowski wrote: > > > labath wro

[Lldb-commits] [lldb] r249020 - [LLDB][MIPS] Fix gp register value for o32 applications on 64-bit target

Author: slthakur Date: Thu Oct 1 10:05:31 2015 New Revision: 249020 URL: http://llvm.org/viewvc/llvm-project?rev=249020&view=rev Log: [LLDB][MIPS] Fix gp register value for o32 applications on 64-bit target GP registers for o32 applications were always giving zero value because SetType() on the

Re: [Lldb-commits] [lldb] r249020 - [LLDB][MIPS] Fix gp register value for o32 applications on 64-bit target

On 1 October 2015 at 16:05, Sagar Thakur via lldb-commits wrote: > +printf("Symbol: name=%s, Type:%d value=%08lx\n", symbol_name, > symbol_type, symbol.st_value); > + You seem to have left a debugging statement in. :) ___ lldb-commits mailing l

[Lldb-commits] [lldb] r249021 - Romove accidentially added statement in r249020

Author: slthakur Date: Thu Oct 1 10:15:42 2015 New Revision: 249021 URL: http://llvm.org/viewvc/llvm-project?rev=249021&view=rev Log: Romove accidentially added statement in r249020 Modified: lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp Modified: lldb/trunk/source/Plugins/Obje

Re: [Lldb-commits] [PATCH] D13334: Preliminary NetBSD support

krytarowski added inline comments. Comment at: source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp:1 @@ +1,2 @@ +//===-- PlatformNetBSD.cpp -*- C++ -*-===// +// labath wrote: > krytarowski wrote: > > labath wrote: > > > krytarowsk

[Lldb-commits] [PATCH] D13350: [lldb] Fix evaluation of global variables

evgeny777 created this revision. evgeny777 added reviewers: clayborg, paulherman. evgeny777 added subscribers: lldb-commits, KLapshin. Current revision contains bug, related to evaluation of global variables. Imagine you have the following code ``` int _g = 1; int func(void) { int _g = 2;

Re: [Lldb-commits] [PATCH] D13350: [lldb] Fix evaluation of global variables

labath added a subscriber: labath. labath added a comment. Could you please put the examples you cite above into the test suite? http://reviews.llvm.org/D13350 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

Re: [Lldb-commits] [lldb] r249020 - [LLDB][MIPS] Fix gp register value for o32 applications on 64-bit target

Would be great if you had a test for this (if it simply fixes an existing broken test, then you should mention that in the patch summary so you don't get these emails from me in the future :)) On Thu, Oct 1, 2015 at 8:10 AM Pavel Labath via lldb-commits < lldb-commits@lists.llvm.org> wrote: > On

Re: [Lldb-commits] [PATCH] D13350: [lldb] Fix evaluation of qualified global variables

zturner added a subscriber: zturner. zturner added a comment. In http://reviews.llvm.org/D13350#257676, @labath wrote: > Could you please put the examples you cite above into the test suite? Agreed, please make a test for this. http://reviews.llvm.org/D13350 ___

[Lldb-commits] [lldb] r249027 - Made Target hold a map of languages to TypeSystems, and added some accessors.

Author: spyffe Date: Thu Oct 1 11:28:02 2015 New Revision: 249027 URL: http://llvm.org/viewvc/llvm-project?rev=249027&view=rev Log: Made Target hold a map of languages to TypeSystems, and added some accessors. Also added some target-level search functions so that persistent variables and symbols

Re: [Lldb-commits] [lldb] r249013 - Fix breakpoint opcode calculation on Linux

Seems like it should be possible to write a test for this. On Thu, Oct 1, 2015 at 6:59 AM Tamas Berghammer via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: tberghammer > Date: Thu Oct 1 08:57:57 2015 > New Revision: 249013 > > URL: http://llvm.org/viewvc/llvm-project?rev=249013&v

Re: [Lldb-commits] [PATCH] D13350: [lldb] Fix evaluation of qualified global variables

sivachandra added a subscriber: sivachandra. sivachandra added a comment. Also, this patch has changes in clang. There should be a clang reviewer I think [unless I am unaware something here.] http://reviews.llvm.org/D13350 ___ lldb-commits mailing

Re: [Lldb-commits] [PATCH] D13350: [lldb] Fix evaluation of qualified global variables

zturner added a comment. Good point. The two patches should actually be separate, and you will need a separate set of tests for the clang patch. http://reviews.llvm.org/D13350 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.

Re: [Lldb-commits] [PATCH] D13350: [lldb] Fix evaluation of qualified global variables

evgeny777 added a comment. Thanks for your comments. I will certainly add the test cases to lldb. I was just curious if this is correct way of fixing the issue. Besides test case what else has to be done? Separate review for changes in clang linked to this review? http://reviews.llvm.org/D1335

[Lldb-commits] [lldb] r249039 - Removed a mutex guard that I accidentally pasted in from other code.

Author: spyffe Date: Thu Oct 1 12:48:25 2015 New Revision: 249039 URL: http://llvm.org/viewvc/llvm-project?rev=249039&view=rev Log: Removed a mutex guard that I accidentally pasted in from other code. It was causing deadlocks when stepping out. Modified: lldb/trunk/source/Target/Target.cpp

Re: [Lldb-commits] [PATCH] D13323: Use %HOME%/.lldb/module_cache as a default module cache directory

ovyalov closed this revision. ovyalov added a comment. Users: ovyalov (Author) http://reviews.llvm.org/rL249040 http://reviews.llvm.org/D13323 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [Lldb-commits] [PATCH] D13350: [lldb] Fix evaluation of qualified global variables

sivachandra added a comment. I suppose you should first post a separate self contained clang patch to the clang list. After landing it in clang, you should post an LLDB specific patch here. About its correctness, I cannot comment on the clang changes. Commenting on the LLDB changes are probabl

[Lldb-commits] [lldb] r249040 - Use %HOME%/.lldb/module_cache as a default module cache directory.

Author: ovyalov Date: Thu Oct 1 12:48:57 2015 New Revision: 249040 URL: http://llvm.org/viewvc/llvm-project?rev=249040&view=rev Log: Use %HOME%/.lldb/module_cache as a default module cache directory. http://reviews.llvm.org/D13323 Modified: lldb/trunk/source/Target/Platform.cpp Modified:

Re: [Lldb-commits] [lldb] r248934 - Now persistent expression data no longer lives with the Target, but rather with

Shouldn't Target::GetPersistentVariable take a language parameter instead of assuming clang? On Wed, Sep 30, 2015 at 12:59 PM Sean Callanan via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: spyffe > Date: Wed Sep 30 14:57:57 2015 > New Revision: 248934 > > URL: http://llvm.org/view

Re: [Lldb-commits] [lldb] r248934 - Now persistent expression data no longer lives with the Target, but rather with

Oh, now I see the search in 249027. But how does this work with multiple type systems? Target no longer manages persistent variable names so won't each type system generate conflicting names? e.g. (lldb) expr -l c -- 1 $1 = 1 (lldb) expr -l go -- 2 $1 = 2 (lldb) expr -l go -- $1 Which $1 do you ge

[Lldb-commits] [lldb] r249047 - Add a 'type lookup' command. This command is meant to look up type information by name in a language-specific way.

Author: enrico Date: Thu Oct 1 13:16:18 2015 New Revision: 249047 URL: http://llvm.org/viewvc/llvm-project?rev=249047&view=rev Log: Add a 'type lookup' command. This command is meant to look up type information by name in a language-specific way. Currently, it only supports Objective-C - C++ ty

Re: [Lldb-commits] [lldb] r248934 - Now persistent expression data no longer lives with the Target, but rather with

The way I understand this from talking with Sean about it is that the persistent variables for each type system will need to generate non-conflicting names In your example, (lldb) expr -l c — 1 $1 = 1 (lldb) expr -l go — 2 $G1 = 2 (lldb) expr -l go — $1 Identifier ‘$1’ not recognized (or whatev

Re: [Lldb-commits] [PATCH] D12968: Fix for lldb-mi crash in Listener code if -exec-abort MI command was invoked without getting process stopped

KLapshin added a comment. @labath, Regarding how to reproduce - this problem looks remote target specific only - in my case gdb-remote modules involved. Repository: rL LLVM http://reviews.llvm.org/D12968 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [lldb] r249055 - Fix Android build after r249047.

Author: ovyalov Date: Thu Oct 1 14:08:00 2015 New Revision: 249055 URL: http://llvm.org/viewvc/llvm-project?rev=249055&view=rev Log: Fix Android build after r249047. Modified: lldb/trunk/source/Plugins/Language/ObjC/ObjCLanguage.cpp Modified: lldb/trunk/source/Plugins/Language/ObjC/ObjCLan

Re: [Lldb-commits] [lldb] r249047 - Add a 'type lookup' command. This command is meant to look up type information by name in a language-specific way.

Hi Enrico, Could you add some tests for this? python API tests and appropriate methods added to SBTarget would be ideal. On Thu, Oct 1, 2015 at 11:17 AM Enrico Granata via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: enrico > Date: Thu Oct 1 13:16:18 2015 > New Revision: 249047

Re: [Lldb-commits] [lldb] r248985 - Fixing a subtle issue on Mac OS X systems with dSYMs (possibly

Thanks Pavel. I'll read through the code and try to figure out what's happening here. J > On Oct 1, 2015, at 3:15 AM, Pavel Labath wrote: > > From one of the failing tests: > === > runCmd: expr release_child_flag = 1 > output: (volatile int) $0 = 1 > > > Expecting sub string

Re: [Lldb-commits] [lldb] r249047 - Add a 'type lookup' command. This command is meant to look up type information by name in a language-specific way.

> On Oct 1, 2015, at 12:49 PM, Zachary Turner wrote: > > Hi Enrico, > > Could you add some tests for this? Sure. I am still churning through a thing or two before declaring victory, but I can add tests as I make progress > python API tests and appropriate methods added to SBTarget There cu

[Lldb-commits] [PATCH] D13362: Enhance test runner timeout logic to detect successful completion of spawned process when stdout/stderr are shared to still-existing child processes

tfiala created this revision. tfiala added reviewers: labath, zturner. tfiala added a subscriber: lldb-commits. This makes one of the internal process_control tests go green. It covers the case where spawned process P1 itself spawns a child process C1, shared stdout/stderr file handles with C1,

Re: [Lldb-commits] [lldb] r249047 - Add a 'type lookup' command. This command is meant to look up type information by name in a language-specific way.

I see there's SBType, does this represent something different? I was thinking you could make a method like SBType * SBTarget::LookupType(const char* type_name, eLanguage lang); Even if it didn't support every possible usage of the "type lookup" command, it would be a start. At one point on the

Re: [Lldb-commits] [PATCH] D13268: Simple readline functionality for interactive python on linux.

ribrdb updated this revision to Diff 36295. ribrdb marked an inline comment as done. ribrdb added a comment. Updated comments. Repository: rL LLVM http://reviews.llvm.org/D13268 Files: scripts/Python/modules/readline/CMakeLists.txt scripts/Python/modules/readline/readline.cpp Index: scr

[Lldb-commits] [lldb] r249072 - [lldb-mi] Add support for StopAtEntry in MI via "-exec-run --start".

Author: dperchik Date: Thu Oct 1 16:15:43 2015 New Revision: 249072 URL: http://llvm.org/viewvc/llvm-project?rev=249072&view=rev Log: [lldb-mi] Add support for StopAtEntry in MI via "-exec-run --start". This patch adds a --start option to the lldb-mi -exec-run command for getting process stopped

Re: [Lldb-commits] [PATCH] D12977: LLDB MI addition for getting process stopped at first instruction right after launch via -exec-run

This revision was automatically updated to reflect the committed changes. Closed by commit rL249072: [lldb-mi] Add support for StopAtEntry in MI via "-exec-run --start". (authored by dperchik). Changed prior to commit: http://reviews.llvm.org/D12977?vs=36128&id=36298#toc Repository: rL LLVM

Re: [Lldb-commits] [lldb] r249047 - Add a 'type lookup' command. This command is meant to look up type information by name in a language-specific way.

> On Oct 1, 2015, at 1:15 PM, Zachary Turner wrote: > > I see there's SBType, does this represent something different? Yes, it represents types. Type lookup does not necessarily always deal with types. For instance, imagine a language that has function declarations such that function foo(int x

Re: [Lldb-commits] [PATCH] D13334: Preliminary NetBSD support

On Thu, Oct 01, 2015 at 10:41:46AM +, Pavel Labath via lldb-commits wrote: > This platform code looks like it was copy-pasted from PlatformFreeBSD. > Do you anticipate making significant changes here? > > If not, it might be a good idea to share this code with FreeBSD in some > way (in fact th

Re: [Lldb-commits] [PATCH] D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range

On Sat, Sep 26, 2015 at 08:13:48AM +, Jason Molenda wrote: > NB: Greg is out for the next nine days, Enrico for the next five days. Is Enrico back now? OK to commit this if he accepts? > http://reviews.llvm.org/D13058 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range

granata.enrico requested changes to this revision. granata.enrico added a comment. This revision now requires changes to proceed. Sorry, I didn't realize you were still waiting on me to land this patch. I have a few extra comments before this is ready to land. Comment at: inclu

Re: [Lldb-commits] [lldb] r249047 - Add a 'type lookup' command. This command is meant to look up type information by name in a language-specific way.

I agree that refactor-as-you-touch-things is definitely the way to go, but if we're going to end up having a test/commands for all the command line tests, then we might as well start it sooner rather than later. On the other hand, if we dont' all agree that that's the best path forward, then I gue

Re: [Lldb-commits] [PATCH] D13350: [lldb] Fix evaluation of qualified global variables

dawn added a subscriber: dawn. dawn added a comment. This patch fixes bugs: - https://llvm.org/bugs/show_bug.cgi?id=24994 (::val gets NS::val inside NS since r247746) - https://llvm.org/bugs/show_bug.cgi?id=24995 (shadowed var gets ambiguity since r247836) See inline comments. Mostly had conc

Re: [Lldb-commits] [PATCH] D13350: [lldb] Fix evaluation of qualified global variables

dawn added a comment. Was this patch run on the entire set of lldb tests? Were there any regressions? http://reviews.llvm.org/D13350 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

Re: [Lldb-commits] [PATCH] D13268: Simple readline functionality for interactive python on linux.

tfiala added a comment. Ooo neat, I'll have a look! Might take me 24 hours. Repository: rL LLVM http://reviews.llvm.org/D13268 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13268: Simple readline functionality for interactive python on linux.

tfiala added a comment. It might need to be conditionalized for libedit support if the CMakeLists doesn't already cover that. I think we had it set up to allow conditional lldb building without libedit support. Repository: rL LLVM http://reviews.llvm.org/D13268 _

Re: [Lldb-commits] [PATCH] D13362: Enhance test runner timeout logic to detect successful completion of spawned process when stdout/stderr are shared to still-existing child processes

tfiala added a comment. Hmm, I'm getting a few more tests to time out now with this change: TIMEOUT: LLDB (suite) :: TestCallStopAndContinue.py (Linux rad 3.13.0-57-generic #95-Ubuntu SMP Fri Jun 19 09:28:15 UTC 2015 x86_64 x86_64) TIMEOUT: LLDB (suite) :: TestCommandScript.py (Linux rad 3.13.0-

[Lldb-commits] [lldb] r249095 - Eliminated redundant "constructors" for ClangExpressionVariable.

Author: spyffe Date: Thu Oct 1 18:07:06 2015 New Revision: 249095 URL: http://llvm.org/viewvc/llvm-project?rev=249095&view=rev Log: Eliminated redundant "constructors" for ClangExpressionVariable.

Re: [Lldb-commits] [PATCH] D13334: Preliminary NetBSD support

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 01.10.2015 23:20, Joerg Sonnenberger via lldb-commits wrote: > On Thu, Oct 01, 2015 at 10:41:46AM +, Pavel Labath via > lldb-commits wrote: >> This platform code looks like it was copy-pasted from >> PlatformFreeBSD. Do you anticipate making s

Re: [Lldb-commits] [PATCH] D13362: Enhance test runner timeout logic to detect successful completion of spawned process when stdout/stderr are shared to still-existing child processes

tfiala added a comment. On OS X the only timeout I'm getting is: TIMEOUT: LLDB (suite) :: TestValueObjectRecursion.py (Darwin tfiala-mbp-01.local 15.0.0 Darwin Kernel Version 15.0.0: Sat Sep 19 15:53:45 PDT 2015; root:xnu-3247.10.11~1/DEVELOPMENT_X86_64 x86_64 i386) http://reviews.llvm.org/D1

Re: [Lldb-commits] [PATCH] D13362: Enhance test runner timeout logic to detect successful completion of spawned process when stdout/stderr are shared to still-existing child processes

tfiala added a comment. The OS X one seems to be related to load (not terribly surprising). I'm seeing timeouts as I crank up the --threads. But I don't think that's the whole story. On the Linux side, I've been cranking down the threads and I'm still seeing it. In light of the more fundam

[Lldb-commits] [lldb] r249117 - Teach 'type lookup' to pull types from clang modules; also add a test case

Author: enrico Date: Thu Oct 1 20:23:11 2015 New Revision: 249117 URL: http://llvm.org/viewvc/llvm-project?rev=249117&view=rev Log: Teach 'type lookup' to pull types from clang modules; also add a test case Added: lldb/trunk/test/functionalities/type_lookup/ lldb/trunk/test/functionalit