Re: [Lldb-commits] [PATCH] D13578: Allow generic arm ArchSpec to merge with specific arm ArchSpec; allow Cortex M0-7's to always force thumb mode

rengolin added a comment. Hi Jason, This has nothing to do with your patch per se, but we have accurate target descriptions in LLVM, and the parser for all the triples and extra options is now publicly available, so I was wondering if (probably after this go in), you could have a look at

Re: [Lldb-commits] [PATCH] D13581: Remove long-forgotten plugin virtuals.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D13581 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13334: Preliminary NetBSD support

tfiala added a comment. > Unless someone else (@emaste?) objects, I think this looks fine to land and > iterate on trunk as discussed in the mailing list thread. Just one minor > comment based on cleanups that are on-going on trunk now. Sounds reasonable. Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D13578: Allow generic arm ArchSpec to merge with specific arm ArchSpec; allow Cortex M0-7's to always force thumb mode

jasonmolenda added a comment. Hi Renato & Tamas, thanks for the feedback. I'm trying to rewrite IsAlwaysThumbInstructions() to use the information that llvm already has, as per Renato's suggestion. The MCSubtargetInfo has a getFeatureBits() method which can indicate ARM::FeatureNoARM. I'm

Re: [Lldb-commits] [PATCH] D13574: [LLDB] Fix Clang-tidy misc-use-override warnings in some files in include/lldb/Core; other minor fixes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL249928: [LLDB] Fix Clang-tidy misc-use-override warnings in some files in… (authored by brucem). Changed prior to commit: http://reviews.llvm.org/D13574?vs=36894=37014#toc Repository: rL LLVM

[Lldb-commits] [lldb] r249928 - [LLDB] Fix Clang-tidy misc-use-override warnings in some files in include/lldb/Core; other minor fixes.

Author: brucem Date: Fri Oct 9 20:11:45 2015 New Revision: 249928 URL: http://llvm.org/viewvc/llvm-project?rev=249928=rev Log: [LLDB] Fix Clang-tidy misc-use-override warnings in some files in include/lldb/Core; other minor fixes. Summary: This is second attempt based on current code. I

[Lldb-commits] [lldb] r249930 - Fixup log enable --stack so it works on Linux.

Author: tfiala Date: Fri Oct 9 20:26:47 2015 New Revision: 249930 URL: http://llvm.org/viewvc/llvm-project?rev=249930=rev Log: Fixup log enable --stack so it works on Linux. The underlying raw_string_stream buffer was not being flushed after asking llvm to collect the backtrace. This worked

Re: [Lldb-commits] [PATCH] D13617: Fix ref-counting of Python objects

zturner added inline comments. Comment at: source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp:337 @@ -336,3 +346,3 @@ { -PythonObject::Reset(PyLong_FromLongLong(value)); } Just to provide one example, here is an instance of a fixed memory leak.

[Lldb-commits] [lldb] r249924 - Fix namespace closing comment.

Author: brucem Date: Fri Oct 9 19:45:34 2015 New Revision: 249924 URL: http://llvm.org/viewvc/llvm-project?rev=249924=rev Log: Fix namespace closing comment. This is closing namespace lldb_utility, not lldb. Modified: lldb/trunk/include/lldb/Utility/PseudoTerminal.h Modified:

[Lldb-commits] [lldb] r249809 - Addressing warning due to rL249651

Author: mohit.bhakkad Date: Fri Oct 9 01:34:52 2015 New Revision: 249809 URL: http://llvm.org/viewvc/llvm-project?rev=249809=rev Log: Addressing warning due to rL249651 Modified: lldb/trunk/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.cpp Modified:

Re: [Lldb-commits] [PATCH] D13577: Fix build with python disabled after r249597

evgeny777 accepted this revision. evgeny777 added a comment. This revision is now accepted and ready to land. Lgtm Repository: rL LLVM http://reviews.llvm.org/D13577 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13334: Preliminary NetBSD support

brucem added a subscriber: brucem. brucem added a comment. Unless someone else (@emaste?) objects, I think this looks fine to land and iterate on trunk as discussed in the mailing list thread. Just one minor comment based on cleanups that are on-going on trunk now. Comment

[Lldb-commits] [PATCH] D13581: Remove long-forgotten plugin virtuals.

brucem created this revision. brucem added reviewers: clayborg, labath, emaste. brucem added a subscriber: lldb-commits. Herald added a subscriber: emaste. EnablePluginLogging, GetPluginCommandHelp and ExecutePluginCommand aren't implemented or used anywhere, so remove them from the Hexagon and

Re: [Lldb-commits] [PATCH] D13555: Cap test threads on Windows to avoid open file limit

amccarth updated this revision to Diff 36993. amccarth added a comment. Using the multiprocessing-pool mode seems more reliable than capping num_threads. I'm doing it only when the number of threads is high because of the loss of Ctrl+C support. http://reviews.llvm.org/D13555 Files:

Re: [Lldb-commits] [PATCH] D13202: [LLDB] Fix display of value of a vector variables in watchpoint operations

mohit.bhakkad added a comment. @loladiro @zturner Thanks for pointing this out, fixed it in http://reviews.llvm.org/rL249897 Repository: rL LLVM http://reviews.llvm.org/D13202 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13608: [TestValueOfVectorVariable] Reduce the vector size to 4.

sivachandra added a comment. I am going to push this to get the bots back to green. http://reviews.llvm.org/D13608 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r249897 - Correction in rL249838: Moving test to appropriate directory

Author: mohit.bhakkad Date: Fri Oct 9 15:36:54 2015 New Revision: 249897 URL: http://llvm.org/viewvc/llvm-project?rev=249897=rev Log: Correction in rL249838: Moving test to appropriate directory Added: lldb/trunk/test/functionalities/watchpoint/watchpoint_on_vectors/

[Lldb-commits] [PATCH] D13602: [LLDB] Fix Clang-tidy misc-use-override warnings in some files in include/lldb/Interpreter and Host; other minor fixes.

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: brucem, labath, clayborg. Eugene.Zelenko added a subscriber: lldb-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. This is second attempt based on current code. I checked this patch on my own build on

[Lldb-commits] [lldb] r249823 - Rename one of the TestGoASTContexts

Author: labath Date: Fri Oct 9 06:15:50 2015 New Revision: 249823 URL: http://llvm.org/viewvc/llvm-project?rev=249823=rev Log: Rename one of the TestGoASTContexts Added: lldb/trunk/test/lang/go/runtime/TestGoLanguageRuntime - copied, changed from r249819,

[Lldb-commits] [lldb] r249825 - Fix the way dwo tests are skipped on darwin

Author: tberghammer Date: Fri Oct 9 07:06:07 2015 New Revision: 249825 URL: http://llvm.org/viewvc/llvm-project?rev=249825=rev Log: Fix the way dwo tests are skipped on darwin We want to skip these tests when the target platform is darwin, not when the host because they have to be enabled in

[Lldb-commits] [lldb] r249826 - Fix the windows build after r249747

Author: tberghammer Date: Fri Oct 9 07:06:10 2015 New Revision: 249826 URL: http://llvm.org/viewvc/llvm-project?rev=249826=rev Log: Fix the windows build after r249747 Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp URL:

[Lldb-commits] [PATCH] D13588: dotest.py: Fail if we detect multiple tests with the same name

labath created this revision. labath added reviewers: tberghammer, zturner. labath added subscribers: lldb-commits, iancottrell. Log files produced by dotest have names derived from the test name, and this produces errors in case we have multiple tests with the same name. Additionally, it's good

[Lldb-commits] [lldb] r249827 - Fix a crash, an UB and add some assert to dwo symbol file handling

Author: tberghammer Date: Fri Oct 9 07:43:08 2015 New Revision: 249827 URL: http://llvm.org/viewvc/llvm-project?rev=249827=rev Log: Fix a crash, an UB and add some assert to dwo symbol file handling Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp

Re: [Lldb-commits] [PATCH] D13588: dotest.py: Fail if we detect multiple tests with the same name

tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D13588 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13588: dotest.py: Fail if we detect multiple tests with the same name

This revision was automatically updated to reflect the committed changes. Closed by commit rL249828: dotest.py: Fail if we detect multiple tests with the same name (authored by labath). Changed prior to commit: http://reviews.llvm.org/D13588?vs=36939=36941#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D13574: [LLDB] Fix Clang-tidy misc-use-override warnings in some files in include/lldb/Core; other minor fixes.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. We are pretty inconsistent with the space after a function name and before the ( so I don't mind. Repository: rL LLVM http://reviews.llvm.org/D13574

Re: [Lldb-commits] [PATCH] D13577: Fix build with python disabled after r249597

clayborg accepted this revision. clayborg added a comment. Wait for the OK from Enrico as well to verify this is OK. Repository: rL LLVM http://reviews.llvm.org/D13577 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13580: [debugserver, cmake] Add DEPENDS to custom commands.

This revision was automatically updated to reflect the committed changes. Closed by commit rL249860: [debugserver,cmake] Add DEPENDS to custom commands. (authored by brucem). Changed prior to commit: http://reviews.llvm.org/D13580?vs=36925=36965#toc Repository: rL LLVM

[Lldb-commits] [lldb] r249864 - Don't blindly use C for eLanguageTypeUnknown when getting a scratch TypeSystem.

Author: spyffe Date: Fri Oct 9 13:01:10 2015 New Revision: 249864 URL: http://llvm.org/viewvc/llvm-project?rev=249864=rev Log: Don't blindly use C for eLanguageTypeUnknown when getting a scratch TypeSystem. Instead check what languages are supported for expressions; use C if available, but

Re: [Lldb-commits] [PATCH] D13574: [LLDB] Fix Clang-tidy misc-use-override warnings in some files in include/lldb/Core; other minor fixes.

amccarth added a subscriber: amccarth. amccarth added a comment. There was an lldb-dev thread from February 9, where it seemed to be agreed that lldb code should be more like llvm code, in particular with the spaces between the function names and the opening parens. I've been omitting the spaces

Re: [Lldb-commits] [PATCH] D13574: [LLDB] Fix Clang-tidy misc-use-override warnings in some files in include/lldb/Core; other minor fixes.

There was an lldb-dev thread from February 9, where it seemed to be agreed that lldb code should be more like llvm code, in particular with the spaces between the function names and the opening parens. I've been omitting the spaces in new code since then. On Fri, Oct 9, 2015 at 10:14 AM, Greg

Re: [Lldb-commits] [PATCH] D13202: [LLDB] Fix display of value of a vector variables in watchpoint operations

zturner added a comment. Strange, it was fine in the review, but wrong in the commit. Yea, that needs to be fixed. Repository: rL LLVM http://reviews.llvm.org/D13202 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r249886 - Port native Python-API to 3.x

Author: zturner Date: Fri Oct 9 14:45:41 2015 New Revision: 249886 URL: http://llvm.org/viewvc/llvm-project?rev=249886=rev Log: Port native Python-API to 3.x With this change, liblldb is 95% of the way towards being able to work under both Python 2.x and Python 3.x. This should introduce no

[Lldb-commits] [lldb] r249885 - Have CMake translate LLDB_PYTHON_HOME to forward slashes.

Author: zturner Date: Fri Oct 9 14:45:26 2015 New Revision: 249885 URL: http://llvm.org/viewvc/llvm-project?rev=249885=rev Log: Have CMake translate LLDB_PYTHON_HOME to forward slashes. Using backslashes causes the compiler to interpret them as escape sequences. Modified:

Re: [Lldb-commits] [PATCH] D13202: [LLDB] Fix display of value of a vector variables in watchpoint operations

Strange, it was fine in the review, but wrong in the commit. Yea, that needs to be fixed. On Fri, Oct 9, 2015 at 11:09 AM Keno Fischer wrote: > loladiro added a subscriber: loladiro. > loladiro added a comment. > > Shouldn't that test have been inside the test/

[Lldb-commits] [lldb] r249837 - [LLDB][MIPS] fix watchpoint searched on client side for same masked variables

Author: mohit.bhakkad Date: Fri Oct 9 10:05:45 2015 New Revision: 249837 URL: http://llvm.org/viewvc/llvm-project?rev=249837=rev Log: [LLDB][MIPS] fix watchpoint searched on client side for same masked variables Reviewers: clayborg, jingham. Subscribers: jaydeep, bhushan, sagar, nitesh.jain,

[Lldb-commits] [lldb] r249838 - [LLDB] Fix display of value of a vector variables in watchpoint operations

Author: mohit.bhakkad Date: Fri Oct 9 10:13:20 2015 New Revision: 249838 URL: http://llvm.org/viewvc/llvm-project?rev=249838=rev Log: [LLDB] Fix display of value of a vector variables in watchpoint operations Reviewers: clayborg, zturner. Subscribers: jaydeep, bhushan, sagar, nitesh.jain,

Re: [Lldb-commits] [PATCH] D13202: [LLDB] Fix display of value of a vector variables in watchpoint operations

This revision was automatically updated to reflect the committed changes. Closed by commit rL249838: [LLDB] Fix display of value of a vector variables in watchpoint operations (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D13202?vs=36837=36952#toc Repository:

[Lldb-commits] [lldb] r249840 - Remove long-forgotten plugin virtuals.

Author: brucem Date: Fri Oct 9 10:37:10 2015 New Revision: 249840 URL: http://llvm.org/viewvc/llvm-project?rev=249840=rev Log: Remove long-forgotten plugin virtuals. Summary: EnablePluginLogging, GetPluginCommandHelp and ExecutePluginCommand aren't implemented or used anywhere, so remove them