mohit.bhakkad updated this revision to Diff 38785.
mohit.bhakkad added a comment.
Changes in this revision:
- Fixed GetUserRegisterCount () to get count registers which are actually
present.
This will make llgs send E45 when reg_index is of some unavailable reg.
Repository:
rL LLVM
http://
Wow. That's a weird problem. Thanks for finding it!
Would it work if we move the definition of the `lldbtest_config` class into
lldbsuite/test/__init__.py? This way the configuration should be part of
the global package state of the lldbsuite.test package, which all the tests
are already member
On Thu, Oct 29, 2015 at 7:57 PM Todd Fiala via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: tfiala
> Date: Thu Oct 29 21:54:52 2015
> New Revision: 251681
>
> URL: http://llvm.org/viewvc/llvm-project?rev=251681&view=rev
> Log:
> Added real editline tests.
>
> These are two simple t
Author: labath
Date: Thu Oct 29 22:52:27 2015
New Revision: 251684
URL: http://llvm.org/viewvc/llvm-project?rev=251684&view=rev
Log:
Make new dotest.py executable
Modified:
lldb/trunk/packages/Python/lldbsuite/test/dotest.py (contents, props
changed)
Modified: lldb/trunk/packages/Python/l
Author: tfiala
Date: Thu Oct 29 21:54:52 2015
New Revision: 251681
URL: http://llvm.org/viewvc/llvm-project?rev=251681&view=rev
Log:
Added real editline tests.
These are two simple tests that make sure single line and
multiline content are processed and received by Editline.cpp.
Fancier tests to
krytarowski added inline comments.
Comment at: tools/lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:72
@@ -71,1 +71,3 @@
+// Missing defines due to bug:
https://sourceware.org/bugzilla/show_bug.cgi?id=4125
+
brucem wrote:
> This bug was fixed in 2007,
Author: enrico
Date: Thu Oct 29 20:09:54 2015
New Revision: 251678
URL: http://llvm.org/viewvc/llvm-project?rev=251678&view=rev
Log:
Some test cases that need the lldbExec path were failing because lldbExec was
turning out to be None even though it was being validly set by dotest.py
It turns out
krytarowski added inline comments.
Comment at: tools/lldb/source/Host/posix/PipePosix.cpp:43
@@ -40,3 +42,3 @@
// TODO: Add more platforms that support pipe2.
-#if defined(__linux__) || (defined(__FreeBSD__) && __FreeBSD__ >= 10) ||
defined(__NetBSD__)
+#if (defined(__linux__) &
brucem added a subscriber: brucem.
brucem requested changes to this revision.
brucem added a reviewer: brucem.
Comment at: tools/lldb/source/Host/linux/HostThreadLinux.cpp:33
@@ -32,3 +32,3 @@
{
-#if (defined(__GLIBC__) && defined(_GNU_SOURCE)) || defined(__ANDROID__)
+#if (defin
krytarowski requested changes to this revision.
krytarowski added a reviewer: krytarowski.
Comment at: tools/lldb/source/Host/posix/PipePosix.cpp:32
@@ -31,1 +31,3 @@
+#include
+
Is this file just for Linux?
Comment at: tools/lldb/source/Host/
krytarowski added a subscriber: krytarowski.
Comment at: tools/lldb/source/Host/common/File.cpp:301
@@ -299,1 +300,3 @@
+
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,23)
if (options & eOpenOptionCloseOnExec)
labath wrote:
> This needs to evaluate to tru
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
Thanks for the patch. Looks good, but we need to make sure things continue to
work on non-linux systems...
Comment at: tools/lldb/source/Host/common/File.cpp:301
@@
Author: eugenezelenko
Date: Thu Oct 29 19:04:20 2015
New Revision: 251673
URL: http://llvm.org/viewvc/llvm-project?rev=251673&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr warnings in include/lldb/Symbol; other
minor fixes.
Modified:
lldb/trunk/include/lldb/Symbol/Block.h
lldb/trunk
Author: enrico
Date: Thu Oct 29 18:53:34 2015
New Revision: 251670
URL: http://llvm.org/viewvc/llvm-project?rev=251670&view=rev
Log:
Remove two #if0ed regions of code that we were using for an experiment but
don't really want
Modified:
lldb/trunk/source/Plugins/Language/CPlusPlus/CPlusPlusLa
Author: enrico
Date: Thu Oct 29 18:40:24 2015
New Revision: 251668
URL: http://llvm.org/viewvc/llvm-project?rev=251668&view=rev
Log:
Add a --offset option to memory read that allows one to specify, given a type,
how many sizeof(type) bytes to speak before starting to read memory
Modified:
l
Author: enrico
Date: Thu Oct 29 17:29:06 2015
New Revision: 251663
URL: http://llvm.org/viewvc/llvm-project?rev=251663&view=rev
Log:
Do not accept nullptr descriptions as valid summaries to be printed
Modified:
lldb/trunk/source/Plugins/Language/ObjC/Cocoa.cpp
Modified: lldb/trunk/source/Plu
Author: enrico
Date: Thu Oct 29 17:18:05 2015
New Revision: 251660
URL: http://llvm.org/viewvc/llvm-project?rev=251660&view=rev
Log:
Add a --language (-l) option to the formatter delete commands in order to allow
removing formatters from language categories
This is slightly harder to test becaus
Author: jingham
Date: Thu Oct 29 16:54:50 2015
New Revision: 251657
URL: http://llvm.org/viewvc/llvm-project?rev=251657&view=rev
Log:
Give the test class it's own name (it was reusing the name from
TestCompletions.py).
Modified:
lldb/trunk/packages/Python/lldbsuite/test/terminal/TestSTTYBefo
granata.enrico accepted this revision.
granata.enrico added a comment.
This revision is now accepted and ready to land.
I think it's OK to land this, yes
I would still like to think about ways that we can avoid using hardcoded
formatters here, but it seems non-trivial and I don't know enough abo
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Yes, that looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D13073
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://li
Author: eugenezelenko
Date: Thu Oct 29 15:33:47 2015
New Revision: 251648
URL: http://llvm.org/viewvc/llvm-project?rev=251648&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr warnings in remaining files in
include/lldb/Target; other minor fixes.
Modified:
lldb/trunk/include/lldb/Target/Exe
ribrdb added a comment.
Is this ready to submit?
http://reviews.llvm.org/D13878
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: eugenezelenko
Date: Thu Oct 29 15:12:40 2015
New Revision: 251647
URL: http://llvm.org/viewvc/llvm-project?rev=251647&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr warnings in some files in
include/lldb/Target; other minor fixes.
Modified:
lldb/trunk/include/lldb/Target/Process.
ribrdb added a comment.
Is this ready to submit?
Comment at: source/Expression/LLVMUserExpression.cpp:43-60
@@ +42,20 @@
+
+LLVMUserExpression::LLVMUserExpression(ExecutionContextScope &exe_scope, const
char *expr, const char *expr_prefix,
+
Author: enrico
Date: Thu Oct 29 13:58:13 2015
New Revision: 251642
URL: http://llvm.org/viewvc/llvm-project?rev=251642&view=rev
Log:
Add an 'internal' kind of summary to support one-off subclasses of
TypeSummaryImpl
Modified:
lldb/trunk/include/lldb/DataFormatters/TypeSummary.h
lldb/trun
> On Oct 29, 2015, at 3:34 AM, Mohit Bhakkad wrote:
>
> mohit.bhakkad added a comment.
>
> In http://reviews.llvm.org/D13296#265608, @jingham wrote:
>
>> This change alters the timing for the handling of ignore counts for
>> watchpoints. The original implementation (and the way ignore counts
On 28 October 2015 at 16:33, Galina Kistanova via llvm-commits
wrote:
> E-mail notification has been changed in the buildmaster. Now it should not
> count interrupted builds to figure out if notification should be send.
Thanks Galina, that'll reduce the noise considerably!
cheers,
--renato
_
Author: abidh
Date: Thu Oct 29 11:30:47 2015
New Revision: 251636
URL: http://llvm.org/viewvc/llvm-project?rev=251636&view=rev
Log:
Better handle the arguments common to all MI commands.
Summary:
I observed that eclipse was passing --thread-group for many other commands
then we are currently hand
ki.stfu accepted this revision.
ki.stfu added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: tools/lldb-mi/MICmdBase.h:68
@@ -67,2 +67,3 @@
virtual MIuint GetGUID();
+void AddCommonArgs();
abidh wrote:
> Changed name. But
ovyalov added a comment.
In http://reviews.llvm.org/D14118#277675, @ravitheja wrote:
> Hi,
>
> This link for the traces needs a password, could u maybe provide me the
> login details or upload these somewhere else ? Also could u provide me the
> value of the AuxVectors during this test ?
abidh marked an inline comment as done.
Comment at: tools/lldb-mi/MICmdBase.h:68
@@ -67,2 +67,3 @@
virtual MIuint GetGUID();
+void AddCommonArgs();
Changed name. But it cant be protected as it is called from the outside.
Comment at: to
abidh updated this revision to Diff 38741.
abidh added a comment.
Handled review comments.
http://reviews.llvm.org/D14177
Files:
packages/Python/lldbsuite/test/tools/lldb-mi/stack/TestMiStack.py
tools/lldb-mi/MICmdBase.cpp
tools/lldb-mi/MICmdBase.h
tools/lldb-mi/MICmdCmdBreak.cpp
tool
ki.stfu added inline comments.
Comment at: tools/lldb-mi/MICmdBase.h:68
@@ -67,2 +67,3 @@
virtual MIuint GetGUID();
+void ParseCommonArgs();
How about renaming it to AddCommonArgs and making it protected?
Comment at: tools/lldb-mi/MICm
abidh created this revision.
abidh added a reviewer: ki.stfu.
abidh added a subscriber: lldb-commits.
I observed that eclipse was passing --thread-group for many other commands
then we are currently handling. Looking at the MI documentation, the
following link states that each MI command accept th
Author: labath
Date: Thu Oct 29 09:14:24 2015
New Revision: 251628
URL: http://llvm.org/viewvc/llvm-project?rev=251628&view=rev
Log:
Fixup lldb-argdumper cmake build
forgot to rename in one spot.
Modified:
lldb/trunk/CMakeLists.txt
Modified: lldb/trunk/CMakeLists.txt
URL:
http://llvm.org/v
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
OK looks good then.
http://reviews.llvm.org/D14162
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
Author: labath
Date: Thu Oct 29 08:44:09 2015
New Revision: 251626
URL: http://llvm.org/viewvc/llvm-project?rev=251626&view=rev
Log:
Fix flakyness in TestChangeProcessGroup
The test was verifying that the pid of the child is not equal to its process
group by searching for text substrings. This fa
mohit.bhakkad added a comment.
In http://reviews.llvm.org/D13296#265608, @jingham wrote:
> This change alters the timing for the handling of ignore counts for
> watchpoints. The original implementation (and the way ignore counts work for
> breakpoints) is that the breakpoint's ignore count get
ravitheja added a comment.
Hi,
This link for the traces needs a password, could u maybe provide me the
login details or upload these somewhere else ? Also could u provide me the
value of the AuxVectors during this test ?
BR,
A Ravi Theja
http://reviews.llvm.org/D14118
_
39 matches
Mail list logo
