Re: [Lldb-commits] [PATCH] D15262: Add initial NetBSD support in lldbsuite/test/lldbtest.py

2015-12-06 Thread Joerg Sonnenberger via lldb-commits
joerg added a comment. Two small cleanups, otherwise LGTM. Comment at: packages/Python/lldbsuite/test/lldbtest.py:1328 @@ -1313,3 +1327,3 @@ cls.platformContext = _PlatformContext('DYLD_LIBRARY_PATH', 'lib', 'dylib') -elif getPlatform() == "linux" or

Re: [Lldb-commits] [PATCH] D15262: Add initial NetBSD support in lldbsuite/test/lldbtest.py

2015-12-06 Thread Kamil Rytarowski via lldb-commits
krytarowski updated the summary for this revision. krytarowski updated this revision to Diff 42013. Repository: rL LLVM http://reviews.llvm.org/D15262 Files: packages/Python/lldbsuite/test/lldbtest.py Index: packages/Python/lldbsuite/test/lldbtest.py

Re: [Lldb-commits] [PATCH] D15262: Add initial NetBSD support in lldbsuite/test/lldbtest.py

2015-12-06 Thread Kamil Rytarowski via lldb-commits
krytarowski updated this revision to Diff 42014. Repository: rL LLVM http://reviews.llvm.org/D15262 Files: packages/Python/lldbsuite/test/lldbtest.py Index: packages/Python/lldbsuite/test/lldbtest.py === ---

Re: [Lldb-commits] [PATCH] D15262: Add initial NetBSD support in lldbsuite/test/lldbtest.py

2015-12-06 Thread Ed Maste via lldb-commits
emaste added inline comments. Comment at: packages/Python/lldbsuite/test/lldbtest.py:832-834 @@ -828,2 +831,5 @@ +def expectedFlakeyNetBSD(bugnumber=None, compilers=None): +return expectedFlakeyOS(['netbsd'], bugnumber, compilers) + def expectedFlakeyLinux(bugnumber=None,

Re: [Lldb-commits] [PATCH] D15263: Add NetBSD in platform specific logging of the specified category in RegisterCommandsTestCase()

2015-12-06 Thread Ed Maste via lldb-commits
emaste accepted this revision. emaste added a comment. This revision is now accepted and ready to land. We could probably replace these freebsd/linux/netbsd cases with a routine that strips trailing digits. Repository: rL LLVM http://reviews.llvm.org/D15263

[Lldb-commits] [lldb] r254890 - Move test summary counts to end; simplify issue detail line

2015-12-06 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Sun Dec 6 21:10:02 2015 New Revision: 254890 URL: http://llvm.org/viewvc/llvm-project?rev=254890=rev Log: Move test summary counts to end; simplify issue detail line Test summary counts now show at the end, with issue details above. Issue details now print "ISSUE_TYPE:

Re: [Lldb-commits] [PATCH] D14896: Local path implementation of swig-bot.py

2015-12-06 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. Basic idea looks fine. (I saw you put this in not long after, but I'm finally getting to look at the actual review). I'm not sure if you're intending to cover all the use cases of the

Re: [Lldb-commits] [lldb] r254890 - Move test summary counts to end; simplify issue detail line

2015-12-06 Thread Todd Fiala via lldb-commits
Oh I'll have a look, thanks. On Sun, Dec 6, 2015 at 7:51 PM, Zachary Turner wrote: > > > On Sun, Dec 6, 2015 at 7:13 PM Todd Fiala via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > >> Author: tfiala >> Date: Sun Dec 6 21:10:02 2015 >> New Revision: 254890 >> >>

[Lldb-commits] [lldb] r254894 - Added lldbsuite.lldb_test_root, switched formatter to use it.

2015-12-06 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Mon Dec 7 00:19:48 2015 New Revision: 254894 URL: http://llvm.org/viewvc/llvm-project?rev=254894=rev Log: Added lldbsuite.lldb_test_root, switched formatter to use it. Modified: lldb/trunk/packages/Python/lldbsuite/__init__.py