Re: [Lldb-commits] [PATCH] D15593: Enhance "target modules dump line " and use it to fix MI's -symbol-list-lines.

2015-12-16 Thread Dawn Perchik via lldb-commits
dawn retitled this revision from "Add "target modules dump line-entries " command and use it to fix MI's -symbol-list-lines." to "Enhance "target modules dump line " and use it to fix MI's -symbol-list-lines.". dawn updated the summary for this revision. dawn updated this revision to Diff 43103.

Re: [Lldb-commits] [PATCH] D15533: Make the aarch64 lldb-server capable of debugging arm32 applications

2015-12-16 Thread Muhammad Omair Javaid via lldb-commits
omjavaid added a comment. I am wondering whats the reason of replacing arm ptrace calls with aarch64 specific calls that use iovec parameters. If arm calls can work then may be dont use aarch64 specific calls at all. If they dont work kindly make relevant changes to NativeRegisterContextLinux_

[Lldb-commits] [lldb] r255880 - test infra: force rerun to use parallel runner

2015-12-16 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Thu Dec 17 00:55:50 2015 New Revision: 255880 URL: http://llvm.org/viewvc/llvm-project?rev=255880&view=rev Log: test infra: force rerun to use parallel runner We've now seen the rerun test phase hang in a few scenarios. Eliminate the serial test runner (which is not exercise

Re: [Lldb-commits] [PATCH] D15593: Add "target modules dump line-entries " command and use it to fix MI's -symbol-list-lines.

2015-12-16 Thread Jim Ingham via lldb-commits
That seems fine for now. Note, if you use the OptionGroupOptions way of defining the new options for your command, then you can call OptionsSeen to tell you which options were actually provided by the user, so for extra credit, if --compile-unit-only is true and no other options were provided

Re: [Lldb-commits] [PATCH] D15593: Add "target modules dump line-entries " command and use it to fix MI's -symbol-list-lines.

2015-12-16 Thread Jim Ingham via lldb-commits
jingham added a comment. That seems fine for now. Note, if you use the OptionGroupOptions way of defining the new options for your command, then you can call OptionsSeen to tell you which options were actually provided by the user, so for extra credit, if --compile-unit-only is true and no oth

Re: [Lldb-commits] [PATCH] D15593: Add "target modules dump line-entries " command and use it to fix MI's -symbol-list-lines.

2015-12-16 Thread Dawn Perchik via lldb-commits
dawn added a comment. I'm only going to support the combinations: --compile-unit-only true --only-explicit-matches false --show-raw true --compile-unit-only false --only-explicit-matches true --show-raw false OK? Repository: rL LLVM http://reviews.llvm.org/D15593

Re: [Lldb-commits] [PATCH] D15593: Add "target modules dump line-entries " command and use it to fix MI's -symbol-list-lines.

2015-12-16 Thread Jim Ingham via lldb-commits
jingham added a comment. Provided we error out appropriately I don't think we need to support all possible combinations of options. I'd happier doing it by options and not supporting the combinations that aren't worth the effort. Then if anybody really needs one of the unsupported ones, the p

Re: [Lldb-commits] [PATCH] D15593: Add "target modules dump line-entries " command and use it to fix MI's -symbol-list-lines.

2015-12-16 Thread Dawn Perchik via lldb-commits
dawn added a comment. In http://reviews.llvm.org/D15593#312665, @jingham wrote: > So it seems like your change is adding three flags > > --compile-unit-only --only-explicit-matches --show-raw > > or something. The current behavior is: > > --compile-unit-only true --only-explicit-matches fals

[Lldb-commits] [lldb] r255868 - Set the minimum stack size for private state thread to 8MB

2015-12-16 Thread Kate Stone via lldb-commits
Author: kate Date: Wed Dec 16 19:37:00 2015 New Revision: 255868 URL: http://llvm.org/viewvc/llvm-project?rev=255868&view=rev Log: Set the minimum stack size for private state thread to 8MB Demangling complex Boost symbols can exhaust the default stack size. In practice, any thread that calls i

Re: [Lldb-commits] [PATCH] D15593: Add "target modules dump line-entries " command and use it to fix MI's -symbol-list-lines.

2015-12-16 Thread Jim Ingham via lldb-commits
jingham added a comment. Okay. So it seems like there are a couple of orthogonal differences here. 1. The current behavior requires that the the source file you pass in be a compile unit. We don't search inside the line tables. So for instance target modules dump line-tables foo.h would cur

[Lldb-commits] [lldb] r255864 - Don't demangle a name when Mangled::GetName() is called with ePreferMangled. Only demangle if this isn't the the value for the "preference" argument indicating the user

2015-12-16 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Wed Dec 16 19:00:50 2015 New Revision: 255864 URL: http://llvm.org/viewvc/llvm-project?rev=255864&view=rev Log: Don't demangle a name when Mangled::GetName() is called with ePreferMangled. Only demangle if this isn't the the value for the "preference" argument indicating t

[Lldb-commits] [lldb] r255863 - Don't strip types of their typedefs when getting function types.

2015-12-16 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Wed Dec 16 18:58:41 2015 New Revision: 255863 URL: http://llvm.org/viewvc/llvm-project?rev=255863&view=rev Log: Don't strip types of their typedefs when getting function types. Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: lldb/trunk/source/Symbol/Cl

Re: [Lldb-commits] [PATCH] D15593: Add "target modules dump line-entries " command and use it to fix MI's -symbol-list-lines.

2015-12-16 Thread Dawn Perchik via lldb-commits
dawn added a comment. In http://reviews.llvm.org/D15593#312571, @jingham wrote: > I don't think this is sufficiently different from "target modules dump > line-tables" to warrant a separate command. This seems more like a candidate > for a flag to "target modules dump line-tables" like --searc

Re: [Lldb-commits] [PATCH] D15593: Add "target modules dump line-entries " command and use it to fix MI's -symbol-list-lines.

2015-12-16 Thread Jim Ingham via lldb-commits
jingham added a subscriber: jingham. jingham requested changes to this revision. jingham added a reviewer: jingham. jingham added a comment. This revision now requires changes to proceed. I don't think this is sufficiently different from "target modules dump line-tables" to warrant a separate com

Re: [Lldb-commits] [PATCH] D15566: Patch cmake to allow detection of python 2.7.9+

2015-12-16 Thread Kamil Rytarowski via lldb-commits
krytarowski added a subscriber: krytarowski. krytarowski added a comment. In http://reviews.llvm.org/D15566#311998, @zturner wrote: > Where did you get this version of Python? I don't see anything wrong with > this patch, but I'm a little curious what this + means I think a patched version. I

Re: [Lldb-commits] [PATCH] D15593: Add "target modules dump line-entries " command and use it to fix MI's -symbol-list-lines.

2015-12-16 Thread Dawn Perchik via lldb-commits
dawn updated this revision to Diff 43076. dawn added a comment. Updated patch to include changes to TestHelp.py. Repository: rL LLVM http://reviews.llvm.org/D15593 Files: packages/Python/lldbsuite/test/help/TestHelp.py packages/Python/lldbsuite/test/tools/lldb-mi/symbol/TestMiSymbol.py

[Lldb-commits] [PATCH] D15593: Add "target modules dump line-entries " command and use it to fix MI's -symbol-list-lines.

2015-12-16 Thread Dawn Perchik via lldb-commits
dawn created this revision. dawn added reviewers: clayborg, ki.stfu, abidh. dawn added a subscriber: lldb-commits. dawn set the repository for this revision to rL LLVM. This adds support for the new command: target modules dump line-entries which dumps the line entries found for 'file' for al

Re: [Lldb-commits] [PATCH] D15562: Add AccessModifierOffset to clang-format style

2015-12-16 Thread Todd Fiala via lldb-commits
tfiala added a comment. I think we're good with this then, Pavel. http://reviews.llvm.org/D15562 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12809: Better scheme to lookup alternate mangled name when looking up function address.

2015-12-16 Thread Dawn Perchik via lldb-commits
dawn added a comment. Can a "code owner" please review this patch? Thanks, -Dawn http://reviews.llvm.org/D12809 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15326: Rework breakpoint language filtering to use the symbol context's language.

2015-12-16 Thread Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL255808: Rework breakpoint language filtering to use the symbol context's language. (authored by dperchik). Changed prior to commit: http://reviews.llvm.org/D15326?vs=42911&id=43044#toc Repository: rL

[Lldb-commits] [lldb] r255808 - Rework breakpoint language filtering to use the symbol context's language.

2015-12-16 Thread Dawn Perchik via lldb-commits
Author: dperchik Date: Wed Dec 16 13:40:00 2015 New Revision: 255808 URL: http://llvm.org/viewvc/llvm-project?rev=255808&view=rev Log: Rework breakpoint language filtering to use the symbol context's language. This patch reworks the breakpoint filter-by-language patch to use the symbol context in

[Lldb-commits] [PATCH] D15582: Improve error handling for `f s #`

2015-12-16 Thread Adrian McCarthy via lldb-commits
amccarth created this revision. amccarth added reviewers: emaste, jasonmolenda. amccarth added a subscriber: lldb-commits. When there were too many arguments given for the `frame select` command, the error message wasn't particularly helpful and then lldb would try to select frame -1, which resu

Re: [Lldb-commits] [PATCH] D15562: Add AccessModifierOffset to clang-format style

2015-12-16 Thread Jim Ingham via lldb-commits
jingham added a subscriber: jingham. jingham added a comment. We don't indent access modifiers, so if AccessModifierOffset does what it's name suggests, then that's right. Jim http://reviews.llvm.org/D15562 ___ lldb-commits mailing list lldb-commi

Re: [Lldb-commits] [PATCH] D15562: Add AccessModifierOffset to clang-format style

2015-12-16 Thread Jim Ingham via lldb-commits
We don't indent access modifiers, so if AccessModifierOffset does what it's name suggests, then that's right. Jim > On Dec 16, 2015, at 8:09 AM, Todd Fiala wrote: > > tfiala added a reviewer: jingham. > tfiala added a comment. > > Hey Jim, this looks right to me. Agree? > > -Todd > > > ht

[Lldb-commits] [PATCH] D15576: Inspect global static const variables

2015-12-16 Thread Ewan Crawford via lldb-commits
EwanCrawford created this revision. EwanCrawford added reviewers: tberghammer, clayborg. EwanCrawford added a subscriber: lldb-commits. EwanCrawford set the repository for this revision to rL LLVM. This patch adds support for printing global static const variables which are given a DW_AT_const_va

[Lldb-commits] [lldb] r255775 - Remove the "MacOSX and Linux" and "Linux" targets from Xcode.

2015-12-16 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Wed Dec 16 10:09:59 2015 New Revision: 255775 URL: http://llvm.org/viewvc/llvm-project?rev=255775&view=rev Log: Remove the "MacOSX and Linux" and "Linux" targets from Xcode. I added these long ago, but as we work to simplify the Xcode project, their lack of use has made them

Re: [Lldb-commits] [PATCH] D15566: Patch cmake to allow detection of python 2.7.9+

2015-12-16 Thread Zachary Turner via lldb-commits
zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. Where did you get this version of Python? I don't see anything wrong with this patch, but I'm a little curious what this + means Repository: rL LLVM http://reviews.llvm.org/D15566 __

Re: [Lldb-commits] [PATCH] D15562: Add AccessModifierOffset to clang-format style

2015-12-16 Thread Todd Fiala via lldb-commits
tfiala added a reviewer: jingham. tfiala added a comment. Hey Jim, this looks right to me. Agree? -Todd http://reviews.llvm.org/D15562 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

[Lldb-commits] [lldb] r255774 - Wrap Notes in --help output to 80 columns

2015-12-16 Thread Ed Maste via lldb-commits
Author: emaste Date: Wed Dec 16 09:49:38 2015 New Revision: 255774 URL: http://llvm.org/viewvc/llvm-project?rev=255774&view=rev Log: Wrap Notes in --help output to 80 columns Modified: lldb/trunk/tools/driver/Driver.cpp Modified: lldb/trunk/tools/driver/Driver.cpp URL: http://llvm.org/viewv

[Lldb-commits] [lldb] r255771 - Include -c, -core in the lldb(1) man page

2015-12-16 Thread Ed Maste via lldb-commits
Author: emaste Date: Wed Dec 16 09:37:21 2015 New Revision: 255771 URL: http://llvm.org/viewvc/llvm-project?rev=255771&view=rev Log: Include -c, -core in the lldb(1) man page Modified: lldb/trunk/docs/lldb.1 Modified: lldb/trunk/docs/lldb.1 URL: http://llvm.org/viewvc/llvm-project/lldb/trun

[Lldb-commits] [lldb] r255769 - Man page whitespace/formatting change to appease igor(1)

2015-12-16 Thread Ed Maste via lldb-commits
Author: emaste Date: Wed Dec 16 08:59:48 2015 New Revision: 255769 URL: http://llvm.org/viewvc/llvm-project?rev=255769&view=rev Log: Man page whitespace/formatting change to appease igor(1) igor is a tool to detect common problems and style conformance issues in man pages and other documents. Th

[Lldb-commits] [PATCH] D15566: Patch cmake to allow detection of python 2.7.9+

2015-12-16 Thread Aidan Dodds via lldb-commits
ADodds created this revision. ADodds added a reviewer: zturner. ADodds added a subscriber: lldb-commits. ADodds set the repository for this revision to rL LLVM. Some distributions of python have their version defined as follows in patchlevel.h (note the '+'): #define PY_VERSION "2.7

[Lldb-commits] [PATCH] D15562: Add AccessModifierOffset to clang-format style

2015-12-16 Thread Pavel Labath via lldb-commits
labath created this revision. labath added reviewers: zturner, tfiala. labath added a subscriber: lldb-commits. As we override the indent option of the LLVM style, we need to override the access modifier offset as well. Otherwise, classes will be formatted like such class A { public: int fo

Re: [Lldb-commits] [PATCH] D15533: Make the aarch64 lldb-server capable of debugging arm32 applications

2015-12-16 Thread Tamas Berghammer via lldb-commits
tberghammer marked an inline comment as done. tberghammer added a comment. http://reviews.llvm.org/D15533 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15533: Make the aarch64 lldb-server capable of debugging arm32 applications

2015-12-16 Thread Tamas Berghammer via lldb-commits
tberghammer updated this revision to Diff 42987. tberghammer added a comment. Fix type http://reviews.llvm.org/D15533 Files: source/Host/common/HostInfoBase.cpp source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.h

Re: [Lldb-commits] [PATCH] D15533: Make the aarch64 lldb-server capable of debugging arm32 applications

2015-12-16 Thread Tamas Berghammer via lldb-commits
tberghammer added a comment. Note: This change is blocked by http://reviews.llvm.org/D15529. If that one will get rejected then we have to move some of the 32 <-> 64 architecture matching code into LLDB. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.c

Re: [Lldb-commits] [PATCH] D15533: Make the aarch64 lldb-server capable of debugging arm32 applications

2015-12-16 Thread Tamas Berghammer via lldb-commits
tberghammer updated this revision to Diff 42986. tberghammer marked 2 inline comments as done. http://reviews.llvm.org/D15533 Files: source/Host/common/HostInfoBase.cpp source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp source/Plugins/Process/Linux/NativeRegisterContextLinux_ar

Re: [Lldb-commits] [PATCH] D15530: [test] Add ability to expect timeouts

2015-12-16 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL255763: [test] Add ability to expect timeouts (authored by labath). Changed prior to commit: http://reviews.llvm.org/D15530?vs=42858&id=42985#toc Repository: rL LLVM http://reviews.llvm.org/D15530

[Lldb-commits] [lldb] r255763 - [test] Add ability to expect timeouts

2015-12-16 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Dec 16 06:09:45 2015 New Revision: 255763 URL: http://llvm.org/viewvc/llvm-project?rev=255763&view=rev Log: [test] Add ability to expect timeouts Summary: This adds ability to mark test that do not complete due to hangs, crashes, etc., as "expected", to avoid flagging th

Re: [Lldb-commits] [PATCH] D15530: [test] Add ability to expect timeouts

2015-12-16 Thread Pavel Labath via lldb-commits
No worries. I wanted to rename that function anyway, but then I forgot, so it's good that you have reminded me. :) On 15 December 2015 at 22:18, Todd Fiala wrote: > tfiala added a comment. > > Hey Pavel, > > Change r255676 changed a few things that will require this patch to get > updated. I th

Re: [Lldb-commits] [PATCH] D15530: [test] Add ability to expect timeouts

2015-12-16 Thread Pavel Labath via lldb-commits
labath added a subscriber: labath. labath added a comment. No worries. I wanted to rename that function anyway, but then I forgot, so it's good that you have reminded me. :) http://reviews.llvm.org/D15530 ___ lldb-commits mailing list lldb-commits@l

Re: [Lldb-commits] Buildbot numbers for week of 12/06/2015 - 12/12/2015

2015-12-16 Thread Kamil Rytarowski via lldb-commits
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 15.12.2015 20:23, Galina Kistanova via lldb-commits wrote: > Hello everyone, > > Below are some buildbot numbers for the last week of 12/06/2015 - > 12/12/2015. > > Thanks > > Galina > > > > Top 10 fastest builders(not docs): > > lldb-amd6