Re: [Lldb-commits] [lldb] r259611 - The compiler may use "line number 0" to indicate compiler generated goo that it can't

2016-02-04 Thread Pavel Labath via lldb-commits
+1 for using IR for hand-crafting tricky functions. On 3 February 2016 at 22:01, Adrian Prantl via lldb-commits wrote: > > On Feb 3, 2016, at 1:58 PM, Zachary Turner wrote: > > I was thinking of a really trivial function that just returned an int or > something. But then again, I don't really

Re: [Lldb-commits] [PATCH] D16872: Move some of the common decorators to decorators.py

2016-02-04 Thread Pavel Labath via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I think it's a good idea. I haven't given it a spin, but I think we can fix up any breakages from this on the fly. http://reviews.llvm.org/D16872 __

[Lldb-commits] [lldb] r259773 - [RenderScript] Add command for recalculating allocation details

2016-02-04 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Thu Feb 4 03:44:23 2016 New Revision: 259773 URL: http://llvm.org/viewvc/llvm-project?rev=259773&view=rev Log: [RenderScript] Add command for recalculating allocation details Patch replaces the --refresh flag removed in r258800 with it's own command, 'language renders

[Lldb-commits] [lldb] r259774 - Add verbose logging support to gdb-remote tests

2016-02-04 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Feb 4 03:53:33 2016 New Revision: 259774 URL: http://llvm.org/viewvc/llvm-project?rev=259774&view=rev Log: Add verbose logging support to gdb-remote tests Summary: gdb-remote tests are not able to use the same logging mechanisms as the rest of our tests, and currently w

[Lldb-commits] [lldb] r259775 - Mark TestProcessIO as flaky on android

2016-02-04 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Feb 4 03:53:37 2016 New Revision: 259775 URL: http://llvm.org/viewvc/llvm-project?rev=259775&view=rev Log: Mark TestProcessIO as flaky on android previously, I have marked only one test as flaky, but now I noticed another test failing with the same error. I am going to

Re: [Lldb-commits] [PATCH] D16858: Add verbose logging support to gdb-remote tests

2016-02-04 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL259774: Add verbose logging support to gdb-remote tests (authored by labath). Changed prior to commit: http://reviews.llvm.org/D16858?vs=46795&id=46884#toc Repository: rL LLVM http://reviews.llvm.or

Re: [Lldb-commits] [PATCH] D16858: Add verbose logging support to gdb-remote tests

2016-02-04 Thread Pavel Labath via lldb-commits
labath added a comment. In http://reviews.llvm.org/D16858#343140, @tfiala wrote: > BTW I was planning on re-organizing the lldb-server/debugserver tests > sometime in the near future to break them into many different directories and > pull off the dsym/dwarf/dwo changes for the many tests where

Re: [Lldb-commits] [PATCH] D16814: Fix handling of the arm IT instruction in the unwinder

2016-02-04 Thread Tamas Berghammer via lldb-commits
tberghammer added inline comments. Comment at: include/lldb/Core/EmulateInstruction.h:390 @@ +389,3 @@ +typedef uint32_t InstructionCondition; +static const InstructionCondition UnconditionalCondition = UINT32_MAX; + clayborg wrote: > It is nice to tell wh

[Lldb-commits] [lldb] r259777 - Enable test_lldbmi_settings_set_target_run_args_before on linux

2016-02-04 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Feb 4 05:51:07 2016 New Revision: 259777 URL: http://llvm.org/viewvc/llvm-project?rev=259777&view=rev Log: Enable test_lldbmi_settings_set_target_run_args_before on linux Test has passed last 200 runs of the build bot. Modified: lldb/trunk/packages/Python/lldbsuite

Re: [Lldb-commits] [PATCH] D16853: Use BKPT instead of UDF for arm/thumb breakpoints

2016-02-04 Thread Tamas Berghammer via lldb-commits
tberghammer updated this revision to Diff 46899. tberghammer added a comment. Update breakpoint opcodes based on review http://reviews.llvm.org/D16853 Files: source/Plugins/Platform/Linux/PlatformLinux.cpp source/Plugins/Process/Linux/NativeProcessLinux.cpp Index: source/Plugins/Process/Li

Re: [Lldb-commits] [PATCH] D16872: Move some of the common decorators to decorators.py

2016-02-04 Thread Tamas Berghammer via lldb-commits
tberghammer accepted this revision. tberghammer added a comment. Looks reasonable Comment at: packages/Python/lldbsuite/test/lldbtest.py:672-682 @@ -768,1 +671,13 @@ + +def skipUnlessListedRemote(remote_list=None): +def is_remote_unlisted(self): +if remote_list and l

Re: [Lldb-commits] [PATCH] D16840: [LLDB][MIPS] Generalise MIPS arch names

2016-02-04 Thread Nitesh Jain via lldb-commits
nitesh.jain marked an inline comment as done. Comment at: packages/Python/lldbsuite/test/functionalities/thread/crash_during_step/TestCrashDuringStep.py:24 @@ -23,3 +23,3 @@ @expectedFailureAndroid("llvm.org/pr24497", archs=['arm', 'aarch64']) -@expectedFailureAll(archs=

Re: [Lldb-commits] [PATCH] D16840: [LLDB][MIPS] Generalise MIPS arch names

2016-02-04 Thread Nitesh Jain via lldb-commits
nitesh.jain updated the summary for this revision. nitesh.jain updated this revision to Diff 46913. nitesh.jain added a comment. Updated as per the suggestion. Repository: rL LLVM http://reviews.llvm.org/D16840 Files: packages/Python/lldbsuite/test/functionalities/thread/crash_during_step

[Lldb-commits] [lldb] r259793 - Provide arguments for all the format string placeholders!

2016-02-04 Thread Adrian McCarthy via lldb-commits
Author: amccarth Date: Thu Feb 4 09:35:55 2016 New Revision: 259793 URL: http://llvm.org/viewvc/llvm-project?rev=259793&view=rev Log: Provide arguments for all the format string placeholders! Log message was wrong because an argument was missing. Modified: lldb/trunk/source/Plugins/Process/

Re: [Lldb-commits] [PATCH] D16840: [LLDB][MIPS] Generalise MIPS arch names

2016-02-04 Thread Nitesh Jain via lldb-commits
nitesh.jain updated this revision to Diff 46919. nitesh.jain added a comment. updates diff with triple =re.compile('^mips') to check if architecture string starts with mips. Repository: rL LLVM http://reviews.llvm.org/D16840 Files: packages/Python/lldbsuite/test/functionalities/thread/cr

[Lldb-commits] [lldb] r259807 - Move some of the common decorators to decorators.py.

2016-02-04 Thread Zachary Turner via lldb-commits
Author: zturner Date: Thu Feb 4 12:03:01 2016 New Revision: 259807 URL: http://llvm.org/viewvc/llvm-project?rev=259807&view=rev Log: Move some of the common decorators to decorators.py. This doesn't attempt to move every decorator. The reason for this is that it requires touching every single t

[Lldb-commits] [lldb] r259810 - Use an artifical namespace so that member vars do not hide local vars.

2016-02-04 Thread Siva Chandra via lldb-commits
Author: sivachandra Date: Thu Feb 4 12:38:35 2016 New Revision: 259810 URL: http://llvm.org/viewvc/llvm-project?rev=259810&view=rev Log: Use an artifical namespace so that member vars do not hide local vars. Summary: While evaluating expressions when stopped in a class method, there was a proble

[Lldb-commits] [lldb] r259818 - Make HostThread SetName work on OS X. GetName doesn't currently work, the code that was in

2016-02-04 Thread Jim Ingham via lldb-commits
Author: jingham Date: Thu Feb 4 13:42:32 2016 New Revision: 259818 URL: http://llvm.org/viewvc/llvm-project?rev=259818&view=rev Log: Make HostThread SetName work on OS X. GetName doesn't currently work, the code that was in GetName actually got the queue name not the thread name and anyway didn

[Lldb-commits] [PATCH] D16895: Revert "Use an artifical namespace so that member vars do not hide local vars."

2016-02-04 Thread Siva Chandra via lldb-commits
sivachandra created this revision. sivachandra added a reviewer: spyffe. sivachandra added a subscriber: lldb-commits. This reverts commit 8af14b5f9af68c31ac80945e5b5d56f0a14b38e4. Reverting as it breaks a few tests on Mac. http://reviews.llvm.org/D16895 Files: include/lldb/Symbol/ClangASTCont

[Lldb-commits] [lldb] r259823 - Revert "Use an artifical namespace so that member vars do not hide local vars."

2016-02-04 Thread Siva Chandra via lldb-commits
Author: sivachandra Date: Thu Feb 4 14:08:40 2016 New Revision: 259823 URL: http://llvm.org/viewvc/llvm-project?rev=259823&view=rev Log: Revert "Use an artifical namespace so that member vars do not hide local vars." Summary: This reverts commit 8af14b5f9af68c31ac80945e5b5d56f0a14b38e4. Revertin

Re: [Lldb-commits] [PATCH] D16895: Revert "Use an artifical namespace so that member vars do not hide local vars."

2016-02-04 Thread Siva Chandra via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL259823: Revert "Use an artifical namespace so that member vars do not hide local vars." (authored by sivachandra). Changed prior to commit: http://reviews.llvm.org/D16895?vs=46944&id=46945#toc Reposito

Re: [Lldb-commits] [PATCH] D16818: [lldb/NetBSD] Remove dead function. Unbreak the build with -Werror

2016-02-04 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. Feel free to land it. http://reviews.llvm.org/D16818 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D16900: Take 2: Use an artifical namespace so that member vars do not hide local vars.

2016-02-04 Thread Siva Chandra via lldb-commits
sivachandra created this revision. sivachandra added reviewers: spyffe, tfiala. sivachandra added a subscriber: lldb-commits. This relands r259810 with fix for failures on Mac. http://reviews.llvm.org/D16900 Files: include/lldb/Symbol/ClangASTContext.h include/lldb/Symbol/CompilerDeclContext

Re: [Lldb-commits] [PATCH] D16900: Take 2: Use an artifical namespace so that member vars do not hide local vars.

2016-02-04 Thread Siva Chandra via lldb-commits
sivachandra added inline comments. Comment at: source/Expression/ExpressionSourceCode.cpp:188 @@ +187,3 @@ +ConstString var_name = var_sp->GetName(); +if (var_name == ConstString("this") || var_name == ConstString(".block_descriptor")) +continue; -

Re: [Lldb-commits] [lldb] r259611 - The compiler may use "line number 0" to indicate compiler generated goo that it can't

2016-02-04 Thread Joerg Sonnenberger via lldb-commits
On Wed, Feb 03, 2016 at 12:14:52AM +, Zachary Turner via lldb-commits wrote: > Shouldn't it be possible to force clang to generate code like this? If so > couldn't you write a test for this by stepping over a function call which > has this kind of code in it? Doesn't global inline assembler t

Re: [Lldb-commits] [PATCH] D16900: Take 2: Use an artifical namespace so that member vars do not hide local vars.

2016-02-04 Thread Todd Fiala via lldb-commits
tfiala added a comment. I'm going to try this out now http://reviews.llvm.org/D16900 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r259834 - Replace tabs with spaces for consistent indentation. No actual text changes.

2016-02-04 Thread Adrian McCarthy via lldb-commits
Author: amccarth Date: Thu Feb 4 16:20:30 2016 New Revision: 259834 URL: http://llvm.org/viewvc/llvm-project?rev=259834&view=rev Log: Replace tabs with spaces for consistent indentation. No actual text changes. Modified: lldb/trunk/www/status.html Modified: lldb/trunk/www/status.html URL:

[Lldb-commits] [PATCH] D16902: Add status for LLDB on Windows to status.html.

2016-02-04 Thread Adrian McCarthy via lldb-commits
amccarth created this revision. amccarth added reviewers: zturner, jingham. amccarth added a subscriber: lldb-commits. Just a proposal. http://reviews.llvm.org/D16902 Files: www/status.html Index: www/status.html === --- www/stat

Re: [Lldb-commits] [PATCH] D16902: Add status for LLDB on Windows to status.html.

2016-02-04 Thread Adrian McCarthy via lldb-commits
amccarth updated this revision to Diff 46964. amccarth added a comment. More tweaks after comments from Zach. Notably removed the Script Bridging row since that's duplicating the Python Scripting row. http://reviews.llvm.org/D16902 Files: www/status.html Index: www/status.html

[Lldb-commits] [PATCH] Fix the search path for CMake files

2016-02-04 Thread Niels Ole Salscheider via lldb-commits
This allows to find the LLVM's CMake files after moving them in r259821. --- cmake/modules/LLDBStandalone.cmake | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/cmake/modules/LLDBStandalone.cmake b/cmake/modules/LLDBStandalone.cmake index d3955f1..4fa5ca9 100644 --- a/c

Re: [Lldb-commits] [PATCH] Fix the search path for CMake files

2016-02-04 Thread Zachary Turner via lldb-commits
Seems fine. Does this only affect the LLDB Standalone build? I don't know if any of the main contributors test that, but if you test it and it works for you then I guess this is ok. On Thu, Feb 4, 2016 at 2:52 PM Niels Ole Salscheider via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Thi

Re: [Lldb-commits] [PATCH] Fix the search path for CMake files

2016-02-04 Thread Niels Ole Salscheider via lldb-commits
On Thursday, 4 February 2016, 23:02:13 CET, Zachary Turner wrote: > Seems fine. Does this only affect the LLDB Standalone build? I don't know > if any of the main contributors test that, but if you test it and it works > for you then I guess this is ok. Yes, this is only relevant for the standal

[Lldb-commits] [lldb] r259845 - Fix the search path for CMake files

2016-02-04 Thread Niels Ole Salscheider via lldb-commits
Author: olesalscheider Date: Thu Feb 4 17:28:57 2016 New Revision: 259845 URL: http://llvm.org/viewvc/llvm-project?rev=259845&view=rev Log: Fix the search path for CMake files This allows to find the LLVM's CMake files after moving them in r259821. Modified: lldb/trunk/cmake/modules/LLDBSta

[Lldb-commits] [lldb] r259850 - Add a little logging to ProcessMachCore so it is easier to tell when a user process dyld

2016-02-04 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Feb 4 17:45:17 2016 New Revision: 259850 URL: http://llvm.org/viewvc/llvm-project?rev=259850&view=rev Log: Add a little logging to ProcessMachCore so it is easier to tell when a user process dyld or mach kernel binary are found, and if there are multiples of them found

[Lldb-commits] Buildbot numbers for week of 1/24/2016 - 1/30/2016

2016-02-04 Thread Galina Kistanova via lldb-commits
Hello everyone, Below are some buildbot numbers for the last week of 1/24/2016 - 1/30/2016. Thanks Galina Number of commits by project: project | commits ---+--- llvm | 283 cfe | 100

Re: [Lldb-commits] [PATCH] D16900: Take 2: Use an artifical namespace so that member vars do not hide local vars.

2016-02-04 Thread Todd Fiala via lldb-commits
This tested cleanly, no failures on OS X. Lgtm. -Todd > On Feb 4, 2016, at 2:15 PM, Todd Fiala wrote: > > tfiala added a comment. > > I'm going to try this out now > > > http://reviews.llvm.org/D16900 > > > ___ lldb-commits mailing list lldb-com

Re: [Lldb-commits] [PATCH] D16900: Take 2: Use an artifical namespace so that member vars do not hide local vars.

2016-02-04 Thread Siva Chandra via lldb-commits
sivachandra added a comment. Thanks a lot Todd. I will put this in tomorrow morning just to be on the safer side. http://reviews.llvm.org/D16900 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[Lldb-commits] [lldb] r259865 - Add two more addresses to check for the address of the kernel in debug mode;

2016-02-04 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Feb 4 19:38:56 2016 New Revision: 259865 URL: http://llvm.org/viewvc/llvm-project?rev=259865&view=rev Log: Add two more addresses to check for the address of the kernel in debug mode; also add some logging about where lldb is lookin for a kernel as it connects. Modif

Re: [Lldb-commits] [PATCH] D16900: Take 2: Use an artifical namespace so that member vars do not hide local vars.

2016-02-04 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. In http://reviews.llvm.org/D16900#344702, @sivachandra wrote: > Thanks a lot Todd. I will put this in tomorrow morning just to be on the > safer side. My pleasure, Siva! http://reviews.llv

Re: [Lldb-commits] [PATCH] D16858: Add verbose logging support to gdb-remote tests

2016-02-04 Thread Todd Fiala via lldb-commits
tfiala added a comment. In http://reviews.llvm.org/D16858#343895, @labath wrote: > In http://reviews.llvm.org/D16858#343140, @tfiala wrote: > > > BTW I was planning on re-organizing the lldb-server/debugserver tests > > sometime in the near future to break them into many different directories >

Re: [Lldb-commits] [PATCH] D16049: [LLDB][MIPS] A small fix in GetBreakableLoadAddress() for MIPS

2016-02-04 Thread Bhushan Attarde via lldb-commits
bhushan closed this revision. bhushan added a comment. Closed by commit http://reviews.llvm.org/rL258919 Repository: rL LLVM http://reviews.llvm.org/D16049 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [PATCH] D16916: [LLDB][MIPS] Fix TestExpressionInSyscall.py for MIPS

2016-02-04 Thread Bhushan Attarde via lldb-commits
bhushan created this revision. bhushan added a reviewer: clayborg. bhushan added subscribers: lldb-commits, nitesh.jain, mohit.bhakkad, sagar, jaydeep. bhushan set the repository for this revision to rL LLVM. This test (TestExpressionInSyscall.py) checks if we are able to evaluate expressions wh