[Lldb-commits] [lldb] r266042 - Process: fix the build with certain kernel versions

Author: compnerd Date: Tue Apr 12 00:40:51 2016 New Revision: 266042 URL: http://llvm.org/viewvc/llvm-project?rev=266042&view=rev Log: Process: fix the build with certain kernel versions The structure definitions are not provided, but we perform a sizeof operation of them which causes a build fai

[Lldb-commits] [PATCH] D19004: Use the section sizes to determine symbols sizes in the Symtab instead of just using the following symbol's address

jasonmolenda created this revision. jasonmolenda added a reviewer: clayborg. jasonmolenda added a subscriber: lldb-commits. jasonmolenda set the repository for this revision to rL LLVM. The Symtab has an array of symbol file addresses and sizes for address-to-symbol lookups, created in Symtab::In

Re: [Lldb-commits] [lldb] r266033 - Restore the lazy initialization of ScriptInterpreterPython, which was lost as part of the SystemLifetimeManager work

> On Apr 11, 2016, at 6:28 PM, Zachary Turner wrote: > > I have a feeling this breaks something, but I'm not sure what. I remember > specifically needing this for some reason. > If you manage to repro the breakage, let’s work on getting it fixed I’d like to not have to initialize Python eager

Re: [Lldb-commits] [lldb] r266033 - Restore the lazy initialization of ScriptInterpreterPython, which was lost as part of the SystemLifetimeManager work

I have a feeling this breaks something, but I'm not sure what. I remember specifically needing this for some reason. Did you verify that the gtest suite as well as the dotest suite and the interactive interpreter all still pass / work? On Mon, Apr 11, 2016 at 6:14 PM Enrico Granata via lldb-commit

[Lldb-commits] [lldb] r266033 - Restore the lazy initialization of ScriptInterpreterPython, which was lost as part of the SystemLifetimeManager work

Author: enrico Date: Mon Apr 11 20:08:35 2016 New Revision: 266033 URL: http://llvm.org/viewvc/llvm-project?rev=266033&view=rev Log: Restore the lazy initialization of ScriptInterpreterPython, which was lost as part of the SystemLifetimeManager work Modified: lldb/trunk/source/Plugins/Scri

[Lldb-commits] [lldb] r266023 - Fixed Variable::GetDecl() and Variable::GetDeclContext() to check the "Type *" before using it so we don't crash if a variable's type can't be realized which happens mo

Author: gclayton Date: Mon Apr 11 19:06:27 2016 New Revision: 266023 URL: http://llvm.org/viewvc/llvm-project?rev=266023&view=rev Log: Fixed Variable::GetDecl() and Variable::GetDeclContext() to check the "Type *" before using it so we don't crash if a variable's type can't be realized which hap

Re: [Lldb-commits] [PATCH] D18886: Reset continue_after_async only if neither SIGINIT nor SIGSTOP received

amccarth added a comment. It's weird in that, if you run the test independently, it passes. But if you run it with the multiprocess test runner (ninja check-lldb), then it fails on this line: self.fail("Setting a breakpoint generated an unexpected event: %s" % lldb.SBDebugger.StateAsCString(l

Re: [Lldb-commits] [PATCH] D18886: Reset continue_after_async only if neither SIGINIT nor SIGSTOP received

ovyalov added a comment. In http://reviews.llvm.org/D18886#397637, @amccarth wrote: > FYI: According to git bisect, this patch seems to have introduced a new test > failure on Windows. Thanks for the report - will fix today. http://reviews.llvm.org/D18886

Re: [Lldb-commits] [PATCH] D18848: Add PDBASTParser and parse type information from PDB

clayborg added a comment. In http://reviews.llvm.org/D18848#397787, @zturner wrote: > Thanks. One more question. Does SymbolFile::FindTypes need to be able to > handle the case of a null type name (which I guess would indicate to find > every type)? No. It should handle the request without

Re: [Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Ok, then setting write only watchpoints should be fine for those tests/ http://reviews.llvm.org/D18978 ___ lldb-commits mailing list lldb-com

Re: [Lldb-commits] [PATCH] D18848: Add PDBASTParser and parse type information from PDB

Thanks. One more question. Does SymbolFile::FindTypes need to be able to handle the case of a null type name (which I guess would indicate to find every type)? On Fri, Apr 8, 2016 at 3:24 PM Greg Clayton wrote: > clayborg added a comment. > > In http://reviews.llvm.org/D18848#395933, @zturner

[Lldb-commits] [lldb] r266001 - Add support for resolving dynamic types of extended ObjC tagged pointers

Author: enrico Date: Mon Apr 11 16:50:35 2016 New Revision: 266001 URL: http://llvm.org/viewvc/llvm-project?rev=266001&view=rev Log: Add support for resolving dynamic types of extended ObjC tagged pointers rdar://problem/24401051 Modified: lldb/trunk/source/Plugins/LanguageRuntime/ObjC/App

Re: [Lldb-commits] [PATCH] D18985: Fix test cases for big-endian systems

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. So many tests above are going to accept either a little endian or big endian value. This will make most of these tests useless since if a little endian machine fails with a big e

Re: [Lldb-commits] [PATCH] D18983: Miscellaneous fixes for big-endian systems

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D18983 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D18984: Fix ARM instruction emulation tests on big-endian systems

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good as long as all tests pass on all other systems. http://reviews.llvm.org/D18984 ___ lldb-commits mailing list lldb-commits@lists.ll

Re: [Lldb-commits] [PATCH] D18982: Handle bit fields on big-endian systems correctly

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good as long as all tests still pass on all other systems. http://reviews.llvm.org/D18982 ___ lldb-commits mailing list lldb-commits@li

Re: [Lldb-commits] [PATCH] D18980: Make Scalar::GetBytes and RegisterValue::GetBytes const

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D18980 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D18981: Fix usage of APInt.getRawData for big-endian systems

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D18981 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D18979: Fixes for platforms that default to unsigned char

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D18979 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Just a few questions on why read watchpoints were being disabled in the few SBValue::Watch() calls. Other than that it looks good. Is it possible to revert the read watchpoint ch

Re: [Lldb-commits] [PATCH] D18886: Reset continue_after_async only if neither SIGINIT nor SIGSTOP received

amccarth added a subscriber: amccarth. amccarth added a comment. FYI: According to git bisect, this patch seems to have introduced a new test failure on Windows. http://reviews.llvm.org/D18886 ___ lldb-commits mailing list lldb-commits@lists.llvm.

Re: [Lldb-commits] [PATCH] D18977: Add new ABI callback to return CFA offset

clayborg added a comment. I am not sure why this offset of 160 isn't represented in the unwind info. I guess the OS unwinder that uses the EH frame info just knows that it must adjust the CFA? That seems like a hack. It seems like the unwind info should be fixed and the OS level unwinder should

Re: [Lldb-commits] [PATCH] D18973: Find .plt section in object files generated by recent ld

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Other ELF experts should OK this one as well, but looks good to me though. http://reviews.llvm.org/D18973 ___ lldb-commits mailing list lldb-

[Lldb-commits] [lldb] r265978 - Add a formatter for zero-sized NSData

Author: enrico Date: Mon Apr 11 13:46:26 2016 New Revision: 265978 URL: http://llvm.org/viewvc/llvm-project?rev=265978&view=rev Log: Add a formatter for zero-sized NSData Modified: lldb/trunk/source/Plugins/Language/ObjC/Cocoa.cpp Modified: lldb/trunk/source/Plugins/Language/ObjC/Cocoa.cpp U

[Lldb-commits] [lldb] r265979 - Add support for additional NSArray formatters

Author: enrico Date: Mon Apr 11 13:46:37 2016 New Revision: 265979 URL: http://llvm.org/viewvc/llvm-project?rev=265979&view=rev Log: Add support for additional NSArray formatters Modified: lldb/trunk/source/Plugins/Language/ObjC/Cocoa.h lldb/trunk/source/Plugins/Language/ObjC/NSArray.cpp

[Lldb-commits] [PATCH] D18985: Fix test cases for big-endian systems

uweigand created this revision. uweigand added reviewers: granata.enrico, clayborg. uweigand added a subscriber: lldb-commits. A number of test cases were failing on big-endian systems simply due to byte order assumptions in the tests themselves, and no underlying bug in LLDB. These two test case

[Lldb-commits] [PATCH] D18984: Fix ARM instruction emulation tests on big-endian systems

uweigand created this revision. uweigand added a reviewer: clayborg. uweigand added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. Running the ARM instruction emulation test on a big-endian system would fail, since the code doesn't respect endianness properly. In Emulat

[Lldb-commits] [PATCH] D18983: Miscellaneous fixes for big-endian systems

uweigand created this revision. uweigand added reviewers: clayborg, granata.enrico, spyffe. uweigand added a subscriber: lldb-commits. This patch fixes a bunch of issues that show up on big-endian systems: - The gnu_libstdcpp.py script doesn't follow the way libstdc++ encodes bit vectors: it sh

[Lldb-commits] [PATCH] D18982: Handle bit fields on big-endian systems correctly

uweigand created this revision. uweigand added reviewers: granata.enrico, clayborg. uweigand added a subscriber: lldb-commits. Currently, the DataExtractor::GetMaxU64Bitfield and GetMaxS64Bitfield routines assume the incoming "bitfield_bit_offset" parameter uses little-endian bit numbering, i.e. a

[Lldb-commits] [PATCH] D18981: Fix usage of APInt.getRawData for big-endian systems

uweigand created this revision. uweigand added reviewers: clayborg, jasonmolenda, spyffe, labath, tberghammer. uweigand added a subscriber: lldb-commits. The Scalar implementation and a few other places in LLDB directly access the internal implementation of APInt values using the getRawData method

[Lldb-commits] [PATCH] D18980: Make Scalar::GetBytes and RegisterValue::GetBytes const

uweigand created this revision. uweigand added reviewers: clayborg, jasonmolenda, labath, tberghammer. uweigand added a subscriber: lldb-commits. Herald added a subscriber: dsanders. Scalar::GetBytes provides a non-const access to the underlying bytes of the scalar value, supposedly allowing for m

[Lldb-commits] [PATCH] D18979: Fixes for platforms that default to unsigned char

uweigand created this revision. uweigand added reviewers: spyffe, clayborg. uweigand added a subscriber: lldb-commits. Herald added a subscriber: aemerson. This fixes several test case failure on s390x caused by the fact that on this platform, the default "char" type is unsigned. - In ClangASTCon

[Lldb-commits] [PATCH] D18977: Add new ABI callback to return CFA offset

uweigand created this revision. uweigand added reviewers: jasonmolenda, clayborg. uweigand added a subscriber: lldb-commits. If the UnwindPlan did not identify how to unwind the stack pointer register, LLDB currently assumes it can determine to caller's SP from the current frame's CFA. This is tr

[Lldb-commits] [PATCH] D18976: Handle lookup of names identifying both a variable and a type

uweigand created this revision. uweigand added a reviewer: spyffe. uweigand added a subscriber: lldb-commits. In C++ code, a variable can have the same name as a type, e.g. like int C; struct C { static int a; }; When evaluating an expression like "C::a" by the LLDB parser, clang will call bac

[Lldb-commits] [PATCH] D18975: Fix unwind failures when PC points beyond the end of a function

uweigand created this revision. uweigand added a reviewer: jasonmolenda. uweigand added a subscriber: lldb-commits. RegisterContextLLDB::InitializeNonZerothFrame already has code to attempt to detect and handle the case where the PC points beyond the end of a function, but there are certain cases

[Lldb-commits] [PATCH] D18973: Find .plt section in object files generated by recent ld

uweigand created this revision. uweigand added reviewers: tberghammer, clayborg, labath. uweigand added a subscriber: lldb-commits. Code in ObjectFileELF::ParseTrampolineSymbols assumes that the sh_info field of the .rel(a).plt section identifies the .plt section. However, with recent GNU ld this

[Lldb-commits] [lldb] r265959 - Mark TestPrintStackTraces as flaky on android arm

Author: labath Date: Mon Apr 11 11:50:08 2016 New Revision: 265959 URL: http://llvm.org/viewvc/llvm-project?rev=265959&view=rev Log: Mark TestPrintStackTraces as flaky on android arm Modified: lldb/trunk/packages/Python/lldbsuite/test/python_api/lldbutil/process/TestPrintStackTraces.py Modi

Re: [Lldb-commits] [PATCH] D18965: [Driver] Fix a segfault in signal handlers

This revision was automatically updated to reflect the committed changes. Closed by commit rL265958: [Driver] Fix a segfault in signal handlers (authored by labath). Changed prior to commit: http://reviews.llvm.org/D18965?vs=53239&id=53265#toc Repository: rL LLVM http://reviews.llvm.org/D18

[Lldb-commits] [lldb] r265958 - [Driver] Fix a segfault in signal handlers

Author: labath Date: Mon Apr 11 11:40:09 2016 New Revision: 265958 URL: http://llvm.org/viewvc/llvm-project?rev=265958&view=rev Log: [Driver] Fix a segfault in signal handlers Summary: If we recieve a SIGCONT or SIGTSTP, while the driver is shutting down (which, sometimes, we do, for reasons whi

[Lldb-commits] [lldb] r265948 - Retry deletion of temporary files to avoid race conditions on Windows.

Author: amccarth Date: Mon Apr 11 10:21:01 2016 New Revision: 265948 URL: http://llvm.org/viewvc/llvm-project?rev=265948&view=rev Log: Retry deletion of temporary files to avoid race conditions on Windows. Differential Revision: http://reviews.llvm.org/D18912 Modified: lldb/trunk/packages/Py

Re: [Lldb-commits] [PATCH] D18912: sleep and retry on failure to delete temp file in tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL265948: Retry deletion of temporary files to avoid race conditions on Windows. (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D18912?vs=53100&id=53249#toc Repository: rL LLV

[Lldb-commits] [PATCH] D18965: [Driver] Fix a segfault in signal handlers

labath created this revision. labath added a reviewer: clayborg. labath added a subscriber: lldb-commits. If we recieve a SIGCONT or SIGTSTP, while the driver is shutting down (which, sometimes, we do, for reasons which are not completely clear to me), we would crash to due a null pointer derefe

[Lldb-commits] [lldb] r265931 - Remove unintentional return

Author: bhushan.attarde Date: Mon Apr 11 06:19:37 2016 New Revision: 265931 URL: http://llvm.org/viewvc/llvm-project?rev=265931&view=rev Log: Remove unintentional return Modified: lldb/trunk/source/Core/ArchSpec.cpp Modified: lldb/trunk/source/Core/ArchSpec.cpp URL: http://llvm.org/viewvc/l

Re: [Lldb-commits] [PATCH] D6272: [lldb] Add @skipIfAddressSanitizerUnsupported test decorator

kubabrecka abandoned this revision. kubabrecka added a comment. This is now done properly by 1) checking out libcxx, and compiler-rt for an LLDB build, and 2) running tests against the just-built clang. http://reviews.llvm.org/D6272 ___ lldb-commit

Re: [Lldb-commits] [PATCH] D5556: [lldb] change MemoryHistoryASan::CreateInstance to not look into all modules, but only in the executable and libclang_rt.asan dynamic library

kubabrecka abandoned this revision. kubabrecka added a comment. This already landed a long time ago. http://reviews.llvm.org/D5556 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r265921 - Fix makefile for TestMiThreadInfo after rL265858 (2nd try)

Author: tberghammer Date: Mon Apr 11 03:54:57 2016 New Revision: 265921 URL: http://llvm.org/viewvc/llvm-project?rev=265921&view=rev Log: Fix makefile for TestMiThreadInfo after rL265858 (2nd try) Modified: lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/threadinfo/Makefile Modified:

[Lldb-commits] [lldb] r265920 - Fix makefile for TestMiThreadInfo after rL265858

Author: tberghammer Date: Mon Apr 11 03:45:01 2016 New Revision: 265920 URL: http://llvm.org/viewvc/llvm-project?rev=265920&view=rev Log: Fix makefile for TestMiThreadInfo after rL265858 The makefile was explicitly setting LDFLAGS what is breaking some rules in the global makefile. Modified: