[Lldb-commits] [lldb] r266165 - Update Symtab::InitAddressIndexes so that computed symbol sizes

Author: jmolenda Date: Tue Apr 12 23:32:49 2016 New Revision: 266165 URL: http://llvm.org/viewvc/llvm-project?rev=266165=rev Log: Update Symtab::InitAddressIndexes so that computed symbol sizes will not exceed the bounds of their Section. This is addressing a problem where a file had a large

[Lldb-commits] [lldb] r266164 - Attempt to fix TestCPPBreakpointLocations on Linux/Android.

Author: ovyalov Date: Tue Apr 12 23:21:05 2016 New Revision: 266164 URL: http://llvm.org/viewvc/llvm-project?rev=266164=rev Log: Attempt to fix TestCPPBreakpointLocations on Linux/Android. Modified:

Re: [Lldb-commits] [PATCH] D18977: Add new ABI callback to provide fallback unwind register locations

jasonmolenda added a comment. Just to be clear, my concern is we get an register location which is "undefined" (I've never seen it, I don't know what it means) and now SavedLocationForRegister() will say "this register is volatile, not looking any further" when it used to say "register not

Re: [Lldb-commits] [PATCH] D18977: Add new ABI callback to provide fallback unwind register locations

jasonmolenda added a comment. Thanks for doing this work Ulrich, the assumption that SP==CFA was mine, I should have put this in the ABI from the start. I worry a little about the change to RegisterContextLLDB::SavedLocationForRegister() where you've moved the ABI is-volatile check into

Re: [Lldb-commits] [PATCH] D18977: Add new ABI callback to provide fallback unwind register locations

uweigand added a comment. OK, here's an implementation of the new approach. In addition to the changes discussed, I had to add handling of undefined register locations -- this might now theoretically also trigger when CFI contains an explicit DW_CFA_undefined, but it should actually do the

Re: [Lldb-commits] [PATCH] D18977: Add new ABI callback to provide fallback unwind register locations

uweigand retitled this revision from "Add new ABI callback to return CFA offset" to "Add new ABI callback to provide fallback unwind register locations". uweigand updated the summary for this revision. uweigand updated this revision to Diff 53502. http://reviews.llvm.org/D18977 Files:

Re: [Lldb-commits] [PATCH] D18985: Fix test cases for big-endian systems

uweigand added a comment. In http://reviews.llvm.org/D18985#397674, @clayborg wrote: > So many tests above are going to accept either a little endian or big endian > value. This will make most of these tests useless since if a little endian > machine fails with a big endian number we won't

Re: [Lldb-commits] [PATCH] D18985: Fix test cases for big-endian systems

uweigand updated the summary for this revision. uweigand updated this revision to Diff 53501. http://reviews.llvm.org/D18985 Files: packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-python-synth/TestDataFormatterPythonSynth.py

Re: [Lldb-commits] [PATCH] D18984: Fix ARM instruction emulation tests on big-endian systems

uweigand added a comment. In http://reviews.llvm.org/D18984#398486, @tberghammer wrote: > Generally looks good with 2 minor comment inline. I also run the test suite > on Android ARM (little endian) and everything looked fine Thanks for the review and test! Comment at:

Re: [Lldb-commits] [PATCH] D18984: Fix ARM instruction emulation tests on big-endian systems

uweigand updated this revision to Diff 53500. http://reviews.llvm.org/D18984 Files: source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp source/Plugins/Instruction/ARM/EmulationStateARM.cpp source/Plugins/Instruction/ARM/EmulationStateARM.h Index:

Re: [Lldb-commits] [PATCH] D19035: Fix breakpoint_set_restart test for Windows

This revision was automatically updated to reflect the committed changes. amccarth marked an inline comment as done. Closed by commit rL266145: Fix breakpoint_set_restart test for Windows (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D19035?vs=53472=53482#toc

[Lldb-commits] [lldb] r266145 - Fix breakpoint_set_restart test for Windows

Author: amccarth Date: Tue Apr 12 17:45:03 2016 New Revision: 266145 URL: http://llvm.org/viewvc/llvm-project?rev=266145=rev Log: Fix breakpoint_set_restart test for Windows When run with the multiprocess test runner, the getchar() trick doesn't work, so ninja check-lldb would fail on this

Re: [Lldb-commits] [PATCH] D19035: Fix breakpoint_set_restart test for Windows

amccarth marked an inline comment as done. Comment at: packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_set_restart/main.cpp:11 @@ -10,2 +10,3 @@ +#include #include #include ovyalov wrote: > You may remove iostream since getchar is no

Re: [Lldb-commits] [PATCH] D19035: Fix breakpoint_set_restart test for Windows

ovyalov accepted this revision. This revision is now accepted and ready to land. Comment at: packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_set_restart/main.cpp:11 @@ -10,2 +10,3 @@ +#include #include #include You may remove iostream

[Lldb-commits] [PATCH] D19035: Fix breakpoint_set_restart test for Windows

amccarth created this revision. amccarth added reviewers: ovyalov, labath. amccarth added a subscriber: lldb-commits. When run with the multiprocess test runner, the getchar() trick doesn't work, so `ninja check-lldb` would fail on this test, but running the test directly worked fine. This

[Lldb-commits] [lldb] r266139 - Fixed being able to set breakpoints on destructors when we don't fully specify the demangled name. So all of the following now work:

Author: gclayton Date: Tue Apr 12 17:02:37 2016 New Revision: 266139 URL: http://llvm.org/viewvc/llvm-project?rev=266139=rev Log: Fixed being able to set breakpoints on destructors when we don't fully specify the demangled name. So all of the following now work: (lldb) b ~Foo (lldb) b Foo::~Foo

[Lldb-commits] [lldb] r266138 - Use the FormatEntity work for great good - parse summary strings before accepting them, and fail to add any strings that fail parsing

Author: enrico Date: Tue Apr 12 16:57:11 2016 New Revision: 266138 URL: http://llvm.org/viewvc/llvm-project?rev=266138=rev Log: Use the FormatEntity work for great good - parse summary strings before accepting them, and fail to add any strings that fail parsing Modified:

[Lldb-commits] [lldb] r266129 - Cleanup the arguments for 'memory find' such that the help system reflects the real way to invoke it

Author: enrico Date: Tue Apr 12 16:26:48 2016 New Revision: 266129 URL: http://llvm.org/viewvc/llvm-project?rev=266129=rev Log: Cleanup the arguments for 'memory find' such that the help system reflects the real way to invoke it Modified: lldb/trunk/source/Commands/CommandObjectMemory.cpp

[Lldb-commits] [lldb] r266118 - Revert to using libdispatch to reap threads on MacOSX. Code was accidentally checked in that is now reverted.

Author: gclayton Date: Tue Apr 12 15:26:41 2016 New Revision: 266118 URL: http://llvm.org/viewvc/llvm-project?rev=266118=rev Log: Revert to using libdispatch to reap threads on MacOSX. Code was accidentally checked in that is now reverted. Modified: lldb/trunk/source/Host/macosx/Host.mm

Re: [Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform

uweigand added a comment. In http://reviews.llvm.org/D18978#398180, @labath wrote: > Could you also add a core file test to `TestLinuxCore`? It should be a matter > of running `make_core.sh`, saving the files and creating a new test function > in the file (I've tried to make it simple, if you

[Lldb-commits] [lldb] r266103 - Initialize the Python script interpreter lazily (i.e. not at debugger startup)

Author: enrico Date: Tue Apr 12 13:23:18 2016 New Revision: 266103 URL: http://llvm.org/viewvc/llvm-project?rev=266103=rev Log: Initialize the Python script interpreter lazily (i.e. not at debugger startup) This time it should also pass the gtests Modified:

Re: [Lldb-commits] [lldb] r266033 - Restore the lazy initialization of ScriptInterpreterPython, which was lost as part of the SystemLifetimeManager work

Yeah. I ended up tracking it down by hand. I am running one final run of tests and should have a commit going in very soon. Sent from my iPhone > On Apr 12, 2016, at 11:20 AM, Zachary Turner wrote: > > I think todd did some work to get the gtests working in Xcode. Is that

Re: [Lldb-commits] [PATCH] D18977: Add new ABI callback to return CFA offset

clayborg added a comment. Yes, that plan sounds great. http://reviews.llvm.org/D18977 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [lldb] r266033 - Restore the lazy initialization of ScriptInterpreterPython, which was lost as part of the SystemLifetimeManager work

I think todd did some work to get the gtests working in Xcode. Is that not working? On Tue, Apr 12, 2016 at 11:12 AM Enrico Granata wrote: > Is there any failure logs I can look at? > I am gonna guess the issue is simply that the unit test is assuming Python > to be

Re: [Lldb-commits] [lldb] r266033 - Restore the lazy initialization of ScriptInterpreterPython, which was lost as part of the SystemLifetimeManager work

Is there any failure logs I can look at? I am gonna guess the issue is simply that the unit test is assuming Python to be initialized. Which is a bad assumption after my change. Sent from my iPhone > On Apr 12, 2016, at 2:16 AM, Pavel Labath wrote: > > This breaks the

Re: [Lldb-commits] [PATCH] D18977: Add new ABI callback to return CFA offset

uweigand added a comment. In http://reviews.llvm.org/D18977#398557, @clayborg wrote: > In http://reviews.llvm.org/D18977#398157, @uweigand wrote: > > > In http://reviews.llvm.org/D18977#397626, @clayborg wrote: > > > > > I am not sure why this offset of 160 isn't represented in the unwind > > >

[Lldb-commits] [lldb] r266093 - Breakpoint conditions were making result variables, which they should not do.

Author: jingham Date: Tue Apr 12 12:17:35 2016 New Revision: 266093 URL: http://llvm.org/viewvc/llvm-project?rev=266093=rev Log: Breakpoint conditions were making result variables, which they should not do. The result variables aren't useful, and if you have a breakpoint on a common function

Re: [Lldb-commits] [PATCH] D18973: Find .plt section in object files generated by recent ld

clayborg added a comment. We can create a new SectionType enumeration in lldb-enumerations.h. Then in ObjectFileELF::CreateSections() we would classify the ".plt" section as eSectionTypeProcedureLinkageTable: static ConstString g_sect_name_plt (".plt"); if (name == g_sect_name_plt)

[Lldb-commits] [lldb] r266092 - 'int' is reported as an exception on OS X not as a signal. I don't think

Author: jingham Date: Tue Apr 12 12:04:12 2016 New Revision: 266092 URL: http://llvm.org/viewvc/llvm-project?rev=266092=rev Log: 'int' is reported as an exception on OS X not as a signal. I don't think this test ever succeeded on OS X. Modified:

Re: [Lldb-commits] [PATCH] D18977: Add new ABI callback to return CFA offset

clayborg added a comment. In http://reviews.llvm.org/D18977#398157, @uweigand wrote: > In http://reviews.llvm.org/D18977#397626, @clayborg wrote: > > > I am not sure why this offset of 160 isn't represented in the unwind info. > > I guess the OS unwinder that uses the EH frame info just knows

Re: [Lldb-commits] [PATCH] D18980: Make Scalar::GetBytes and RegisterValue::GetBytes const

tberghammer accepted this revision. tberghammer added a comment. Looks good http://reviews.llvm.org/D18980 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D18973: Find .plt section in object files generated by recent ld

tberghammer accepted this revision. tberghammer added a comment. Looks good as I am not aware of any system where the plt sections has different section name http://reviews.llvm.org/D18973 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r266072 - Fixup TestFdLeak

Author: labath Date: Tue Apr 12 08:55:54 2016 New Revision: 266072 URL: http://llvm.org/viewvc/llvm-project?rev=266072=rev Log: Fixup TestFdLeak this test was unintentionally XFAILed due to a change in the behavior of the expectedFailure decorator. Fix that. Also, mark the test as debug-info

Re: [Lldb-commits] [PATCH] D18985: Fix test cases for big-endian systems

uweigand added a comment. In http://reviews.llvm.org/D18985#398171, @labath wrote: > Just because the tests test the console interface, it doesn't mean you can't > use the python interface to do auxiliary tasks, like computing the > expectations. It sounds like you should be able to to a >

Re: [Lldb-commits] [PATCH] D18984: Fix ARM instruction emulation tests on big-endian systems

omjavaid added a comment. Seems legit but One cosmetic comment inline. Also have you tested this patch by running LLDB testsuite on arm in both little and big endian modes? Comment at: source/Plugins/Instruction/ARM/EmulationStateARM.cpp:157 @@ -149,12 +156,3 @@ { -if

[Lldb-commits] [lldb] r266058 - Bump up timeout in TestGdbRemoteProcessInfo

Author: labath Date: Tue Apr 12 06:59:41 2016 New Revision: 266058 URL: http://llvm.org/viewvc/llvm-project?rev=266058=rev Log: Bump up timeout in TestGdbRemoteProcessInfo the process info packet is slow, and sometimes it does not arrive on time when run on the android emulator. Modified:

Re: [Lldb-commits] [PATCH] D18981: Fix usage of APInt.getRawData for big-endian systems

labath added a comment. It would be great if you could add a some unit tests for your modifications to the Scalar class. You don't have to be too exhaustive, but a couple of tests would go a long way. http://reviews.llvm.org/D18981 ___

Re: [Lldb-commits] [PATCH] D18982: Handle bit fields on big-endian systems correctly

labath added a subscriber: labath. labath added a comment. It would be worthwhile to add a unit test for the DataExtractor fix (we don't have many of those, but we're trying to build them up). http://reviews.llvm.org/D18982 ___ lldb-commits

Re: [Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform

labath added a comment. Could you also add a core file test to `TestLinuxCore`? It should be a matter of running `make_core.sh`, saving the files and creating a new test function in the file (I've tried to make it simple, if you see room for improvement, then let me know). I think this is

[Lldb-commits] [lldb] r266054 - Skip a test in TestNamespaceLookup on linux to avoid a crash

Author: labath Date: Tue Apr 12 05:06:37 2016 New Revision: 266054 URL: http://llvm.org/viewvc/llvm-project?rev=266054=rev Log: Skip a test in TestNamespaceLookup on linux to avoid a crash Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/namespace/TestNamespaceLookup.py

Re: [Lldb-commits] [PATCH] D18985: Fix test cases for big-endian systems

labath added a subscriber: labath. labath added a comment. In http://reviews.llvm.org/D18985#398169, @uweigand wrote: > In http://reviews.llvm.org/D18985#397674, @clayborg wrote: > > > So many tests above are going to accept either a little endian or big > > endian value. This will make most of

Re: [Lldb-commits] [PATCH] D18985: Fix test cases for big-endian systems

uweigand added a comment. In http://reviews.llvm.org/D18985#397674, @clayborg wrote: > So many tests above are going to accept either a little endian or big endian > value. This will make most of these tests useless since if a little endian > machine fails with a big endian number we won't

Re: [Lldb-commits] [PATCH] D18977: Add new ABI callback to return CFA offset

uweigand added a comment. In http://reviews.llvm.org/D18977#397626, @clayborg wrote: > I am not sure why this offset of 160 isn't represented in the unwind info. I > guess the OS unwinder that uses the EH frame info just knows that it must > adjust the CFA? That seems like a hack. It seems

Re: [Lldb-commits] [lldb] r266033 - Restore the lazy initialization of ScriptInterpreterPython, which was lost as part of the SystemLifetimeManager work

This breaks the python unit tests. Doesn't seem hard to fix, it seems we just need some way to "really" initialize python before we run the tests. However, I have reverted this change until that happens to keep to bots green. pl On 12 April 2016 at 02:41, Enrico Granata via lldb-commits <

[Lldb-commits] [lldb] r266050 - Revert "Restore the lazy initialization of ScriptInterpreterPython, which was lost as part of the SystemLifetimeManager work"

Author: labath Date: Tue Apr 12 04:06:08 2016 New Revision: 266050 URL: http://llvm.org/viewvc/llvm-project?rev=266050=rev Log: Revert "Restore the lazy initialization of ScriptInterpreterPython, which was lost as part of the SystemLifetimeManager work" This change breaks python unit tests.

Re: [Lldb-commits] [PATCH] D18886: Reset continue_after_async only if neither SIGINIT nor SIGSTOP received

labath added a comment. A random thought: will `getchar()` block the inferior on windows (because of missing stdio forwarding, et al.). If it wont then this could be the cause of the flakyness. If that's the case, then we can replace that call with something that will surely halt progress,

Re: [Lldb-commits] [PATCH] D18886: Reset continue_after_async only if neither SIGINIT nor SIGSTOP received

labath added a comment. In http://reviews.llvm.org/D18886#397843, @amccarth wrote: > It's weird in that, if you run the test independently, it passes. But if you > run it with the multiprocess test runner (ninja check-lldb), then it fails on > this line: > > self.fail("Setting a breakpoint