Awesome! Good catch, Adrian!
(And my pleasure!)
-Todd
> On Apr 25, 2016, at 4:13 PM, Adrian McCarthy wrote:
>
> amccarth added a comment.
>
> I got it. There was an exception being thrown from asyncore so early that it
> didn't give a proper stack trace. The problem boils down to Python 3
tfiala added a subscriber: tfiala.
tfiala added a comment.
Awesome! Good catch, Adrian!
(And my pleasure!)
-Todd
http://reviews.llvm.org/D19214
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
omjavaid created this revision.
omjavaid added reviewers: tberghammer, labath.
omjavaid added a subscriber: lldb-commits.
Herald added subscribers: rengolin, aemerson.
rL267291 introduces a lot of regression on arm-linux by fixing module
architecture to thumb if it finds thumb32 tag set.
Tag_THU
Author: omjavaid
Date: Mon Apr 25 20:08:59 2016
New Revision: 267508
URL: http://llvm.org/viewvc/llvm-project?rev=267508&view=rev
Log:
Fix arm-linux-gnueabi regression due to rL267291
rL267291 introduces a lot regression on arm-linux LLDB testsuite.
This patch fixes half of them. I am merging it
Debug mode doesn't mean no optimization, but -O0 SHOULD... OTOH, long
experience has shown that it is very hard to convince compilers to be as dumb
at -O0 as you would like them to be. That's why in all our test cases, we
initialize variables, and generally do something dumb like printf the va
Because it's compiled in debug mode? I wouldn't expect *any* optimization
to be done in that case.
On Mon, Apr 25, 2016 at 4:35 PM, Siva Chandra
wrote:
> Clang is probably right. Why bother to emit an unused file static scalar?
>
> On Mon, Apr 25, 2016 at 4:21 PM, Chaoren Lin wrote:
> > Ah, I s
Author: jingham
Date: Mon Apr 25 19:29:59 2016
New Revision: 267500
URL: http://llvm.org/viewvc/llvm-project?rev=267500&view=rev
Log:
When building the list of variables we're going to write "using
$_lldb_local_vars"
statements for, be sure not to include variables that have no locations. We
w
clayborg added a comment.
Looks good. We will need to remove the darwin only decorator as well to enable
this for other platforms.
Repository:
rL LLVM
http://reviews.llvm.org/D19511
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http:
Author: gclayton
Date: Mon Apr 25 18:39:19 2016
New Revision: 267494
URL: http://llvm.org/viewvc/llvm-project?rev=267494&view=rev
Log:
Make sure that the following SymbolFileDWARF functions can handle getting a
lldb::user_id_t for another SymbolFileDWARF:
CompilerDecl
SymbolFileDWARF::GetDeclFor
Clang is probably right. Why bother to emit an unused file static scalar?
On Mon, Apr 25, 2016 at 4:21 PM, Chaoren Lin wrote:
> Ah, I see. Is that a known clang bug?
>
> On Mon, Apr 25, 2016 at 4:07 PM, Siva Chandra
> wrote:
>>
>> AFAICT, happens only with Clang; Using g_static_var, say as "retu
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267492: Fix TestGetVariables.py. (authored by chaoren).
Changed prior to commit:
http://reviews.llvm.org/D19511?vs=54940&id=54944#toc
Repository:
rL LLVM
http://reviews.llvm.org/D19511
Files:
lld
Author: chaoren
Date: Mon Apr 25 18:29:53 2016
New Revision: 267492
URL: http://llvm.org/viewvc/llvm-project?rev=267492&view=rev
Log:
Fix TestGetVariables.py.
Reviewers: sivachandra, clayborg
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D19511
Modified:
lldb/tr
chaoren created this revision.
chaoren added reviewers: sivachandra, clayborg.
chaoren added a subscriber: lldb-commits.
http://reviews.llvm.org/D19511
Files:
packages/Python/lldbsuite/test/python_api/frame/get-variables/TestGetVariables.py
packages/Python/lldbsuite/test/python_api/frame/get
Ah, I see. Is that a known clang bug?
On Mon, Apr 25, 2016 at 4:07 PM, Siva Chandra
wrote:
> AFAICT, happens only with Clang; Using g_static_var, say as "return
> g_static_var - 123;", fixes for me.
>
> On Mon, Apr 25, 2016 at 3:50 PM, Chaoren Lin via lldb-commits
> wrote:
> > Is g_global_var n
amccarth created this revision.
amccarth added a reviewer: tfiala.
amccarth added a subscriber: lldb-commits.
Python 3.5 is pickier about the distinction between chars and bytes (and
strings and bytearrays) than Python 2.7.
The call to ack_bytes.append(chr(42)) was causing a type error to be thr
amccarth added a comment.
I got it. There was an exception being thrown from asyncore so early that it
didn't give a proper stack trace. The problem boils down to Python 3 drawing a
distinction between strings and bytearrays. Patch to come momentarily.
Thanks for your help.
http://reviews.
AFAICT, happens only with Clang; Using g_static_var, say as "return
g_static_var - 123;", fixes for me.
On Mon, Apr 25, 2016 at 3:50 PM, Chaoren Lin via lldb-commits
wrote:
> Is g_global_var necessarily static?
>
> On Linux, we're only seeing 2 static variables when your test expects 3.
>
>> sta
Is g_global_var necessarily static?
On Linux, we're only seeing 2 static variables when your test expects 3.
> static_names = ['static_var', 'g_global_var', 'static_var']
I'm guessing g_global_var isn't treated as static.
On Mon, Apr 25, 2016 at 2:54 PM, Greg Clayton via lldb-commits <
lldb-co
Author: gclayton
Date: Mon Apr 25 16:54:10 2016
New Revision: 267478
URL: http://llvm.org/viewvc/llvm-project?rev=267478&view=rev
Log:
Fix StackFrame::GetVariables(...) function that was broken by 261858 when
lambda functions were added to Block::AppendBlockVariables(). The
Stackframe::GetVariab
tfiala added a comment.
Ick. Yeah that sounds like something to resolve quickly.
They shouldn't be getting stuck. That would imply that the side running via
dosep.py (the listener socket) is either (1) no longer running and therefore
the listener isn't spinning up, although that would be cata
amccarth added a comment.
We already limit threads on Windows to work around other problems.
Technically, we force Windows to always use the multiprocessing-pool instead of
the threading-pool, which I think has the effect of limiting the number of
threads.
I suspect that the first several inv
Author: fjricci
Date: Mon Apr 25 14:02:05 2016
New Revision: 267443
URL: http://llvm.org/viewvc/llvm-project?rev=267443&view=rev
Log:
test commit
Modified:
lldb/trunk/docs/lldb-for-gdb-users.txt
Modified: lldb/trunk/docs/lldb-for-gdb-users.txt
URL:
http://llvm.org/viewvc/llvm-project/lldb/t
tfiala added a comment.
Didn't get to it in time, but yes this looks fine.
Repository:
rL LLVM
http://reviews.llvm.org/D19082
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
My guess here would be that the fixing of the race - i.e. ensuring the
listening side is up and running before allowing the sender to continue, is
probably keeping more sockets open than before (i.e. fixing the race, but doing
so by using an average larger number of reso
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267468: Maintain register numbering across xml include
features (authored by fjricci).
Changed prior to commit:
http://reviews.llvm.org/D19303?vs=54298&id=54904#toc
Repository:
rL LLVM
http://review
Author: fjricci
Date: Mon Apr 25 16:03:55 2016
New Revision: 267468
URL: http://llvm.org/viewvc/llvm-project?rev=267468&view=rev
Log:
Maintain register numbering across xml include features
Summary:
If the remote uses include features when communicating
xml register info back to lldb, the existin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267467: Properly unload modules from target image list when
using svr4 packets (authored by fjricci).
Changed prior to commit:
http://reviews.llvm.org/D19230?vs=54083&id=54902#toc
Repository:
rL LLVM
Author: fjricci
Date: Mon Apr 25 16:02:24 2016
New Revision: 267467
URL: http://llvm.org/viewvc/llvm-project?rev=267467&view=rev
Log:
Properly unload modules from target image list when using svr4 packets
Summary:
When we receive an svr4 packet from the remote, we check for new modules
and add th
fjricci added a comment.
Committed with comment added to ReadRegister declaration to specify that the
argument is an eRegisterKindProcessPlugin register number
Repository:
rL LLVM
http://reviews.llvm.org/D19305
___
lldb-commits mailing list
lldb
Author: fjricci
Date: Mon Apr 25 15:59:11 2016
New Revision: 267466
URL: http://llvm.org/viewvc/llvm-project?rev=267466&view=rev
Log:
Use Process Plugin register indices when communicating with remote
Summary:
eRegisterKindProcessPlugin is used to store the register
indices used by the remote, an
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267466: Use Process Plugin register indices when
communicating with remote (authored by fjricci).
Changed prior to commit:
http://reviews.llvm.org/D19305?vs=54303&id=54900#toc
Repository:
rL LLVM
ht
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267463: Store absolute path for lldb executable in dotest.py
(authored by fjricci).
Changed prior to commit:
http://reviews.llvm.org/D19082?vs=53637&id=54895#toc
Repository:
rL LLVM
http://reviews.l
Author: fjricci
Date: Mon Apr 25 15:36:22 2016
New Revision: 267463
URL: http://llvm.org/viewvc/llvm-project?rev=267463&view=rev
Log:
Store absolute path for lldb executable in dotest.py
Summary:
lldb-server tests are currently being skipped on the
check-lldb target. This is because we get the pa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267462: Create _lldb python symlink correctly when
LLVM_LIBDIR_SUFFIX is used (authored by fjricci).
Changed prior to commit:
http://reviews.llvm.org/D19067?vs=54077&id=54894#toc
Repository:
rL LLVM
Author: fjricci
Date: Mon Apr 25 15:34:34 2016
New Revision: 267462
URL: http://llvm.org/viewvc/llvm-project?rev=267462&view=rev
Log:
Create _lldb python symlink correctly when LLVM_LIBDIR_SUFFIX is used
Summary:
Do not assume that liblldb.so is located in $(lldb -P)/../../../lib
when creating th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267459: Add missing qRegisterInfo option to gdbremote
testcase (authored by fjricci).
Changed prior to commit:
http://reviews.llvm.org/D18807?vs=52743&id=54892#toc
Repository:
rL LLVM
http://reviews
Author: fjricci
Date: Mon Apr 25 15:24:30 2016
New Revision: 267459
URL: http://llvm.org/viewvc/llvm-project?rev=267459&view=rev
Log:
Add missing qRegisterInfo option to gdbremote testcase
Summary:
"gcc" is equivalent to "ehframe" in ProcessGDBRemote, but
only "ehframe" was a valid response in th
amccarth created this revision.
amccarth added a reviewer: spyffe.
amccarth added a subscriber: lldb-commits.
http://reviews.llvm.org/D19489
Files:
source/Expression/DiagnosticManager.cpp
Index: source/Expression/DiagnosticManager.cpp
===
amccarth added a subscriber: amccarth.
amccarth added a comment.
FYI: This patch seems to have broken all LLDB testing on Windows. I'll
investigate why.
Lots of the socket calls now result in stack traces like this:
Traceback (most recent call last):
File "C:\python_35\lib\multiprocessi
rengolin added a comment.
In http://reviews.llvm.org/D19480#410762, @tberghammer wrote:
> I committed in this change based on the approval from @labath with the
> Android - EABI support (no hard float) to get the LLDB Android ARM buildbots
> green again. If you have any more question comment th
Author: tberghammer
Date: Mon Apr 25 10:51:45 2016
New Revision: 267422
URL: http://llvm.org/viewvc/llvm-project?rev=267422&view=rev
Log:
Fix ARM attribute parsing for Android after rL267291
Differential revision: http://reviews.llvm.org/D19480
Modified:
lldb/trunk/source/Core/ArchSpec.cpp
tberghammer added a comment.
I committed in this change based on the approval from @labath with the Android
- EABI support (no hard float) to get the LLDB Android ARM buildbots green
again. If you have any more question comment then please let me know and I am
happy to address them with a separ
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267422: Fix ARM attribute parsing for Android after rL267291
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D19480?vs=54854&id=54864#toc
Repository:
rL LLVM
http://revie
Author: tfiala
Date: Mon Apr 25 10:48:34 2016
New Revision: 267421
URL: http://llvm.org/viewvc/llvm-project?rev=267421&view=rev
Log:
skip TestBitfields.py on OS X
tracked by:
https://llvm.org/bugs/show_bug.cgi?id=27515
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/c/bitfields/Test
tberghammer updated this revision to Diff 54854.
tberghammer added a comment.
I updated the diff to only address the soft-flat case (Android-EABI). This
fixes the most important case but I would like to fix the hard-flat case as
well in the not so distant future as we have the same problem (regr
srhines added a comment.
In http://reviews.llvm.org/D19480#410664, @tberghammer wrote:
> This patch only effects debugging (all modified file is part of LLDB).
>
> I want to get the Android <-> EABI part fixed ASAP as a recent LLDB change
> completely broke Android ARM debugging with adding ARM.
tberghammer added a comment.
This patch only effects debugging (all modified file is part of LLDB).
I want to get the Android <-> EABI part fixed ASAP as a recent LLDB change
completely broke Android ARM debugging with adding ARM.Attributes support
(causing Environment mismatch between EABI and
srhines added a comment.
In http://reviews.llvm.org/D19480#410641, @rengolin wrote:
> In http://reviews.llvm.org/D19480#410620, @tberghammer wrote:
>
> > Both executables and shared libraries are containing ARM Attributes what
> > contains the information about soft-float vs hard-float. I am not
rengolin added a comment.
In http://reviews.llvm.org/D19480#410620, @tberghammer wrote:
> Both executables and shared libraries are containing ARM Attributes what
> contains the information about soft-float vs hard-float. I am not sure how
> accurate it is as in theory you can link together an
Author: labath
Date: Mon Apr 25 09:00:23 2016
New Revision: 267407
URL: http://llvm.org/viewvc/llvm-project?rev=267407&view=rev
Log:
Skip TestBitfileds on linux
Test added in r267248 exposed a bug in handling of dwarf produced by
clang>=3.9, which causes a
crash during expression evaluation. Ski
tberghammer added a comment.
Both executables and shared libraries are containing ARM Attributes what
contains the information about soft-float vs hard-float. I am not sure how
accurate it is as in theory you can link together an object file compiled with
soft float with a one compiled with har
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267405: Handle invalid values of PLT entry size generated by
linker (authored by omjavaid).
Changed prior to commit:
http://reviews.llvm.org/D19252?vs=54146&id=54845#toc
Repository:
rL LLVM
http://r
Author: omjavaid
Date: Mon Apr 25 08:45:39 2016
New Revision: 267405
URL: http://llvm.org/viewvc/llvm-project?rev=267405&view=rev
Log:
Handle invalid values of PLT entry size generated by linker
Make sure we figure out correct plt entry field in case linker has generated a
small value below real
rengolin added a comment.
Don't Android libraries output build attributes for ARM? If they do, that's an
easy way to know.
http://reviews.llvm.org/D19480
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Ideally, we'd be able to pick up the fact that we're dealing with an android
shared library just from looking at it, but it seems they don't contain any
information which would identify them a
tberghammer added inline comments.
Comment at: source/Core/ArchSpec.cpp:1017
@@ +1016,3 @@
+// considered to be compatible. This is required as a workaround for
shared libraries compiled
+// for Android without the NOTE section indicating that they are using the
Android
rengolin added inline comments.
Comment at: source/Core/ArchSpec.cpp:1017
@@ +1016,3 @@
+// considered to be compatible. This is required as a workaround for
shared libraries compiled
+// for Android without the NOTE section indicating that they are using the
Android ABI
tberghammer created this revision.
tberghammer added reviewers: labath, compnerd.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer, rengolin, aemerson.
Fix ARM attribute parsing for Android after rL267291
http://reviews.llvm.org/D19480
Files
Author: labath
Date: Mon Apr 25 05:32:23 2016
New Revision: 267392
URL: http://llvm.org/viewvc/llvm-project?rev=267392&view=rev
Log:
Remove flaky decorator from two tests on linux
The flakyness is no longer reproducible, and the tests seem to be passing
reliably now.
Modified:
lldb/trunk/p
59 matches
Mail list logo
