compnerd accepted this revision.
This revision is now accepted and ready to land.
Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:149
@@ +148,3 @@
+{
+spec.SetTriple("armv7-pc-windows");
+specs.Append(Module
krytarowski added a comment.
I had this working with 2.8:
--- source/Plugins/SymbolFile/PDB/CMakeLists.txt.orig 2016-04-27
00:55:50.0 +
+++ source/Plugins/SymbolFile/PDB/CMakeLists.txt
@@ -1,7 +1,11 @@
-set(LLVM_PRIVATE_LINK_COMPONENTS
-DebugInfoPDB)
+#set(LLVM_PRIV
I don't think we should be adding more CMake hacks in lldb when llvm is
supposed to handle this. Why don't the existing lines work?
On Sat, Apr 30, 2016 at 4:24 PM Kamil Rytarowski wrote:
> krytarowski added a comment.
>
> I had this working with 2.8:
>
> --- source/Plugins/SymbolFile/PDB/CMake
krytarowski added a comment.
In http://reviews.llvm.org/D19685#417896, @zturner wrote:
> I don't think we should be adding more CMake hacks in lldb when llvm is
> supposed to handle this. Why don't the existing lines work?
I don't know. Perhaps because LLVM and Clang requires newer cmake than
krytarowski updated this revision to Diff 55729.
krytarowski added a comment.
Set minimal required CMake to 2.8.12.2 - fixes build on NetBSD with CMake 3.5.2
Repository:
rL LLVM
http://reviews.llvm.org/D19685
Files:
CMakeLists.txt
cmake/modules/LLDBStandalone.cmake
Index: cmake/modules/
Can't you just remove that line and let it inherit the minimum version from
LLVM?
On Sat, Apr 30, 2016 at 4:58 PM Kamil Rytarowski wrote:
> krytarowski updated this revision to Diff 55729.
> krytarowski added a comment.
>
> Set minimal required CMake to 2.8.12.2 - fixes build on NetBSD with CMak
krytarowski created this revision.
krytarowski added reviewers: emaste, labath, zturner.
krytarowski added subscribers: lldb-commits, joerg.
krytarowski set the repository for this revision to rL LLVM.
NetBSD ships with pkgsrc that installs versioned Python executables with
suffix, like: python2.
krytarowski added a comment.
In http://reviews.llvm.org/D19685#417911, @zturner wrote:
> Can't you just remove that line and let it inherit the minimum version from
> LLVM?
It doesn't work.
CMake Warning (dev) in CMakeLists.txt:
No cmake_minimum_required command is present. A line of c
Ahh ok. Well setting it to 2.8.12 is still fine, if that fixes the problem
with no other changes then that seems like the best fix.
On Sat, Apr 30, 2016 at 5:23 PM Kamil Rytarowski wrote:
> krytarowski added a comment.
>
> In http://reviews.llvm.org/D19685#417911, @zturner wrote:
>
> > Can't yo
Don't we already call FindPythonInterp from somewhere else in the LLDB's
CMake files?
On Sat, Apr 30, 2016 at 5:17 PM Kamil Rytarowski wrote:
> krytarowski created this revision.
> krytarowski added reviewers: emaste, labath, zturner.
> krytarowski added subscribers: lldb-commits, joerg.
> kryta
zturner added a subscriber: zturner.
zturner added a comment.
Don't we already call FindPythonInterp from somewhere else in the LLDB's
CMake files?
Repository:
rL LLVM
http://reviews.llvm.org/D19772
___
lldb-commits mailing list
lldb-commits@list
krytarowski added a comment.
In http://reviews.llvm.org/D19772#417922, @zturner wrote:
> Don't we already call FindPythonInterp from somewhere else in the LLDB's
> CMake files?
$ git grep FindPythonInterp
cmake/modules/LLDBStandalone.cmake:include(FindPythonInterp)
scripts/Python/m
krytarowski added a comment.
In http://reviews.llvm.org/D19685#417919, @zturner wrote:
> Ahh ok. Well setting it to 2.8.12 is still fine, if that fixes the problem
> with no other changes then that seems like the best fix.
No other changes are needed.
Repository:
rL LLVM
http://reviews.l
zturner added inline comments.
Comment at: scripts/CMakeLists.txt:12
@@ -11,1 +11,3 @@
+include(FindPythonInterp)
+
Is the problem that `PYTHON_EXECUTABLE` is not set? I see a call to
`include(FindPythonInterp)` in `llvm/CMakeLists.txt`. Is the value getting
krytarowski added a comment.
I'm using standalone build, it may be the reason why this value isn't inherited.
Repository:
rL LLVM
http://reviews.llvm.org/D19772
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
Ahh makes sense. In that case maybe this line should go in
LLDBStandalone.cmake?
On Sat, Apr 30, 2016 at 6:15 PM Kamil Rytarowski wrote:
> krytarowski added a comment.
>
> I'm using standalone build, it may be the reason why this value isn't
> inherited.
>
>
> Repository:
> rL LLVM
>
> http://r
zturner added a comment.
Ahh makes sense. In that case maybe this line should go in
LLDBStandalone.cmake?
Repository:
rL LLVM
http://reviews.llvm.org/D19772
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
krytarowski added a comment.
If the change should go to LLDBStandalone.cmake -- can I just put there in one
go all the bits for standalone builds?
--- cmake/modules/LLDBStandalone.cmake.orig 2016-04-27 00:55:49.0
+
+++ cmake/modules/LLDBStandalone.cmake
@@ -2,61 +2,82 @@
I'm not sure anyone else uses the standalone build, so as long as the
changes you're making are confined to LLDBStandalone, it should be fine
On Sat, Apr 30, 2016 at 6:41 PM Kamil Rytarowski wrote:
> krytarowski added a comment.
>
> If the change should go to LLDBStandalone.cmake -- can I just pu
zturner added a comment.
I'm not sure anyone else uses the standalone build, so as long as the
changes you're making are confined to LLDBStandalone, it should be fine
Repository:
rL LLVM
http://reviews.llvm.org/D19772
___
lldb-commits mailing lis
krytarowski added a comment.
Great! I think I will close
In http://reviews.llvm.org/D19772#417952, @zturner wrote:
> I'm not sure anyone else uses the standalone build, so as long as the
> changes you're making are confined to LLDBStandalone, it should be fine
Thanks!
I think I can close thi
zturner added a comment.
Yea, just don't bump the minimum CMake version past 2.8.12
Repository:
rL LLVM
http://reviews.llvm.org/D19772
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
Yea, just don't bump the minimum CMake version past 2.8.12
On Sat, Apr 30, 2016 at 6:56 PM Kamil Rytarowski wrote:
> krytarowski added a comment.
>
> Great! I think I will close
>
> In http://reviews.llvm.org/D19772#417952, @zturner wrote:
>
> > I'm not sure anyone else uses the standalone build,
23 matches
Mail list logo
