Re: [Lldb-commits] [PATCH] D9740: Add MiSyntaxTestCase.test_lldbmi_output_grammar test (MI)

2016-09-11 Thread Ilia K via lldb-commits
ki.stfu updated this revision to Diff 70977. ki.stfu added a comment. Herald added a subscriber: ki.stfu. Rebase against ToT https://reviews.llvm.org/D9740 Files: packages/Python/lldbsuite/test/tools/lldb-mi/syntax/TestMiSyntax.py tools/lldb-mi/MIDriver.cpp Index: tools/lldb-mi/MIDriver.cp

Re: [Lldb-commits] [PATCH] D24202: [lldb-mi] Fix parsing expressions to evaluate with spaces and optional args

2016-09-11 Thread Ilia K via lldb-commits
ki.stfu accepted this revision. ki.stfu added a comment. This revision is now accepted and ready to land. lgtm @edmunoz, good job. Thank you! Would you like me to commit? Repository: rL LLVM https://reviews.llvm.org/D24202 ___ lldb-commits maili

Re: [Lldb-commits] [PATCH] D23026: [LLDB-MI] removing requirement of a parameter for -break-insert's -f flag

2016-09-11 Thread Ilia K via lldb-commits
ki.stfu added a comment. PS: I think it will look like: Index: tools/lldb-mi/MICmdCmdBreak.cpp === --- tools/lldb-mi/MICmdCmdBreak.cpp (revision 281191) +++ tools/lldb-mi/MICmdCmdBreak.cpp (working copy) @@ -84,8 +84,7

Re: [Lldb-commits] [PATCH] D23026: [LLDB-MI] removing requirement of a parameter for -break-insert's -f flag

2016-09-11 Thread Ilia K via lldb-commits
ki.stfu requested changes to this revision. ki.stfu added a comment. This revision now requires changes to proceed. Hi @pieandcakes! I'm sorry for the delay, have a lot of work. Please folllow my inline comments, rebase against ToT and update CL's summary. Comment at: tools/ll

Re: [Lldb-commits] [PATCH] D23883: Remove MIUtilParse (no longer used)

2016-09-11 Thread Ilia K via lldb-commits
ki.stfu requested changes to this revision. ki.stfu added a reviewer: ki.stfu. ki.stfu added a comment. This revision now requires changes to proceed. You forgot to remove its header file https://reviews.llvm.org/D23883 ___ lldb-commits mailing list

[Lldb-commits] [lldb] r281191 - Fix about a dozen compile warnings

2016-09-11 Thread Ilia K via lldb-commits
Author: ki.stfu Date: Mon Sep 12 00:25:33 2016 New Revision: 281191 URL: http://llvm.org/viewvc/llvm-project?rev=281191&view=rev Log: Fix about a dozen compile warnings Summary: It fixes the following compile warnings: 1. '0' flag ignored with precision and ā€˜%dā€™ gnu_printf format 2. enumeral and

Re: [Lldb-commits] [PATCH] D24331: Fix about a dozen compile warnings

2016-09-11 Thread Ilia K via lldb-commits
ki.stfu updated this revision to Diff 70976. ki.stfu added a comment. Apply clang-format https://reviews.llvm.org/D24331 Files: source/Core/Log.cpp source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp source/Plugins/Process/elf-core/Proces

Re: [Lldb-commits] [PATCH] D24331: Fix about a dozen compile warnings

2016-09-11 Thread Ilia K via lldb-commits
ki.stfu updated this revision to Diff 70973. ki.stfu added a comment. Rebase against ToT https://reviews.llvm.org/D24331 Files: source/Core/Log.cpp source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp source/Plugins/Process/elf-core/Proces

Re: [Lldb-commits] [PATCH] D23883: Remove MIUtilParse (no longer used)

2016-09-11 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. In https://reviews.llvm.org/D23883#539471, @mgorny wrote: > In https://reviews.llvm.org/D23883#539442, @krytarowski wrote: > > > It looks good. Remaining TODO for standalone builds: > > > > - sanitize six.py usage (it's installed into system-wide directory, where > >