[Lldb-commits] [PATCH] D26553: Remove weak-linked symbols for SBBreakpointListImpl

This revision was automatically updated to reflect the committed changes. Closed by commit rL286631: Remove weak-linked symbols for SBBreakpointListImpl (authored by tfiala). Changed prior to commit: https://reviews.llvm.org/D26553?vs=77639=77662#toc Repository: rL LLVM

[Lldb-commits] [lldb] r286631 - Remove weak-linked symbols for SBBreakpointListImpl

Author: tfiala Date: Fri Nov 11 15:06:40 2016 New Revision: 286631 URL: http://llvm.org/viewvc/llvm-project?rev=286631=rev Log: Remove weak-linked symbols for SBBreakpointListImpl Summary: Similar to SBStructuredData's Impl class, SBBreakpointListImpl was getting weak-link exported in the lldb

[Lldb-commits] [PATCH] D26553: Remove weak-linked symbols for SBBreakpointListImpl

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This looks fine. https://reviews.llvm.org/D26553 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D26553: Remove weak-linked symbols for SBBreakpointListImpl

tfiala created this revision. tfiala added a reviewer: jingham. tfiala added a subscriber: lldb-commits. Similar to SBStructuredData's Impl class, SBBreakpointListImpl was getting weak-link exported in the lldb namespace. This change list fixes that by moving out of the lldb public namespace,

Re: [Lldb-commits] [PATCH] D26528: Fix uninitialized members.

I think we can just add it to LLVM Coding Standards page. I think part of why it's not used more often is that people just don't know about it, so that would help increase the visibility for everyone. On Fri, Nov 11, 2016 at 10:51 AM Jim Ingham

Re: [Lldb-commits] [lldb] r286581 - Fix TestHelp on linux after version number syntax change

Thank you for fixing this! It was my bad. -Chris > On Nov 11, 2016, at 3:39 AM, Tamas Berghammer via lldb-commits > wrote: > > Author: tberghammer > Date: Fri Nov 11 05:39:23 2016 > New Revision: 286581 > > URL: http://llvm.org/viewvc/llvm-project?rev=286581=rev

Re: [Lldb-commits] [PATCH] D26528: Fix uninitialized members.

Is it worthwhile having some place where we can put this sort of policy so people don't have to follow our mailing list to know this sort of rule? The coding conventions were one possible site, but that fell victim to the code reformat... Jim > On Nov 11, 2016, at 9:11 AM, Zachary Turner

Re: [Lldb-commits] [PATCH] D26528: Fix uninitialized members.

Yea, I agree doing it for a whole class at a time should be the standard On Fri, Nov 11, 2016 at 9:10 AM Jim Ingham wrote: > > > On Nov 10, 2016, at 8:57 PM, Zachary Turner via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > > > > Maybe just inline the initializations

Re: [Lldb-commits] [PATCH] D26528: Fix uninitialized members.

> On Nov 10, 2016, at 8:57 PM, Zachary Turner via lldb-commits > wrote: > > Maybe just inline the initializations so we don't have to repeat code across > multiple constructors? i.e. > > bool m_is_resolved = false; > > in the header file. I actually like the

[Lldb-commits] [PATCH] D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files

dvlahovski updated this revision to Diff 77626. dvlahovski marked an inline comment as done. dvlahovski added a comment. Use unique_ptr instead of shared_ptr https://reviews.llvm.org/D26300 Files: packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/TestLinuxCore.py

[Lldb-commits] [lldb] r286581 - Fix TestHelp on linux after version number syntax change

Author: tberghammer Date: Fri Nov 11 05:39:23 2016 New Revision: 286581 URL: http://llvm.org/viewvc/llvm-project?rev=286581=rev Log: Fix TestHelp on linux after version number syntax change Modified: lldb/trunk/packages/Python/lldbsuite/test/help/TestHelp.py Modified:

[Lldb-commits] [PATCH] D26542: [LLDB][MIPS] Fix some test case failures due to "elf_abi" field of qprocessInfo packet

nitesh.jain added a comment. The elf_abi field was introduced in qprocessInfo packet (commit https://reviews.llvm.org/rL284001) so that LLDB can set pointer size and parse aux vector accordingly. This patch fix some test cases failures by introducing this field in _KNOWN_PROCESS_INFO_KEYS.

[Lldb-commits] [PATCH] D26542: [LLDB][MIPS] Fix some test case failures due to "elf_abi" field of qprocessInfo packet

nitesh.jain created this revision. nitesh.jain added reviewers: jaydeep, bhushan, clayborg. nitesh.jain added subscribers: lldb-commits, slthakur. https://reviews.llvm.org/D26542 Files: packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py Index:

[Lldb-commits] [lldb] r286574 - Mark xfail TestNamespaceDefinitions for arm/aarch64 targets

Author: omjavaid Date: Fri Nov 11 04:00:53 2016 New Revision: 286574 URL: http://llvm.org/viewvc/llvm-project?rev=286574=rev Log: Mark xfail TestNamespaceDefinitions for arm/aarch64 targets Fails with all versions of arm/aarch64 gcc available on ubuntu 16.04/14.04. Passes with Linaro GCC