[Lldb-commits] [lldb] r296855 - Remove some dead code in FileSpec.

Author: zturner Date: Fri Mar 3 00:14:38 2017 New Revision: 296855 URL: http://llvm.org/viewvc/llvm-project?rev=296855=rev Log: Remove some dead code in FileSpec. This in turn triggered some fallout where other files had been transitively picking up includes that they needed from FileSpec.h, so

[Lldb-commits] [PATCH] D30560: Split DataExtractor into two classes.

zturner updated this revision to Diff 90432. zturner added a comment. I basically turned the two dump methods into free functions and moved the DWARF specific function into `DWARFCallFrameInfo.cpp`. I think this is much better than before, as we don't muck with the inheritance hierarchy at all

Re: [Lldb-commits] [PATCH] D30560: Split DataExtractor into two classes.

I was actually thinking of making the dump functions free functions that take a const DataExtractor&. This way the entire implementation could remain unchanged with the exception of replacing implicit member variable reads with reads through an explicit instance of the extractor. This way we

[Lldb-commits] [PATCH] D30560: Split DataExtractor into two classes.

jingham added a comment. The EH stuff should definitely go in a specific subclass. It also seems a shame to lose the capability to Dump DataExtractors in general. The only thing the exe_scope is used for in Dump (which is what is causing you problems) is to print instructions, and to do a

Re: [Lldb-commits] [PATCH] D30560: Split DataExtractor into two classes.

Tbh I felt dirty calling it Ex, so thanks for calling me out on it :) I'll whip up some changes later On Thu, Mar 2, 2017 at 6:09 PM Jim Ingham via Phabricator < revi...@reviews.llvm.org> wrote: > jingham added a comment. > > Is it horrible of me to ask that we choose a name that is more

[Lldb-commits] [PATCH] D30560: Split DataExtractor into two classes.

jingham added a comment. Is it horrible of me to ask that we choose a name that is more descriptive than DataExtractorEx? That "Ex" extension to a class name is just such a punt, and I'd really rather not encourage it. The subclass you made adds the ability to: (a) Dump itself (b) Extract

[Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions

jingham added a comment. I added a few comments. It doesn't look like you addressed Pavel's idea for testing more of the code path you're introducing. Do you plan to do that? Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:3766-3776 +

[Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions

eugene updated this revision to Diff 90407. eugene added a comment. Addressing code review commends, and moving a signal filtering method to the base Process class. https://reviews.llvm.org/D30520 Files: include/lldb/Target/Process.h include/lldb/Target/UnixSignals.h

[Lldb-commits] [lldb] r296833 - Mention fetching thread lists lazily.

Author: jingham Date: Thu Mar 2 16:13:45 2017 New Revision: 296833 URL: http://llvm.org/viewvc/llvm-project?rev=296833=rev Log: Mention fetching thread lists lazily. Modified: lldb/trunk/www/projects.html Modified: lldb/trunk/www/projects.html URL:

[Lldb-commits] [lldb] r296826 - Forgot about local variable lookup.

Author: jingham Date: Thu Mar 2 16:04:05 2017 New Revision: 296826 URL: http://llvm.org/viewvc/llvm-project?rev=296826=rev Log: Forgot about local variable lookup. Yay for coffee lines. Modified: lldb/trunk/www/projects.html Modified: lldb/trunk/www/projects.html URL:

Re: [Lldb-commits] [lldb] r296814 - Added a list of outstanding projects that would benefit lldb.

Nice list, thanks! On Thu, Mar 2, 2017 at 1:51 PM Jim Ingham via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: jingham > Date: Thu Mar 2 15:39:27 2017 > New Revision: 296814 > > URL: http://llvm.org/viewvc/llvm-project?rev=296814=rev > Log: > Added a list of outstanding projects

[Lldb-commits] [lldb] r296814 - Added a list of outstanding projects that would benefit lldb.

Author: jingham Date: Thu Mar 2 15:39:27 2017 New Revision: 296814 URL: http://llvm.org/viewvc/llvm-project?rev=296814=rev Log: Added a list of outstanding projects that would benefit lldb. This was a list that I've had kicking around for a while, and would add to whenever some hallway

Re: [Lldb-commits] [lldb] r296717 - Fix various warnings. NFC

FAILED: C:\PROGRA~2\MICROS~3.0\VC\bin\cl.exe /nologo /TP -DGTEST_HAS_RTTI=0 -DLLDB_DISABLE_CURSES -DLLDB_DISABLE_LIBEDIT -DLLDB_PYTHON_HOME=\"C:/Users/lldb_build/ll/prebuilts/python-2015/x86\" -DLLDB_USE_BUILTIN_DEMANGLER -DLLVM_BUILD_GLOBAL_ISEL -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE

Re: [Lldb-commits] [lldb] r296717 - Fix various warnings. NFC

What capture does it say is missing? Also what version of msvc? On Thu, Mar 2, 2017 at 7:17 AM Zachary Turner wrote: > Clang-cl > On Thu, Mar 2, 2017 at 2:51 AM Pavel Labath wrote: > > > On 2 March 2017 at 00:05, Zachary Turner via lldb-commits < >

Re: [Lldb-commits] [lldb] r296717 - Fix various warnings. NFC

Clang-cl On Thu, Mar 2, 2017 at 2:51 AM Pavel Labath wrote: > > On 2 March 2017 at 00:05, Zachary Turner via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > > -DumpValueObjectOptions::DeclPrintingHelper helper = > -[_sp, qualify_cxx_base_classes]( > -

[Lldb-commits] [PATCH] D30457: [LLDB][MIPS] Core Dump Support

nitesh.jain marked an inline comment as done. nitesh.jain added a comment. The .note.ABI-tag is missing in the ELF file, generated by test/testcases/functionalities/postmortem/elf-core/make-core.sh. Need to look into it. -Thanks https://reviews.llvm.org/D30457

[Lldb-commits] [PATCH] D30457: [LLDB][MIPS] Core Dump Support

nitesh.jain marked an inline comment as done. nitesh.jain added inline comments. Comment at: source/Plugins/Process/Utility/RegisterInfoInterface.h:32 + virtual const lldb_private::RegisterSet * + GetRegisterSet(size_t set) const {return nullptr;} labath

[Lldb-commits] [PATCH] D30457: [LLDB][MIPS] Core Dump Support

nitesh.jain updated this revision to Diff 90328. nitesh.jain added a comment. Update diff as per suggestion. https://reviews.llvm.org/D30457 Files: source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_mips64.h source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp

[Lldb-commits] [lldb] r296741 - Fix flakyness in TestGdbRemoteHostInfo

Author: labath Date: Thu Mar 2 05:36:14 2017 New Revision: 296741 URL: http://llvm.org/viewvc/llvm-project?rev=296741=rev Log: Fix flakyness in TestGdbRemoteHostInfo this test was using the VPATH hack to avoid having a copy of the inferior source code. This makes the test fail if in happens to

[Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions

labath added a comment. Jim's comment about putting the function in the parent class makes sense -- apart from remote stubs I guess you could also envision other ways a process class could speed up signal processing in case it know we don't care about them). Jim: do you have a idea about how

Re: [Lldb-commits] [lldb] r296717 - Fix various warnings. NFC

On 2 March 2017 at 00:05, Zachary Turner via lldb-commits < lldb-commits@lists.llvm.org> wrote: > -DumpValueObjectOptions::DeclPrintingHelper helper = > -[_sp, qualify_cxx_base_classes]( > -ConstString type, ConstString var, > -const DumpValueObjectOptions ,

[Lldb-commits] [lldb] r296738 - Fix MSVC build

Author: labath Date: Thu Mar 2 04:35:53 2017 New Revision: 296738 URL: http://llvm.org/viewvc/llvm-project?rev=296738=rev Log: Fix MSVC build MSVC (at least the version I am using) does not want to implicitly capture a const bool variable. Move it into the lambda, as it is not used outside

[Lldb-commits] [PATCH] D30454: [LLDB][MIPS] Fix typo in MatchesModuleSpec()

nitesh.jain added a comment. Attach log file F3122646: module.log https://reviews.llvm.org/D30454 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D30454: [LLDB][MIPS] Fix typo in MatchesModuleSpec()

nitesh.jain added a comment. The issue was observed while parsing "vdso module" for the core file. When the DynamicLoader::LoadModuleAtAddress is called to load "vdso" module. Since "vdso" doesn't match with any of the module in the target.GetImages(), the check_alternative_file_name becomes