[Lldb-commits] [lldb] r305873 - Fix a python object leak in SWIG glue.

2017-06-20 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Jun 20 20:52:37 2017 New Revision: 305873 URL: http://llvm.org/viewvc/llvm-project?rev=305873&view=rev Log: Fix a python object leak in SWIG glue. PyObject_CallFunction returns a PyObject which needs to be decref'ed when it is no longer needed. Patch by David Luyer Diff

Re: [Lldb-commits] [PATCH] D34400: Move Connection from Core to Host

2017-06-20 Thread Pavel Labath via lldb-commits
On 20 June 2017 at 16:47, Zachary Turner wrote: > I do think at some point we will need to break up Host, but whether the best > way is to move stuff into Utility or to somewhere else is an open question. > Host also depends on Target, Symbol, process plugins, and various other > things. So we wil

Re: [Lldb-commits] [PATCH] D34400: Move Connection from Core to Host

2017-06-20 Thread Zachary Turner via lldb-commits
I do think at some point we will need to break up Host, but whether the best way is to move stuff into Utility or to somewhere else is an open question. Host also depends on Target, Symbol, process plugins, and various other things. So we will need a way to group together all the stuff in Host that

Re: [Lldb-commits] [PATCH] D34400: Move Connection from Core to Host

2017-06-20 Thread Pavel Labath via lldb-commits
On 20 June 2017 at 14:28, Zachary Turner wrote: > I had actually been considering going the other way. Moving connection and > all implementations to Utility. Host is a big contributor to the dependency > problems, so putting more stuff in seems like the wrong direction. Well, I'd say that Core i

[Lldb-commits] [lldb] r305794 - Correct syntax mistake hidden in assert(3)

2017-06-20 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Tue Jun 20 08:51:06 2017 New Revision: 305794 URL: http://llvm.org/viewvc/llvm-project?rev=305794&view=rev Log: Correct syntax mistake hidden in assert(3) wait_status cannot be compared with WaitStatus::Stop, go for wait_status.type. Modified: lldb/trunk/source/Plugins/Pr

Re: [Lldb-commits] [PATCH] D34400: Move Connection from Core to Host

2017-06-20 Thread Zachary Turner via lldb-commits
I had actually been considering going the other way. Moving connection and all implementations to Utility. Host is a big contributor to the dependency problems, so putting more stuff in seems like the wrong direction. The end state i had in mind was similar to llvm support (which is more less the

[Lldb-commits] [PATCH] D34400: Move Connection from Core to Host

2017-06-20 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. Herald added a subscriber: mgorny. All implementations of the connection interface live in the Host module already, so it makes sense for the interface itself to be defined there. https://reviews.llvm.org/D34400 Files: include/lldb/Core/Connection.h include/lld

[Lldb-commits] [lldb] r305789 - Delete a lot of empty directories in test/

2017-06-20 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Jun 20 06:23:36 2017 New Revision: 305789 URL: http://llvm.org/viewvc/llvm-project?rev=305789&view=rev Log: Delete a lot of empty directories in test/ The files in those directories have been moved to packages/Python/lldbsuite/test quite a while ago. However, the director

[Lldb-commits] [PATCH] D34352: [linux] Change the way we load vdso pseudo-module

2017-06-20 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL305780: [linux] Change the way we load vdso pseudo-module (authored by labath). Changed prior to commit: https://reviews.llvm.org/D34352?vs=103045&id=103170#toc Repository: rL LLVM https://reviews.l

[Lldb-commits] [lldb] r305780 - [linux] Change the way we load vdso pseudo-module

2017-06-20 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Jun 20 03:11:47 2017 New Revision: 305780 URL: http://llvm.org/viewvc/llvm-project?rev=305780&view=rev Log: [linux] Change the way we load vdso pseudo-module Summary: This is basically a revert of D16107 and parts of D10800, which were trying to get vdso loading working.

[Lldb-commits] [PATCH] D34274: Remove home-grown thread-local storage wrappers

2017-06-20 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL305779: Remove home-grown thread-local storage wrappers (authored by labath). Changed prior to commit: https://reviews.llvm.org/D34274?vs=102810&id=103169#toc Repository: rL LLVM https://reviews.llv

[Lldb-commits] [lldb] r305779 - Remove home-grown thread-local storage wrappers

2017-06-20 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Jun 20 03:11:43 2017 New Revision: 305779 URL: http://llvm.org/viewvc/llvm-project?rev=305779&view=rev Log: Remove home-grown thread-local storage wrappers Summary: Use c++11 thread_local variables instead. As far as I am aware, they are supported by all compilers/targets

[Lldb-commits] [lldb] r305778 - ProcessLauncherPosixFork: Fetch errno early

2017-06-20 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Jun 20 03:11:37 2017 New Revision: 305778 URL: http://llvm.org/viewvc/llvm-project?rev=305778&view=rev Log: ProcessLauncherPosixFork: Fetch errno early I was seeing some unlikely errno values here. I am not sure if this will help, but it nontheless seems like a good idea