[Lldb-commits] [lldb] r346848 - [LLDB] - Support the single file split DWARF.

Author: grimar Date: Wed Nov 14 02:35:14 2018 New Revision: 346848 URL: http://llvm.org/viewvc/llvm-project?rev=346848&view=rev Log: [LLDB] - Support the single file split DWARF. DWARF5 spec describes a single file split dwarf case (when .dwo sections are in the .o files). Problem is that LLDB d

[Lldb-commits] [PATCH] D52403: [LLDB] - Support the single file split DWARF.

grimar closed this revision. grimar added a comment. Committed as https://reviews.llvm.org/rLLDB346848. The commit message has a wrong review link by mistake. https://reviews.llvm.org/D52403 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r346849 - Fix a crash when parsing incorrect DWARF

Author: labath Date: Wed Nov 14 03:12:40 2018 New Revision: 346849 URL: http://llvm.org/viewvc/llvm-project?rev=346849&view=rev Log: Fix a crash when parsing incorrect DWARF Summary: While parsing a childless compile unit DIE we could crash if the DIE was followed by any extra data (such as a sup

[Lldb-commits] [PATCH] D54417: Fix a crash when parsing incorrect DWARF

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB346849: Fix a crash when parsing incorrect DWARF (authored by labath, committed by ). Herald added a subscriber: abidh. Changed prior to commit: https://reviews.llvm.org/D54417?vs=173634&id=174006#to

[Lldb-commits] [lldb] r346853 - Revert r346848 "[LLDB] - Support the single file split DWARF."

Author: grimar Date: Wed Nov 14 04:04:31 2018 New Revision: 346853 URL: http://llvm.org/viewvc/llvm-project?rev=346853&view=rev Log: Revert r346848 "[LLDB] - Support the single file split DWARF." It broke BB: http://green.lab.llvm.org/green/job/lldb-cmake/12522/testReport/junit/LLDB/Breakpoint/si

[Lldb-commits] [lldb] r346855 - [LLDB] - Recommit r346848 "[LLDB] - Support the single file split DWARF.".

Author: grimar Date: Wed Nov 14 05:01:15 2018 New Revision: 346855 URL: http://llvm.org/viewvc/llvm-project?rev=346855&view=rev Log: [LLDB] - Recommit r346848 "[LLDB] - Support the single file split DWARF.". Test cases were updated to not use the local compilation dir which is different between d

[Lldb-commits] [lldb] r346867 - Move DataExtractorTest to unittests/Utility

Author: labath Date: Wed Nov 14 06:58:36 2018 New Revision: 346867 URL: http://llvm.org/viewvc/llvm-project?rev=346867&view=rev Log: Move DataExtractorTest to unittests/Utility The DataExtractor class itself was moved to Utility some time ago, but it seems this was not reflected in the location o

[Lldb-commits] [PATCH] D54476: [CMake] Streamline code signing for debugserver

sgraenitz updated this revision to Diff 174053. sgraenitz marked 4 inline comments as done. sgraenitz added a comment. debugserver cannot be ad-hoc code signed; handle entitlements&identity also in standalone debugserver, add feasibility checks, polishing https://reviews.llvm.org/D54476 Files:

[Lldb-commits] [PATCH] D54476: [CMake] Streamline code signing for debugserver

sgraenitz marked 2 inline comments as not done. sgraenitz added inline comments. Comment at: tools/debugserver/source/CMakeLists.txt:128-133 +# TODO: Following the old behavior, DEBUGSERVER_PATH still points to the +# original system binary, even if we copy it over. Keep

Re: [Lldb-commits] [lldb] r346783 - [Cocoa] Implement formatter for the new NSDate representation.

On Tue, Nov 13, 2018 at 11:46 AM Davide Italiano via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: davide > Date: Tue Nov 13 11:43:43 2018 > New Revision: 346783 > > URL: http://llvm.org/viewvc/llvm-project?rev=346783&view=rev > Log: > [Cocoa] Implement formatter for the new NSDate

Re: [Lldb-commits] [lldb] r346783 - [Cocoa] Implement formatter for the new NSDate representation.

On Tue, Nov 13, 2018 at 11:46 AM Davide Italiano via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: davide > Date: Tue Nov 13 11:43:43 2018 > New Revision: 346783 > > URL: http://llvm.org/viewvc/llvm-project?rev=346783&view=rev > Log: > [Cocoa] Implement formatter for the new NSDate

Re: [Lldb-commits] [PATCH] D54009: Refactor LLDB lit configuration files

Simplifying (and making things more robust in the process) sounds great to me. I think the current iteration of how parameters are passed to the tests is quite complicated and unclear, so this will be a step in the right direction and if there’s a need for gcc later, we can take the time to desi

[Lldb-commits] [lldb] r346873 - Fix some compilation failures introduced in recent patches.

Author: zturner Date: Wed Nov 14 09:22:09 2018 New Revision: 346873 URL: http://llvm.org/viewvc/llvm-project?rev=346873&view=rev Log: Fix some compilation failures introduced in recent patches. This fixes two compilation failures: 1) Designated initializers are C++20. We can't use them in LLV

[Lldb-commits] [PATCH] D54528: [lldb] NFC: Remove the extra ';'

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM, thank you for fixing this. Repository: rLLDB LLDB https://reviews.llvm.org/D54528 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [PATCH] D54443: [CMake] Accept ENTITLEMENTS in add_llvm_executable and llvm_codesign

sgraenitz updated this revision to Diff 174055. sgraenitz added a comment. Remove force option Repository: rL LLVM https://reviews.llvm.org/D54443 Files: CMakeLists.txt cmake/modules/AddLLVM.cmake Index: cmake/modules/AddLLVM.cmake ==

[Lldb-commits] [PATCH] D54444: [CMake] Use extended llvm_codesign to pass entitlements for lldb-server

aprantl added a comment. Why does lldb-server need to be signed? I was under the impression that on macOS lldb-server is not used? Or are we building it for testing and need sign it because of that? https://reviews.llvm.org/D5 ___ lldb-commits

[Lldb-commits] [PATCH] D54443: [CMake] Accept ENTITLEMENTS in add_llvm_executable and llvm_codesign

sgraenitz added a comment. Two use-cases for executables: LLDB lldb-server https://reviews.llvm.org/D5 LLDB debugserver https://reviews.llvm.org/D54476 I have no use-case for shared libraries (yet), so I didn't add ENTITLEMENTS there. Is that ok? Repository: rL LLVM https://reviews.llvm

[Lldb-commits] [PATCH] D54444: [CMake] Use extended llvm_codesign to pass entitlements for lldb-server

sgraenitz added a comment. In Xcode we have ad-hoc signing when targeting iOS and signing with entitlements in case of macOS for lldb-server. https://reviews.llvm.org/D5 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llv

[Lldb-commits] [PATCH] D54444: [CMake] Use extended llvm_codesign to pass entitlements for lldb-server

sgraenitz added a comment. + LLDB.framework has lldb-server as a dependency there. Not sure if it's (really) necessary, though. https://reviews.llvm.org/D5 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[Lldb-commits] [PATCH] D54444: [CMake] Use extended llvm_codesign to pass entitlements for lldb-server

jingham added a comment. We do use lldb-server, though only in the platform mode, for remote testsuite running. The gdbserver mode doesn't do anything for a macOS hosted lldb-server, so lldb-server should not require any entitlements. But we do use it. https://reviews.llvm.org/D5 ___

[Lldb-commits] [PATCH] D54221: Add setting to require hardware breakpoints.

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. The lldb API's parameters are ordered input first than output. Pretty much all the API's that take a Status as a parameter take it as the last parameter. So it looks weird to hav

Re: [Lldb-commits] [PATCH] D54009: Refactor LLDB lit configuration files

I think I have a pretty good handle on what the problems are. I'm honestly surprised the lit test suite ever worked, even before my patch that "broke" it. We were basically just picking up whatever the system PATH was and just going with it, so a lot of the substitutions weren't actually substitu

[Lldb-commits] [PATCH] D54221: Add setting to require hardware breakpoints.

JDevlieghere updated this revision to Diff 174091. JDevlieghere added a comment. Feedback Jim: move argument to the end of the list. https://reviews.llvm.org/D54221 Files: include/lldb/API/SBBreakpoint.h include/lldb/API/SBThreadPlan.h include/lldb/Breakpoint/Breakpoint.h include/lldb/T

[Lldb-commits] [lldb] r346900 - update xcode project file for reproducers.

Author: jmolenda Date: Wed Nov 14 14:14:07 2018 New Revision: 346900 URL: http://llvm.org/viewvc/llvm-project?rev=346900&view=rev Log: update xcode project file for reproducers. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL: http

[Lldb-commits] [PATCH] D54221: Add setting to require hardware breakpoints.

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Looks good to me. https://reviews.llvm.org/D54221 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[Lldb-commits] [lldb] r346906 - Remove the expectedFlakeyDsym decorator. It's not useful anymore.

Author: adrian Date: Wed Nov 14 14:54:43 2018 New Revision: 346906 URL: http://llvm.org/viewvc/llvm-project?rev=346906&view=rev Log: Remove the expectedFlakeyDsym decorator. It's not useful anymore. Modified: lldb/trunk/packages/Python/lldbsuite/test/decorators.py lldb/trunk/packages/Pyt

[Lldb-commits] [lldb] r346919 - [reproducer] Post-commit cleanup

Author: jdevlieghere Date: Wed Nov 14 17:05:40 2018 New Revision: 346919 URL: http://llvm.org/viewvc/llvm-project?rev=346919&view=rev Log: [reproducer] Post-commit cleanup After committing the initial reproducer feature I noticed a few small issues which warranted addressing here. It fixes incorr

[Lldb-commits] [lldb] r346921 - Fix copy/paste mistake for r346919.

Author: jdevlieghere Date: Wed Nov 14 17:18:16 2018 New Revision: 346921 URL: http://llvm.org/viewvc/llvm-project?rev=346921&view=rev Log: Fix copy/paste mistake for r346919. Modified: lldb/trunk/source/Core/Debugger.cpp Modified: lldb/trunk/source/Core/Debugger.cpp URL: http://llvm.org/vie

[Lldb-commits] [lldb] r346920 - Add setting to require hardware breakpoints.

Author: jdevlieghere Date: Wed Nov 14 17:18:15 2018 New Revision: 346920 URL: http://llvm.org/viewvc/llvm-project?rev=346920&view=rev Log: Add setting to require hardware breakpoints. When debugging read-only memory we cannot use software breakpoint. We already have support for hardware breakpoin

[Lldb-commits] [PATCH] D54221: Add setting to require hardware breakpoints.

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB346920: Add setting to require hardware breakpoints. (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D54221?vs=174091&id=174136#toc Repository: rLLDB L

[Lldb-commits] [lldb] r346932 - Fix a use-after-free of the ABI plugin.

Author: zturner Date: Wed Nov 14 21:06:59 2018 New Revision: 346932 URL: http://llvm.org/viewvc/llvm-project?rev=346932&view=rev Log: Fix a use-after-free of the ABI plugin. This was introduced in r346775. Previously the ABI shared_ptr was declared as a function local static meaning it would liv

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

zturner created this revision. zturner added reviewers: stella.stamenova, labath, aleksandr.urakov, rnk. Herald added subscribers: jfb, arphaman, delcypher, JDevlieghere, aheejin, aprantl, mgorny. Herald added a reviewer: alexshap. Recently I tried to port LLDB's lit configuration files over to u