[Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

labath added a comment. In D56293#1345790 , @zturner wrote: > I don't think we can check in an executable file, we should try to compile it > on the spot. We have 1-2 existing unit tests that check in an exe and we > occasionally get reports that people

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

labath added a comment. I was under the impression I've convinced you of this direction, but your questions make it sound like you're going back to the "standalone" breakpad file idea (which I am not fond of). I'll try to explain again what I'm doing here. This is going to be somewhat repetitiv

[Lldb-commits] [lldb] r350384 - Symtab: Remove one copy of symbol size computation code

Author: labath Date: Fri Jan 4 02:11:25 2019 New Revision: 350384 URL: http://llvm.org/viewvc/llvm-project?rev=350384&view=rev Log: Symtab: Remove one copy of symbol size computation code Summary: The implementation in CalculateSymbolSizes has been made redundant in D19004, as this patch added a

[Lldb-commits] [PATCH] D56132: Symtab: Remove one copy of symbol size computation code

This revision was automatically updated to reflect the committed changes. Closed by commit rL350384: Symtab: Remove one copy of symbol size computation code (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [lldb] r350388 - [CMake] Streamline code signing for debugserver #2

Author: stefan.graenitz Date: Fri Jan 4 04:46:30 2019 New Revision: 350388 URL: http://llvm.org/viewvc/llvm-project?rev=350388&view=rev Log: [CMake] Streamline code signing for debugserver #2 Summary: Major fixes after D54476 (use Diff1 as base for comparison to see only recent changes): * In s

[Lldb-commits] [lldb] r350389 - [CMake] Aggregate options for LLDB in LLDBConfig.cmake

Author: stefan.graenitz Date: Fri Jan 4 04:46:34 2019 New Revision: 350389 URL: http://llvm.org/viewvc/llvm-project?rev=350389&view=rev Log: [CMake] Aggregate options for LLDB in LLDBConfig.cmake Summary: In preparation for LLDB.framework changes, collect options for LLDB in LLDBConfig.cmake (u

[Lldb-commits] [lldb] r350391 - [CMake] Revised LLDB.framework builds

Author: stefan.graenitz Date: Fri Jan 4 04:46:50 2019 New Revision: 350391 URL: http://llvm.org/viewvc/llvm-project?rev=350391&view=rev Log: [CMake] Revised LLDB.framework builds Summary: Add features to LLDB CMake builds that have so far only been available in Xcode. Clean up a few inconvenien

[Lldb-commits] [PATCH] D55320: [CMake] Move debugserver options to separate debugserverConfig.cmake

This revision was automatically updated to reflect the committed changes. Closed by commit rL350390: [CMake] Move debugserver options to separate debugserverConfig.cmake (authored by stefan.graenitz, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAS

[Lldb-commits] [lldb] r350393 - [CMake] Python bindings generation polishing

Author: stefan.graenitz Date: Fri Jan 4 04:47:02 2019 New Revision: 350393 URL: http://llvm.org/viewvc/llvm-project?rev=350393&view=rev Log: [CMake] Python bindings generation polishing Summary: Simplify SWIG invocation and handling of generated files. The `swig_wrapper` target can generate `LL

[Lldb-commits] [lldb] r350390 - [CMake] Move debugserver options to separate debugserverConfig.cmake

Author: stefan.graenitz Date: Fri Jan 4 04:46:38 2019 New Revision: 350390 URL: http://llvm.org/viewvc/llvm-project?rev=350390&view=rev Log: [CMake] Move debugserver options to separate debugserverConfig.cmake Summary: One place for debugserver options, analog to LLDBConfig for LLDB options (see

[Lldb-commits] [lldb] r350392 - [CMake] Revised RPATH handling

Author: stefan.graenitz Date: Fri Jan 4 04:46:57 2019 New Revision: 350392 URL: http://llvm.org/viewvc/llvm-project?rev=350392&view=rev Log: [CMake] Revised RPATH handling Summary: If we build LLDB.framework, dependant tools need appropriate RPATHs in both locations, the build-tree (for testing

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

This revision was automatically updated to reflect the committed changes. Closed by commit rL350388: [CMake] Streamline code signing for debugserver #2 (authored by stefan.graenitz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55013

[Lldb-commits] [PATCH] D55317: [CMake] Aggregate options for LLDB in LLDBConfig.cmake

This revision was automatically updated to reflect the committed changes. Closed by commit rL350389: [CMake] Aggregate options for LLDB in LLDBConfig.cmake (authored by stefan.graenitz, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION htt

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

This revision was automatically updated to reflect the committed changes. Closed by commit rL350391: [CMake] Revised LLDB.framework builds (authored by stefan.graenitz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55328?vs=177554&id

[Lldb-commits] [PATCH] D55330: [CMake] Revised RPATH handling

This revision was automatically updated to reflect the committed changes. Closed by commit rL350392: [CMake] Revised RPATH handling (authored by stefan.graenitz, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5

[Lldb-commits] [PATCH] D55332: [CMake] Python bindings generation polishing

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB350393: [CMake] Python bindings generation polishing (authored by stefan.graenitz, committed by ). Changed prior to commit: https://reviews.llvm.org/D55332?vs=177533&id=180232#toc Repository: rLLD

[Lldb-commits] [PATCH] D56315: Add a verbose mode to "image dump line-table" and use it to write a .debug_line test

labath created this revision. labath added reviewers: clayborg, zturner. Herald added a subscriber: JDevlieghere. The motivation for this is being able to write tests for the upcoming breakpad line table parser, but this could be useful for testing the low-level workings of any line table format.

[Lldb-commits] [PATCH] D56173: Introduce SymbolFileBreakpad and use it to fill symtab

labath updated this revision to Diff 180240. labath added a comment. A couple of minor tweaks to the patch: - log in case we were unable to fetch the base address of the object file - extend the test case to cover ICF-ed symbols (marked with m) - move the yaml representation of an empty ELF file

[Lldb-commits] [PATCH] D55761: lldb-test ir-memory-map: Use IntervalMap::contains

labath closed this revision. labath added a comment. Landed in r350087. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55761/new/ https://reviews.llvm.org/D55761 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

Re: [Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

For those kinds of cases, we could use obj2yaml and check in yaml right? Fwiw I tried to round-trip an exe through obj->yaml->obj recently and the resulting exe was incorrect but it was close, so I think there’s only some small fixes needed. In regards to your previous response, couldn’t we have l

Re: [Lldb-commits] [PATCH] D56315: Add a verbose mode to "image dump line-table" and use it to write a .debug_line test

It seems like this test could be made to work with non dwarf debug info by compiling a real source file. WDYT? On Fri, Jan 4, 2019 at 5:31 AM Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote: > labath created this revision. > labath added reviewers: clayborg, zturner. > Herald added

[Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

lemo updated this revision to Diff 180263. lemo added a comment. Removed sigsegv.exe from the test inputs CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56293/new/ https://reviews.llvm.org/D56293 Files: lit/Minidump/Windows/Sigsegv/Inputs/sigsegv.cpp lit/Minidump/Windows/Sigsegv/Inp

Re: [Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

> > I have a minidump generator if you need me to make any specific minidump > files for you. > Maybe not in this case, but it seems an interesting idea. What are the capabilities of this generator tool? On Thu, Jan 3, 2019 at 3:49 PM Greg Clayton via Phabricator < revi...@reviews.llvm.org> wrote

Re: [Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

> > ouldn’t we have lldb generate the mini dump itself as the first step of > the test? > How would this work cross-platform? On Fri, Jan 4, 2019 at 8:48 AM Zachary Turner wrote: > For those kinds of cases, we could use obj2yaml and check in yaml right? > Fwiw I tried to round-trip an exe throu

Re: [Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

You're right, it wouldn't. I didn't think of that. I guess the obj -> yaml round-tripping would be the only way in that case, and the tool would need to be fixed first so that it can round trip executable object files. On Fri, Jan 4, 2019 at 9:46 AM Leonard Mosescu wrote: > ouldn’t we have lld

Re: [Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

> On Jan 4, 2019, at 9:45 AM, Leonard Mosescu wrote: > > I have a minidump generator if you need me to make any specific minidump > files for you. > > Maybe not in this case, but it seems an interesting idea. What are the > capabilities of this generator tool? I can generate threads context

Re: [Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

Waiiit a second. Why don't we just teach obj2yaml and yaml2obj to round-trip minidumps? This way you could run it on a minidump, then hand-edit it to customize some bits you want to change, then check in the yaml. On Fri, Jan 4, 2019 at 10:56 AM Greg Clayton wrote: > > On Jan 4, 2019, at 9

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. You have convinced me! Sorry I had paged out the original intent you conveyed from before the break. Thanks for the details. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55434/ne

Re: [Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

The main goal for this minidump module was so I could load it into lldb and then run "minidump --save" to save the current process as a minidump file since I like minidump files better than core files... It just happens to work for generating very small and targeted minidump files for testing as

[Lldb-commits] [lldb] r350428 - [Scalar] Simplify comparison operators and add coverage.

Author: davide Date: Fri Jan 4 11:23:52 2019 New Revision: 350428 URL: http://llvm.org/viewvc/llvm-project?rev=350428&view=rev Log: [Scalar] Simplify comparison operators and add coverage. Modified: lldb/trunk/source/Utility/Scalar.cpp lldb/trunk/unittests/Utility/ScalarTest.cpp Modifie

Re: [Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

Sounds very useful. Are you planning to add it to the LLDB repository? On Fri, Jan 4, 2019 at 10:56 AM Greg Clayton wrote: > > > On Jan 4, 2019, at 9:45 AM, Leonard Mosescu wrote: > > I have a minidump generator if you need me to make any specific minidump >> files for you. >> > > Maybe not in

Re: [Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

> On Jan 4, 2019, at 12:37 PM, Leonard Mosescu wrote: > > Sounds very useful. Are you planning to add it to the LLDB repository? Yes > > > On Fri, Jan 4, 2019 at 10:56 AM Greg Clayton > wrote: > > >> On Jan 4, 2019, at 9:45 AM, Leonard Mosescu >

Re: [Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

Great! I can see how we can put this to good use. In the meantime, I'd like to submit this change as is - the included input files are intended to be reused for future test cases as well (they are extracted from my larger change to add support for the native PDB reader + minidumps). On Fri, Jan 4

[Lldb-commits] [PATCH] D56231: [lldb-server] Improve support on Windows

Hui added a comment. With all the aaron's pending reviews on lldb-server, I could try the patch with the following platform apis. Seems to me is working on Windows and no regression on Linux side. Some difference (performance) might be (1) Previous, the vfile:write packet has a maximum as 102

[Lldb-commits] [PATCH] D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()

Hui added a comment. Not quite sure but correct me if i am wrong. (1) I think the Debug Directory is optional for COFF if it does have debug information and pdb to match with. (2) The Debug Directory does not contain COFF timestamp. Using md5 seems very tentative. Please elaborate how to lever

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

Hui added inline comments. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp:1138 + // Double quote the string. + ::snprintf(arg_cstr, sizeof(arg_cstr), "--log-channels=\"%s\"", + env_debugserver_log_channels.c_str());

[Lldb-commits] [PATCH] D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()

zturner added a comment. In D56229#1346869 , @Hui wrote: > Not quite sure but correct me if i am wrong. > > (1) I think the Debug Directory is optional for COFF if it does have debug > information and pdb to match with. > > (2) The Debug Directory does no

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

zturner added inline comments. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp:1138 + // Double quote the string. + ::snprintf(arg_cstr, sizeof(arg_cstr), "--log-channels=\"%s\"", + env_debugserver_log_channels.c_str());

[Lldb-commits] [PATCH] D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()

clayborg added a comment. The UUID that is used in ELF and Mach-o is designed to be something that is stable in a binary after it has been linked and should be the same before and after any kind of post production (stripping symbols, stripping section content to make a stand alone symbol file,

[Lldb-commits] [lldb] r350446 - [Driver] Some more cleanup. NFC

Author: jdevlieghere Date: Fri Jan 4 16:01:04 2019 New Revision: 350446 URL: http://llvm.org/viewvc/llvm-project?rev=350446&view=rev Log: [Driver] Some more cleanup. NFC Modified: lldb/trunk/tools/driver/Driver.cpp lldb/trunk/tools/driver/Driver.h Modified: lldb/trunk/tools/driver/Drive