[Lldb-commits] [lldb] r356113 - Make sure that a sanitizer LLDB's environment doesn't get passed on

Author: adrian Date: Wed Mar 13 17:46:15 2019 New Revision: 356113 URL: http://llvm.org/viewvc/llvm-project?rev=356113=rev Log: Make sure that a sanitizer LLDB's environment doesn't get passed on to test binaries. Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py Modified:

[Lldb-commits] [PATCH] D59340: [lldb-vscode] Don't try to launch an invalid program.

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB356110: [lldb-vscode] Dont try to launch an invalid program. (authored by jgorbe, committed by ). Changed prior to commit: https://reviews.llvm.org/D59340?vs=190535=190542#toc Repository: rLLDB

[Lldb-commits] [lldb] r356110 - [lldb-vscode] Don't try to launch an invalid program.

Author: jgorbe Date: Wed Mar 13 16:50:35 2019 New Revision: 356110 URL: http://llvm.org/viewvc/llvm-project?rev=356110=rev Log: [lldb-vscode] Don't try to launch an invalid program. If an invalid program is specified, lldb-vscode will send back a response with "success" = false, but then will

[Lldb-commits] [lldb] r356108 - Reorder the operations in

Author: jmolenda Date: Wed Mar 13 16:34:20 2019 New Revision: 356108 URL: http://llvm.org/viewvc/llvm-project?rev=356108=rev Log: Reorder the operations in DynamicLoaderDarwinKernel::KextImageInfo::LoadImageUsingMemoryModule a bit so that we only read the binaries out of memory once we've

[Lldb-commits] [PATCH] D59340: [lldb-vscode] Don't try to launch an invalid program.

jgorbe created this revision. jgorbe added a reviewer: zturner. Herald added a project: LLDB. If an invalid program is specified, lldb-vscode will send back a response with `"success": false`, but then will continue executing the rest of `request_launch()`, try to launch the program anyway and

[Lldb-commits] [lldb] r356096 - [Python] Fix TestDataFormatterSmartArray to work across python versions.

Author: davide Date: Wed Mar 13 13:04:34 2019 New Revision: 356096 URL: http://llvm.org/viewvc/llvm-project?rev=356096=rev Log: [Python] Fix TestDataFormatterSmartArray to work across python versions. Python 3 default encoding is utf-8, so taking random bytes and interpreting them as a string

[Lldb-commits] [PATCH] D59314: Fix an invalid static cast in ClangExpressionParser.cpp

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB356090: Fix an invalid static cast in ClangExpressionParser.cpp (authored by adrian, committed by ). Herald added a

[Lldb-commits] [lldb] r356090 - Fix an invalid static cast in ClangExpressionParser.cpp

Author: adrian Date: Wed Mar 13 12:46:30 2019 New Revision: 356090 URL: http://llvm.org/viewvc/llvm-project?rev=356090=rev Log: Fix an invalid static cast in ClangExpressionParser.cpp This was found by the green dragon sanitizer bot. rdar://problem/48536644 Differential Revision:

[Lldb-commits] [PATCH] D59314: Fix an invalid static cast in ClangExpressionParser.cpp

aprantl added a comment. Renamed enumerators. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59314/new/ https://reviews.llvm.org/D59314 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D59314: Fix an invalid static cast in ClangExpressionParser.cpp

aprantl updated this revision to Diff 190476. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59314/new/ https://reviews.llvm.org/D59314 Files: lldb/include/lldb/Expression/Expression.h lldb/include/lldb/Expression/FunctionCaller.h lldb/include/lldb/Expression/LLVMUserExpression.h

[Lldb-commits] [PATCH] D59314: Fix an invalid static cast in ClangExpressionParser.cpp

aprantl added a comment. I was following http://www.llvm.org/docs/HowToSetUpLLVMStyleRTTI.html I will rename it to eKind... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59314/new/ https://reviews.llvm.org/D59314 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D59314: Fix an invalid static cast in ClangExpressionParser.cpp

jingham added a comment. Also naming quibble... Comment at: lldb/include/lldb/Expression/Expression.h:38 + /// Discriminator for LLVM-style RTTI (dyn_cast<> et al.) + enum ExpressionKind { +EK_FunctionCaller, I don't think we use this naming for enum's

[Lldb-commits] [PATCH] D59314: Fix an invalid static cast in ClangExpressionParser.cpp

aprantl updated this revision to Diff 190470. aprantl added a comment. Excellent point! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59314/new/ https://reviews.llvm.org/D59314 Files: lldb/include/lldb/Expression/Expression.h lldb/include/lldb/Expression/FunctionCaller.h

[Lldb-commits] [lldb] r356079 - [ExpressionParser] Restore removed intance of FileSystem::Resolve while resolving clang resource dir

Author: xiaobai Date: Wed Mar 13 11:51:22 2019 New Revision: 356079 URL: http://llvm.org/viewvc/llvm-project?rev=356079=rev Log: [ExpressionParser] Restore removed intance of FileSystem::Resolve while resolving clang resource dir I committed a change that removed this line, but I meant to

[Lldb-commits] [PATCH] D59314: Fix an invalid static cast in ClangExpressionParser.cpp

jingham added a comment. I think you have to protect against your dyn_cast failing. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:495 - auto _expr = *static_cast(_expr); - if (clang_expr.DidImportCxxModules()) { + auto *clang_expr =

[Lldb-commits] [PATCH] D59314: Fix an invalid static cast in ClangExpressionParser.cpp

aprantl updated this revision to Diff 190460. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59314/new/ https://reviews.llvm.org/D59314 Files: lldb/include/lldb/Expression/Expression.h lldb/include/lldb/Expression/FunctionCaller.h lldb/include/lldb/Expression/LLVMUserExpression.h

[Lldb-commits] [PATCH] D59314: Fix an invalid static cast in ClangExpressionParser.cpp

aprantl created this revision. aprantl added a reviewer: jingham. Herald added a project: LLDB. This was found by the green dragon sanitizer bot. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D59314 Files: lldb/include/lldb/Expression/Expression.h

[Lldb-commits] [lldb] r356073 - Update.

Author: jmolenda Date: Wed Mar 13 11:24:42 2019 New Revision: 356073 URL: http://llvm.org/viewvc/llvm-project?rev=356073=rev Log: Update. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [lldb] r356065 - [lldbsuite] Un-xfail TestPyObjSynthProvider on Windows

Author: stella.stamenova Date: Wed Mar 13 09:53:53 2019 New Revision: 356065 URL: http://llvm.org/viewvc/llvm-project?rev=356065=rev Log: [lldbsuite] Un-xfail TestPyObjSynthProvider on Windows One of Davide's changes yesterday fixed the behavior on Windows, so the test is now passing.

[Lldb-commits] [PATCH] D59291: Add basic minidump support to obj2yaml

aprantl added inline comments. Comment at: include/llvm/BinaryFormat/Minidump.h:26 + +struct Header { + static constexpr uint32_t MagicSignature = 0x504d444d; // PMDM Can you please make sure to Doxygen-ify all the public headers? Repository: rL LLVM

[Lldb-commits] [lldb] r356057 - Make sure FileSystem::Resolve preserves the path/file distinction.

Author: adrian Date: Wed Mar 13 08:54:18 2019 New Revision: 356057 URL: http://llvm.org/viewvc/llvm-project?rev=356057=rev Log: Make sure FileSystem::Resolve preserves the path/file distinction. This should finally fix TestPaths.py. Modified: lldb/trunk/source/Host/common/FileSystem.cpp

Re: [Lldb-commits] [lldb] r355998 - [Python] Fix another batch of python 2/python 3 portability issues.

Probably. I can try doing that. On Wed, Mar 13, 2019 at 2:38 AM Pavel Labath via lldb-commits wrote: > > On 13/03/2019 01:48, Davide Italiano via lldb-commits wrote: > > Author: davide > > Date: Tue Mar 12 17:48:29 2019 > > New Revision: 355998 > > > > URL:

[Lldb-commits] [PATCH] D59291: Add basic minidump support to obj2yaml

labath planned changes to this revision. labath added a comment. Ok, let me try to do that. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59291/new/ https://reviews.llvm.org/D59291 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D59297: Delete type_sp member from TypePair

labath created this revision. labath added reviewers: clayborg, zturner, jingham. Herald added a subscriber: jdoerfert. As discussed in the review of D59217 , this member is unnecessary since always the first thing we do is convert it to a CompilerType. This

[Lldb-commits] [PATCH] D59291: Add basic minidump support to obj2yaml

jhenderson added a comment. In D59291#1427349 , @labath wrote: > So, if we want to split this up more, I can propose the following: > > - split off the BinaryFormat changes into a separate patch, test it > with some inline C char arrays > - write the

[Lldb-commits] [PATCH] D59217: Fix/unify SBType comparison

This revision was automatically updated to reflect the committed changes. Closed by commit rL356048: Fix/unify SBType comparison (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] r356048 - Fix/unify SBType comparison

Author: labath Date: Wed Mar 13 06:45:14 2019 New Revision: 356048 URL: http://llvm.org/viewvc/llvm-project?rev=356048=rev Log: Fix/unify SBType comparison Summary: In my next step at cleaning up modify-python-lldb.py, I started focusing on equality comparison. To my surprise, I found out that

[Lldb-commits] [PATCH] D59217: Fix/unify SBType comparison

labath added a comment. Thanks. I'm going to commit this, and then see whether it is possible to remove the type_sp member. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59217/new/ https://reviews.llvm.org/D59217 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D59291: Add basic minidump support to obj2yaml

labath added a comment. The BinaryFormat changes are basically just defining a bunch of structs and enums, so there isn't much to test there. The only actual functional change there is the addition of the magic recognition code in Magic.cpp. That could easily be unit-tested, but that would

[Lldb-commits] [PATCH] D59291: Add basic minidump support to obj2yaml

jhenderson added a comment. Is it possible to unit-test some of the Object and BinaryFormat changes? That would allow you to split those parts away from the obj2yaml changes. Also, if you added support in yaml2obj, you could test that, then use that in testing the obj2yaml changes more easily,

[Lldb-commits] [PATCH] D59291: Add basic minidump support to obj2yaml

labath created this revision. labath added reviewers: Bigcheese, jhenderson, zturner. Herald added subscribers: fedor.sergeev, mgorny, dschuff, srhines. Herald added a project: LLVM. This commit adds enough code to be able to dump a simple minidump (a windows "core" file) file into yaml. It

Re: [Lldb-commits] [lldb] r355998 - [Python] Fix another batch of python 2/python 3 portability issues.

On 13/03/2019 01:48, Davide Italiano via lldb-commits wrote: Author: davide Date: Tue Mar 12 17:48:29 2019 New Revision: 355998 URL: http://llvm.org/viewvc/llvm-project?rev=355998=rev Log: [Python] Fix another batch of python 2/python 3 portability issues. Modified: