[Lldb-commits] [PATCH] D59433: Fix UUID decoding from minidump files.

clayborg added a comment. In D59433#1431488 , @zturner wrote: > "MinidumpNew" is a little bit vague. What's "new" about it? Is there a way > we could come up with a better name? This was an existing file that I just added new tests to, and it seemed

[Lldb-commits] [PATCH] D59433: Fix UUID decoding from minidump files.

zturner added a comment. "MinidumpNew" is a little bit vague. What's "new" about it? Is there a way we could come up with a better name? As an aside, since there's no interactivity in these tests, they seem like a good candidate for lit/Minidump, with 1 file for each test. Something like:

[Lldb-commits] [PATCH] D59433: Fix UUID decoding from minidump files.

clayborg created this revision. clayborg added reviewers: zturner, labath. Herald added a subscriber: javed.absar. Herald added a reviewer: serge-sans-paille. This patch fixes: - UUIDs now don't include the age field from a PDB70 when the age is zero. Prior to this they would incorrectly

Re: [Lldb-commits] [PATCH] D59427: [lldb] [API] Split SBRegistry into smaller files

That being said, the tool won't generate register macros when the corresponding record macro is already in place, so the initial move would have to be done by hand. On Fri, Mar 15, 2019 at 1:47 PM Jonas Devlieghere wrote: > They actually are auto generated, using the lldb-inst tool. Currently

Re: [Lldb-commits] [PATCH] D59427: [lldb] [API] Split SBRegistry into smaller files

They actually are auto generated, using the lldb-inst tool. Currently the record macros are inserted in place, while the register macros are dumped to stdout. I didn’t want to add too much complexity. However, it would be really easy to just dump the register macros in the file as well. On Fri,

[Lldb-commits] [PATCH] D59427: [lldb] [API] Split SBRegistry into smaller files

zturner added a comment. Or better yet, make it a static method on each SB class. E.g. `SBTarget::InitializeReproducerRegistry();` etc, one for each class. Random thought, but this all seems like a very high maintenance strategy, having to manually update this registry when methods are added

[Lldb-commits] [PATCH] D59427: [lldb] [API] Split SBRegistry into smaller files

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. In D59427#1431383 , @krytarowski wrote: > It looks good to me, but maybe @JDevlieghere has a better idea how to > optimize it.

[Lldb-commits] [PATCH] D59430: Update DwarfDebugInfoEntry to use llvm::Error and llvm::Expected

zturner marked 3 inline comments as done. zturner added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:218 + assert(offset < cu->GetNextCompileUnitOffset() && + debug_info_data.ValidOffset(offset)); aprantl

[Lldb-commits] [PATCH] D59430: Update DwarfDebugInfoEntry to use llvm::Error and llvm::Expected

aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:218 + assert(offset < cu->GetNextCompileUnitOffset() && + debug_info_data.ValidOffset(offset)); Should this be a lldb_assert() followed by `return

[Lldb-commits] [PATCH] D59427: [lldb] [API] Split SBRegistry into smaller files

krytarowski added a comment. It looks good to me, but maybe @JDevlieghere has a better idea how to optimize it. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59427/new/ https://reviews.llvm.org/D59427 ___

[Lldb-commits] [PATCH] D59430: Update DwarfDebugInfoEntry to use llvm::Error and llvm::Expected

zturner created this revision. zturner added reviewers: clayborg, aprantl, labath. Herald added a subscriber: jdoerfert. This hits the next batch of classes and adds better error handling and recovery to them. After this, the only remaining case is the line table stuff, at which point we

[Lldb-commits] [lldb] r356284 - Abbreviation declarations are required to have non-null tags.

Author: zturner Date: Fri Mar 15 11:00:43 2019 New Revision: 356284 URL: http://llvm.org/viewvc/llvm-project?rev=356284=rev Log: Abbreviation declarations are required to have non-null tags. Treat a null tag as an error. Modified:

[Lldb-commits] [PATCH] D59381: Change CompileUnit and ARanges interfaces to propagate errors

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rL356278: Return Error and Expected from more DWARF interfaces. (authored by zturner, committed by ). Herald added a

[Lldb-commits] [lldb] r356278 - Return Error and Expected from more DWARF interfaces.

Author: zturner Date: Fri Mar 15 10:32:05 2019 New Revision: 356278 URL: http://llvm.org/viewvc/llvm-project?rev=356278=rev Log: Return Error and Expected from more DWARF interfaces. This continues the work of introducing Error and Expected into the DWARF parsing interfaces, this time for the

[Lldb-commits] [lldb] r356275 - Implement a better way of not passing the sanitizer environment on to tests.

Author: adrian Date: Fri Mar 15 10:22:00 2019 New Revision: 356275 URL: http://llvm.org/viewvc/llvm-project?rev=356275=rev Log: Implement a better way of not passing the sanitizer environment on to tests. rdar://problem/48889580 Modified:

[Lldb-commits] [lldb] r356271 - [DataFormatters] Remove LLDB_DISABLE_PYTHON from TypeCategory.

Author: davide Date: Fri Mar 15 09:55:51 2019 New Revision: 356271 URL: http://llvm.org/viewvc/llvm-project?rev=356271=rev Log: [DataFormatters] Remove LLDB_DISABLE_PYTHON from TypeCategory. Modified: lldb/trunk/include/lldb/DataFormatters/TypeCategoryMap.h

Re: [Lldb-commits] [lldb] r355103 - [cmake] Move LLDB_DISABLE_LIBEDIT handling code into a central place

On Fri, Mar 15, 2019 at 10:04 AM Pavel Labath wrote: > On 14/03/2019 21:45, Nico Weber wrote: > > I tried LLVM_ENABLE_PROJECTS=all today, and it fails with > > > > CMake Error: The following variables are used in this project, but they > > are set to NOTFOUND. > > Please set them or make sure

[Lldb-commits] [PATCH] D59291: [Object] Add basic minidump support

labath updated this revision to Diff 190832. labath marked 8 inline comments as done. labath edited the summary of this revision. labath added a comment. - fix comments and error messages - use DenseMap Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59291/new/

[Lldb-commits] [PATCH] D59291: [Object] Add basic minidump support

labath added inline comments. Comment at: include/llvm/Object/Minidump.h:77 + ArrayRef Streams, + std::unordered_map StreamMap) + : Binary(ID_Minidump, Source), Header(Header), Streams(Streams), zturner wrote: > jhenderson wrote:

[Lldb-commits] [PATCH] D59414: Remove the TypePair class

labath created this revision. labath added reviewers: clayborg, jingham, zturner. Herald added subscribers: jdoerfert, dexonsmith, mehdi_amini. After D59297 , the TypePair class kind of lost its purpose as it was no longer a "pair". This finished the job started

Re: [Lldb-commits] [lldb] r355103 - [cmake] Move LLDB_DISABLE_LIBEDIT handling code into a central place

On 14/03/2019 21:45, Nico Weber wrote: I tried LLVM_ENABLE_PROJECTS=all today, and it fails with CMake Error: The following variables are used in this project, but they are set to NOTFOUND. Please set them or make sure they are set and tested correctly in the CMake files:

[Lldb-commits] [lldb] r356263 - Fix a typo in FindLibEdit.cmake

Author: labath Date: Fri Mar 15 07:03:52 2019 New Revision: 356263 URL: http://llvm.org/viewvc/llvm-project?rev=356263=rev Log: Fix a typo in FindLibEdit.cmake The package name is LibEdit, so we should use that name in the call to find_package_handle_standard_args. Failing to do so results in

[Lldb-commits] [PATCH] D59297: Delete type_sp member from TypePair

This revision was automatically updated to reflect the committed changes. Closed by commit rL356262: Delete type_sp member from TypePair (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] r356262 - Delete type_sp member from TypePair

Author: labath Date: Fri Mar 15 07:02:35 2019 New Revision: 356262 URL: http://llvm.org/viewvc/llvm-project?rev=356262=rev Log: Delete type_sp member from TypePair Summary: As discussed in the review of D59217, this member is unnecessary since always the first thing we do is convert it to a