[Lldb-commits] [lldb] r357451 - Simplify TestGdbRemoteRegisterState

Author: labath Date: Tue Apr 2 00:47:38 2019 New Revision: 357451 URL: http://llvm.org/viewvc/llvm-project?rev=357451&view=rev Log: Simplify TestGdbRemoteRegisterState While reviewing D56233 it became clear to me that this test can be simplified. There's no need for a start-stop cycle in the inf

[Lldb-commits] [PATCH] D56233: [lldb-server] Add initial support for lldb-server on Windows

labath added a comment. The patch is pretty big, so I haven't done an in-depth review yet. The fact that you've ran clang-format over entire files (and not just the diffs) does not help. For a start, I've highlighted the parts that I believe can/should go into a separate patch. Some of them ar

[Lldb-commits] [PATCH] D60001: Allow partial UUID matching in Minidump core file plug-in

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm. Thanks for the patience. Comment at: source/Plugins/Process/minidump/ProcessMinidump.cpp:401 + basename_module_spec.GetUUID().Clear(); + basename_module_spec.

[Lldb-commits] [PATCH] D60068: PDBFPO: Refactor register reference resolution

labath marked an inline comment as done. labath added a comment. Thanks. BTW, do you have any thoughts where this code could live (it can't stay here because I need to access it from SymbolFileBreakpad too). I was thinking of the Symbol library, as both users are `SymbolFile`s. I don't think t

[Lldb-commits] [lldb] r357455 - PDBFPO: Refactor register reference resolution

Author: labath Date: Tue Apr 2 01:44:24 2019 New Revision: 357455 URL: http://llvm.org/viewvc/llvm-project?rev=357455&view=rev Log: PDBFPO: Refactor register reference resolution Summary: This refactors moves the register name->number resolution out of the FPOProgramNodeRegisterRef class. Instea

[Lldb-commits] [PATCH] D60068: PDBFPO: Refactor register reference resolution

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB357455: PDBFPO: Refactor register reference resolution (authored by labath, committed by ). Herald added a subscriber: abidh. Herald added a project: LLDB. Changed prior to commit: https://reviews.ll

[Lldb-commits] [lldb] r357456 - Fix llvm_unreachable in TestWriteMemory

Author: labath Date: Tue Apr 2 01:56:22 2019 New Revision: 357456 URL: http://llvm.org/viewvc/llvm-project?rev=357456&view=rev Log: Fix llvm_unreachable in TestWriteMemory The test was hitting llvm_unreachable in Platform::GetSoftwareBreakpointTrapOpcode because it could not figure out the archi

[Lldb-commits] [PATCH] D60022: [Process] Fix WriteMemory return value

labath added a comment. Just an FYI: I was hitting llvm_unreachable in Platform::GetSoftwareBreakpointTrapOpcode in this test. I fixed it in r357456 by specifying an explicit triple in the test. (I'm not sure how this wasn't hit on the darwin bots.) Comment at: packages/Pyt

[Lldb-commits] [PATCH] D59826: [expression] Explicitly build the lookup table of any TagDecl's context

martong added a comment. Ping Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59826/new/ https://reviews.llvm.org/D59826 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[Lldb-commits] [lldb] r357459 - Fix flakyness in TestCommandScriptImmediateOutput

Author: labath Date: Tue Apr 2 02:45:40 2019 New Revision: 357459 URL: http://llvm.org/viewvc/llvm-project?rev=357459&view=rev Log: Fix flakyness in TestCommandScriptImmediateOutput I'm not sure why this surfaced at this particular point, but TestCommandScriptImmediateOutput (a pexpect test) had

[Lldb-commits] [PATCH] D60068: PDBFPO: Refactor register reference resolution

aleksandr.urakov added a comment. I think both approaches are acceptable, but I would prefer to include it into the Symbols library because this functionality is more symbols-related than general. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60068/new/ https

[Lldb-commits] [lldb] r357463 - Make operator==s consistent between c++ and python APIs

Author: labath Date: Tue Apr 2 03:18:46 2019 New Revision: 357463 URL: http://llvm.org/viewvc/llvm-project?rev=357463&view=rev Log: Make operator==s consistent between c++ and python APIs Summary: modify-python-lldb.py had code to insert python equality operators to some classes. Some of those c

[Lldb-commits] [PATCH] D59819: Make operator==s consistent between c++ and python APIs

This revision was automatically updated to reflect the committed changes. Closed by commit rL357463: Make operator==s consistent between c++ and python APIs (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

[Lldb-commits] [PATCH] D59634: Add minidump support to obj2yaml

jhenderson accepted this revision. jhenderson added a comment. This revision is now accepted and ready to land. In D59634#1449621 , @labath wrote: > James, do you have any thoughts on this? I think the minidump-specific > changes are all pretty straight-f

[Lldb-commits] [PATCH] D60119: modify-python-lldb.py: clean up __iter__ and __len__ support

labath created this revision. labath added reviewers: zturner, jingham, amccarth. Herald added a subscriber: jdoerfert. Instead of modifying the swig-generated code, just add the appropriate methods to the interface files in order to get the swig to do the generation for us. This is a straight-fo

[Lldb-commits] [PATCH] D59634: Add minidump support to obj2yaml

labath added a comment. In D59634#1451182 , @jhenderson wrote: > Sorry, I've been a bit snowed under with other stuff recently. I don't claim > to be an expert on obj2yaml, but this LGTM. No worries. You still have the fastest average response time for

[Lldb-commits] [PATCH] D59634: Add minidump support to obj2yaml

This revision was automatically updated to reflect the committed changes. Closed by commit rG3cee663e71f6: Add minidump support to obj2yaml (authored by labath). Herald added a subscriber: hiraditya. Changed prior to commit: https://reviews.llvm.org/D59634?vs=191656&id=193254#toc Repository:

[Lldb-commits] [PATCH] D60121: Object/Minidump: Add support for reading the ModuleList stream

labath created this revision. labath added reviewers: zturner, amccarth, jhenderson, clayborg. Herald added a subscriber: jdoerfert. Herald added a project: LLVM. The ModuleList stream consists of an integer giving the number of entries in the list, followed by the list itself. Each entry in the l

[Lldb-commits] [PATCH] D59826: [expression] Explicitly build the lookup table of any TagDecl's context

clayborg added a comment. Any way to dump the AST in a test to verify we don't create multiple? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59826/new/ https://reviews.llvm.org/D59826 ___ lldb-commits mailing list

[Lldb-commits] [lldb] r357482 - Allow partial UUID matching in Minidump core file plug-in

Author: gclayton Date: Tue Apr 2 08:40:54 2019 New Revision: 357482 URL: http://llvm.org/viewvc/llvm-project?rev=357482&view=rev Log: Allow partial UUID matching in Minidump core file plug-in Breakpad had bugs in earlier versions where it would take a 20 byte ELF build ID and put it into the mi

[Lldb-commits] [PATCH] D60001: Allow partial UUID matching in Minidump core file plug-in

This revision was automatically updated to reflect the committed changes. Closed by commit rL357482: Allow partial UUID matching in Minidump core file plug-in (authored by gclayton, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[Lldb-commits] [PATCH] D60001: Allow partial UUID matching in Minidump core file plug-in

clayborg marked an inline comment as done. clayborg added inline comments. Comment at: source/Plugins/Process/minidump/ProcessMinidump.cpp:401 + basename_module_spec.GetUUID().Clear(); + basename_module_spec.GetFileSpec().GetDirectory().Clear(); + module_sp = GetTa

Re: [Lldb-commits] [lldb] r357482 - Allow partial UUID matching in Minidump core file plug-in

This broke the green dragon cmake bot == FAIL: test_partial_uuid_match (TestMiniDumpUUID.MiniDumpUUIDTestCase) -- Traceback (most recent call last): File "/Users/

Re: [Lldb-commits] [lldb] r357482 - Allow partial UUID matching in Minidump core file plug-in

I'll take a look > On Apr 2, 2019, at 9:27 AM, Davide Italiano wrote: > > This broke the green dragon cmake bot > > == > FAIL: test_partial_uuid_match (TestMiniDumpUUID.MiniDumpUUIDTestCase) > --

[Lldb-commits] [lldb] r357491 - Fix buildbot where paths were not matching up.

Author: gclayton Date: Tue Apr 2 09:36:34 2019 New Revision: 357491 URL: http://llvm.org/viewvc/llvm-project?rev=357491&view=rev Log: Fix buildbot where paths were not matching up. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpUUID.

[Lldb-commits] [lldb] r357495 - Fix typo; NFC

Author: asmith Date: Tue Apr 2 10:02:21 2019 New Revision: 357495 URL: http://llvm.org/viewvc/llvm-project?rev=357495&view=rev Log: Fix typo; NFC Modified: lldb/trunk/include/lldb/Target/Platform.h Modified: lldb/trunk/include/lldb/Target/Platform.h URL: http://llvm.org/viewvc/llvm-project

[Lldb-commits] [lldb] r357496 - [lldb-server] Use llgs namespace to avoid conflicts with Win32 API

Author: asmith Date: Tue Apr 2 10:10:12 2019 New Revision: 357496 URL: http://llvm.org/viewvc/llvm-project?rev=357496&view=rev Log: [lldb-server] Use llgs namespace to avoid conflicts with Win32 API Modified: lldb/trunk/tools/lldb-server/lldb-server.cpp Modified: lldb/trunk/tools/lldb-serve

[Lldb-commits] [PATCH] D56233: [lldb-server] Add initial support for lldb-server on Windows

asmith marked 5 inline comments as done. asmith added a comment. Committed a few NFC changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56233/new/ https://reviews.llvm.org/D56233 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r357504 - Clean up windows build bot.

Author: gclayton Date: Tue Apr 2 10:50:08 2019 New Revision: 357504 URL: http://llvm.org/viewvc/llvm-project?rev=357504&view=rev Log: Clean up windows build bot. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpUUID.py Modified: lldb

[Lldb-commits] [lldb] r357507 - [Reproducers] Print warning when generating the reproducer.

Author: jdevlieghere Date: Tue Apr 2 11:23:16 2019 New Revision: 357507 URL: http://llvm.org/viewvc/llvm-project?rev=357507&view=rev Log: [Reproducers] Print warning when generating the reproducer. Encourage users to look at the directory so they know what data they'd be sharing by uploading the

[Lldb-commits] [PATCH] D60001: Allow partial UUID matching in Minidump core file plug-in

aprantl added a comment. Since this commit, TestMiniDumpUUID_py is failing on green dragon. Could you please revert the change or commit a fix? http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/lastCompletedBuild/testReport/lldb-Suite/functionalities_postmortem_minidump-new/TestMiniDumpUU

[Lldb-commits] [lldb] r357513 - [NativePDB] Don't fail on import modules.

Author: zturner Date: Tue Apr 2 12:39:45 2019 New Revision: 357513 URL: http://llvm.org/viewvc/llvm-project?rev=357513&view=rev Log: [NativePDB] Don't fail on import modules. A recent patch to LLD started emitting information about import modules. These are represented as compile units in the PD

[Lldb-commits] [PATCH] D60152: Fix and simplify PrepareCommandsForSourcing

amccarth created this revision. amccarth added reviewers: zturner, labath, rnk. Spotted some problems in the Driver's PrepareCommandsForSourcing while helping a colleague track another problem. 1. One error case was not handled because there was no else clause. Fixed by switching to llvm's early

[Lldb-commits] [PATCH] D60153: Re-enable most lldb-vscode tests on Linux.

jgorbe created this revision. jgorbe added reviewers: zturner, clayborg. Herald added a project: LLDB. After https://reviews.llvm.org/D59828 and https://reviews.llvm.org/D59849, I believe the problems with these tests hanging have been solved. I tried enabling all of them on my machine, and got t

[Lldb-commits] [lldb] r357534 - Revert r357504, r357491, r357482 because of bot breakage.

Author: adrian Date: Tue Apr 2 15:03:22 2019 New Revision: 357534 URL: http://llvm.org/viewvc/llvm-project?rev=357534&view=rev Log: Revert r357504, r357491, r357482 because of bot breakage. See discussion in https://reviews.llvm.org/D60001. Revert Clean up windows build bot. This reverts r35750

[Lldb-commits] [PATCH] D60001: Allow partial UUID matching in Minidump core file plug-in

aprantl added a comment. The bots were broken for more than six hours so I took the liberty to revert the change in r357534. Sorry for the inconvenience! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60001/new/ https://reviews.llvm.org/D60001 _

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

JDevlieghere added a comment. Hey Tatyana, what's the plan with regards to testing this? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55718/new/ https://reviews.llvm.org/D55718 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D60018: [codeview] Remove Type member from CVRecord

rnk updated this revision to Diff 193388. rnk marked 4 inline comments as done. rnk added a comment. - Add RecordPrefix ctor, remove all dummy RecordLen assignments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60018/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D60018: [codeview] Remove Type member from CVRecord

rnk updated this revision to Diff 193390. rnk marked an inline comment as done. rnk added a comment. - one more change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60018/new/ https://reviews.llvm.org/D60018 Files: lld/COFF/PDB.cpp lldb/source

[Lldb-commits] [PATCH] D60018: [codeview] Remove Type member from CVRecord

rnk added inline comments. Comment at: llvm/include/llvm/DebugInfo/CodeView/CVRecord.h:29 +/// Carrying the size separately instead of trusting the size stored in the +/// record prefix provides some extra safety and flexibility. template class CVRecord { agane

[Lldb-commits] [PATCH] D60018: [codeview] Remove Type member from CVRecord

aganea accepted this revision. aganea added a comment. This revision is now accepted and ready to land. LGTM. With a few minor comments: Comment at: llvm/include/llvm/DebugInfo/CodeView/TypeDeserializer.h:122 ~FieldListDeserializer() override { -CVType FieldList; -Fi

[Lldb-commits] [lldb] r357553 - Avoid macro redefinition error if HAVE_LIBCOMPRESSION

Author: jmolenda Date: Tue Apr 2 18:16:54 2019 New Revision: 357553 URL: http://llvm.org/viewvc/llvm-project?rev=357553&view=rev Log: Avoid macro redefinition error if HAVE_LIBCOMPRESSION is already defined. Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient

[Lldb-commits] [lldb] r357554 - [lldb-dotest] Print dotest.py invocation.

Author: jdevlieghere Date: Tue Apr 2 18:26:38 2019 New Revision: 357554 URL: http://llvm.org/viewvc/llvm-project?rev=357554&view=rev Log: [lldb-dotest] Print dotest.py invocation. In order to debug a failing python test, you need to debug Python instead of the wrapper. For a while I've been addi

[Lldb-commits] [lldb] r357555 - [lit] Use 10 minute timeout by default.

Author: jdevlieghere Date: Tue Apr 2 18:26:41 2019 New Revision: 357555 URL: http://llvm.org/viewvc/llvm-project?rev=357555&view=rev Log: [lit] Use 10 minute timeout by default. Lit has the ability to set a timeout for individual tests. This patch enables that functionality with a default of 10

[Lldb-commits] [PATCH] D60172: Renamed Target::GetSharedModule to AddModule, allow for ModulesDidLoad to be delayed when batch adding Modules

jasonmolenda created this revision. jasonmolenda added reviewers: clayborg, jingham. Herald added a subscriber: abidh. Herald added a project: LLDB. I'm addressing a perf issue where DynamicLoaderDarwin has been notified that a batch of solibs have been loaded. It adds them to the target one-by-

[Lldb-commits] [PATCH] D60172: Renamed Target::GetSharedModule to AddModule, allow for ModulesDidLoad to be delayed when batch adding Modules

clayborg added inline comments. Comment at: include/lldb/Target/Target.h:535 + bool notify, + Status *error_ptr = nullptr); Pavel had questions about this error. If we specify an error when we call this, is t

Re: [Lldb-commits] [PATCH] D60001: Allow partial UUID matching in Minidump core file plug-in

No worries. I tried to get things working with a few patches. Is there a way to try out a patch on green dragon other than just submitting the changes? > On Apr 2, 2019, at 3:03 PM, Adrian Prantl via Phabricator > wrote: > > aprantl added a comment. > > The bots were broken for more than six

[Lldb-commits] [PATCH] D60172: Renamed Target::GetSharedModule to AddModule, allow for ModulesDidLoad to be delayed when batch adding Modules

jasonmolenda marked 2 inline comments as done. jasonmolenda added a comment. Thanks for looking the patch over. Comment at: include/lldb/Target/Target.h:535 + bool notify, + Status *error_ptr = nullptr); cla

[Lldb-commits] [PATCH] D60178: [Reproducers] Capture return values of functions returning by ptr/ref

JDevlieghere created this revision. JDevlieghere added reviewers: labath, friss. Herald added a reviewer: jfb. Herald added a subscriber: abidh. Herald added a project: LLDB. For some reason I had convinced myself that functions returning by pointer or reference do not require recording their res

[Lldb-commits] [PATCH] D60178: [Reproducers] Capture return values of functions returning by ptr/ref

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Herald added a subscriber: dexonsmith. Comment at: lldb/include/lldb/Utility/ReproducerInstrumentation.h:679 + template const Result &RecordResult(const Result &r) { +UpdateBoundary(); +i

[Lldb-commits] [PATCH] D60180: [CMake] Don't explicitly use LLVM_LIBRARY_DIR in standalone builds

xiaobai created this revision. xiaobai added reviewers: compnerd, sgraenitz, labath. Herald added subscribers: kristof.beyls, javed.absar, mgorny. xiaobai added a reviewer: mgorny. This line is unnecessary because add_llvm_executable will handle linking the correct LLVM libraries for you. LLDB sta