[Lldb-commits] [PATCH] D60018: [codeview] Remove Type member from CVRecord

This revision was automatically updated to reflect the committed changes. Closed by commit rLLD357658: [codeview] Remove Type member from CVRecord (authored by rnk, committed by ). Changed prior to commit: https://reviews.llvm.org/D60018?vs=193526=193633#toc Repository: rLLD LLVM Linker

[Lldb-commits] [PATCH] D60172: Renamed Target::GetSharedModule to AddModule, allow for ModulesDidLoad to be delayed when batch adding Modules

jasonmolenda updated this revision to Diff 193609. jasonmolenda added a comment. Remove const bool notify's. Rename method to Target::GetOrCreateModule. Refine the method headerdoc a bit. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60172/new/

[Lldb-commits] [lldb] r357641 - Un-xfail one of the TestMiniDumpUUID tests on Windows

Author: stella.stamenova Date: Wed Apr 3 14:57:41 2019 New Revision: 357641 URL: http://llvm.org/viewvc/llvm-project?rev=357641=rev Log: Un-xfail one of the TestMiniDumpUUID tests on Windows The test is passing on Windows and the windows bot is failing because of the unexpected pass Modified:

[Lldb-commits] [PATCH] D60172: Renamed Target::GetSharedModule to AddModule, allow for ModulesDidLoad to be delayed when batch adding Modules

jasonmolenda added a comment. OK looked things over a bit. I think there's a case for adopting llvm::ErrorOr here, and elsewhere across, but today the only place we're using that return type is when the error is encoded in a std::error_code (aka fancy errno). We should have an ErrorOr that

[Lldb-commits] [PATCH] D60178: [Reproducers] Capture return values of functions returning by ptr/ref

This revision was automatically updated to reflect the committed changes. Closed by commit rL357639: [Reproducers] Capture return values of functions returning by ptr/ref (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[Lldb-commits] [lldb] r357639 - [Reproducers] Capture return values of functions returning by ptr/ref

Author: jdevlieghere Date: Wed Apr 3 14:31:22 2019 New Revision: 357639 URL: http://llvm.org/viewvc/llvm-project?rev=357639=rev Log: [Reproducers] Capture return values of functions returning by ptr/ref For some reason I had convinced myself that functions returning by pointer or reference do

[Lldb-commits] [PATCH] D60178: [Reproducers] Capture return values of functions returning by ptr/ref

friss accepted this revision. friss added a comment. This revision is now accepted and ready to land. This seems super mechanical and we discussed it at length offline. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60178/new/ https://reviews.llvm.org/D60178

[Lldb-commits] [PATCH] D60180: [CMake] Don't explicitly use LLVM_LIBRARY_DIR in standalone builds

xiaobai added a comment. So I ran the lldb test suite from a standalone build tree, and this patch didn't change anything. I added some logging to the CMake and `LLVM_LIBRARY_DIR` is being set correctly. It appears to be getting it from the LLVMConfig we get from `find_package(LLVM)`. I think

[Lldb-commits] [PATCH] D60153: Re-enable most lldb-vscode tests on Linux.

This revision was automatically updated to reflect the committed changes. jgorbe marked 2 inline comments as done. Closed by commit rL357633: Re-enable most lldb-vscode tests on Linux. (authored by jgorbe, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[Lldb-commits] [lldb] r357633 - Re-enable most lldb-vscode tests on Linux.

Author: jgorbe Date: Wed Apr 3 13:43:20 2019 New Revision: 357633 URL: http://llvm.org/viewvc/llvm-project?rev=357633=rev Log: Re-enable most lldb-vscode tests on Linux. Summary: After https://reviews.llvm.org/D59828 and https://reviews.llvm.org/D59849, I believe the problems with these tests

[Lldb-commits] [PATCH] D60153: Re-enable most lldb-vscode tests on Linux.

jgorbe updated this revision to Diff 193585. jgorbe added a comment. Increased wait time in test binary for TestVSCode_attach.py from 5 to 10 seconds. If this is still unreliable, or it makes the test take too long, I'll switch it to use the `debugger_flag` pattern as suggested. Repository:

[Lldb-commits] [PATCH] D60178: [Reproducers] Capture return values of functions returning by ptr/ref

JDevlieghere updated this revision to Diff 193581. JDevlieghere added a comment. - Add tests for lldb-instr - Feedback Pavel CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60178/new/ https://reviews.llvm.org/D60178 Files: lldb/include/lldb/Utility/ReproducerInstrumentation.h

[Lldb-commits] [PATCH] D60152: Fix and simplify PrepareCommandsForSourcing

zturner added inline comments. Comment at: lldb/tools/driver/Driver.cpp:492-496 #ifdef _WIN32 - _close(fds[WRITE]); - fds[WRITE] = -1; + _close(fd); #else - close(fds[WRITE]); - fds[WRITE] = -1; + close(fd); #endif labath wrote:

[Lldb-commits] [PATCH] D60152: Fix and simplify PrepareCommandsForSourcing

This revision was automatically updated to reflect the committed changes. Closed by commit rL357626: Fix and simplify PrepareCommandsForSourcing (authored by amccarth, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r357626 - Fix and simplify PrepareCommandsForSourcing

Author: amccarth Date: Wed Apr 3 12:49:14 2019 New Revision: 357626 URL: http://llvm.org/viewvc/llvm-project?rev=357626=rev Log: Fix and simplify PrepareCommandsForSourcing Spotted some problems in the Driver's PrepareCommandsForSourcing while helping a colleague track another problem. 1. One

[Lldb-commits] [PATCH] D59775: Minidump: Add support for reading/writing strings

labath added a reviewer: amccarth. labath added a comment. In D59775#1442987 , @clayborg wrote: > Looks fine to me, but probably need a LLVM specific person for the final ok Maybe @zturner or @amccarth could be the LLVM person ? :) Repository: rL

[Lldb-commits] [PATCH] D60152: Fix and simplify PrepareCommandsForSourcing

labath accepted this revision. labath added inline comments. Comment at: lldb/tools/driver/Driver.cpp:492-496 #ifdef _WIN32 - _close(fds[WRITE]); - fds[WRITE] = -1; + _close(fd); #else - close(fds[WRITE]); - fds[WRITE] = -1; + close(fd); #endif

[Lldb-commits] [PATCH] D60180: [CMake] Don't explicitly use LLVM_LIBRARY_DIR in standalone builds

xiaobai added a comment. In D60180#1453106 , @sgraenitz wrote: > Major concern from my side is that clang does something like this too: > > clang/CMakeLists.txt > 86: set(LLVM_LIBRARY_DIR ${LIBRARY_DIR} CACHE PATH "Path to llvm/lib") > 125:

[Lldb-commits] [PATCH] D60153: Re-enable most lldb-vscode tests on Linux.

clayborg added a comment. Thanks for getting this stuff reliably working. I debug using VS Code every day using lldb-vscode and it is my favorite LLDB based debugger! I look forward to seeing support for Windows and linux being tested and available. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D59826: [expression] Explicitly build the lookup table of any TagDecl's context

clayborg added a comment. In D59826#1452771 , @martong wrote: > In D59826#1451536 , @clayborg wrote: > > > Any way to dump the AST in a test to verify we don't create multiple? > > > I think I might be able to

Re: [Lldb-commits] [PATCH] D60001: Allow partial UUID matching in Minidump core file plug-in

So I resubmitted with 357603 and green dragon seems happy. I will continue to watch for any issues. Let me know if there are other failures that I don't know about > On Apr 2, 2019, at 11:57 AM, Adrian Prantl via Phabricator > wrote: > > aprantl added a comment. > > Since this commit,

[Lldb-commits] [PATCH] D60018: [codeview] Remove Type member from CVRecord

rnk updated this revision to Diff 193526. rnk added a comment. - final updates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60018/new/ https://reviews.llvm.org/D60018 Files: lld/COFF/PDB.cpp

[Lldb-commits] [PATCH] D60018: [codeview] Remove Type member from CVRecord

rnk marked 2 inline comments as done. rnk added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60018/new/ https://reviews.llvm.org/D60018 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D60001: Allow partial UUID matching in Minidump core file plug-in

clayborg added a comment. ok, so I think I figured out what was going on: I had the .so files still in my build packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new directory. They didn't show up in the "svn stat" command because they are ignored!!! arg! That is what was

[Lldb-commits] [lldb] r357603 - Attempt #2 to get this patch working. I will watch the build bots carefully today.

Author: gclayton Date: Wed Apr 3 09:30:44 2019 New Revision: 357603 URL: http://llvm.org/viewvc/llvm-project?rev=357603=rev Log: Attempt #2 to get this patch working. I will watch the build bots carefully today. Allow partial UUID matching in Minidump core file plug-in Breakpad had bugs in

[Lldb-commits] [PATCH] D60195: modify-python-lldb.py: (Re)move __len__ and __iter__ support

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. Nice! Thanks for cleaning up the affected comments as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60195/new/ https://reviews.llvm.org/D60195

[Lldb-commits] [PATCH] D60152: Fix and simplify PrepareCommandsForSourcing

amccarth updated this revision to Diff 193515. amccarth edited the summary of this revision. amccarth added a comment. Further simplification per labath's feedback. Specifically: 1. Use a utility function from llvm to avoid making own wrapper for closing a file descriptor. 2. Don't bother

[Lldb-commits] [PATCH] D60001: Allow partial UUID matching in Minidump core file plug-in

clayborg marked 2 inline comments as done. clayborg added inline comments. Comment at: lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpUUID.py:160 +self.verify_module(modules[0], +

[Lldb-commits] [PATCH] D60152: Fix and simplify PrepareCommandsForSourcing

amccarth marked an inline comment as done. amccarth added a comment. Thanks for the review. In D60152#1452704 , @labath wrote: > FTR, I believe using pipes here is wrong altogether because it can lead to > deadlock. The size of the pipe buffer is

[Lldb-commits] [lldb] r357600 - [LLDB] - Update the test cases after yaml2obj change.

Author: grimar Date: Wed Apr 3 08:28:35 2019 New Revision: 357600 URL: http://llvm.org/viewvc/llvm-project?rev=357600=rev Log: [LLDB] - Update the test cases after yaml2obj change. https://reviews.llvm.org/D60122 (r357595) changed the symbols description format in yaml2obj. This change updates

Re: [Lldb-commits] [PATCH] D60001: Allow partial UUID matching in Minidump core file plug-in

At the moment no. In a hypothetical future where LLVM is hosted on github, we could set up a system similar to the swift-lldb pull request testing, but for now that is all we have. On the flip side, I don't mind trying things out by committing a speculative fix as long as it is quickly reverted

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha added a comment. Hi, currently we have a private build server that executes the test-suite on ARC. There are failures for now, mostly due to unimplemented features for ARC like expressions support. I'll take care of a public build-bot, if it is required. Repository: rLLDB

[Lldb-commits] [PATCH] D60001: Allow partial UUID matching in Minidump core file plug-in

labath added inline comments. Comment at: lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpUUID.py:160 +self.verify_module(modules[0], + "libuuidmatch.so", +

[Lldb-commits] [PATCH] D60195: modify-python-lldb.py: (Re)move __len__ and __iter__ support

labath created this revision. labath added reviewers: amccarth, clayborg, jingham. This patch moves the modify-python-lldb code for adding new functions to the SBModule class into the SBModule interface file. As this is the last class using this functionality, I also remove all support for this

[Lldb-commits] [lldb] r357572 - modify-python-lldb.py: clean up __iter__ and __len__ support

Author: labath Date: Wed Apr 3 04:48:38 2019 New Revision: 357572 URL: http://llvm.org/viewvc/llvm-project?rev=357572=rev Log: modify-python-lldb.py: clean up __iter__ and __len__ support Summary: Instead of modifying the swig-generated code, just add the appropriate methods to the interface

[Lldb-commits] [PATCH] D60119: modify-python-lldb.py: clean up __iter__ and __len__ support

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB357572: modify-python-lldb.py: clean up __iter__ and __len__ support (authored by labath, committed by ). Herald added a subscriber: abidh. Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D60180: [CMake] Don't explicitly use LLVM_LIBRARY_DIR in standalone builds

labath added a comment. The reasoning makes sense to me, but maybe one of the standalone folks could confirm that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60180/new/ https://reviews.llvm.org/D60180 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D59826: [expression] Explicitly build the lookup table of any TagDecl's context

martong added a comment. In D59826#1451536 , @clayborg wrote: > Any way to dump the AST in a test to verify we don't create multiple? I think I might be able to use the `log` object to dump the AST and then from python it would be possible to check for

[Lldb-commits] [PATCH] D60178: [Reproducers] Capture return values of functions returning by ptr/ref

labath added a comment. I agree that these functions should be recorded. I think the reason that the infrastructure already mostly supports that is that we were modelling constructors as functions that return pointers (and you definitely need to record constructors).

[Lldb-commits] [PATCH] D60172: Renamed Target::GetSharedModule to AddModule, allow for ModulesDidLoad to be delayed when batch adding Modules

labath added a comment. Thank you for taking the time to rename this function. I think this has been long overdue. However, I believe that the name `AddModule` might cause confusion coming from the other direction, as now one may think that it unconditionally adds a new module to the target

[Lldb-commits] [PATCH] D60152: Fix and simplify PrepareCommandsForSourcing

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Nice cleanup, thanks. I have one suggestion inline you can implement if you think it's a good idea. FTR, I believe using pipes here is wrong altogether because it can lead to deadlock. The