[Lldb-commits] [PATCH] D61292: Include inlined functions when figuring out a contiguous address range

aadsm created this revision. aadsm added reviewers: clayborg, jasonmolenda. Herald added subscribers: lldb-commits, jdoerfert, eraman, mgorny. Herald added a project: LLDB. This diff changes the function `LineEntry::GetSameLineContiguousAddressRange` so that it also includes function calls that w

[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump

aadsm updated this revision to Diff 197246. aadsm added a comment. Only store needed data for dumping and put everything in the struct. Also fix tests to do sequential calls instead of recursive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61235/

[Lldb-commits] [PATCH] D61128: Support member function types in PdbAstBuilder

zloyrobot added a comment. In D61128#1482765 , @amccarth wrote: > Thanks for the improved commit message. Again, sorry about the delay. No problem, thanks for review! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6112

[Lldb-commits] [lldb] r359420 - [Windows] Dump more information about access violation exception

Author: aleksandr.urakov Date: Mon Apr 29 00:29:25 2019 New Revision: 359420 URL: http://llvm.org/viewvc/llvm-project?rev=359420&view=rev Log: [Windows] Dump more information about access violation exception Summary: Dump more information about "access violation" and "in page error" exceptions to

[Lldb-commits] [PATCH] D60519: [Windows] Dump more information about access violation exception

This revision was automatically updated to reflect the committed changes. Closed by commit rL359420: [Windows] Dump more information about access violation exception (authored by aleksandr.urakov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[Lldb-commits] [PATCH] D61210: [lldb] [lit] Introduce tests for reading x86 general purpose registers

labath added a comment. Looks good to me. In your place, I wouldn't bother with making sure that the process can correctly terminate after we have read the registers, but now that you have done it, there's no reason to take it out. :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61210

[Lldb-commits] [PATCH] D61221: [lldb] [lit] Introduce tests for writing x86 general-purpose registers

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This is great stuff. Thanks for doing this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61221/new/ https://reviews.llvm.org/D61221 ___

[Lldb-commits] [PATCH] D61233: Refactor ObjectFile::GetSDKVersion

labath added a comment. In D61233#1481527 , @teemperor wrote: > I decided to go for a vector because otherwise the implementation in > ObjectFileMachO gets a bit awkward. But I have no problem with doing a > VersionTuple instead and adding some manual tr

[Lldb-commits] [PATCH] D61231: Add 'oneOf' utility function for comparing a ConstString against a set of strings

labath added a comment. In D61231#1481804 , @teemperor wrote: > Yeah, I'm also just like 60% confident that this more readable/expressive. I'm about 70% against this ( :P ), and the main reason for that opinion is that there is nothing like this in ll

[Lldb-commits] [PATCH] D61244: Re-enable gmodules tests on Linux

labath added a comment. LG, but note that this has no effect on the overall set of tests which will run as long as gmodules remains disabled in `test_categories.is_supported_on_platform`. The other thing to note is that the effect of enabling gmodules extremely strongly depends on how your sys

[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump

labath added inline comments. Comment at: lldb/source/Utility/Timer.cpp:98-101 m_category.m_nanos += std::chrono::nanoseconds(timer_dur).count(); + m_category.m_nanos_total += std::chrono::nanoseconds(total_dur).count(); + m_category.m_nanos_child += + std::chrono::nano

[Lldb-commits] [PATCH] D61244: Re-enable gmodules tests on Linux

teemperor updated this revision to Diff 197074. teemperor added a comment. - Add 'linux' to the list of platforms supporting gmodules. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61244/new/ https://reviews.llvm.org/D61244 Files: lldb/packages/Python/lldbsuite/test/lang/cpp/gmodule

[Lldb-commits] [PATCH] D61244: Re-enable gmodules tests on Linux

teemperor added a comment. In D61244#1482146 , @labath wrote: > LG, but note that this has no effect on the overall set of tests which will > run as long as gmodules remains disabled in > `test_categories.is_supported_on_platform`. Oh, true, thanks for

[Lldb-commits] [PATCH] D61212: [lldb] [lit] Add tests for reading ZMM registers (AVX512)

labath accepted this revision. labath added a subscriber: JDevlieghere. labath added a comment. This revision is now accepted and ready to land. The test fails on linux even with the right hardware, but that's not surprising as the original test was also @skipUnlessDarwin (and I see no trace of z

[Lldb-commits] [PATCH] D61216: [Docs] Make it possible to generate the python reference without building all of LLDB

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good to me. Thanks for looking into this. On one hand, it would be nice to create avoid creating the fake package, and just run epydoc from the final destination, but on the other, the n

[Lldb-commits] [PATCH] D61182: DWARFExpression: Fix implementation of DW_OP_pick

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB359436: DWARFExpression: Fix implementation of DW_OP_pick (authored by labath, committed by ). Herald added a subscriber: abidh. Herald added a project: LLDB. Changed prior to commit: https://reviews

[Lldb-commits] [lldb] r359436 - DWARFExpression: Fix implementation of DW_OP_pick

Author: labath Date: Mon Apr 29 03:55:22 2019 New Revision: 359436 URL: http://llvm.org/viewvc/llvm-project?rev=359436&view=rev Log: DWARFExpression: Fix implementation of DW_OP_pick Summary: The DWARF spec states that the DWARF stack arguments are numbered from the top. Our implementation of DW_

[Lldb-commits] [PATCH] D61183: PostfixExpression: Introduce CFANode

labath added a comment. In D61183#1480948 , @clayborg wrote: > FYI: for all DWARF expressions found in EH frame stuff, they expect the CFA > address to be pushed onto the stack prior to executing the expression. Do we > just want to follow suit with the

[Lldb-commits] [PATCH] D61183: PostfixExpression: Introduce CFANode

labath updated this revision to Diff 197086. labath added a comment. s/CFA/InitialValue/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61183/new/ https://reviews.llvm.org/D61183 Files: include/lldb/Symbol/PostfixExpression.h source/Symbol/PostfixExpression.cpp unittests/Symbol/Po

Re: [Lldb-commits] [PATCH] D61090: [SBHostOS} Remove getting the python script interpreter path

On 26/04/2019 19:34, Jim Ingham wrote: On Apr 26, 2019, at 1:29 AM, Pavel Labath via Phabricator wrote: labath added a comment. In D61090#1479049 , @jingham wrote: I really thought there was one at the SB layer, because in terms of design that is

[Lldb-commits] [lldb] r359440 - [lldb] [test] Remove duplicate YMM/ZMM dotest tests

Author: mgorny Date: Mon Apr 29 04:38:17 2019 New Revision: 359440 URL: http://llvm.org/viewvc/llvm-project?rev=359440&view=rev Log: [lldb] [test] Remove duplicate YMM/ZMM dotest tests Removed: lldb/trunk/packages/Python/lldbsuite/test/functionalities/register/intel_avx/ ___

[Lldb-commits] [PATCH] D61221: [lldb] [lit] Introduce tests for writing x86 general-purpose registers

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB359441: [lldb] [lit] Introduce tests for writing x86 general-purpose registers (authored by mgorny, committed by ). Herald added a subscriber: teemperor. Herald added a project: LLDB. Changed prior to

[Lldb-commits] [lldb] r359438 - [lldb] [lit] Introduce tests for reading x86 general purpose registers

Author: mgorny Date: Mon Apr 29 04:37:58 2019 New Revision: 359438 URL: http://llvm.org/viewvc/llvm-project?rev=359438&view=rev Log: [lldb] [lit] Introduce tests for reading x86 general purpose registers Introduce tests for reading the eight x86 general purpose registers, i.e. RAX/RBX/RCX/RDX/RBP

[Lldb-commits] [lldb] r359439 - [lldb] [lit] Add tests for reading ZMM registers (AVX512)

Author: mgorny Date: Mon Apr 29 04:38:10 2019 New Revision: 359439 URL: http://llvm.org/viewvc/llvm-project?rev=359439&view=rev Log: [lldb] [lit] Add tests for reading ZMM registers (AVX512) Differential Revision: https://reviews.llvm.org/D61212 Added: lldb/trunk/lit/Register/Inputs/x86-zmm-

[Lldb-commits] [lldb] r359441 - [lldb] [lit] Introduce tests for writing x86 general-purpose registers

Author: mgorny Date: Mon Apr 29 04:38:28 2019 New Revision: 359441 URL: http://llvm.org/viewvc/llvm-project?rev=359441&view=rev Log: [lldb] [lit] Introduce tests for writing x86 general-purpose registers Introduce two initial tests for 'register write' command. The tests first clobber x86 genera

[Lldb-commits] [PATCH] D61210: [lldb] [lit] Introduce tests for reading x86 general purpose registers

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB359438: [lldb] [lit] Introduce tests for reading x86 general purpose registers (authored by mgorny, committed by ). Herald added a subscriber: teemperor. Herald added a project: LLDB. Changed prior to

[Lldb-commits] [PATCH] D61212: [lldb] [lit] Add tests for reading ZMM registers (AVX512)

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB359439: [lldb] [lit] Add tests for reading ZMM registers (AVX512) (authored by mgorny, committed by ). Herald added a subscriber: teemperor. Herald added a project: LLDB. Changed prior to commit: htt

Re: [Lldb-commits] [PATCH] D61191: Editline: Fix an msan error

On 26/04/2019 18:56, Christos Zoulas wrote: On Apr 26, 3:11pm, revi...@reviews.llvm.org (Pavel Labath via Phabricator) wrote: -- Subject: [PATCH] D61191: Editline: Fix an msan error | | --b1_b299efcc557883c5ff30a5eebc16e12b | Content-Type: text/plain; charset=us-ascii | Content-Transfer-Encodi

[Lldb-commits] [PATCH] D59537: Instantiate 'std' templates explicitly in the expression evaluator

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. In D59537#1481333 , @teemperor wrote: > @martong See D59485 for the new ASTImporter > method for registering import

[Lldb-commits] [PATCH] D59485: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior.

martong accepted this revision. martong added a comment. Looks good, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59485/new/ https://reviews.llvm.org/D59485 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

Re: [Lldb-commits] [PATCH] D61191: Editline: Fix an msan error

Yes, you don't need to NULL terminate the argument list now. Here's a link to the commit: http://mail-index.netbsd.org/source-changes/2019/04/26/msg105454.html Best, christos > On Apr 29, 2019, at 7:39 AM, Pavel Labath wro

[Lldb-commits] [PATCH] D59485: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior.

martong added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:625 + "class shouldNotBeImported {};", Lang_CXX, "class realDecl {};", Lang_CXX, + "shouldNotBeImported", RedirectingImporter::Constructor); + auto *Imported = cast(To); ---

[Lldb-commits] [PATCH] D61191: Editline: Fix an msan error

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB359449: Editline: Fix an msan error (authored by labath, committed by ). Herald added a subscriber: abidh. Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D61191?vs=19

[Lldb-commits] [lldb] r359449 - Editline: Fix an msan error

Author: labath Date: Mon Apr 29 06:54:12 2019 New Revision: 359449 URL: http://llvm.org/viewvc/llvm-project?rev=359449&view=rev Log: Editline: Fix an msan error Summary: libedit implementation of el_get(EL_GETTC) had a bug, where it was consuming vararg arguments until reaching the first null poi

[Lldb-commits] [lldb] r359450 - Remove obsoleted NativePDB tests

Author: labath Date: Mon Apr 29 07:00:58 2019 New Revision: 359450 URL: http://llvm.org/viewvc/llvm-project?rev=359450&view=rev Log: Remove obsoleted NativePDB tests Their functionality overlaps with the newly introduced PostfixExpressionTests (r359288). Tests, which still exercise some pdb-relat

[Lldb-commits] [lldb] r359451 - Fix a typo in x86-64-gp-write.test

Author: labath Date: Mon Apr 29 07:04:41 2019 New Revision: 359451 URL: http://llvm.org/viewvc/llvm-project?rev=359451&view=rev Log: Fix a typo in x86-64-gp-write.test The test was building the wrong inferior, causing failures. Modified: lldb/trunk/lit/Register/x86-64-gp-write.test Modified

[Lldb-commits] [lldb] r359452 - @skipIfLinux another batch of flaky lldb-mi tests

Author: labath Date: Mon Apr 29 07:12:05 2019 New Revision: 359452 URL: http://llvm.org/viewvc/llvm-project?rev=359452&view=rev Log: @skipIfLinux another batch of flaky lldb-mi tests Modified: lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/breakpoint/TestMiBreak.py lldb/trunk/p

[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump

aadsm planned changes to this revision. aadsm marked 2 inline comments as done. aadsm added inline comments. Comment at: lldb/source/Utility/Timer.cpp:110-123 +namespace { +struct Stats { + uint64_t nanos; + uint64_t nanos_total; + uint64_t nanos_child; + uint64_t count; +};

[Lldb-commits] [lldb] r359456 - Remove XFAIL: windows from x86-64-gp-write.test

Author: labath Date: Mon Apr 29 08:16:26 2019 New Revision: 359456 URL: http://llvm.org/viewvc/llvm-project?rev=359456&view=rev Log: Remove XFAIL: windows from x86-64-gp-write.test The typo fix in r359451 was enough to get it passing there. Modified: lldb/trunk/lit/Register/x86-64-gp-write.t

[Lldb-commits] [PATCH] D59015: [lldb-mi] Include full path in the -data-disassemble response

anton.kolesov updated this revision to Diff 197117. anton.kolesov added a comment. Allocate path buffer on stack instead of heap. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59015/new/ https://reviews.llvm.org/D59015 Files: lldb/packages/Python/lldbsuite/t

[Lldb-commits] [lldb] r359465 - [Docs] Generate the python reference without building all of LLDB

Author: jdevlieghere Date: Mon Apr 29 09:29:10 2019 New Revision: 359465 URL: http://llvm.org/viewvc/llvm-project?rev=359465&view=rev Log: [Docs] Generate the python reference without building all of LLDB As discussed on the mailing list, we should be able to generate the Python reference without

[Lldb-commits] [PATCH] D61266: Skip TestClassTemplateParameterPack.py on all platforms

shafik created this revision. shafik added reviewers: jingham, aprantl, teemperor. The `TestClassTemplateParameterPack.py` test does not work for the right reasons. The expressions such as: expression -- C().isSixteenThirtyTwo() work only because we are currently pulling all the local variabl

[Lldb-commits] [PATCH] D61216: [Docs] Make it possible to generate the python reference without building all of LLDB

This revision was automatically updated to reflect the committed changes. Closed by commit rL359465: [Docs] Generate the python reference without building all of LLDB (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [PATCH] D59015: [lldb-mi] Include full path in the -data-disassemble response

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. LGTM. If there are any other " std::unique_ptr" instances you would like to fix after this patch, feel free to submit more fixes without need for review. Repository: rLLDB LLDB CHANGE

[Lldb-commits] [PATCH] D61266: Skip TestClassTemplateParameterPack.py on all platforms

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. > So a long-term fix for this would require at least reworking ho that debug > information is generated. I believe the debug information correct but our lookup is just not finding/loa

[Lldb-commits] [lldb] r359471 - Fix a stack-smasher in PlatformMacOSX::GetSDKDirectory()

Author: adrian Date: Mon Apr 29 10:28:38 2019 New Revision: 359471 URL: http://llvm.org/viewvc/llvm-project?rev=359471&view=rev Log: Fix a stack-smasher in PlatformMacOSX::GetSDKDirectory() GetSDKVersion expects the number of version fields not their byte size and will happily overwrite later con

[Lldb-commits] [PATCH] D61218: Fix a stack-smasher in PlatformMacOSX::GetSDKDirectory()

This revision was automatically updated to reflect the committed changes. Closed by commit rL359471: Fix a stack-smasher in PlatformMacOSX::GetSDKDirectory() (authored by adrian, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: http

[Lldb-commits] [PATCH] D59485: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior.

teemperor updated this revision to Diff 197149. teemperor added a comment. - Refactored test according to Gábor's feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59485/new/ https://reviews.llvm.org/D59485 Files: clang/include/clang/AST/ASTImporter.h clang/lib/AST/ASTImporte

[Lldb-commits] [PATCH] D61128: Support member function types in PdbAstBuilder

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. Thanks for the improved commit message. Again, sorry about the delay. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.h:183

[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump

aadsm marked an inline comment as done. aadsm added inline comments. Comment at: lldb/unittests/Utility/TimerTest.cpp:100-101 + << "String: " << ss.GetData(); + EXPECT_GT(total1 - child1, seconds1 - 0.001); + EXPECT_LT(total1 - child1, seconds1 + 0.001); + EXPECT_EQ(1, co

[Lldb-commits] [PATCH] D61240: Implement GetSystemIncludeDirectories for macOS

aprantl added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp:244 + case lldb::eLanguageTypeObjC_plus_plus: +return {sys_root + "/usr/include/"}; + default: I'm not 100% sure if that is how Clang header search works, but

[Lldb-commits] [PATCH] D61240: Implement GetSystemIncludeDirectories for macOS

aprantl added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp:244 + case lldb::eLanguageTypeObjC_plus_plus: +return {sys_root + "/usr/include/"}; + default: aprantl wrote: > aprantl wrote: > > I'm not 100% sure if that is

[Lldb-commits] [PATCH] D61240: Implement GetSystemIncludeDirectories for macOS

aprantl added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp:244 + case lldb::eLanguageTypeObjC_plus_plus: +return {sys_root + "/usr/include/"}; + default: aprantl wrote: > I'm not 100% sure if that is how Clang header s

[Lldb-commits] [PATCH] D61233: Refactor ObjectFile::GetSDKVersion

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Awesome. I should have done that right away. This isn't super important, but I feel like just returning a vector (with potentially zero elements would be just as good) and the Optional doesn

[Lldb-commits] [lldb] r359487 - [test] Disable x86-64-gp-write on Darwin

Author: jdevlieghere Date: Mon Apr 29 12:39:09 2019 New Revision: 359487 URL: http://llvm.org/viewvc/llvm-project?rev=359487&view=rev Log: [test] Disable x86-64-gp-write on Darwin Modified: lldb/trunk/lit/Register/x86-64-gp-write.test Modified: lldb/trunk/lit/Register/x86-64-gp-write.test UR

[Lldb-commits] [PATCH] D59537: Instantiate 'std' templates explicitly in the expression evaluator

aprantl added inline comments. Comment at: lldb/include/lldb/Symbol/ClangASTContext.h:1005 +// May be null if we are already done parsing this ASTContext or the +// ASTContext wasn't created by parsing source code. +clang::Sema * m_se

[Lldb-commits] [lldb] r359490 - [CMake] Fix subtle CMake bug

Author: xiaobai Date: Mon Apr 29 12:44:43 2019 New Revision: 359490 URL: http://llvm.org/viewvc/llvm-project?rev=359490&view=rev Log: [CMake] Fix subtle CMake bug CMake specifies that the DEPENDS field of add_custom_target is for files and output of add_custom_command. In order to add a target de

[Lldb-commits] [PATCH] D61266: Skip TestClassTemplateParameterPack.py on all platforms

friss requested changes to this revision. friss added a comment. This revision now requires changes to proceed. We shouldn't skip the whole test, just the expressions that worked for bad reasons. Calling functions on local variables should work, it's just creating the templated objects that is c

[Lldb-commits] [lldb] r359492 - [lit] Fix the timeout.

Author: jdevlieghere Date: Mon Apr 29 12:55:49 2019 New Revision: 359492 URL: http://llvm.org/viewvc/llvm-project?rev=359492&view=rev Log: [lit] Fix the timeout. The timeout wasn't working because it's a property of the lit configuration, not of the configuration in lit.site.cfg. This sets the pr

[Lldb-commits] [PATCH] D59537: Instantiate 'std' templates explicitly in the expression evaluator

teemperor updated this revision to Diff 197170. teemperor added a comment. - Fixed m_sema documentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59537/new/ https://reviews.llvm.org/D59537 Files: lldb/include/lldb/Symbol/ClangASTContext.h lldb/include/lldb/Symbol/ClangASTImpor

[Lldb-commits] [PATCH] D61183: PostfixExpression: Introduce CFANode

amccarth accepted this revision. amccarth added a comment. LGTM, but I found one comment a bit confusing for me. Comment at: source/Symbol/PostfixExpression.cpp:150 + /// InitialValueNodes in our input expression, we assume the initial stack + /// will contain their value (he

[Lldb-commits] [PATCH] D59537: Instantiate 'std' templates explicitly in the expression evaluator

teemperor marked 2 inline comments as done. teemperor added inline comments. Comment at: lldb/include/lldb/Symbol/ClangASTImporter.h:249 +/// it at the end of the scope. Supports being used multiple times on the +/// same Minion instance in nested scopes. +class CxxMo

[Lldb-commits] [PATCH] D59537: Instantiate 'std' templates explicitly in the expression evaluator

aprantl added inline comments. Comment at: lldb/include/lldb/Symbol/ClangASTImporter.h:249 +/// it at the end of the scope. Supports being used multiple times on the +/// same Minion instance in nested scopes. +class CxxModuleScope { teemperor wrote:

[Lldb-commits] [PATCH] D61244: Re-enable gmodules tests on Linux

teemperor added a reviewer: aprantl. teemperor planned changes to this revision. teemperor added a comment. I looked into this a bit further and I think the best way forward is to enable gmodules on Linux but exclude all tests that rely on system modules (i.e. std or libc) as that really seems t

[Lldb-commits] [lldb] r359503 - [lit] Check for the psutil module when setting a timeout

Author: jdevlieghere Date: Mon Apr 29 14:03:39 2019 New Revision: 359503 URL: http://llvm.org/viewvc/llvm-project?rev=359503&view=rev Log: [lit] Check for the psutil module when setting a timeout Apparently setting the per-test-timeout and not having the psutil package constitutes to a fatal erro

[Lldb-commits] [PATCH] D61266: Skip TestClassTemplateParameterPack.py on all platforms

shafik added a comment. @friss updated the change to only effect those specifically broken. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61266/new/ https://reviews.llvm.org/D61266 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

[Lldb-commits] [PATCH] D59485: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior.

teemperor added a comment. I'll land this as it seems only the tests are subject to change and I want to also land the dependencies of this patch. Please let me know if you want any other changes changes to the test and thanks for the review! CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D61266: Skip TestClassTemplateParameterPack.py on all platforms

shafik updated this revision to Diff 197178. shafik added a comment. Fred is correct, I mistakenly thought the parts of the test that were working were being covered elsewhere but that is not the case. So I have reworked this change to instead of skipping the whole test to comment out the inline

[Lldb-commits] [PATCH] D59485: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior.

This revision was automatically updated to reflect the committed changes. Closed by commit rC359502: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior. (authored by teemperor, committed by ). Changed prior to commit: https://reviews.llvm.org/D59485?vs=197149&id=197180#

[Lldb-commits] [PATCH] D61266: Skip TestClassTemplateParameterPack.py on all platforms

friss added inline comments. Comment at: packages/Python/lldbsuite/test/lang/cpp/class-template-parameter-pack/main.cpp:48-50 +// Commenting out some of the expressions because they work for the wrong reasons and will break all together +

[Lldb-commits] [PATCH] D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF

teemperor added inline comments. Comment at: packages/Python/lldbsuite/test/expression_command/argument_passing_restrictions/main.cpp:40 +return Shape::empty_shape()->bounds().x; // break here +} Some small things: 1. I think the source here is not clang-for

[Lldb-commits] [PATCH] D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF

aprantl added inline comments. Comment at: packages/Python/lldbsuite/test/expression_command/argument_passing_restrictions/TestArgumentPassingRestrictions.py:26 +lldbutil.run_to_source_breakpoint(self, '// break here', +lldb.SBFileSpec("main.cpp", False)) + -

[Lldb-commits] [PATCH] D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()

asmith updated this revision to Diff 197239. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56229/new/ https://reviews.llvm.org/D56229 Files: lit/Modules/PECOFF/export-dllfunc.yaml lit/Modules/PECOFF/uuid.yaml source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/Ob

[Lldb-commits] [lldb] r359528 - [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()

Author: asmith Date: Mon Apr 29 18:41:33 2019 New Revision: 359528 URL: http://llvm.org/viewvc/llvm-project?rev=359528&view=rev Log: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID() Summary: Provide an implementation of GetUUID() for remote debugging scenarios. Return a PDB's GUID (or PDB