Author: rsmith
Date: Wed May 8 21:40:57 2019
New Revision: 360312
URL: http://llvm.org/viewvc/llvm-project?rev=360312&view=rev
Log:
Fix up lldb after clang r360311.
Patch by Tyker!
Differential Revision: https://reviews.llvm.org/D60934
Modified:
lldb/trunk/source/Symbol/ClangASTContext.cpp
jgorbe created this revision.
jgorbe added reviewers: labath, zturner.
Herald added a subscriber: teemperor.
Herald added a project: LLDB.
All the other paths in the find_toolchain function return a tuple
(detected_toolchain_type, compiler_path), but when the parameter to
`--compiler` is not one
Author: jingham
Date: Wed May 8 18:43:27 2019
New Revision: 360304
URL: http://llvm.org/viewvc/llvm-project?rev=360304&view=rev
Log:
Fix the output file dependency for Options.inc.
The script phase to do Options.td -> Options.inc was
wrong (missing the "include" directory) so the rule didn't
get
Author: jdevlieghere
Date: Wed May 8 15:59:35 2019
New Revision: 360298
URL: http://llvm.org/viewvc/llvm-project?rev=360298&view=rev
Log:
[Reproducers] Fix reproducer unittest
I think the recent change to flush the SB API recording uncovered a real
issue on the Windows bot. Although I couldn't m
Author: gclayton
Date: Wed May 8 15:03:22 2019
New Revision: 360292
URL: http://llvm.org/viewvc/llvm-project?rev=360292&view=rev
Log:
Fix bug in ArchSpec::MergeFrom
Previous ArchSpec tests didn't catch this bug since we never tested just the OS
being out of date. Fixed the bug and covered this
This revision was automatically updated to reflect the committed changes.
Closed by commit rL360292: Fix bug in ArchSpec::MergeFrom (authored by
gclayton, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D61
stella.stamenova added a comment.
A couple of the tests from TestVSCode_attach.py (test_by_pid and test_by_name)
are failing for us on Ubuntu because they are failing to attach:
`AssertionError: False is not True : attach failed (Operation not permitted)`.
It looks like attaching by pid or by n
Author: jdevlieghere
Date: Wed May 8 14:07:19 2019
New Revision: 360286
URL: http://llvm.org/viewvc/llvm-project?rev=360286&view=rev
Log:
[Reproducers] Flush files to disk periodically
Periodically flush some of the data to disk. Although not perfect, this
helps when the debugger crashes.
Modif
Author: jdevlieghere
Date: Wed May 8 14:07:15 2019
New Revision: 360285
URL: http://llvm.org/viewvc/llvm-project?rev=360285&view=rev
Log:
[Reproducers] Fix unitialized pointer
The FileCollector pointer in the FileSystem class wasn't initialized to
nullptr during replay.
Modified:
lldb/trunk
Tagging in Teresa as well for the thinlto parts.
On Wed, May 8, 2019 at 12:43 PM Nico Weber via Phabricator
wrote:
>
> thakis added a comment.
>
> That problem only seems to happen when (thin) lto is enabled.
>
>
> Repository:
> rL LLVM
>
> CHANGES SINCE LAST ACTION
> https://reviews.llvm.org
compnerd added inline comments.
Comment at: include/lldb/Host/windows/PosixApi.h:108
+ // To be implemented.
+ return pid_t(-1);
+}
This should be out-of-lined. Furthermore, is there any place where the use
requires process group handling? Otherwise, can't w
amccarth marked an inline comment as done.
amccarth added inline comments.
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:220
+// In most cases the missing notifications do not affect lldb-server
+// so we are temporarily relaxing the
thakis added a comment.
That problem only seems to happen when (thin) lto is enabled.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54747/new/
https://reviews.llvm.org/D54747
___
lldb-commits mailing list
lldb-commits
Hui added inline comments.
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:220
+// In most cases the missing notifications do not affect lldb-server
+// so we are temporarily relaxing the following for Windows.
+#if !defined(_WIN32)
---
thakis added a comment.
Hello, in a bit of a https://xkcd.com/1172/ moment this breaks the
chromium/android build. We have a list of "resources" (strings, bitmaps, etc)
that we list in an XML file which then generates a header with lots of
"IDR_foo" constants. As it turns out, now all of these
amccarth added inline comments.
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:220
+// In most cases the missing notifications do not affect lldb-server
+// so we are temporarily relaxing the following for Windows.
+#if !defined(_WIN32
sgraenitz added inline comments.
Comment at: lldb/source/Symbol/ClangASTImporter.cpp:68
+ return *ret_or_error;
+} else {
+ Log *log =
aprantl wrote:
> The `else` is redundant.
Here it's necessary for the scope of `ret_or_error`. That's a bit unfort
sgraenitz marked 3 inline comments as done.
sgraenitz added a comment.
Thanks for your reply and thoughts about that.
> I'd strongly encourage you to try to come up with a testing strategy here.
Yes, I just added a simple lit test. What do you think?
I ran it in isolation on macOS (`UNSUPPORTED`
sgraenitz updated this revision to Diff 198692.
sgraenitz added a comment.
Herald added a reviewer: alexshap.
Add lit test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61611/new/
https://reviews.llvm.org/D61611
Files:
lldb/lit/Breakpoint/Inputs
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB360269: [Docs] list command: lldb run
(authored by JDevlieghere, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D61483?vs=198223&id=198686#toc
Repository:
rLLDB LLDB
CHA
Author: jdevlieghere
Date: Wed May 8 09:31:47 2019
New Revision: 360269
URL: http://llvm.org/viewvc/llvm-project?rev=360269&view=rev
Log:
[Docs] list command: lldb run
The run command is only an abbreviation for the more verbose process
launch -- but it works just as with GDB and therefore sho
aprantl added inline comments.
Comment at: clang/lib/AST/ASTImporter.cpp:5039
+ if (!ToOrErr)
+// FIXME: return the error?
+consumeError(ToOrErr.takeError());
We don't typically commit FIXME's into LLVM code. Why not just deal wit
asmith updated this revision to Diff 198675.
asmith retitled this revision from "Disable pty redirection on Windows and add
a method to get the parent pid" to "Enable lldb-server on Windows".
asmith edited the summary of this revision.
Herald added subscribers: mgorny, srhines.
CHANGES SINCE LAST
asmith created this revision.
asmith added reviewers: labath, rnk.
Herald added a reviewer: jfb.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D61687
Files:
packages/Python/lldbsuite/test/dotest.py
packages/Python/lld
martong added a comment.
Ping @shafik @teemperor
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61333/new/
https://reviews.llvm.org/D61333
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https
asmith created this revision.
asmith added reviewers: labath, rnk.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
More changes for lldb-server on Windows
- Disable pty redirection for Windows since there is no pty support currently
- Add a method to get the parent pid for
labath updated this revision to Diff 198653.
labath marked 2 inline comments as done.
labath added a comment.
Address review comments.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61423/new/
https://reviews.llvm.org/D61423
Files:
include/llvm/ObjectYAML/Minidu
labath marked 9 inline comments as done.
labath added inline comments.
Comment at: include/llvm/ObjectYAML/MinidumpYAML.h:58
+/// streams with similar structure.
+template
+struct ListStream : public Stream {
jhenderson wrote:
> KindV and TypeV aren't clear name
This revision was automatically updated to reflect the committed changes.
labath marked an inline comment as done.
Closed by commit rL360246: [DWARF] Centralize user_id <-> DWARFDIE
conversions (authored by labath, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commi
labath marked 3 inline comments as done.
labath added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h:138-139
+ DWARFDIE GetDIEFromUID(lldb::user_id_t uid);
+ lldb::user_id_t GetUIDFromDIE(DWARFBaseDIE die);
+ lldb::user_id_t GetUIDFromDIERef(DIE
Author: labath
Date: Wed May 8 04:43:05 2019
New Revision: 360246
URL: http://llvm.org/viewvc/llvm-project?rev=360246&view=rev
Log:
[DWARF] Centralize user_id <-> DWARFDIE conversions
Summary:
The logic for translating a user_id into a DWARFDIE was replicated in
several places. This removes that
martong updated this revision to Diff 198623.
martong added a comment.
- Use LLDB_LOG_ERROR in ImportDefinitionTo
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61438/new/
https://reviews.llvm.org/D61438
Files:
clang/include/clang/AST/ASTImporter
martong updated this revision to Diff 198618.
martong added a comment.
- Add braces to 'true' cases when 'false' case has braces
- Simplify logging and error handling with LLDB_LOG_ERROR
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61438/new/
http
kkleine added a comment.
@labath @jingham @teemperor I've updated the documentation in both, the new and
the old places. Can you please merge this?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61483/new/
https://reviews.llvm.org/D61483
___
34 matches
Mail list logo
