[Lldb-commits] [PATCH] D62771: [LLDBregisterNum] Update function call llvm::codeview::getRegisterNames(CPUType) in lldb

kusmour created this revision. kusmour added reviewers: xiaobai, compnerd. Herald added subscribers: lldb-commits, kristof.beyls, javed.absar. Herald added a project: LLDB. llvm updated the function from `llvm::codeview::getRegisterNames()` to `llvm::codeview::getRegisterNames(CPUType)` according

[Lldb-commits] [PATCH] D62772: [COFF, ARM64] Fix CodeView API change for getRegisterNames

TomTan created this revision. TomTan added reviewers: efriedma, rnk, mgorny, mstorsjo. TomTan added a project: LLDB. Herald added subscribers: lldb-commits, kristof.beyls. Change rL362280 (https://reviews.llvm.org/rL362280) changed CodeView API getRegisterNames

[Lldb-commits] [PATCH] D62772: [COFF, ARM64] Fix CodeView API change for getRegisterNames

mgorny added a reviewer: labath. mgorny added a comment. Are you sure this triple → CPUType mapping belongs in each consumer? Maybe it'd be better to have something inside LLVM, so that we wouldn't have to keep this up-to-date in all the places. Maybe `getRegisterNames()` overload that takes a

[Lldb-commits] [PATCH] D62772: [COFF, ARM64] Fix CodeView API change for getRegisterNames

TomTan updated this revision to Diff 202540. TomTan edited the summary of this revision. TomTan added a comment. Update variable naming to be consistent with current file. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62772/new/ https://reviews.llvm.org/D62772

[Lldb-commits] [PATCH] D62772: [COFF, ARM64] Fix CodeView API change for getRegisterNames

TomTan added a comment. In D62772#1526145 , @mgorny wrote: > Are you sure this triple → CPUType mapping belongs in each consumer? Maybe > it'd be better to have something inside LLVM, so that we wouldn't have to > keep this up-to-date in all the places.

[Lldb-commits] [PATCH] D62634: Improve DWARF parsing and accessing by 1% to 2%

jankratochvil added a comment. On Fedora 29 x86_64 it broke: FAIL: LLDB (/home/jkratoch/redhat/llvm-monorepo-clangassert/bin/clang-9-x86_64) :: test_enable_dwo (TestBreakpointLocations.BreakpointLocationsTestCase) FAIL: LLDB (/home/jkratoch/redhat/llvm-monorepo-clangassert/bin/clang-9-x86_

[Lldb-commits] [PATCH] D62634: Improve DWARF parsing and accessing by 1% to 2%

clayborg added a comment. In D62634#1526174 , @jankratochvil wrote: > On Fedora 29 x86_64 it broke: > > FAIL: LLDB > (/home/jkratoch/redhat/llvm-monorepo-clangassert/bin/clang-9-x86_64) :: > test_enable_dwo (TestBreakpointLocations.BreakpointLocations

[Lldb-commits] [PATCH] D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register

compnerd added inline comments. Comment at: lldb/source/Symbol/ClangASTContext.cpp:3915 +bool ClangASTContext::CanPassInRegisters(const CompilerType &type) { + if (clang::RecordDecl *record_decl = + ClangASTContext::GetAsRecordDecl(type)) { I think that us

[Lldb-commits] [PATCH] D62772: [COFF, ARM64] Fix CodeView API change for getRegisterNames

jankratochvil added a comment. D62771 does address the same. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62772/new/ https://reviews.llvm.org/D62772 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D62785: Fix compilation following r362280

aganea created this revision. aganea added reviewers: TomTan, labath, tstellar. aganea added a project: LLDB. aganea edited reviewers, added: stella.stamenova; removed: tstellar. Repository: rLLDB LLDB https://reviews.llvm.org/D62785 Files: source/Plugins/SymbolFile/NativePDB/PdbFPOProgramTo

[Lldb-commits] [PATCH] D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register

kusmour marked 2 inline comments as done. kusmour added inline comments. Comment at: lldb/source/Symbol/ClangASTContext.cpp:3915 +bool ClangASTContext::CanPassInRegisters(const CompilerType &type) { + if (clang::RecordDecl *record_decl = + ClangASTContext::GetAsRecordDecl(

[Lldb-commits] [PATCH] D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register

kusmour updated this revision to Diff 202574. kusmour marked an inline comment as done. kusmour added a comment. small update :) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62702/new/ https://reviews.llvm.org/D62702 Files: lldb/include/lldb/Symbol/ClangAST

[Lldb-commits] [PATCH] D62788: [lldb-server unittest] Add missing teardown logic

aadsm created this revision. aadsm added reviewers: clayborg, xiaobai, labath. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This test base class is missing the teardown making the second set of tests extending it to fail in an assertion in the FileSystem::Initialize() (a

[Lldb-commits] [PATCH] D62788: [lldb-server unittest] Add missing teardown logic

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. Thanks for fixing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62788/new/ https://reviews.llvm.org/D62788 __

[Lldb-commits] [PATCH] D62771: [LLDBRegisterNum] Update function call llvm::codeview::getRegisterNames(CPUType) in lldb

xiaobai requested changes to this revision. xiaobai added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:32 +case llvm::Triple::ArchType::aarch64_32: + cpu = llvm::c

[Lldb-commits] [PATCH] D62771: [LLDBRegisterNum] Update function call llvm::codeview::getRegisterNames(CPUType) in lldb

kusmour updated this revision to Diff 202585. kusmour added a comment. fix switch statement Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62771/new/ https://reviews.llvm.org/D62771 Files: lldb/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpressio

[Lldb-commits] [PATCH] D62771: [LLDBRegisterNum] Update function call llvm::codeview::getRegisterNames(CPUType) in lldb

kusmour marked 2 inline comments as done. kusmour added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:32 +case llvm::Triple::ArchType::aarch64_32: + cpu = llvm::codeview::CPUType::ARM64; +default: --

[Lldb-commits] [lldb] r362318 - [Target] Adjust header in Thread

Author: xiaobai Date: Sat Jun 1 23:03:05 2019 New Revision: 362318 URL: http://llvm.org/viewvc/llvm-project?rev=362318&view=rev Log: [Target] Adjust header in Thread Modified: lldb/trunk/source/Target/Thread.cpp Modified: lldb/trunk/source/Target/Thread.cpp URL: http://llvm.org/viewvc/llvm

[Lldb-commits] [PATCH] D62743: Add color to the default thread and frame format.

JDevlieghere updated this revision to Diff 202587. JDevlieghere added a comment. Adrian's feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62743/new/ https://reviews.llvm.org/D62743 Files: lldb/source/Core/Debugger.cpp Index: lldb/source/Core/Debugger.cpp