[Lldb-commits] [PATCH] D62501: Implement GetSharedLibraryInfoAddress

labath added a comment. I think this is pretty good now. The only concern I have is about the placement NativeProcessTestUtils. The way you're including it now looks weird. I think we should put that in a separate place, as per the inline coment. In D62501#1533483

[Lldb-commits] [PATCH] D62502: Implement xfer:libraries-svr4:read packet

labath added a comment. In D62502#1533490 , @aadsm wrote: > @labath that's a really good point. I've talked with @clayborg and @xiaobai > about this and we decided it would be fine to do it manually as well so I > added a `XMLEncodeAttributeValue` funct

[Lldb-commits] [lldb] r362784 - Fix some signed/unsigned comparison warnings

Author: labath Date: Fri Jun 7 02:43:53 2019 New Revision: 362784 URL: http://llvm.org/viewvc/llvm-project?rev=362784&view=rev Log: Fix some signed/unsigned comparison warnings Modified: lldb/trunk/unittests/SymbolFile/DWARF/SymbolFileDWARFTests.cpp Modified: lldb/trunk/unittests/SymbolFile

[Lldb-commits] [PATCH] D62943: DWARF: Simplify SymbolFileDWARF::GetDWARFCompileUnit

This revision was automatically updated to reflect the committed changes. Closed by commit rL362783: DWARF: Simplify SymbolFileDWARF::GetDWARFCompileUnit (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINC

[Lldb-commits] [lldb] r362783 - DWARF: Simplify SymbolFileDWARF::GetDWARFCompileUnit

Author: labath Date: Fri Jun 7 02:43:47 2019 New Revision: 362783 URL: http://llvm.org/viewvc/llvm-project?rev=362783&view=rev Log: DWARF: Simplify SymbolFileDWARF::GetDWARFCompileUnit Summary: The DWARFCompileUnit is set as the "user data" of the lldb compile unit directly in the constructor (s

[Lldb-commits] [PATCH] D62948: lit/Register: Avoid stdio in register write tests

labath planned changes to this revision. labath added a comment. It looks like this problem is more widespread than we originally thought (a bunch of other tests are affected too). I'll need to think whether we can come up with a more general solution. In D62948#1533088

[Lldb-commits] [PATCH] D63005: DWARF: Don't create lldb CompileUnits for DWARF type units

labath created this revision. labath added reviewers: clayborg, JDevlieghere, aprantl. Herald added a subscriber: jdoerfert. labath added a parent revision: D62894: DWARF: Share line tables of type units. Type units don't represent actual compilations and a lot of the operations that we do with ll

[Lldb-commits] [PATCH] D62395: WIP: Dont vend lldb_private::CompileUnits for DWARFTypeUnits

labath abandoned this revision. labath added a comment. Obsoleted by https://reviews.llvm.org/D63005. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62395/new/ https://reviews.llvm.org/D62395 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [lldb] r362803 - [CMake] Add special case for processing LLDB_DOTEST_ARGS

Author: stefan.graenitz Date: Fri Jun 7 07:32:51 2019 New Revision: 362803 URL: http://llvm.org/viewvc/llvm-project?rev=362803&view=rev Log: [CMake] Add special case for processing LLDB_DOTEST_ARGS Summary: Allow to run the test suite when building LLDB Standalone with Xcode against a provided

[Lldb-commits] [PATCH] D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS

This revision was automatically updated to reflect the committed changes. Closed by commit rL362803: [CMake] Add special case for processing LLDB_DOTEST_ARGS (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[Lldb-commits] [PATCH] D62934: [LanguageRuntime] Introdce LLVM-style casts

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm Comment at: source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp:1128 - RenderScriptRuntime *lang_rt = - (RenderScriptRuntime

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

guiandrade added a comment. In D62931#1532510 , @clayborg wrote: > In D62931#1531965 , @labath wrote: > > > > > > There are so many various GDB remote servers and it is hard to say what will > work for most people.

[Lldb-commits] [PATCH] D62894: DWARF: Share line tables of type units

clayborg added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:309 + decl.SetFile( + die.GetDWARF()->GetSupportFile(*die.GetCU(), form_value.Unsigned())); break; Maybe make a "FileSpec DWARFDie::GetFile(ui

[Lldb-commits] [PATCH] D58678: Improve step over performance by not stopping at branches that are function calls and stepping into and them out of each one

clayborg added a comment. In D58678#1530031 , @lanza wrote: > @clayborg Seems like this still steps into the `call` if the call is the last > instruction in the range. `ThreadPlanStepRange::SetNextBranchBreakpoint` > checks `if (last_index - pc_index > 1

[Lldb-commits] [lldb] r362843 - [lldb] Fix msan use-of-uninitialized-value in DWARFDebugLine::FileNameEntry.

Author: jgorbe Date: Fri Jun 7 14:09:30 2019 New Revision: 362843 URL: http://llvm.org/viewvc/llvm-project?rev=362843&view=rev Log: [lldb] Fix msan use-of-uninitialized-value in DWARFDebugLine::FileNameEntry. lldb/lit/SymbolFile/DWARF/debug-types-expressions.test fails with msan. This change fix

[Lldb-commits] [PATCH] D62887: Update the thread list before setting stop reasons with an OS plugin

clayborg added inline comments. Comment at: source/Target/Process.cpp:3037-3041 + // Somebody might have gotten threads before now, but we need to force the + // update after we've loaded the OperatingSystem plugin or it won't get a + // chance to process the threads. + m_thr

[Lldb-commits] [lldb] r362844 - Fix lit tests on Windows related to CR+LF

Author: amccarth Date: Fri Jun 7 14:13:30 2019 New Revision: 362844 URL: http://llvm.org/viewvc/llvm-project?rev=362844&view=rev Log: Fix lit tests on Windows related to CR+LF Problem discovered in the breakpoint lit test, but probably exists in others. lldb-test splits lines on LF. Input files

[Lldb-commits] [lldb] r362845 - NFC: Fix typo in a cmake message

Author: amccarth Date: Fri Jun 7 14:14:01 2019 New Revision: 362845 URL: http://llvm.org/viewvc/llvm-project?rev=362845&view=rev Log: NFC: Fix typo in a cmake message Modified: lldb/trunk/cmake/modules/LLDBConfig.cmake Modified: lldb/trunk/cmake/modules/LLDBConfig.cmake URL: http://llvm.o

[Lldb-commits] [PATCH] D62759: Fix lit tests on Windows related to CR

This revision was automatically updated to reflect the committed changes. Closed by commit rL362844: Fix lit tests on Windows related to CR+LF (authored by amccarth, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

[Lldb-commits] [PATCH] D62894: DWARF: Share line tables of type units

aprantl added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:814 + offset == llvm::DenseMapInfo::getTombstoneKey()) +return empty_list; + `return {};` ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62894/new/

[Lldb-commits] [PATCH] D63005: DWARF: Don't create lldb CompileUnits for DWARF type units

aprantl added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:726 DWARFDebugInfo *info = DebugInfo(); if (info) { +BuildCuTranslationTable(); ``` if (!info) return {}; ``` ? CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [lldb] r362862 - Revert "DWARF: Simplify SymbolFileDWARF::GetDWARFCompileUnit"

Author: xiaobai Date: Fri Jun 7 17:55:03 2019 New Revision: 362862 URL: http://llvm.org/viewvc/llvm-project?rev=362862&view=rev Log: Revert "DWARF: Simplify SymbolFileDWARF::GetDWARFCompileUnit" This reverts commit 58afc1bdebf9fa8b178d6c9d89af94c5cc091760. This commit caused the test suite on ma

[Lldb-commits] [PATCH] D62943: DWARF: Simplify SymbolFileDWARF::GetDWARFCompileUnit

xiaobai added a comment. Just a heads up: I reverted this change (rL362862 ) because it broke the test suite on macOS. Breakpoints were not being resolved correctly. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62943/new/ http

[Lldb-commits] [PATCH] D62501: Implement GetSharedLibraryInfoAddress

aadsm updated this revision to Diff 203653. aadsm marked 2 inline comments as done. aadsm added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62501/new/ https://reviews.llvm.org/D62501 Files: lldb/source/Plugins/Proce

[Lldb-commits] [PATCH] D62501: Implement GetSharedLibraryInfoAddress

aadsm updated this revision to Diff 203654. aadsm added a comment. Removed unwanted change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62501/new/ https://reviews.llvm.org/D62501 Files: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp

[Lldb-commits] [PATCH] D62502: Implement xfer:libraries-svr4:read packet

aadsm updated this revision to Diff 203656. aadsm added a comment. Move XMLEncodeAttributeValue to GDBRemoteCommunicationServerLLGS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62502/new/ https://reviews.llvm.org/D62502 Files: lldb/include/lld

[Lldb-commits] [PATCH] D62502: Implement xfer:libraries-svr4:read packet

aadsm added a comment. Sounds good, I put it there initially because the XML.cpp set of classes abstract the libxml2 specific away but I guess it is odd to have XMLDocument::XMLEnabled() returning false and still be able to call that new function. Repository: rG LLVM Github Monorepo CHANGE

[Lldb-commits] [PATCH] D62503: Add ReadCStringFromMemory for faster string reads

aadsm updated this revision to Diff 203658. aadsm added a comment. Fix a little bug and add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62503/new/ https://reviews.llvm.org/D62503 Files: lldb/include/lldb/Host/common/NativeProcessProtocol