[Lldb-commits] [PATCH] D62502: Implement xfer:libraries-svr4:read packet

labath added a comment. Ok, so given that both NetBSD and FreeBSD implement this feature (and the current DynamicLoaderPOSIXDYLD plugin reads it), I think we should move this bit of code into NativeProcessELF -- after all, that's what we've created it for. Repository: rG LLVM Github Monorep

[Lldb-commits] [PATCH] D62852: Ignore DIEs in the skeleton unit in a DWO scenario

kwk added a comment. > This patch fixes a couple of existing tests, @labath can you please tell which tests are fixed by this commit exactly? I try to reproduce an issue with a test that (potentially under load) used tp sometimes hang. Now it does no longer do that and I wonder if your change h

[Lldb-commits] [PATCH] D62503: Add ReadCStringFromMemory for faster string reads

labath added a comment. Given that you're improving the linux implementation (which is the only one that benefits from chunked reads) of ReadMemory in https://reviews.llvm.org/D62715, does it make sense to do the chunking here? After all, if an implementation (like NetBSD) has an efficient ptra

[Lldb-commits] [PATCH] D62852: Ignore DIEs in the skeleton unit in a DWO scenario

labath added a comment. In D62852#1537529 , @kwk wrote: > > This patch fixes a couple of existing tests, > > @labath can you please tell which tests are fixed by this commit exactly? I > try to reproduce an issue with a test that (potentially under load)

[Lldb-commits] [PATCH] D62894: DWARF: Share line tables of type units

labath marked 11 inline comments as done. labath added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:309 + decl.SetFile( + die.GetDWARF()->GetFile(*die.GetCU(), form_value.Unsigned())); break; clayborg w

[Lldb-commits] [PATCH] D62894: DWARF: Share line tables of type units

labath updated this revision to Diff 203992. labath marked an inline comment as done. labath added a comment. - add DWARFUnit::GetFile helper function CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62894/new/ https://reviews.llvm.org/D62894 Files: lit/SymbolFile/DWARF/debug-types-line

[Lldb-commits] [PATCH] D63110: Fix a crash in option parsing.

clayborg added a comment. nice Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63110/new/ https://reviews.llvm.org/D63110 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/

[Lldb-commits] [PATCH] D62756: Be consistent when adding names and mangled names to the index

clayborg added a comment. In D62756#1526996 , @labath wrote: > Being consistent definitely sounds like a good idea. Since this does change > behavior somewhat, I'm wondering whether it would make sense to add a test > here. The thing that's not clear to

[Lldb-commits] [PATCH] D62756: Be consistent when adding names and mangled names to the index

clayborg updated this revision to Diff 204104. clayborg added a comment. Changed to use ConstString in AddMangled which simplifies the logic quite a bit. I verified performance didn't regress. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62756/new/ https://reviews.llvm.org/D62756 Fil

[Lldb-commits] [PATCH] D62756: Be consistent when adding names and mangled names to the index

clayborg updated this revision to Diff 204116. clayborg added a comment. Remove commented out code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62756/new/ https://reviews.llvm.org/D62756 Files: source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp Index: source/Plugins/SymbolFile/D

[Lldb-commits] [PATCH] D62502: Implement xfer:libraries-svr4:read packet

aadsm added a comment. Yeah, that makes sense. I was thinking about this yesterday after checking the freebsd code. I was concerned if there's something different that I'm not aware of but we do have tests and I guess we can also override these functions if needed in the future. Repository:

[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

This revision was automatically updated to reflect the committed changes. Closed by commit rL363098: Add support to read aux vector values (authored by aadsm, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

[Lldb-commits] [PATCH] D63166: Move common functionality from processwindows into processdebugger

asmith created this revision. asmith added reviewers: labath, Hui. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. asmith added reviewers: jfb, clayborg. Herald added a subscriber: dexonsmith. This change extracts functionalities from processwindows into a introduced

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

clayborg added a comment. I don't see much I would change here as long as this works and gets tested by the generic GDB remote protocol testing? Any others have comments? Comment at: source/Plugins/Process/Windows/Common/DebuggerThread.cpp:350 +(info.ExceptionRecord.Ex

[Lldb-commits] [lldb] r363101 - Fix a crash in option parsing.

Author: adrian Date: Tue Jun 11 14:14:02 2019 New Revision: 363101 URL: http://llvm.org/viewvc/llvm-project?rev=363101&view=rev Log: Fix a crash in option parsing. The call to getopt_long didn't handle the case where the *last* option had an argument missing. Differential Revision: https://rev

[Lldb-commits] [PATCH] D63110: Fix a crash in option parsing.

This revision was automatically updated to reflect the committed changes. Closed by commit rL363101: Fix a crash in option parsing. (authored by adrian, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D6311

[Lldb-commits] [lldb] r363102 - Update AuxVector.cpp

Author: jmolenda Date: Tue Jun 11 14:20:34 2019 New Revision: 363102 URL: http://llvm.org/viewvc/llvm-project?rev=363102&view=rev Log: Update AuxVector.cpp Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL: http://llvm.org/viewvc/llv

[Lldb-commits] [PATCH] D62797: [Expression] Add PersistentExpressionState::GetCompilerTypeFromPersistentDecl

JDevlieghere accepted this revision. JDevlieghere added inline comments. Comment at: source/Plugins/ExpressionParser/Clang/ClangPersistentVariables.cpp:66 +const_cast(tdecl->getTypeForDecl(; +return compiler_type; + } I think there's a match

[Lldb-commits] [lldb] r363103 - When reading ObjC class table, use new SPI if it is avail

Author: jmolenda Date: Tue Jun 11 14:31:19 2019 New Revision: 363103 URL: http://llvm.org/viewvc/llvm-project?rev=363103&view=rev Log: When reading ObjC class table, use new SPI if it is avail In the latest OS betas, the objc runtime has a special interface for the debugger, class_getNameRaw(), i

[Lldb-commits] [PATCH] D63171: Don't try to parse ObjC method if CU isn't ObjC

clayborg created this revision. clayborg added reviewers: labath, aprantl, jingham. Herald added a subscriber: arphaman. Improve manual indexing performance when indexing non objective C code. One question I have is all Darwin compilers currently support the apple DWARF indexes, so do we even ne

[Lldb-commits] [lldb] r363109 - [LanguageRuntime] Simplify CreateExceptionSearchFilter in derived classes

Author: xiaobai Date: Tue Jun 11 15:52:08 2019 New Revision: 363109 URL: http://llvm.org/viewvc/llvm-project?rev=363109&view=rev Log: [LanguageRuntime] Simplify CreateExceptionSearchFilter in derived classes Modified: lldb/trunk/include/lldb/Target/LanguageRuntime.h lldb/trunk/source/Plu

[Lldb-commits] [PATCH] D63171: Don't try to parse ObjC method if CU isn't ObjC

aprantl added a comment. I suppose one could compile Objective-C code on Linux using GCC. Comment at: source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp:255 + bool is_objc_method = false; + if (check_objc) { +ObjCLanguage::MethodName objc_method(

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

compnerd added inline comments. Comment at: source/Plugins/Process/Utility/RegisterContextWindows_i386.cpp:40 + +// clang-format off +#define DEFINE_GPR(reg, alt, kind1, kind2, kind3, kind4) \ I believe that this bounds the range, and needs

[Lldb-commits] [PATCH] D63171: Don't try to parse ObjC method if CU isn't ObjC

clayborg marked an inline comment as done. clayborg added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp:255 + bool is_objc_method = false; + if (check_objc) { +ObjCLanguage::MethodName objc_method(name, true);

[Lldb-commits] [PATCH] D63171: Don't try to parse ObjC method if CU isn't ObjC

clayborg added a comment. In D63171#1539049 , @aprantl wrote: > I suppose one could compile Objective-C code on Linux using GCC. Will GCC not set the language to ObjC or ObjC++? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63171/new/ https://

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

amccarth added a comment. Sorry for the stupid question, but ... What exactly is meant here by "Native"? How is a NativeProcessWindows different from ProcessWindows? Comment at: source/Plugins/Process/Windows/Common/NativeProcessWindows.h:16 +#include "IDebugDelegate.h" +#in

[Lldb-commits] [PATCH] D63171: Don't try to parse ObjC method if CU isn't ObjC

aprantl added a comment. In D63171#1539070 , @clayborg wrote: > In D63171#1539049 , @aprantl wrote: > > > I suppose one could compile Objective-C code on Linux using GCC. > > > Will GCC not set the language to ObjC

[Lldb-commits] [lldb] r363115 - Back out r363103 ("When reading ObjC class table, use new SPI if it is avail")

Author: jmolenda Date: Tue Jun 11 18:01:34 2019 New Revision: 363115 URL: http://llvm.org/viewvc/llvm-project?rev=363115&view=rev Log: Back out r363103 ("When reading ObjC class table, use new SPI if it is avail") because it breaks the windows bot - asprintf() is not available. Modified: ll

[Lldb-commits] [PATCH] D63181: [Target] Decouple ObjCLanguageRuntime from LanguageRuntime

xiaobai created this revision. xiaobai added reviewers: labath, JDevlieghere, davide, compnerd. ObjCLanguageRuntime was being pulled into LanguageRuntime because of Breakpoint Preconditions. I tried a few ideas, but I felt like this was the last invasive. Other ideas I had and reasons I rejected

[Lldb-commits] [PATCH] D63181: [Target] Decouple ObjCLanguageRuntime from LanguageRuntime

JDevlieghere added a comment. Have you considered making just `AddExceptionPrecondition` virtual? Wouldn't that solve the problem too, without the code duplication of making `CreateExceptionBreakpoint` virtual? Also, I think it's totally reasonable to hoist `BreakpointPrecondition` out of `Brea

[Lldb-commits] [PATCH] D63181: [Target] Decouple ObjCLanguageRuntime from LanguageRuntime

xiaobai added a comment. In D63181#1539291 , @JDevlieghere wrote: > Have you considered making just `AddExceptionPrecondition` virtual? Wouldn't > that solve the problem too, without the code duplication of making > `CreateExceptionBreakpoint` virtual?