[Lldb-commits] [PATCH] D63370: Specify log level for CMake messages (less stderr)

siedentop marked an inline comment as done. siedentop added a comment. Thank you for the review, @xiaobai. I've made the requested change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63370/new/ https://reviews.llvm.org/D63370 ___

[Lldb-commits] [PATCH] D63370: Specify log level for CMake messages (less stderr)

siedentop updated this revision to Diff 204886. siedentop added a comment. Modified STATUS to WARNING as requested by @xiaobai CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63370/new/ https://reviews.llvm.org/D63370 Files: compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour updated this revision to Diff 204885. kusmour added a comment. complete the code for floating point registers and cleaned up the support for floating point registers fixed `TestRegistersIterator` update the testcased Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D63370: Specify log level for CMake messages (less stderr)

xiaobai added a reviewer: sgraenitz. xiaobai added a comment. Seems alright to me. I'd like to see 1 message changed from a STATUS to a WARNING though. Comment at: lldb/cmake/modules/LLDBConfig.cmake:131 if ("${PYTHON_HOME}" STREQUAL "") -message("LLDB embedded Python

[Lldb-commits] [PATCH] D63370: Specify log level for CMake messages (less stderr)

siedentop created this revision. siedentop added reviewers: zturner, beanz, xiaobai, kbobyrev. Herald added subscribers: llvm-commits, lldb-commits, Sanitizers, lebedev.ri, mgorny. Herald added a reviewer: lebedev.ri. Herald added projects: Sanitizers, LLDB, LLVM. Specify message levels in

[Lldb-commits] [PATCH] D63363: [Signals] Create a plugin directory just for signals

xiaobai updated this revision to Diff 204862. xiaobai added a comment. Fix up include in gtest CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63363/new/ https://reviews.llvm.org/D63363 Files: source/Plugins/CMakeLists.txt

[Lldb-commits] [PATCH] D63363: [Signals] Create a plugin directory just for signals

xiaobai created this revision. xiaobai added reviewers: compnerd, JDevlieghere, labath, clayborg, davide. Herald added subscribers: atanasyan, mgorny, sdardis, emaste. Herald added a reviewer: jfb. I plan on setting up a plugin architecture for UnixSignals since I don't think it makes sense for

[Lldb-commits] [PATCH] D62743: Add color to the default thread and frame format.

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62743/new/ https://reviews.llvm.org/D62743 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D62743: Add color to the default thread and frame format.

davide added a comment. Can you add a screenshot of the final result for everybody? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62743/new/ https://reviews.llvm.org/D62743 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D62743: Add color to the default thread and frame format.

JDevlieghere added a comment. In D62743#1544371 , @davide wrote: > Can you add a screenshot of the final result for everybody? Of course! https://i.imgur.com/1cvIbjB.png CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62743/new/

[Lldb-commits] [PATCH] D63357: [Process] Remove unused field from HistoryThread

clayborg added a comment. Added Jason and Jim. Not sure if all libdispatch stuff is in llvm.org? Either Jim or Jason should ok this just in case they still use this in Apple specific repos. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63357/new/ https://reviews.llvm.org/D63357

[Lldb-commits] [PATCH] D62743: Add color to the default thread and frame format.

JDevlieghere updated this revision to Diff 204855. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Highlight line and column in different color CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62743/new/ https://reviews.llvm.org/D62743 Files:

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

Hui added inline comments. Comment at: source/Plugins/Process/Windows/Common/NativeRegisterContextWindows.h:31 +protected: + Status ReadAllRegisterValues(lldb::DataBufferSP _sp, + const size_t data_size); labath wrote: > Is this

[Lldb-commits] [PATCH] D62502: Implement xfer:libraries-svr4:read packet

aadsm updated this revision to Diff 204850. aadsm added a comment. Only extend support to NetBSD Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62502/new/ https://reviews.llvm.org/D62502 Files:

[Lldb-commits] [PATCH] D62501: Implement GetSharedLibraryInfoAddress

This revision was automatically updated to reflect the committed changes. Closed by commit rL363458: Implement GetSharedLibraryInfoAddress (authored by aadsm, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D63166: Move common functionality from processwindows into processdebugger

Hui added inline comments. Comment at: source/Plugins/Process/Windows/Common/ProcessDebugger.cpp:169-170 + +Status ProcessDebugger::AttachProcess(lldb::pid_t pid, + const ProcessAttachInfo _info, +

[Lldb-commits] [PATCH] D62743: Add color to the default thread and frame format.

JDevlieghere updated this revision to Diff 204842. JDevlieghere added a comment. Match dwarfdump color scheme CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62743/new/ https://reviews.llvm.org/D62743 Files: lldb/source/Core/Debugger.cpp Index: lldb/source/Core/Debugger.cpp

[Lldb-commits] [PATCH] D62743: Add color to the default thread and frame format.

JDevlieghere marked 4 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Core/Debugger.cpp:124 +#define FILE_COLOR "${ansi.fg.yellow}" +#define STOP_COLOR "${ansi.fg.red}$" + aprantl wrote: > Thanks, but I was thinking more

[Lldb-commits] [PATCH] D63357: [Process] Remove unused field from HistoryThread

xiaobai created this revision. xiaobai added reviewers: compnerd, JDevlieghere, davide, labath. Herald added a subscriber: kubamracek. These fields are unused and have been since their inception, from what I can tell. https://reviews.llvm.org/D63357 Files:

[Lldb-commits] [PATCH] D63322: DWARF: Avoid storing DIERefs in long-lived containers

aprantl added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2970 if (die) { TypeSystem *type_system = If you find the time: ``` if (!die) return {}; auto *type_system =

[Lldb-commits] [PATCH] D63166: Move common functionality from processwindows into processdebugger

Hui added inline comments. Comment at: source/Plugins/Process/Windows/Common/ProcessDebugger.cpp:169-170 + +Status ProcessDebugger::AttachProcess(lldb::pid_t pid, + const ProcessAttachInfo _info, +

[Lldb-commits] [lldb] r363441 - Don't try to parse ObjC method if CU isn't ObjC

Author: gclayton Date: Fri Jun 14 12:18:10 2019 New Revision: 363441 URL: http://llvm.org/viewvc/llvm-project?rev=363441=rev Log: Don't try to parse ObjC method if CU isn't ObjC Improve manual indexing performance when indexing non objective C code. Differential Revision:

[Lldb-commits] [PATCH] D63171: Don't try to parse ObjC method if CU isn't ObjC

This revision was automatically updated to reflect the committed changes. Closed by commit rL363441: Dont try to parse ObjC method if CU isnt ObjC (authored by gclayton, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D63166: Move common functionality from processwindows into processdebugger

amccarth added a comment. I'm OK with moving common stuff out for now, and I like the separation of ProcessWindows and ProcessDebugger. I agree that we don't want to live too long in a state with a regular plugin and a remote plugin, I still think there's advantage to having common Windows

[Lldb-commits] [lldb] r363438 - Remove stale comment and disabled code (NFC)

Author: jdevlieghere Date: Fri Jun 14 11:12:55 2019 New Revision: 363438 URL: http://llvm.org/viewvc/llvm-project?rev=363438=rev Log: Remove stale comment and disabled code (NFC) Modified: lldb/trunk/source/Symbol/Symtab.cpp Modified: lldb/trunk/source/Symbol/Symtab.cpp URL:

[Lldb-commits] [PATCH] D63166: Move common functionality from processwindows into processdebugger

clayborg added a comment. I would rather see this stuff just moved into NativeProcessWindows (or some class in the windows lldb-server plug-in) and have all code in ProcessWindow.cpp and ProcessDebugger.cpp go away once lldb-server works on windows? The goal is to get rid of the

[Lldb-commits] [PATCH] D63322: DWARF: Avoid storing DIERefs in long-lived containers

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63322/new/ https://reviews.llvm.org/D63322 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D63339: Extend D55859 symbols.enable-external-lookup=false for more testcases

jankratochvil created this revision. jankratochvil added reviewers: labath, clayborg. jankratochvil added a project: LLDB. Herald added subscribers: abidh, aprantl, ki.stfu. D55859 has no effect for some of the testcases so this patch extends it even for (all?)

[Lldb-commits] [PATCH] D63311: Python 3: decode string as utf-8 to avoid type mismatch.

This revision was automatically updated to reflect the committed changes. Closed by commit rL363413: Python 3: decode string as utf-8 to avoid type mismatch. (authored by adrian, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D63310: Make crashlog.py less noisy

This revision was automatically updated to reflect the committed changes. Closed by commit rL363412: Make crashlog.py less noisy (authored by adrian, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r363413 - Python 3: decode string as utf-8 to avoid type mismatch.

Author: adrian Date: Fri Jun 14 08:39:14 2019 New Revision: 363413 URL: http://llvm.org/viewvc/llvm-project?rev=363413=rev Log: Python 3: decode string as utf-8 to avoid type mismatch. rdar://problem/51464644 Differential Revision: https://reviews.llvm.org/D63311 Modified:

[Lldb-commits] [lldb] r363412 - Make crashlog.py less noisy

Author: adrian Date: Fri Jun 14 08:39:11 2019 New Revision: 363412 URL: http://llvm.org/viewvc/llvm-project?rev=363412=rev Log: Make crashlog.py less noisy For end-users there is no point in printing dSYM load errors for system frameworks, since they will all fail and there's nothing they can do

[Lldb-commits] [PATCH] D63311: Python 3: decode string as utf-8 to avoid type mismatch.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63311/new/ https://reviews.llvm.org/D63311 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D63311: Python 3: decode string as utf-8 to avoid type mismatch.

aprantl updated this revision to Diff 204772. aprantl added a comment. Address review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63311/new/ https://reviews.llvm.org/D63311 Files: lldb/examples/python/crashlog.py Index: lldb/examples/python/crashlog.py

[Lldb-commits] [lldb] r363404 - EditlineTest: Improve error message

Author: labath Date: Fri Jun 14 07:33:04 2019 New Revision: 363404 URL: http://llvm.org/viewvc/llvm-project?rev=363404=rev Log: EditlineTest: Improve error message This test seems to occasionally fail because editline returns a different number of lines. Rewrite the message in such a way that we

[Lldb-commits] [lldb] r363400 - DWARF: port debug_ranges/rnglists over to DWARFContext

Author: labath Date: Fri Jun 14 07:12:25 2019 New Revision: 363400 URL: http://llvm.org/viewvc/llvm-project?rev=363400=rev Log: DWARF: port debug_ranges/rnglists over to DWARFContext Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFContext.cpp

[Lldb-commits] [lldb] r363382 - DWARF: Remove unused includes from DWARFDebugAranges.h/cpp

Author: labath Date: Fri Jun 14 06:21:57 2019 New Revision: 363382 URL: http://llvm.org/viewvc/llvm-project?rev=363382=rev Log: DWARF: Remove unused includes from DWARFDebugAranges.h/cpp Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp

[Lldb-commits] [lldb] r363381 - Have DWARFUnit store a *reference* to SymbolFileDWARF

Author: labath Date: Fri Jun 14 06:01:16 2019 New Revision: 363381 URL: http://llvm.org/viewvc/llvm-project?rev=363381=rev Log: Have DWARFUnit store a *reference* to SymbolFileDWARF Previously it was storing a *pointer*, which left open the possibility of this pointer being null. We never made

[Lldb-commits] [lldb] r363373 - DWARFIndex: s/ReportInvalidDIEOffset/ReportInvalidDIERef

Author: labath Date: Fri Jun 14 05:01:18 2019 New Revision: 363373 URL: http://llvm.org/viewvc/llvm-project?rev=363373=rev Log: DWARFIndex: s/ReportInvalidDIEOffset/ReportInvalidDIERef In a dwo/debug_types world, the die offset is not enough to uniquely idendify a debug info entry. Pass the the

[Lldb-commits] [PATCH] D63322: DWARF: Avoid storing DIERefs in long-lived containers

labath created this revision. labath added reviewers: clayborg, JDevlieghere. Herald added a subscriber: aprantl. A user_id_t carries the same information as a DIERef, but it takes up less space. Furthermore, DIERef::operator<'s implementation is very questionable, as it does not take the

[Lldb-commits] [PATCH] D63268: Make UniqueCStringMap work with non-default-constructible types and other improvements/cleanups

This revision was automatically updated to reflect the committed changes. Closed by commit rL363357: Make UniqueCStringMap work with non-default-constructible types and other… (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[Lldb-commits] [lldb] r363357 - Make UniqueCStringMap work with non-default-constructible types and other improvements/cleanups

Author: labath Date: Thu Jun 13 23:33:31 2019 New Revision: 363357 URL: http://llvm.org/viewvc/llvm-project?rev=363357=rev Log: Make UniqueCStringMap work with non-default-constructible types and other improvements/cleanups Summary: The motivation for this was me wanting to make the validity of

[Lldb-commits] [PATCH] D63311: Python 3: decode string as utf-8 to avoid type mismatch.

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. Yep, we should decode all the check_output results, as they may contain unicode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D63241: Fixed typos in Log.h

This revision was automatically updated to reflect the committed changes. Closed by commit rL363356: Fixed typos in Log.h (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r363356 - Fixed typos in Log.h

Author: jdevlieghere Date: Thu Jun 13 23:06:47 2019 New Revision: 363356 URL: http://llvm.org/viewvc/llvm-project?rev=363356=rev Log: Fixed typos in Log.h Patch by: Yuya Fujita Differential revision: https://reviews.llvm.org/D63241 Modified: lldb/trunk/include/lldb/Utility/Log.h Modified: