[Lldb-commits] [PATCH] D64013: Correctly use GetLoadedModuleList to take advantage of libraries-svr4

aadsm updated this revision to Diff 207455. aadsm added a comment. Address comments, add GetAction that returns an enum with what to do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64013/new/ https://reviews.llvm.org/D64013 Files: lldb/include

[Lldb-commits] [PATCH] D63853: [Symbol] Add DeclVendor::FindTypes

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63853/new/ https://reviews.llvm.org/D63853 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D63853: [Symbol] Add DeclVendor::FindTypes

xiaobai updated this revision to Diff 207425. xiaobai added a comment. Pavel's suggestion CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63853/new/ https://reviews.llvm.org/D63853 Files: include/lldb/Symbol/DeclVendor.h source/API/SBTarget.cpp source/Plugins/Language/ObjC/ObjCLang

[Lldb-commits] [PATCH] D64042: [Symbol] Improve Variable::GetLanguage

xiaobai created this revision. xiaobai added reviewers: jingham, clayborg. Herald added a subscriber: jdoerfert. When trying to ascertain what language a variable belongs to, just checking the compilation unit is often not enough. In r364845 I added a way to check for a variable's language type, b

[Lldb-commits] [lldb] r364860 - [lldb] [lldbsuite] Use a unique class name for TestValueVarUpdate

Author: stella.stamenova Date: Mon Jul 1 15:12:55 2019 New Revision: 364860 URL: http://llvm.org/viewvc/llvm-project?rev=364860&view=rev Log: [lldb] [lldbsuite] Use a unique class name for TestValueVarUpdate It looks like when this test was added, it was based on TestHelloWorld and it ended up

[Lldb-commits] [lldb] r364852 - [Reproducer] Assert on unexpected packet

Author: jdevlieghere Date: Mon Jul 1 14:25:34 2019 New Revision: 364852 URL: http://llvm.org/viewvc/llvm-project?rev=364852&view=rev Log: [Reproducer] Assert on unexpected packet I'm not able to reproduce the reproducer flakiness we're seeing on GreenDragon. I want to add this assert to find out

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL364845: [Core] Generalize ValueObject::IsRuntimeSupportValue (authored by xiaobai, committed by ). Herald added a project:

[Lldb-commits] [lldb] r364845 - [Core] Generalize ValueObject::IsRuntimeSupportValue

Author: xiaobai Date: Mon Jul 1 13:36:33 2019 New Revision: 364845 URL: http://llvm.org/viewvc/llvm-project?rev=364845&view=rev Log: [Core] Generalize ValueObject::IsRuntimeSupportValue Summary: Instead of falling back to ObjCLanguageRuntime, we should be falling back to every loaded language ru

[Lldb-commits] [PATCH] D64013: Correctly use GetLoadedModuleList to take advantage of libraries-svr4

labath added inline comments. Comment at: lldb/include/lldb/Target/Process.h:684 + ///A status object indicating if the operation was sucessful or not. + virtual Status LoadModules() { return Status("Not implemented"); } aadsm wrote: > labath wrote: > > S

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

jingham accepted this revision. jingham added a comment. Sure, NP. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63240/new/ https://reviews.llvm.org/D63240 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

[Lldb-commits] [lldb] r364826 - [lldb] [lldbsuite] Use a unique class name for TestBacktraceAll

Author: stella.stamenova Date: Mon Jul 1 11:13:20 2019 New Revision: 364826 URL: http://llvm.org/viewvc/llvm-project?rev=364826&view=rev Log: [lldb] [lldbsuite] Use a unique class name for TestBacktraceAll It looks like when this test was added, it was based on TestBreakAfterJoin and it ended u

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

clayborg added a comment. Jim, you ok with doing the symbol context scope refactoring as a separate diff? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63240/new/ https://reviews.llvm.org/D63240 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

xiaobai added a comment. Centralizing it means changing the classes that inherit from SymbolContextScope, so I will refactor that in a seaparate change and stack this change on top of that one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63240/new/ https://reviews.llvm.org/D63240

[Lldb-commits] [PATCH] D64013: Correctly use GetLoadedModuleList to take advantage of libraries-svr4

aadsm marked 2 inline comments as done. aadsm added inline comments. Comment at: lldb/include/lldb/Target/Process.h:684 + ///A status object indicating if the operation was sucessful or not. + virtual Status LoadModules() { return Status("Not implemented"); }

[Lldb-commits] [PATCH] D64013: Correctly use GetLoadedModuleList to take advantage of libraries-svr4

labath added a comment. I don't have time to do a full review of this today, but this seems pretty good at a first glance... Comment at: lldb/include/lldb/Target/Process.h:684 + ///A status object indicating if the operation was sucessful or not. + virtual Status LoadMod

[Lldb-commits] [PATCH] D63792: [lldb] [Process/NetBSD] Use global enable bits for watchpoints

This revision was automatically updated to reflect the committed changes. Closed by commit rL364781: [lldb] [Process/NetBSD] Use global enable bits for watchpoints (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D63791: [lldb] [Process/NetBSD] Fix segfault when handling watchpoint

This revision was automatically updated to reflect the committed changes. Closed by commit rL364780: [lldb] [Process/NetBSD] Fix segfault when handling watchpoint (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D63545: [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE

This revision was automatically updated to reflect the committed changes. Closed by commit rL364779: [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

[Lldb-commits] [lldb] r364781 - [lldb] [Process/NetBSD] Use global enable bits for watchpoints

Author: mgorny Date: Mon Jul 1 08:11:42 2019 New Revision: 364781 URL: http://llvm.org/viewvc/llvm-project?rev=364781&view=rev Log: [lldb] [Process/NetBSD] Use global enable bits for watchpoints Set global enable bits (i.e. bits 1, 3, 5, 7) to enable watchpoints on NetBSD rather than the local e

[Lldb-commits] [lldb] r364780 - [lldb] [Process/NetBSD] Fix segfault when handling watchpoint

Author: mgorny Date: Mon Jul 1 08:11:10 2019 New Revision: 364780 URL: http://llvm.org/viewvc/llvm-project?rev=364780&view=rev Log: [lldb] [Process/NetBSD] Fix segfault when handling watchpoint Fix the watchpoint/breakpoint code to search for matching thread entry in m_threads explicitly rather

[Lldb-commits] [lldb] r364779 - [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE

Author: mgorny Date: Mon Jul 1 08:11:04 2019 New Revision: 364779 URL: http://llvm.org/viewvc/llvm-project?rev=364779&view=rev Log: [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE Provide a (conditional) support for the new PT_GETXSTATE and PT_SETXSTATE ptrace() requests, an

[Lldb-commits] [PATCH] D64013: Correctly use GetLoadedModuleList to take advantage of libraries-svr4

aadsm created this revision. aadsm added reviewers: labath, jankratochvil, clayborg. Herald added subscribers: lldb-commits, JDevlieghere, srhines. Herald added a project: LLDB. aadsm added a reviewer: xiaobai. Here's a replacement for D62504 . I thought I could u

[Lldb-commits] [PATCH] D62504: Avoid calling LoadModules twice when modules change

aadsm abandoned this revision. aadsm added a comment. Replaced by D62503 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62504/new/ https://reviews.llvm.org/D62504 ___ l

[Lldb-commits] [PATCH] D63792: [lldb] [Process/NetBSD] Use global enable bits for watchpoints

krytarowski added a comment. I would follow the same kernel behavior here as Linux, but that can be done independently. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63792/new/ https://reviews.llvm.org/D63792 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D63791: [lldb] [Process/NetBSD] Fix segfault when handling watchpoint

krytarowski accepted this revision. krytarowski added inline comments. Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:250 +if (!thread) { + LLDB_LOG(log, + "thread not found in m_threads, pid = {0}, LWP = {1}", We sh

[Lldb-commits] [PATCH] D62503: Add ReadCStringFromMemory for faster string reads

aadsm added a comment. Yap, that makes a lot of sense to me. I looked into this over the weekend and figured out the reason why it was broken (tl;dr: we can't use LoadModules) and created a tidier version of D63868 that, like D62504

[Lldb-commits] [lldb] r364776 - Revert "[lldb] [Process/NetBSD] Fix constructor after r363707"

Author: mgorny Date: Mon Jul 1 07:38:47 2019 New Revision: 364776 URL: http://llvm.org/viewvc/llvm-project?rev=364776&view=rev Log: Revert "[lldb] [Process/NetBSD] Fix constructor after r363707" Now that r364751 has been reverted, we need to revert this fixup as well. Modified: lldb/trunk/s

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

This revision was automatically updated to reflect the committed changes. jankratochvil marked an inline comment as done. Closed by commit rL364773: Fix lookup of symbols at the same address with no size vs. size (authored by jankratochvil, committed by ). Herald added a project: LLVM. Herald adde

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

jankratochvil marked 2 inline comments as done. jankratochvil added inline comments. Comment at: lldb/lit/SymbolFile/sizeless-symbol.test:5 + +image lookup --address 1 +# CHECK: Summary: sizeless-symbol.test.tmp.o`sizeful clayborg wrote: > Symbols are ordered in

[Lldb-commits] [lldb] r364773 - Fix lookup of symbols at the same address with no size vs. size

Author: jankratochvil Date: Mon Jul 1 07:31:26 2019 New Revision: 364773 URL: http://llvm.org/viewvc/llvm-project?rev=364773&view=rev Log: Fix lookup of symbols at the same address with no size vs. size This fixes a failing testcase on Fedora 30 x86_64 (regression Fedora 29->30): PASS: ./bin/ll

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

clayborg accepted this revision. clayborg added inline comments. Comment at: lldb/lit/SymbolFile/sizeless-symbol.test:5 + +image lookup --address 1 +# CHECK: Summary: sizeless-symbol.test.tmp.o`sizeful Symbols are ordered in the same order as they appear in the s

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

labath added a comment. I think it will be pretty hard for a single person to gather all of these stats for all targets. So perhaps the best solution is to have the setting for the `g` packet, defaulting to true. After a while, if nobody notices a regression, we can just remove it... Reposito

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

labath added inline comments. Comment at: lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows.cpp:31-36 + if (!data_sp) { +error.SetErrorStringWithFormat( +"failed to allocate DataBufferHeap instance of size %" PRIu64, +data_size); +r

[Lldb-commits] [lldb] r364754 - Don't check the validity of newly contructed data buffers

Author: labath Date: Mon Jul 1 06:18:19 2019 New Revision: 364754 URL: http://llvm.org/viewvc/llvm-project?rev=364754&view=rev Log: Don't check the validity of newly contructed data buffers A bunch of places were checking that DataBufferHeap::GetBytes returns a non-null pointer right after const

[Lldb-commits] [lldb] r364753 - @skipIfXmlSupportMissing TestRecognizeBreakpoint

Author: labath Date: Mon Jul 1 06:12:29 2019 New Revision: 364753 URL: http://llvm.org/viewvc/llvm-project?rev=364753&view=rev Log: @skipIfXmlSupportMissing TestRecognizeBreakpoint Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestRecognizeBreakpoint.

[Lldb-commits] [PATCH] D62503: Add ReadCStringFromMemory for faster string reads

labath added a comment. I've also reverted the preceeding patch in this series as reverting this one has caused one of the other tests to start failing (I've tried to make a more surgical fix first, but @jankratochvil pointed out that this basically reintroduced the problem that we were trying

[Lldb-commits] [lldb] r364751 - Revert "Implement xfer:libraries-svr4:read packet"

Author: labath Date: Mon Jul 1 05:41:20 2019 New Revision: 364751 URL: http://llvm.org/viewvc/llvm-project?rev=364751&view=rev Log: Revert "Implement xfer:libraries-svr4:read packet" D62502, together with D62503 have broken the builds which have XML support enabled. Reverting D62503 (r364355) fi

[Lldb-commits] [lldb] r364748 - Fix TestGdbRemoteLibrariesSvr4Support

Author: labath Date: Mon Jul 1 05:00:25 2019 New Revision: 364748 URL: http://llvm.org/viewvc/llvm-project?rev=364748&view=rev Log: Fix TestGdbRemoteLibrariesSvr4Support D62502 had a bug (visible only with D62503 reverted), where it would error out if attempting to read a string from memory and

[Lldb-commits] [lldb] r364744 - Remove null checks of results of new expressions

Author: labath Date: Mon Jul 1 04:09:15 2019 New Revision: 364744 URL: http://llvm.org/viewvc/llvm-project?rev=364744&view=rev Log: Remove null checks of results of new expressions operator new doesn't return a null pointer, even if one turns off exceptions (it calls std::terminate instead). The

[Lldb-commits] [PATCH] D63792: [lldb] [Process/NetBSD] Use global enable bits for watchpoints

mgorny updated this revision to Diff 207255. mgorny added a comment. Updated per review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63792/new/ https://reviews.llvm.org/D63792 Files: lldb/packages/Python/lldbsuite/test/functionalities/watchpoint/hello_watchlocation/TestWatchLocati

[Lldb-commits] [PATCH] D63791: [lldb] [Process/NetBSD] Fix segfault when handling watchpoint

mgorny added a comment. I'm going to ask Kamil to stamp those patches anyway but I always appreciate your advice wrt LLDB coding style and general integration. After all, we all want LLDB codebase to be more unified. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63791/new/ https://rev

[Lldb-commits] [PATCH] D63868: Unify+fix remote XML libraries handling with the legacy one

labath added a comment. In D63868#1563873 , @jankratochvil wrote: > In D63868#1563802 , @labath wrote: > > > Does this mean that there is a bug in lldb-server, where some memory read > > requests fail if they span

[Lldb-commits] [PATCH] D63792: [lldb] [Process/NetBSD] Use global enable bits for watchpoints

mgorny marked an inline comment as done. mgorny added a comment. That's probably one of the reasons why NetBSD normally prevents unprivileged users from setting DRs. Comment at: lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.cpp:733 // for watchpoint

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

jankratochvil updated this revision to Diff 207252. jankratochvil marked 2 inline comments as done. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63540/new/ https://reviews.llvm.org/D63540 Files: lldb/lit/SymbolFile/Inputs/sizeless-symbol.s lldb/lit/SymbolFi

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

jankratochvil marked 5 inline comments as done. jankratochvil added inline comments. Comment at: lldb/lit/SymbolFile/sizeless-symbol.test:10 +image dump symtab +# CHECK:Index UserID DSX TypeFile Address/Value Load Address Size Flags Name +#

[Lldb-commits] [PATCH] D63791: [lldb] [Process/NetBSD] Fix segfault when handling watchpoint

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. LGTM. I don't know what Kamil is up to these days. It might be better to have him review patches like this, but if he's unable to do that, I'm happy to stamp them too... CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D63792: [lldb] [Process/NetBSD] Use global enable bits for watchpoints

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Sorry about the delay, I was OOO last week. BTW, the usual rate of pinging on a patch is one week https://llvm.org/docs/DeveloperPolicy.html#code-reviews. If the NetBSD kernel really sets the

[Lldb-commits] [PATCH] D63545: [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I don't know whether the code is correct for NetBSD, but it looks ok from a general readability perspective. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63545/new/ https://reviews.

[Lldb-commits] [PATCH] D63868: Unify+fix remote XML libraries handling with the legacy one

jankratochvil added a comment. In D63868#1563802 , @labath wrote: > Does this mean that there is a bug in lldb-server, where some memory read > requests fail if they span an unreadable page. Can this also be triggered by > a $m packet? Would you be inter

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good to me, but I'd suggest waiting a while to give @clayborg a chance to respond... Comment at: lldb/lit/SymbolFile/sizeless-symbol.test:4 + +image lookup --address 1

[Lldb-commits] [PATCH] D63868: Unify+fix remote XML libraries handling with the legacy one

labath added a comment. @jankratochvil wrote: > That is because it fixed failing ReadMemory (due to PAGE_SIZE size reading > shared library name overlapping to a next page which is accidentally unmapped) Does this mean that there is a bug in lldb-server, where some memory read requests fail i

Re: [Lldb-commits] [lldb] r364494 - [Reproducers] Fix flakiness and off-by-one during replay.

Do we have a test which records us interrupting a process, and then makes sure this replays correctly ? On 27/06/2019 04:03, Jonas Devlieghere via lldb-commits wrote: Author: jdevlieghere Date: Wed Jun 26 19:03:34 2019 New Revision: 364494 URL: http://llvm.org/viewvc/llvm-project?rev=364494&

[Lldb-commits] [PATCH] D63853: [Symbol] Add DeclVendor::FindTypes

labath resigned from this revision. labath added a comment. Besides picking at code style details, I don't believe I have anything useful to add here. :) Comment at: source/Plugins/Language/ObjC/ObjCLanguage.cpp:939-941 +auto types = +decl_vendor->F

[Lldb-commits] [PATCH] D61233: Refactor ObjectFile::GetSDKVersion

labath added a comment. looks good to me too... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61233/new/ https://reviews.llvm.org/D61233 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [PATCH] D63792: [lldb] [Process/NetBSD] Use global enable bits for watchpoints

mgorny added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63792/new/ https://reviews.llvm.org/D63792 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D63545: [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE

mgorny added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63545/new/ https://reviews.llvm.org/D63545 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D63791: [lldb] [Process/NetBSD] Fix segfault when handling watchpoint

mgorny added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63791/new/ https://reviews.llvm.org/D63791 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits