[Lldb-commits] [PATCH] D64546: [lldb] Make TestDeletedExecutable more reliable

teemperor created this revision. teemperor added a reviewer: davide. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. It seems that calling Popen can return to the caller before the started process has read all the needed information from its executable. This means that in

[Lldb-commits] [PATCH] D64545: [lldb] Don't use __FUNCTION__ as a file name

teemperor created this revision. teemperor added a reviewer: davide. Herald added subscribers: lldb-commits, abidh. Herald added a project: LLDB. I saw while debugging that we call this file `ParseInternal`, which is not a very good name for our fake expression file and also adds this

[Lldb-commits] [PATCH] D64365: [lldb] Let table gen create command option initializers.

teemperor updated this revision to Diff 209119. teemperor added a comment. - Better formatting and comments for generated Options.inc - Added support and example for arguments that have enum values. - Fixed some typos in the Options.td definitions that caused some tests to fail. CHANGES SINCE

[Lldb-commits] [PATCH] D64535: Add convenience methods to convert LLDB to LLVM data structures.

JDevlieghere updated this revision to Diff 209107. JDevlieghere added a comment. Herald added a subscriber: arphaman. Update use in debug names. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64535/new/ https://reviews.llvm.org/D64535 Files: lldb/include/lldb/Core/Section.h

[Lldb-commits] [PATCH] D64535: Add convenience methods to convert LLDB to LLVM data structures.

JDevlieghere updated this revision to Diff 209106. JDevlieghere added a comment. Cache the LLVM DWARF context. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64535/new/ https://reviews.llvm.org/D64535 Files: lldb/include/lldb/Core/Section.h

[Lldb-commits] [lldb] r365719 - [lldb] Disable TestDollarInVariable.py on Windows

Author: teemperor Date: Wed Jul 10 17:35:31 2019 New Revision: 365719 URL: http://llvm.org/viewvc/llvm-project?rev=365719=rev Log: [lldb] Disable TestDollarInVariable.py on Windows It seems on Windows we don't handle the lldb_expr_result variable correctly: ``` AssertionError: False is not True

[Lldb-commits] [lldb] r365718 - [swig] Add workaround for old swig

Author: jdevlieghere Date: Wed Jul 10 17:12:59 2019 New Revision: 365718 URL: http://llvm.org/viewvc/llvm-project?rev=365718=rev Log: [swig] Add workaround for old swig Apparently, when using swig 1.3.40, properties to set values do not work without the `__swig_setmethods__` workaround. I

[Lldb-commits] [PATCH] D63854: NFC: Convert large lambda into method

This revision was automatically updated to reflect the committed changes. Closed by commit rL365708: NFC: Convert large lambda into method (authored by vitalybuka, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D64535: Add convenience methods to convert LLDB to LLVM data structures.

clayborg added a comment. Just wondering if we want to cache the llvm::DWARFContext in the LLDB DWARFContext. See inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFContext.h:69 + + std::unique_ptr GetAsLLVM() const; }; Should we cache

[Lldb-commits] [PATCH] D64251: Don't depend on psutil on AIX

daltenty added a comment. In D64251#1577374 , @davide wrote: > This is adding a fair amount of complexity on something that just works fine > on basically every platform but AIX. > If AIX has issue with `psutil`, maybe the fix should be submitted to >

[Lldb-commits] [PATCH] D64535: Add convenience methods to convert LLDB to LLVM data structures.

JDevlieghere created this revision. JDevlieghere added reviewers: labath, clayborg. Herald added a subscriber: aprantl. Herald added a project: LLDB. This adds two convenience methods named `GetAsLLVM` to the LLDB versions of the DWARF DataExtractor and the DWARF context. Repository: rLLDB

[Lldb-commits] [PATCH] D63854: [NFC] Convert large lambda into method

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM if it's really NFC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63854/new/ https://reviews.llvm.org/D63854

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

guiandrade updated this revision to Diff 209063. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62931/new/ https://reviews.llvm.org/D62931 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp

[Lldb-commits] [lldb] r365698 - [lldb] Fix handling of dollar characters in expr command

Author: teemperor Date: Wed Jul 10 14:04:01 2019 New Revision: 365698 URL: http://llvm.org/viewvc/llvm-project?rev=365698=rev Log: [lldb] Fix handling of dollar characters in expr command Added: lldb/trunk/packages/Python/lldbsuite/test/expression_command/dollar-in-variable/

[Lldb-commits] [PATCH] D64013: Correctly use GetLoadedModuleList to take advantage of libraries-svr4

labath added a comment. Looks mostly good. Just a couple of style comments. Comment at: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp:185-207 + if ( + // When the previous and current states are consistent this is the first + // time we have been

[Lldb-commits] [lldb] r365696 - [Expression] IR Instrumenters should have a UtilityFunction

Author: xiaobai Date: Wed Jul 10 13:41:36 2019 New Revision: 365696 URL: http://llvm.org/viewvc/llvm-project?rev=365696=rev Log: [Expression] IR Instrumenters should have a UtilityFunction Right now, IR Instrumenters take a DynamicCheckerFunctions object which has all the UtilityFunctions used

[Lldb-commits] [PATCH] D64373: Don't use PyInt on Python 3

clayborg added a comment. never mind, I missed that you had! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64373/new/ https://reviews.llvm.org/D64373 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D64444: Add Python 3.6 and 3.7 to the version list

This revision was automatically updated to reflect the committed changes. Closed by commit rL365688: Add Python 3.6 and 3.7 to the version list (authored by nico, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r365688 - Add Python 3.6 and 3.7 to the version list

Author: nico Date: Wed Jul 10 12:18:38 2019 New Revision: 365688 URL: http://llvm.org/viewvc/llvm-project?rev=365688=rev Log: Add Python 3.6 and 3.7 to the version list Python 3.6 and 3.7 have been released. Differential Revision: https://reviews.llvm.org/D6 Patch from Christian Biesinger

[Lldb-commits] [PATCH] D64373: Don't use PyInt on Python 3

cbiesinger added a comment. Yeah. (I thought I did? I'm not super familiar with this interface) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64373/new/ https://reviews.llvm.org/D64373 ___

[Lldb-commits] [PATCH] D64373: Don't use PyInt on Python 3

clayborg added a comment. ok, so do you want to abandon this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64373/new/ https://reviews.llvm.org/D64373 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D64444: Add Python 3.6 and 3.7 to the version list

cbiesinger added a comment. Thanks Greg! I'm not a committer -- how do I get this committed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/ https://reviews.llvm.org/D6 ___ lldb-commits

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

clayborg added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ThreadGDBRemote.h:103 lldb_private::LazyBool m_associated_with_libdispatch_queue; + bool m_use_g_packet; Not a big deal, but might be easier to store this in

[Lldb-commits] [PATCH] D62503: Add ReadCStringFromMemory for faster string reads

jankratochvil added a comment. In D62503#1578934 , @aadsm wrote: > Does it sound good to you? Yes, that sounds great, thanks. Sorry I am not participating these days. Repository: rL LLVM CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D64194: [lldb] Fix crash due to unicode characters and dollars in variable names.

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64194/new/ https://reviews.llvm.org/D64194 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r365677 - [scripts] Remove the unused 'shush' script.

Author: davide Date: Wed Jul 10 11:13:46 2019 New Revision: 365677 URL: http://llvm.org/viewvc/llvm-project?rev=365677=rev Log: [scripts] Remove the unused 'shush' script. There are pre-made utilities doing this. If somebody finds an use for it and wants to resurrect, I would recommend to revise

[Lldb-commits] [PATCH] D64013: Correctly use GetLoadedModuleList to take advantage of libraries-svr4

aadsm added a comment. @labath can I ask for a re-review on this one please? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64013/new/ https://reviews.llvm.org/D64013 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D62503: Add ReadCStringFromMemory for faster string reads

aadsm added a comment. @jankratochvil I'm planning to follow Pavel's plan now that the new setting has landed and finally got some time for this. It will be: - Revert rL364751 (which is a revert itself) - Revert 9c10b620c061

[Lldb-commits] [PATCH] D64194: [lldb] Fix crash due to unicode characters and dollars in variable names.

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionSourceCode.cpp:223 +// Returns true if this is the last token we get from the lexer. +exit = lex.LexFromRawLexer(token); +

[Lldb-commits] [PATCH] D63770: Options: Reduce code duplication

This revision was automatically updated to reflect the committed changes. Closed by commit rL365665: Options: Reduce code duplication (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] r365665 - Options: Reduce code duplication

Author: labath Date: Wed Jul 10 10:09:47 2019 New Revision: 365665 URL: http://llvm.org/viewvc/llvm-project?rev=365665=rev Log: Options: Reduce code duplication Summary: While investigating breakages caused by D63110, I noticed we were building the short options strings in three places. Some of

[Lldb-commits] [lldb] r365654 - ObjectFileELF: Add support for gnu-style compressed sections

Author: labath Date: Wed Jul 10 09:10:43 2019 New Revision: 365654 URL: http://llvm.org/viewvc/llvm-project?rev=365654=rev Log: ObjectFileELF: Add support for gnu-style compressed sections With this style, a compressed section is indicated by a "z" in the section name, instead of a section

[Lldb-commits] [lldb] r365651 - [CMake][NFC] Remove dead code lldb_append_link_flags() from AddLLDB.cmake

Author: stefan.graenitz Date: Wed Jul 10 09:02:46 2019 New Revision: 365651 URL: http://llvm.org/viewvc/llvm-project?rev=365651=rev Log: [CMake][NFC] Remove dead code lldb_append_link_flags() from AddLLDB.cmake Modified: lldb/trunk/cmake/modules/AddLLDB.cmake Modified:

[Lldb-commits] [lldb] r365648 - [CMake] Polish Apple-lldb caches

Author: stefan.graenitz Date: Wed Jul 10 08:59:50 2019 New Revision: 365648 URL: http://llvm.org/viewvc/llvm-project?rev=365648=rev Log: [CMake] Polish Apple-lldb caches Modified: lldb/trunk/cmake/caches/Apple-lldb-base.cmake lldb/trunk/cmake/caches/Apple-lldb-macOS.cmake Modified:

[Lldb-commits] [lldb] r365650 - [CMake][NFC] Polish comments in AddLLDB.cmake

Author: stefan.graenitz Date: Wed Jul 10 09:00:03 2019 New Revision: 365650 URL: http://llvm.org/viewvc/llvm-project?rev=365650=rev Log: [CMake][NFC] Polish comments in AddLLDB.cmake Modified: lldb/trunk/cmake/modules/AddLLDB.cmake Modified: lldb/trunk/cmake/modules/AddLLDB.cmake URL:

[Lldb-commits] [lldb] r365649 - [CMake] Add Apple-lldb-Linux.cmake cache

Author: stefan.graenitz Date: Wed Jul 10 08:59:56 2019 New Revision: 365649 URL: http://llvm.org/viewvc/llvm-project?rev=365649=rev Log: [CMake] Add Apple-lldb-Linux.cmake cache Added: lldb/trunk/cmake/caches/Apple-lldb-Linux.cmake Added: lldb/trunk/cmake/caches/Apple-lldb-Linux.cmake URL:

[Lldb-commits] [PATCH] D64408: [CMake] `install-distribution` for LLDB on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rL365617: [CMake] `install-distribution` for LLDB on Darwin (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D64399: [CMake] Distribution builds for LLDB standalone

This revision was automatically updated to reflect the committed changes. Closed by commit rL365616: [CMake] Distribution builds for LLDB standalone (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D64397: [CMake] Remove extra lldb-framework target

This revision was automatically updated to reflect the committed changes. Closed by commit rL365615: [CMake] Remove extra lldb-framework target (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r365617 - [CMake] `install-distribution` for LLDB on Darwin

Author: stefan.graenitz Date: Wed Jul 10 04:09:29 2019 New Revision: 365617 URL: http://llvm.org/viewvc/llvm-project?rev=365617=rev Log: [CMake] `install-distribution` for LLDB on Darwin Summary: There's a number of requirements for installing LLDB on macOS that are untypical for LLVM projects:

[Lldb-commits] [lldb] r365616 - [CMake] Distribution builds for LLDB standalone

Author: stefan.graenitz Date: Wed Jul 10 04:09:11 2019 New Revision: 365616 URL: http://llvm.org/viewvc/llvm-project?rev=365616=rev Log: [CMake] Distribution builds for LLDB standalone Summary: Enable `distribution` and `install-distribution` targets in LLDB standalone and pre-populate the

[Lldb-commits] [lldb] r365615 - [CMake] Remove extra lldb-framework target

Author: stefan.graenitz Date: Wed Jul 10 04:09:01 2019 New Revision: 365615 URL: http://llvm.org/viewvc/llvm-project?rev=365615=rev Log: [CMake] Remove extra lldb-framework target Summary: The custom lldb-framework target was meant to encapsulate all build steps that LLDB.framework needs on top

[Lldb-commits] Inconsistency in cmakefile vs code

In: lldb\source\Plugins\Process\Windows\Common\CMakeLists.txt these files are built based on the SYSTEM Architecture: if(CMAKE_SYSTEM_PROCESSOR MATCHES "x86_64|AMD64") target_sources(lldbPluginProcessWindowsCommon PRIVATE x64/RegisterContextWindows_x64.cpp) elseif(CMAKE_SYSTEM_PROCESSOR